Commit Graph

79322 Commits

Author SHA1 Message Date
srdjan@google.com 6ae61921fa Update co19-runtime.status with issues assigned.
Review URL: http://codereview.chromium.org//8555019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1524 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-15 00:22:09 +00:00
nweiz@google.com 07a7a968a8 StopWatch -> Stopwatch in dartdoc.
TBR=rnystrom

Review URL: http://codereview.chromium.org//8567015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1523 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-15 00:10:29 +00:00
cshapiro@google.com cce17823db Wait on the monotonic clock to guard against changes to the system clock.
Review URL: http://codereview.chromium.org//8463032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1522 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 22:25:07 +00:00
srdjan@google.com 22ea3cf225 Fix String.trim implementation (follow spec).
Fix Queue.every, Queue.some, Queue.filter, ..
Adapt co19 status files.
Review URL: http://codereview.chromium.org//8510066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1521 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 22:23:41 +00:00
srdjan@google.com 17aa639eb1 Update co19 status for runtime.
Review URL: http://codereview.chromium.org//8536044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1518 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 18:03:41 +00:00
cshapiro@google.com eccf8cdae6 Use a common subroutine for the snapshot reading and writing of strings.
Review URL: http://codereview.chromium.org//8340017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1517 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 18:03:02 +00:00
mmendez@google.com 8274140bb5 Sort the file members.
TBR=codefu

Review URL: http://codereview.chromium.org//8566008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1512 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 16:27:53 +00:00
scheglov@google.com 7cea876fef Better redirecting constructor and initializers problems reporting.
Preparation for work on http://code.google.com/p/dart/issues/detail?id=351

R=zundel@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8527005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1511 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 16:18:08 +00:00
ager@google.com bd670664bb Implement more progress modes.
R=whesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8528025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1509 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 15:52:36 +00:00
sgjesse@google.com 5950638350 Better handling of stdin/stdout/stderr
When using stdout/stderr it is no longer necessary to explicitly
close the streams for the program to terminate. The automatic
close is handled by always closing the associated receive port
for write only streams when not waiting for any events. If a
close or error handler is installed for stdout/stderr these will
still keep the program alive.

For stdin better handling of the difference between sockets and
pipes have been immplemented. As a special case for stdin when
reading from a terminal the a POLLIN signal with 0 available
bytes is treated as end-of-file. This will trigger when pressing
ctrl-d in a terminal as POLLHUP is not set in that situation.

R=ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8533005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1507 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 14:47:58 +00:00
floitsch@google.com 1bf944156e Fix dual-pivot sort.
BUG=dart:432
TEST=

Review URL: http://codereview.chromium.org//8510047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1506 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 13:57:59 +00:00
floitsch@google.com e24dec2169 Rename StopWatch to Stopwatch. Add new Stopwatch.start() and Stopwatch.reset().
BUG=dart:418
TEST=
Review URL: http://codereview.chromium.org//8537011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1505 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 13:56:18 +00:00
ahe@google.com f69dd219f7 Revert various changes to Link factories.
Also, hack/work around bugs in VM and Frog to get LinkFactory to work.

Review URL: http://codereview.chromium.org//8566003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1504 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 12:54:41 +00:00
whesse@google.com 9873986daf tools/test.dart: Enable // DartOptions= lines in Dart test runner.
BUG=
TEST=tools/test.dart

Review URL: http://codereview.chromium.org//8565006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1503 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 12:28:54 +00:00
ager@google.com 211968eb7a Implement test selection.
Make it very simple and flexible. I don't think we need to make
it more restrictive than this.

R=whesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8566001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1502 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 11:28:54 +00:00
ager@google.com 1c96143867 Fix activity tracking in test scripts.
Only shutdown when all test listers are done and the process queue
is empty. Before there was a posibility that the script would shut
down when the queue got empty before all the listers were done.

R=whesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8565001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1500 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-14 09:21:28 +00:00
asiva@google.com 5cf3ad018a Changes to pass the current isolate to all runtime and native calls.
Review URL: http://codereview.chromium.org//8528010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1499 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 05:55:22 +00:00
sigmund@google.com 67a5aded5a Don't increase default timeouts in frogium tests
Review URL: http://codereview.chromium.org//8536046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1498 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 02:28:54 +00:00
jmesserly@google.com e89a0bf296 Better fix for client tests.
There was a simple bug in $varMethod. We don't hit this path much--you need to be dynamic & in the DOM library.

Review URL: http://codereview.chromium.org//8511081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1497 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 02:28:41 +00:00
jmesserly@google.com 9db3945f72 Fix client status from my previous checkin.
Looking at this now. I think my change may have exposed a different compiler bug.

Review URL: http://codereview.chromium.org//8538033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1496 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 01:56:50 +00:00
cshapiro@google.com 4ad48f74e5 Add methods for creating Bigint objects from unsigned 64-bit integers.
Review URL: http://codereview.chromium.org//8539034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1495 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 01:54:18 +00:00
jmesserly@google.com 5a8a4b3cce Fix dispatch on MemberSets to always go dynamic if needed.
And a bug where we'd put a dynamic toString and == on Object that conflicts with the one that is actually on Object.

Review URL: http://codereview.chromium.org//8540030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1494 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 01:32:50 +00:00
hausner@google.com a17bea5481 More info in disassembled code
Print out first 5 elements of an array object, rather than
just 'Array'. This helps in particular in disassembled
method and stub calls which now print the content of the
IC cache and ArgumentsDescriptor arrays. E.g.:

0x7404a5    ff7508            push [ebp+0x8]
0x7404a8    ff750c            push [ebp+0xc]
0x7404ab    b9012f7000        mov ecx,0x702f01  Array[bitAndFromInteger, 1, null, null]
0x7404b0    bafd050003        mov edx,0x30005fd  Array[2, 2, null]
0x7404b5    e8b6fcffff        call 0x740170  [stub: InlineCache]
0x7404ba    83c408            add esp,0x8
Review URL: http://codereview.chromium.org//8491061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1493 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 00:45:17 +00:00
jmesserly@google.com 469f38d61d Fix co19 status in light of r1485. Trying to get the bots green.
Review URL: http://codereview.chromium.org//8539033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1492 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 00:38:17 +00:00
jmesserly@google.com 090673a5db Fix dartcombat_tests status
Review URL: http://codereview.chromium.org//8511078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1491 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 00:30:12 +00:00
nweiz@google.com feb92073e0 Only set initializer fields as fields, not properties.
This should fix issue 422.

TBR=jimhug

Review URL: http://codereview.chromium.org//8540023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1489 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 00:17:42 +00:00
hausner@google.com 87ba9c00b5 Nix obsolete function prototype
Review URL: http://codereview.chromium.org//8536038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1488 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 00:10:28 +00:00
sigmund@google.com 41240c4926 minor fix to get dartcombat tests passing
Review URL: http://codereview.chromium.org//8540024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1485 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 00:04:33 +00:00
jmesserly@google.com 21943943f5 fix co19 status
I was trying to be too clever. The tests are plain old passing, regardless of checked mode.

BUG=
TEST=

Review URL: http://codereview.chromium.org//8536039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1484 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 23:46:13 +00:00
srdjan@google.com 0a87f0b9f1 FactoryNegativeTest is now correct for dartium as well.
Review URL: http://codereview.chromium.org//8491059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1483 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 23:46:00 +00:00
rnystrom@google.com a1fa8e8245 Move doc generator out of frog samples.
It's on its way to being a real library now so it isn't a sample anymore.

Review URL: http://codereview.chromium.org//8515029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1482 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 23:41:34 +00:00
jmesserly@google.com 66e7eed905 Optimize boolean asserts
This change adds a notion of non-nullability to the type system. We use this to track nullable vs non-nullable bools, removing a lot of the checks in "if" "for" etc.
Also fixes ?: precedence, uncovered by sra's PEG tests

Review URL: http://codereview.chromium.org//8463027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1481 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 23:31:57 +00:00
srdjan@google.com 1ea6e2e0de Stop building blind: report errors with factories and parametrized types.
Enable test. This CL expects the frog/leg changes to be submitted first.
Review URL: http://codereview.chromium.org//8511070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1479 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 22:23:45 +00:00
sigmund@google.com e2b35683cc Minor code clean-ups addressing Nicolas suggestions
Review URL: http://codereview.chromium.org//8491052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1478 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 22:20:27 +00:00
regis@google.com 8b9ebb3528 Second attempt at finalizing all classes in the VM (fix issue 364).
Review URL: http://codereview.chromium.org//8491055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1475 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 21:38:49 +00:00
srdjan@google.com 4e73a18984 Fix frog testing with ../tools/test.py -c frog
(leg testing is still broken as many language tests are failing)
Review URL: http://codereview.chromium.org//8537019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1474 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 21:19:49 +00:00
jimhug@google.com 30f83aefc5 incremental progress on Value
I particularly like the fun type error this caught in corelib_impl.

Review URL: http://codereview.chromium.org//8538019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1472 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 19:48:55 +00:00
jmesserly@google.com 92ba3e1590 Change presubmit to run co19 tests, but run a few less frog configurations to keep the total runtime similar.
Review URL: http://codereview.chromium.org//8528015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1471 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 19:36:05 +00:00
turnidge@google.com 8c64adf13e Deal with unhandled exceptions the same way in all Dart api functions.
--

Terminology change: invalid handles are now called error handles.

Unhandled exceptions used to be a kind of valid handle.  Now they are
a kind of error handle.

For the Dart_Invoke* functions, this means that the standard
error-checking blob drops from two tests to one test and is
harder to mess up.

Many other Dart api functions (Dart_ToString, for example) previously
dealt with unhandled exceptions by turning them into terse error
messages.  Now these functions preserve information about the
exceptions and generate better error messages.

Changed Dart_HandleMessage to return success/failure.  It seemed to fit.

--

Details:

Dart_IsValid becomes Dart_IsError (negated sense).

Dart_GetError now knows how to print a stack trace semi-nicely.

Dart_ExceptionOccurred -> Dart_IsUnhandledException.

Renamed ApiFailure class to ApiError to fit better.

ApiError now has a "data" pointer that points to either an error
message string or to an unhandled exception object.

Documentation changes aplenty.
Review URL: http://codereview.chromium.org//8501034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1470 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 19:31:04 +00:00
srdjan@google.com 81be68ae18 Giving up on the change to report errors with factories and generic types.
This means that you will continue to have crashes in Debug mode, but you will be able to "run" in Release mode. Best solution is to get rid of generic types in Link until factories and generic types have been fully implemented. Until then we do not know what can happen when running in release mode.

Still trying to figure out how to test frog and leg correctly.
Review URL: http://codereview.chromium.org//8540013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1469 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 18:52:53 +00:00
srdjan@google.com a41b5acbff Hopefully fixing leg breakage.
Review URL: http://codereview.chromium.org//8536020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1468 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 18:23:16 +00:00
vsm@google.com ef590ec928 Fix typo
TBR=sigmund

Review URL: http://codereview.chromium.org//8491047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1467 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 17:54:22 +00:00
vsm@google.com 22f003b5b1 Fix formatting on error string
Review URL: http://codereview.chromium.org//8463021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1466 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 17:52:16 +00:00
srdjan@google.com 6ff41ed334 Require legacy form of type parameters in factories and report errors if a factory class does not have a required parametrized type (fixes crashes in VM). Fix frog code, however, there are frogs problem with --compileall:
leg/util/link_implementation.dart:38:12: error: wrong number of arguments, expected 0 but found 2
    return new Link<T>(element, this);
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
Review URL: http://codereview.chromium.org//8515024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1464 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 17:04:00 +00:00
whesse@google.com 29294f393b tools/test.dart: Handle VMOptions lines in test files.
BUG=
TEST=tools/test.dart

Review URL: http://codereview.chromium.org//8536013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1461 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 14:44:41 +00:00
ager@google.com 1191c37e56 Enable frog testing components.
Respect timeout command-line option.

Use option names with underscores understood by all components.

Improve compact progress report using stdout access.

R=whesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8537010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1460 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 14:08:07 +00:00
sgjesse@google.com 38b2b0d5d8 Provide access to stdin, stdout and stderr
R=ager@google.com, iposva@google.com

BUG=dart:402
TEST=

Review URL: http://codereview.chromium.org//8525002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1456 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 11:45:53 +00:00
whesse@google.com 636a5d6df7 tools/test.dart: Implement --checked option.
BUG=
TEST=tools/test.dart

Review URL: http://codereview.chromium.org//8537009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1455 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 11:44:06 +00:00
ager@google.com dde03ed8ad Fix build: use strings for booleans in status expression evaluation.
R=whesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8511057

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1454 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 10:57:39 +00:00
ager@google.com 10092daafd Parse command-line options into a list of test configurations.
This allows to run multiple variants at once:

./tools/test.dart --mode=debug,release --component=most

R=whesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8511056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1453 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 10:53:18 +00:00