df490b9c9c
Add some tests for dartdoc name reference resolution.
...
Currently these just test existing behavior, but the goal is to set the stage
for adding more advanced resolution.
TBR
Review URL: http://codereview.chromium.org//9150011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3117 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 22:39:24 +00:00
f67c7c44af
Get dartdoc running again.
...
TBR
Review URL: http://codereview.chromium.org//9152013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3116 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 22:33:48 +00:00
a7b543760e
TryCatch8NegativeTest looks like it is out of sync with the spec, other TryCatch?NegativeTest cases have outdated or illegal syntax other than the true object of the test.
...
Review URL: http://codereview.chromium.org//9162001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3115 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 22:14:08 +00:00
b2b7cb0f6f
running presubmit
...
review suggestions
BUG=
TEST=
Review URL: http://codereview.chromium.org//9151015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3114 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 22:01:16 +00:00
4c274d4106
Fixes for parsing warnigs, issue 1060.
...
1. Diet parsing notification fix.
2. Disable name shadow warnings for htmlimpl.dart library, until library itself will be fixed.
3. Fix for identifying core libraries in Editor.
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9149008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3113 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 20:33:12 +00:00
3a5bd98866
test.dart: Stop looping over vmOptions in browser tests to turn the buildbot green.
...
There are some flaky tests in the language suite in component chromium with the dart test script. They all have multiple vmOptions lines, so temporarily disabling that functionality to turn the build green again.
BUG=
TEST=tools/test.dart -cchromium language
Review URL: http://codereview.chromium.org//9150006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3110 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 18:55:45 +00:00
74015409f2
Issue 988: Compile time error missing for const class / non-final instance variables
...
http://code.google.com/p/dart/issues/detail?id=988
7.5.3: It is a compile-time error if a constant constructor is declared by a class that has a non-final instance variable.
The above refers to both locally declared and inherited instance variables.
R=mmendez,zundel
BUG=
TEST=
Review URL: http://codereview.chromium.org//9122015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3108 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 17:58:08 +00:00
421d80b491
Create multiple temporary directories in test.dart for multiple vmOptions in a test.
...
BUG=
TEST=tools/test.dart -cchromium language/StaticImplicitClosure
Review URL: http://codereview.chromium.org//9148007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3107 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 17:57:35 +00:00
87a48c0bc0
Update test expectatins after implementing bailout on parameters.
...
Review URL: http://codereview.chromium.org//9151005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3106 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 17:46:36 +00:00
69b567e798
in dartc, generics in Typedef not working as expected, when extending generic type
...
http://code.google.com/p/dart/issues/detail?id=436
Review URL: http://codereview.chromium.org//9049016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3103 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 17:06:37 +00:00
01abdc883f
Blacklist types from core library, issue 969
...
http://code.google.com/p/dart/issues/detail?id=969
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9124006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3102 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 16:36:04 +00:00
84fc2e6305
Use test.dart for dartc buildbot. Ensure that test.dart creates the build directory.
...
BUG=
TEST=rm -rf out; tools/test.dart -cdartium
Review URL: http://codereview.chromium.org//9155001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3100 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 15:47:43 +00:00
c2bf7a2524
remove dartdoc from sdk until it actually works there.
...
TBR=efortuna
Review URL: http://codereview.chromium.org//9147005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3099 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 15:40:58 +00:00
34b6799f7c
Fix http://code.google.com/p/dart/issues/detail?id=990 .
...
Need to check that the implicit super call resolves. Updated the unit tests until the c019 tests are refreshed.
Review URL: http://codereview.chromium.org//9139001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3098 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 15:35:16 +00:00
ee205dd7eb
Missed a status update
...
R=mmendez
BUG=
TEST=
Review URL: http://codereview.chromium.org//9150004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3097 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 15:29:56 +00:00
bde6167ce4
Issue 1097: Optimized builds running out of stack on linux machines
...
http://code.google.com/p/dart/issues/detail?id=1097
This change only makes Linux builds match Mac for stack size.
R=mmendez
BUG=
TEST=
Review URL: http://codereview.chromium.org//9154001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3096 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 15:06:53 +00:00
8bfac9fe95
Test 13_4_Interface_Types_A11_t01 can crash in dartc release.
...
BUG=1097
Review URL: http://codereview.chromium.org//9148005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3090 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 13:22:14 +00:00
4e3faf80e4
Revert change 3084.
...
Review URL: http://codereview.chromium.org//9146003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3086 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 10:47:03 +00:00
1b7d7303d8
Replace test.py with test.dart, using test_wrapper.py, temporarily to find problems. Will be reverted immediately.
...
Review URL: http://codereview.chromium.org//9148002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3084 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 10:35:36 +00:00
2b388ee864
Enable webdriver component in test.dart
...
BUG=dart:1046
TEST=tools/test.dart -cwebdriver
Review URL: http://codereview.chromium.org//9110031
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3082 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 09:42:07 +00:00
a6071e0880
Thread pool changes
...
Make one global thread pool instead of a thread pool for each
eventhandler (i.e. isolate).
Also:
* Added handler function for thread pool tasks.
* Added thread pool shutdown.
* Added a simple test.
R=ager@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9112013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3079 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 07:38:30 +00:00
1dd7a8484c
continued cleanup of initialization and Value
...
Less code, more tests passing... EvaluatedValue and MethodGenerator.evalBody are both in the right direction but will be evolving fairly rapidly to get to a fully cleaned up state.
Review URL: http://codereview.chromium.org//9146001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3077 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 03:42:49 +00:00
154e4ce2d2
Fixes 2 tests and a crash - while cleaning up EvaluatedValue
...
Another step towards cleaning up the use of Value. Greatly reduced use of .dynamic and slowly increasing modularity of code for handling consts by moving it into the constant Values themselves. Apologies for the ugliness of added parens around ALL numeric constants - but this did simplify several parts of the code while fixing a couple of broken tests. I'm confident this step back in readability won't last out the weekend (though I'm not telling you which one <smile>).
Review URL: http://codereview.chromium.org//9143001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3076 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-08 00:04:20 +00:00
8fcfbe459a
Fix so that listeners will get notified. Sorry I missed this when reviewing the change.
...
Review URL: http://codereview.chromium.org//9124018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3073 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-07 15:54:00 +00:00
87209aa2b8
cl # Enter a description of the change.
...
Add missing file.
BUG=
TEST=
Review URL: http://codereview.chromium.org//9127020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3071 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-07 04:01:02 +00:00
eade45daf7
Remove last 'extra_snippet'
...
The last remaining piece of snippet code is moved to an ordinary file.
BUG=
TEST=
Review URL: http://codereview.chromium.org//9123023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3070 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-07 03:56:54 +00:00
ab7e321da0
update status file
...
Accidentally fixed a crash <smile>.
Review URL: http://codereview.chromium.org//9127018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3068 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-07 03:26:31 +00:00
81c2ca4ff5
cleanup to Value - fix for StringEscapesTest
...
Motivation of this change was cleaning up value.dart. This also led to finally handling parsing and escaping string literals in a rational way - which accidentally fixed a test. This is intended to setup a future change that can simplify EvaluatedValue hopefully dramatically. Changes to await were required due to refactoring of tree.
Review URL: http://codereview.chromium.org//9121025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3067 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-07 03:07:34 +00:00
cabddd03f4
More fixes for foo.continue()
...
BUG=
TEST=
Review URL: http://codereview.chromium.org//9127017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3066 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-07 02:51:23 +00:00
007933c446
Avoid generating "foo.continue()" because JSCompiler chokes.
...
Generate foo['continue']() instead.
BUG=
TEST=
Review URL: http://codereview.chromium.org//9122019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3065 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-07 01:44:05 +00:00
24feb26169
Fix type on _Collections.map; Fix removal of native file.
...
Two oversights from previous changes.
BUG=
TEST=
Review URL: http://codereview.chromium.org//9124025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3064 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-07 00:37:06 +00:00
2e410f76d4
- Remove redundant initialization in Array::New
...
- Add timer for measuing isolate initialization
Review URL: http://codereview.chromium.org//9108036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3063 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-07 00:06:31 +00:00
d4e44a3670
Fix for Issue 1075
...
Don't use ImplementationFunction - that is the C++ name.
There used to be a problem with IDBCursor.delete - some browsers didn't like the call foo.delete()
The way to fix this if it reappears is to generate foo['delete']() instead.
BUG=1075
TEST=
Review URL: http://codereview.chromium.org//9125011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3060 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 22:15:49 +00:00
2cfa7066ba
- Update status file.
...
Review URL: http://codereview.chromium.org//9120013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3059 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 22:02:49 +00:00
d09c5a4bfe
Fix broken tests:
...
- For compilation to trigger a method has to be called.
- operator [] is not allowed in compile time constants.
- Trigger --compile_all for added verification.
Review URL: http://codereview.chromium.org//9121014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3058 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 21:45:36 +00:00
b08fcc744b
Small performance improvement: avoid looking up builtin types too much by tracking them, particularly ones in coreimpl like NumImplementation.
...
I also did a few refactorings:
* Tried to tame the "nativeName" stuff to keep the code paths from forking too much
* Removed the bad code duplication between needsConversion and convertTo in Value (they had gone out of sync again!)
* Simplified the function wrapping code & made it clear it's about isolates. The code still checks for DOM, but conceptually it's part of our isolate impl. If we had a different way to tag native function types (e.g. perhaps the "native" keyword, if it's allowed in that position?) we could remove the DOM check there.
Review URL: http://codereview.chromium.org//9110027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3057 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 21:36:59 +00:00
b015c01998
Properly type the clone method for Element and a few of its subclasses.
...
TBR
Review URL: http://codereview.chromium.org//9127005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3051 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 19:44:42 +00:00
2726b1e229
Issue 1061: Duplicate members causes NPE in type analyzer
...
http://code.google.com/p/dart/issues/detail?id=1061
Replace Map<Element> with MultiMap<Element> (LinkedHashMap).
R=zundel,messick
BUG=1061
TEST=
Review URL: http://codereview.chromium.org//9122003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3047 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 18:32:20 +00:00
bf920d8dfd
Add unitAboutToCompile() into DartCompilerListener
...
R=brianwilkerson@google.com ,codefu@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9113017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3045 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 16:34:20 +00:00
08b8a9cd71
Implementation of List.setRange for frog. Re-enable test.
...
BUG=934
Review URL: http://codereview.chromium.org//8983019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3043 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 15:55:33 +00:00
203196c37a
Fix test.dart on Frogium component, enable in buildbot.
...
BUG=
TEST=cd frog; ../tools/build.py; ../tools/test.py -cfrogium frog
Review URL: http://codereview.chromium.org//9110032
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3042 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 15:15:24 +00:00
19aeb06a9a
Removing dead status lines for non-existant co19 tests.
...
R=zundel
BUG=
TEST=
Review URL: http://codereview.chromium.org//9108020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3040 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 14:24:03 +00:00
480722154a
Fix assertion failure in Process object, where non-integer pid could be passed to kill.
...
BUG=
TEST=
Review URL: http://codereview.chromium.org//9120004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3038 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 13:54:31 +00:00
5078ebb745
Add FuturesTest.dart as failing for leg
...
TBR=ajohnsen@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9120005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3037 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 13:32:53 +00:00
9b9a51361e
Remove reference to removed bin/global.h from .gypi file
...
TBR=ahe@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9123005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3036 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 13:11:13 +00:00
8b3b89bf23
Remove bin/global.h now that the buildbot is green again
...
TBR=ahe@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9125003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3035 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 12:59:39 +00:00
7e66a1488a
Add back bin/globals.h to help buildbot
...
TBR=ahe@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9110030
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3034 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 12:51:43 +00:00
5dcd61b851
Futures.wait should call then, even if some(or all) of the futures are done
...
Review URL: http://codereview.chromium.org//9108010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3033 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 12:41:29 +00:00
c686e7bd0d
Dummy update to gypi file to force rebuild on buildbot
...
TBR=ahe@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9124003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3032 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 12:40:31 +00:00
1d11ece030
AST nodes for function-typed parameters.
...
Review URL: http://codereview.chromium.org//9109015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3031 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 12:24:49 +00:00
nweiz@google.com