Commit Graph

1458 Commits

Author SHA1 Message Date
floitsch@google.com 09f6d09d88 Make isEmpty a getter.
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
floitsch@google.com 0e47b363ae Make hasNext a getter instead of a method.
Review URL: https://codereview.chromium.org//11230011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14015 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 13:05:11 +00:00
lrn@google.com a083c1a108 Removed IllegalAccessException and UnsupportedOperationException.
Both were converted to StateError.

Review URL: https://codereview.chromium.org//11235054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:36:10 +00:00
amouravski@google.com fa916d3169 Fixed the HTML doc breakage.
Temporary fix until we can make all of apidoc work with new import syntax.

Review URL: https://codereview.chromium.org//11260005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13991 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 01:56:42 +00:00
rnystrom@google.com 4c04a099d5 Apply patch from other client.
BUG=

Review URL: https://codereview.chromium.org//11235067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13984 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 20:25:58 +00:00
efortuna@google.com ce3543f212 Reapply ie to ie9 rename.
Review URL: https://codereview.chromium.org//11231081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13978 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 17:17:30 +00:00
efortuna@google.com 920589055f Revert rename ie to ie9.
Review URL: https://codereview.chromium.org//11249003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13976 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 16:28:33 +00:00
floitsch@google.com 27cadf2b66 isEven, isOdd, isNegative, isMaxValue, isMinValue, isInfinite, isPositive, isSingleValue.
Review URL: https://codereview.chromium.org//11227042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13974 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 16:15:36 +00:00
ager@google.com 0f11f4baa0 Skip git pub tests as they do not work on Windows buildbots.
They work locally on my machine.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//11227053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13966 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 14:04:25 +00:00
ager@google.com 57d5cd2278 Remove second sleep in pub and enable pub tests on Windows.
After the inherit fix I cannot reproduce the other 7zip
problem either so I'm removing the sleep call. All tests
pass on my machine.

Bob, could you test this with all of your migthty pub
power and see if you can make it break?

R=sgjesse@google.com,rnystrom@google.com
BUG=dartbug.com/5910

Review URL: https://codereview.chromium.org//11225056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13964 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:56:54 +00:00
ager@google.com e18e79217d Do *not* make file handles inheritable on Windows.
This is the cause of the pub failures to unpack a file that has
just been created. The problem is that another 7-zip process has
inherited the file handle for a file that we are still writing.
When we are done writing the file, we cannot use it because the
other process still keeps the handle.

R=sgjesse@google.com,rnystrom@google.com
BUG=dartbug.com/5910

Review URL: https://codereview.chromium.org//11230051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13960 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:04:02 +00:00
kasperl@google.com 5fb2069f5c Get rid of more () in getter definitions.
R=antonm@google.com
BUG=

Review URL: https://codereview.chromium.org//11228053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13952 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 11:59:22 +00:00
efortuna@google.com 31fb4a0c74 Complete renaming of ie bots to ie9, to add ie10.
Review URL: https://codereview.chromium.org//11189101

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13908 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 20:59:01 +00:00
floitsch@google.com 9074fd0178 Make hashCode a getter and not a method.
Review URL: https://codereview.chromium.org//11191078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13866 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 12:41:04 +00:00
ricow@google.com bb04388ecc Temporary fix to make IE bots green.
There is a bigger cl doing all of the renaming here:
https://codereview.chromium.org/11189101/
Review URL: https://codereview.chromium.org//11234026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13860 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 10:58:52 +00:00
ahe@google.com 755abed9dc Generate snapshot for dartj2s; use it in the SDK.
Review URL: https://codereview.chromium.org//11187028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13773 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 11:25:11 +00:00
regis@google.com 8c3cfbb381 Second round of cleanups for new optional parameter semantics.
Review URL: https://codereview.chromium.org//11194025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13759 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 20:58:19 +00:00
efortuna@google.com 4839206863 Rename ie to ie9.
Review URL: https://codereview.chromium.org//11184015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13748 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 17:44:38 +00:00
ager@google.com ff9e0f75fb Change Process.start to return a future that completes with a
Process object only when the process has been successfully started.

This is less error prone since you can use all the methods on a
Process object as soon as you can get your hands on it. Unfortunately,
this change leads to quite a few changes in test.dart. Some of those
changes will fix bugs as well. We used to have a problem with a
timeout that could fire just in between two steps in a chain of
commands that constitute one test run. This change should address
that issue as well.

BUG=dartbug.com/5305

Review URL: https://codereview.chromium.org//11091070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13729 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 10:57:45 +00:00
efortuna@google.com f8948ae8b9 Delete temporary files on Opera bot.
Review URL: https://codereview.chromium.org//11186012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13714 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 00:54:35 +00:00
nweiz@google.com 11a3d6b769 Reverting 13708
TBR

Review URL: https://codereview.chromium.org//11192019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13710 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 22:39:50 +00:00
nweiz@google.com ac3242b205 Add a Pub test that runs against the real Dart SDK.
BUG=5906

Review URL: https://codereview.chromium.org//11187011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13708 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 22:31:44 +00:00
regis@google.com adb534674c Change core lib, dart2js, and more for new optional parameters syntax and semantics (new semantics is not enforced yet).
Review URL: https://codereview.chromium.org//11090016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13684 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 16:03:47 +00:00
ajohnsen@google.com 1cbee26da4 Use correct newline-token on windows, in pub.
BUG=

Review URL: https://codereview.chromium.org//11174003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13678 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 09:09:49 +00:00
ajohnsen@google.com 5a104d7f2b Extract a list of lines from a process' stdout and stderr, in pub.
BUG=

Review URL: https://codereview.chromium.org//11169003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13677 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 08:34:20 +00:00
johnniwinther@google.com 19d27b1fe0 Pub fix for Windows
BUG=5859

Review URL: https://codereview.chromium.org//11170003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13676 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 08:09:51 +00:00
ricow@google.com f7b22d4cbb Download packages to temp dir inside system cache.
This fixes an issue where the rename will fail if your system temp directory is
on a different volume from your user directory (and thus your pub cache).
Review URL: https://codereview.chromium.org//11151035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13674 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 06:18:49 +00:00
rnystrom@google.com e6fbcf3426 Add prefix.
Review URL: https://codereview.chromium.org//11142028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13671 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 22:52:38 +00:00
rnystrom@google.com ba0802348c Sleep before moving directory on Windows.
Gives 7zip more time to finish extracting before we access the
directory.

BUG=

Review URL: https://codereview.chromium.org//11151030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13670 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 22:43:15 +00:00
rnystrom@google.com 4091f4ed21 Put a nasty sleep() on Windows.
We get "file in use" errors between downloading and extracting archives, so sleep for a bit.

BUG=

Review URL: https://codereview.chromium.org//11146022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13668 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 21:27:59 +00:00
rnystrom@google.com 1bb574612e Download to a temp dir and rename on success.
This prevents ghost packages ending up in your pub cache if a
download fails. Also added some more output during installation so
you can see what's happening.

BUG=

Review URL: https://codereview.chromium.org//11151026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13666 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 20:59:56 +00:00
efortuna@google.com 5c4c062a2f Delete temporary profile files for Opera as well as Firefox.
Review URL: https://codereview.chromium.org//11137007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13640 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-13 00:04:23 +00:00
gram@google.com 403bbf44b0 Added the ability for testrunner to start the HTTP server with a random port and communicate that port to the tests via a 'testState' map in unittest.
Review URL: https://codereview.chromium.org//11103015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13507 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 23:47:56 +00:00
gram@google.com 29611d7d98 Added ability to have custom test HTTP server handlers in the test directories.
Review URL: https://codereview.chromium.org//11093033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13490 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-10 19:48:18 +00:00
rnystrom@google.com fc169ee8b2 "Reverting 13451"
Review URL: https://codereview.chromium.org//11066091

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13452 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 23:32:21 +00:00
rnystrom@google.com 87f5622b44 Print out the working directory when git fails.
Also (sigh) re-enabling Windows again.

Review URL: https://codereview.chromium.org//11087039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13451 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 23:26:43 +00:00
rnystrom@google.com e9ff2669b8 "Reverting 13440"
Review URL: https://codereview.chromium.org//11099019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13441 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 21:02:26 +00:00
rnystrom@google.com 8fe2700fd8 Try enabling Git on Windows again.
Review URL: https://codereview.chromium.org//11098025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13440 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 20:55:46 +00:00
rnystrom@google.com 20788ffcba Show git command that failed.
Review URL: https://codereview.chromium.org//11066088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13439 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 20:54:05 +00:00
rnystrom@google.com 7707b979c4 "Reverting 13434"
Review URL: https://codereview.chromium.org//11028097

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13436 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 20:01:58 +00:00
rnystrom@google.com 68fdad3715 Enable Git on Windows, again.
Now with slightly better error reporting so I can try to see what's going on.

Review URL: https://codereview.chromium.org//11066084

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13434 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 19:56:40 +00:00
rnystrom@google.com 182ae3e26c Update pub to use new import syntax.
Review URL: https://codereview.chromium.org//11093012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13391 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 01:25:43 +00:00
rnystrom@google.com 1ac8be8aa3 Better pub integration test error reporting.
Always includes the stderr when a test failures. Shows errors in stdout, stderr
and the exit code all at once. Displays differences in expected output better.

Review URL: https://codereview.chromium.org//11091015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13390 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 01:11:52 +00:00
rnystrom@google.com eb33df709b Include stderr on git failure.
Also moves the git stuff out of io into its own library.

Review URL: https://codereview.chromium.org//11066066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13388 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 00:56:57 +00:00
rnystrom@google.com 9de6ef8dee "Reverting 13373"
Review URL: https://codereview.chromium.org//11091010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13374 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-08 21:02:31 +00:00
rnystrom@google.com d6bef3ac7a Enable pub git tests on Windows.
Review URL: https://codereview.chromium.org//11091008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13373 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-08 20:51:45 +00:00
ricow@google.com 1bde0bc06d Update buildbot.py to support jsshell builders.
Review URL: https://codereview.chromium.org//11029048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13342 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-08 05:49:13 +00:00
rnystrom@google.com 6a2cac8d2a Create destination directory before git cloning into it.
BUG=

Review URL: https://codereview.chromium.org//11076004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13334 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 23:13:14 +00:00
gram@google.com 2602f8c28e Change imports etc to new syntax.
Fix issues wutrh handling console messages from DRT when using --list-tests and --list-groups.
Review URL: https://codereview.chromium.org//11033042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13327 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 22:13:12 +00:00
rnystrom@google.com 57a43b6fd5 Spit pub tests into smaller suites.
Windows is slow and our large tests suites time out.

Review URL: https://codereview.chromium.org//11035066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13315 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 20:01:50 +00:00