Commit Graph

6631 Commits

Author SHA1 Message Date
kustermann@google.com 3561aeaff9 Set public-read acl on editor installers
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//18875003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24843 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 14:54:17 +00:00
kustermann@google.com 1a0def6a46 When using content_shell to run tests, run them with '--single-process'
It seems that the exit code of the renderer process is not correctly propagated
to content_shell (at least on windows). By passing the '--single-process' flag
to content_shell, we ensure that we can detect renderer crashes.

R=whesse@google.com

Review URL: https://codereview.chromium.org//18826010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24840 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 12:33:03 +00:00
hausner@google.com 7bb78b9620 Generate better debugging info for actor phase check
The phase check was generated at a token position that was one token
past the end of the constructor body, which threw debugger clients
off.

Fixes issue 8916.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//18465007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24830 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 22:40:35 +00:00
efortuna@google.com f19afa5cbf Adjust list_pkg_directories to always have / slashes so that we don't accidentally create escape characters on Windows.
BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//18238010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24827 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 22:05:29 +00:00
blois@google.com ef9f4e7973 Properly hiding import of deprecate from collection-dev.
CL https://codereview.chromium.org//18692002 modified the generated files but missed the source files. Also skipped Dartium files which have the same conflicts.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//18342003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24814 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 18:40:10 +00:00
efortuna@google.com f1ca162781 Add markdown to third_party/pkg
BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//18497012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24807 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 17:43:43 +00:00
kustermann@google.com 58c6fd4e23 Allow re-running of failing tests on drt-windows
Our windows dartium builders are currently flaky. The reasons seems to be that
content_shell.exe is sometimes not able to fetch resources from the HttpServer.

This CL makes sure we try to re-run failing tests on drt-windows. This will
hopefully make the builder less flaky and will buy us some time to figure out
what the exact issue is.

The default number of retries before we give up is 2.

TBR=ricow@google.com

Review URL: https://codereview.chromium.org//18144012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24785 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-05 13:05:19 +00:00
kustermann@google.com 658ea93cec Allow selectors for test.py to match against a subtest of a multitest
Previously we were not able to select a subtest of a multitest
(i.e. "tools/test.py suite/path-to-test/01").

R=johnniwinther@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//18121013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24782 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-05 08:50:26 +00:00
lrn@google.com 1315656027 Make asBroadcastStream take two callbacks.
These callbacks will be called when the broadcast stream no longer
has any listeners, or when it gets a listener after having none.

The callback is provided with a StreamSubscription-like object where
it can pause/resume/cancel the underlying subscription on the original
stream.

BUG=http://dartbug.com/11289
R=floitsch@google.com

Review URL: https://codereview.chromium.org//17490002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24776 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-04 13:02:02 +00:00
kustermann@google.com ad95ee86e2 Make multiple attempts to write binding files to disc
Our dartium-win builders are currently flaky on the compile step. Sometimes
we're not able to write the generated dart bindings to disc (we get an IOError:
Permission denied).

This change makes sure we do multiple attempts for writing out the generated
files before we give up. Hopefully we can eliminate this hack as soon as we
found the root cause.

TBR=efortuna@google.com

Review URL: https://codereview.chromium.org//18676003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24772 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-04 11:55:19 +00:00
efortuna@google.com 842b1f41c3 Make type parameter in toDataUrl have an optional default value as per the spec.
BUG=
R=amouravski@google.com

Review URL: https://codereview.chromium.org//18500010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24753 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 21:19:16 +00:00
efortuna@google.com da548d2be4 Make keySystem argument optional in MediaElement.canPlayType.
BUG=
R=amouravski@google.com

Review URL: https://codereview.chromium.org//18346012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24752 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 21:15:49 +00:00
kustermann@google.com 5937290e27 Enabling logger information for multiemitter.py and add more debug information
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//18326018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24725 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 13:59:13 +00:00
efortuna@google.com f81052f2c8 Reapply expanding overloaded functions into separate functions.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//18577002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24709 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 22:32:44 +00:00
kustermann@google.com d06e9eb36e Catch IOError instead of OSError
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//18541003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24692 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 15:29:08 +00:00
kustermann@google.com a63d13556c Adding debug information to multiemitter.py
Our win-dartium builders are flaky. Very often the compilation fails because
dartdomgenerator.py gets an "IOError: [Errno 13] Permission denied" error.

This is an attempt to get more insight into which other processes have
the file open at the same time.

R=antonm@google.com

Review URL: https://codereview.chromium.org//18534002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24688 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 14:39:07 +00:00
zarah@google.com b515c8e2aa Fix error.
Review URL: https://codereview.chromium.org//18528002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24682 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 12:45:49 +00:00
zarah@google.com 93f70b1125 correct syntax error.
Review URL: https://codereview.chromium.org//18526002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24679 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 12:20:46 +00:00
zarah@google.com 01251efd5e Add isActive field on Timer.
BUG= http://dartbug.com/10010
R=floitsch@google.com

Review URL: https://codereview.chromium.org//18325006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24678 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 12:01:11 +00:00
amouravski@google.com 6f88eecf44 Removed overloads for WebGLRenderingContext.texImage2D and texSubImage2D.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//17738007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24670 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 00:01:15 +00:00
jmesserly@google.com 89c18e96f0 [package:mdv] port createInstance change
HTMLTemplateElement.prototype.createInstance takes model & syntaxString, sets up bindings -- https://github.com/Polymer/mdv/commit/22c32ebfa84b6e08341b2e1af71a25b5bee4b2be

R=sigmund@google.com

Review URL: https://codereview.chromium.org//18162004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24660 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 21:38:45 +00:00
efortuna@google.com 3629744086 "Reverting 24655"
BUG=

Review URL: https://codereview.chromium.org//18277003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24656 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 21:09:19 +00:00
efortuna@google.com fc0df10d8b Expand overloaded methods and optional parameters in the html library.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//16494002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24655 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 20:49:07 +00:00
amouravski@google.com 894a503bfd Fixed a typo that broke tests.
Review URL: https://codereview.chromium.org//18379002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24644 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 19:05:46 +00:00
amouravski@google.com c0a39d0412 Make html metadata follow the spec.
Per https://code.google.com/p/dart/issues/detail?id=11568

R=scheglov@google.com

Review URL: https://codereview.chromium.org//18182010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24638 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 18:34:30 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors.
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
blois@google.com 7c12f9ea0f Fixing analyzer warnings on overloading == but not get hashCode.
BUG=11613
R=sra@google.com

Review URL: https://codereview.chromium.org//18034021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24614 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 22:36:50 +00:00
blois@google.com f191d0d4de Fixing DateTime values in serialized script values.
This allows Dart's DateTime objects to be passed as serialized script values. Especially useful for DB values.

BUG=11449
R=sra@google.com

Review URL: https://codereview.chromium.org//17574008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24608 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 20:55:23 +00:00
amouravski@google.com 13c403d83a Added named constructors to Element to construct common elements.
R=blois@google.com

Review URL: https://codereview.chromium.org//18089011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24606 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 20:34:56 +00:00
blois@google.com 0c17281a29 Fixing type error for WebGL's getShaderParameter.
Was preventing the return of bools in dart2js.

BUG=11487
R=efortuna@google.com

Review URL: https://codereview.chromium.org//18089016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24599 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 17:54:42 +00:00
jmesserly@google.com c326893f6a Continue updating MDV.
add OPTGROUP as an attribute template -- https://github.com/Polymer/mdv/commit/af1733d905ac96852357db5e7a78a63ba2a488fc
template ref should check treeScope.getElementById -- https://github.com/Polymer/mdv/commit/7de0697e318bb001e1649005ec48eb294edad6e4
Use correct event type for checkbox bindings -- https://github.com/Polymer/mdv/commit/2c675cab75aea2ef3d1b981a616469587b9210fe

Review URL: https://codereview.chromium.org//17917002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24562 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 23:30:33 +00:00
jmesserly@google.com fca7d29b2c Disallow template instances when !parentNode || !owner.defaultView https://github.com/Polymer/mdv/commit/d035acecab7c2d1afd9eb67bb01818d7ed9eb11f
extract template element from attribute templates. https://github.com/Polymer/mdv/commit/13741f22d94cec1d7ca115f023cf3a25b9245def

Note: this is based on https://codereview.chromium.org/17552019/ (reorg mdv)

R=justinfagnani@google.com

Review URL: https://codereview.chromium.org//17706003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24546 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 19:59:04 +00:00
ricow@google.com af21d74d2d Fix safari browser to use Future.value
Also correct type errors found by the analyzer.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//18089005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24532 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 17:07:17 +00:00
ricow@google.com 545f6e1341 Update checked in binary to version 0.5.19.0
This is a reland of r24086 with a fix catching errors in the websocket server in tools/testing/dart/http_server.dart.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//18065003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24520 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 16:10:59 +00:00
ricow@google.com de1180fa94 Change the target that we build on the android bot from samples to runtime
It seems that the sample is broken, do we even support this?

R=efortuna@google.com, vsm@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//17854002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24507 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 05:59:15 +00:00
jmesserly@google.com 5ec4d52def fix analysis issue caught by dart2js bots
TBR

Review URL: https://codereview.chromium.org//17973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24501 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 00:06:30 +00:00
jmesserly@google.com d6b9207588 Reorganize mdv and observe functionality
* keep correct dart:html APIs
* move implementation into package:mdv and package:observe
* remove dart:mdv_observe_impl
* remove getValueWorkaround/setValueWorkaround from package:observe

R=blois@google.com, floitsch@google.com, justinfagnani@google.com

Review URL: https://codereview.chromium.org//17552019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24498 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 23:25:47 +00:00
sra@google.com 4d9098cb0e Move some native type dispatch tags from runtime into class definitions.
R=blois@google.com

Review URL: https://codereview.chromium.org//17893009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24488 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 20:40:02 +00:00
blois@google.com edf30f6b20 Exposing Node.firstChild and Node.lastChild.
These are the most efficient way access children and are very commonly used.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//17909002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24476 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 16:53:50 +00:00
amouravski@google.com 1a6eb93f25 Added link to HTML5 samples to the top of HTML library.
Bug: https://code.google.com/p/dart/issues/detail?id=9954

R=efortuna@google.com

Review URL: https://codereview.chromium.org//17793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24452 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 06:29:16 +00:00
amouravski@google.com a3f57b00ab Fixed old docs for WebSocket.
Bug: https://code.google.com/p/dart/issues/detail?id=10507

R=efortuna@google.com

Review URL: https://codereview.chromium.org//17792002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24451 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 06:17:09 +00:00
amouravski@google.com 67ab947580 Added minimal documentation to the KeyboardEvent class.
Bug: https://code.google.com/p/dart/issues/detail?id=11483

R=efortuna@google.com

Review URL: https://codereview.chromium.org//17759006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24450 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 06:15:18 +00:00
amouravski@google.com 304a2c477b Fix typo in documentation of CanvasElement.toDataUrl.
Bug: https://code.google.com/p/dart/issues/detail?id=10994

R=efortuna@google.com

Review URL: https://codereview.chromium.org//17789002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24449 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 06:12:21 +00:00
jmesserly@google.com 7fd6e0a3dc Restore adoptNode and importNode to dart:html
http://dom.spec.whatwg.org/#dom-document-importnode
These seem more relevant in a <template>/ShadowRoot world. In particular I wanted to port an MDV test that uses adoptNode.

R=blois@google.com

Review URL: https://codereview.chromium.org//17681003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24423 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 18:02:26 +00:00
kustermann@google.com 48527d06cd Revert "Do not compile tests for different browsers separately"
We have to use subdirectories instead of special names in the javascript files.

R=ahe@google.com

Review URL: https://codereview.chromium.org//17601013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24408 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 14:37:53 +00:00
kustermann@google.com 3b23ea198f Bugfix: make the new compilation artifact layout also work with dart2dart
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//17619013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24407 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 13:59:49 +00:00
kustermann@google.com 30511a9190 Bugfix in test_suite.dart
R=ricow@google.com

Review URL: https://codereview.chromium.org//17644011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24404 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 13:38:56 +00:00
kustermann@google.com f6e9601c01 Do not compile tests for different browsers separately
Currently we recompile tests with dart2js for all browsers. There is no
need to do these compilations for all browsers, since the output should be
exactly the same.

R=ricow@google.com

Review URL: https://codereview.chromium.org//17570018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24402 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 13:25:11 +00:00
ricow@google.com ee35be8712 Simplify close functionality in the browser controller.
Add a done future that can be used by users to determine if a browser crashes.

This future is the same we return from the close call.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//17633008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24395 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 11:35:24 +00:00
blois@google.com e1221d88fc Running go.sh
TBR
BUG=

Review URL: https://codereview.chromium.org//17572018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24376 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 23:32:58 +00:00