Alexander Thomas
a96b4f6dfe
[homebrew] Add support for the beta channel formula
...
This changes to the homebrew tooling to modify instead of replace the
formulas. The formulas can now be changed by editing them in the
dart-lang/homebrew-dart repo, rather than in the release tooling.
Also adds a dry-run mode for local testing.
https://github.com/dart-lang/sdk/issues/40990
Change-Id: Ibed90894800e4d84fac3c4558e6f08d629baed62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141244
Reviewed-by: William Hesse <whesse@google.com >
2020-03-27 14:17:40 +00:00
Karl Klose
7387682bec
[infra] Handle test steps with no tested configuration
...
Change-Id: I95543f88a64884bf2334165baa986d381bbf7872
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141241
Commit-Queue: Karl Klose <karlklose@google.com >
Reviewed-by: Karl Klose <karlklose@google.com >
2020-03-27 07:09:37 +00:00
Daco Harkes
445d279ff3
[vm] Add Reachability Fence Instruction
...
The reachability fence keeps a value alive and reachable.
Required for finalizers: https://github.com/dart-lang/sdk/issues/35770
Design: go/dart-ffi-finalizers (See "Premature Cleanup (Single Object)".)
Change-Id: I9742889f0f8d8b15bbcb5dca47f2a4231899dd59
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,dart-sdk-linux-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,front-end-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try,vm-kernel-mac-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136188
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2020-03-26 18:30:44 +00:00
Srujan Gaddam
fcc43457b3
[dart:html] Add nullability to EventTarget conversion
...
initMouseEvent uses this conversion to call the native function,
and it is allowed for the EventTarget to be null in the native
call.
Change-Id: I345e82fa00f4cca72e15f713cd7a271d306b7d37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141040
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-03-26 16:36:14 +00:00
Karl Klose
f6acefa078
[infra] Ensure configuration names for custom test-runner steps are valid
...
Change-Id: I1bf57a3258aeb37f5fee485bde9a74a2ff3af8ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139803
Commit-Queue: Karl Klose <karlklose@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2020-03-26 07:01:27 +00:00
Jonas Termansen
188ab04445
[infra] Delete approve_results.
...
Change-Id: I43346ff69e6b82f700a06b52bdff891122d38572
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128551
Reviewed-by: Alexander Thomas <athom@google.com >
2020-03-25 10:27:40 +00:00
Leaf Petersen
72086df689
Bump ABI version for runZoneGuarded.
...
New API (runZonedGuarded) was added to the core libraries.
Bug: https://github.com/dart-lang/sdk/issues/41192
Change-Id: Iae56be055bf1e23051fdc93b07ac2db2902c9bd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140880
Auto-Submit: Leaf Petersen <leafp@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2020-03-25 03:43:19 +00:00
Ryan Macnak
b5d657c3f0
[vm] Fix memory leaks during ELF generation.
...
Change-Id: I8c7d5506a91a4e2190951e083438fee652b736ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140371
Reviewed-by: Teagan Strickland <sstrickl@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-03-24 01:09:35 +00:00
Srujan Gaddam
ed41036d2f
[dart:html] Migrate NodeValidator fix to NNBD
...
Addresses failure in api_dynamic_test, and copies the
vulnerability fix from src to nnbd_src.
Closes https://github.com/dart-lang/sdk/issues/41158
Change-Id: Ic1c6766c066174f4d0504e429ed70f1ce0a487e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140645
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-03-24 00:46:55 +00:00
Kevin Moore
6a5d73dfe7
Address a vulnerability in node validator
...
Related to DOM clobbering of previousSibling
Change-Id: Ib4ed1cdba4217c351804b0689a999b73713f79ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140622
Auto-Submit: Kevin Moore <kevmoo@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-03-23 20:01:58 +00:00
Liam Appelbe
b3c89f4b92
[tools] Fix addlatexhash.dart in NNBD mode
...
The List() constructor isn't allowed anymore, so switched to [].
This fixes addlatexhash_test.dart in weak NNBD mode.
Change-Id: I8070c6d1ea74b58e75db02aead8905f42f555156
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140662
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Liam Appelbe <liama@google.com >
2020-03-23 19:47:52 +00:00
Alexander Thomas
8350f423ee
[vm] Add the channel name to the VM/dart:io version string
...
Dev and beta version strings will look very look very similar, so adding
the channel name will make it easy for users to see if they are on be,
dev, beta, or stable. This will change both the output of
`dart --version` as well as the value of `Platform.version`.
This also removes the Flutter stable release version hack.
Fixes https://github.com/dart-lang/sdk/issues/40993
Change-Id: Iceb8e84a9cf4d0bfb7659669878e42d0a59febc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140287
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2020-03-23 10:00:03 +00:00
asiva
1a8d6ad16e
[VM] Bump ABI version to 30
...
Change-Id: Icb60b5ea76a6cbb053d0841be65616b416aaa122
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140260
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
Auto-Submit: Siva Annamalai <asiva@google.com >
2020-03-20 04:59:50 +00:00
Ben Konyi
a74e877104
[ package:dds ] Initial commit of the Dart Development Service, package:dds
...
- Defined initial interface
- Currently can spawn an HTTP server and forward websocket and HTTP
requests to the VM service
- Simple smoke tests
- Initial documentation in dds_protocol.md and other book keeping
- Enabled analysis on bots
Change-Id: Ia11e9e33fd10b0b4700b704a29e2977341441cec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139542
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2020-03-19 23:36:45 +00:00
asiva
a980fb1849
[Tests/NNBD] - Migrate initial set of isolate tests for NNBD.
...
Fix all warnings/errors when running with --enable-experiment=non-nullable flag
Change-Id: I7673aa34466273d623f7a429d96b0ccd6b612dae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139980
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2020-03-19 20:07:58 +00:00
Alexander Thomas
97afe8410a
[beta] Support the beta channel in SDK scripts
...
Fixes https://github.com/dart-lang/sdk/issues/40992
Change-Id: Icc6888c94517667a184931d3e690db2fe67cc0ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139814
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2020-03-19 07:49:38 +00:00
Joshua Litt
44669206b3
[dart2js] Fix html_dart2js to handle null argument.
...
Change-Id: I711261840fd733ecf640586b82da54d6f61c6bb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139746
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Joshua Litt <joshualitt@google.com >
2020-03-17 17:11:36 +00:00
Alexander Thomas
c816525c29
[infra] Add support for the beta channel to promote.py
...
Closes https://github.com/dart-lang/sdk/issues/40984
Change-Id: I0459b3709cc008890d4d66c3b0f98cc5b4fd6b36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139281
Reviewed-by: William Hesse <whesse@google.com >
2020-03-13 10:53:26 +00:00
asiva
c3673bdca4
[VM/Testing] - Turn on testing in strong NNBD mode.
...
Change-Id: I272de0ca65afb4327d9ec6457c7e514fb1c73449
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139030
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2020-03-11 04:04:49 +00:00
Sigmund Cherem
bff20985ce
[cfe] remove whitelist of opt-out packages
...
Closes https://github.com/dart-lang/sdk/issues/40775
Change-Id: Ib713494edf34046bbf7de43811659863fbc5884e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138901
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2020-03-11 03:19:59 +00:00
asiva
7617e327a1
[VM/Testing] - Turn on co19_2 legacy testing in NNBD bots.
...
Change-Id: I5592a5a8d6dfd068e45ecf9b4ec2d12fbe67b4a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138621
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Liam Appelbe <liama@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2020-03-09 16:24:07 +00:00
William Hesse
a4f6479998
[infra] Print details of unapproved (new or previous) failures in build failure message
...
Change-Id: Ic9f9151f5884b636b902b5ba6b7d2c35cec6417b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138287
Reviewed-by: Karl Klose <karlklose@google.com >
2020-03-09 15:11:40 +00:00
Karl Klose
7bdc910670
[infra] Remove unused bot script
...
Change-Id: Id65295b28642c0faf3db89aa383696bd8c8e8ccd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138292
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Karl Klose <karlklose@google.com >
2020-03-09 07:29:00 +00:00
Sigmund Cherem
a410f5bde1
[dart2js] rename null-safety flag and plumb through CFE
...
The new flag name follows the changes in https://github.com/dart-lang/language/pull/779 , the change also is converging on not having each tool infer a default on the input, but rely on build systems to provide the appropriate flag instead.
Fixes https://github.com/dart-lang/sdk/issues/39979
Change-Id: I39c143b7985dbfe6dab5dfd9a7347a7a4420479b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138569
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2020-03-06 02:22:41 +00:00
Sigmund Cherem
800f4b10d4
run co19 and lib2 on dart2js nnbd bots
...
Change-Id: I7e458f0d2351a31a4c5cb1afc2fcb4d7ffce0378
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138420
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2020-03-05 01:41:33 +00:00
Ryan Macnak
df5036eb6e
[vm] Require only an isolate group, not an isolate, in Dart_Delete[Weak]PersistentHandle.
...
Remove the now-misleading isolate parameter of Dart_DeleteWeakPersistentHandle.
Bug: https://github.com/dart-lang/sdk/issues/40836
Change-Id: I784f1ecf564484b59f60ebef53ddb975aff1bd23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138015
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2020-03-04 18:56:16 +00:00
Alexander Thomas
800008ba64
[infra] Run more migrated tests on the analyzer-nnbd builder
...
Change-Id: I03a070bc09c9e90cf1f27bacdfe8489a1bcf7846
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138090
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-04 09:36:00 +00:00
Alexander Thomas
38cc00cd2c
[infra] Balance the number shards on the AOT builder with co19_2 tests
...
The regular test shards run in about half the time. Therefore, we can
use less shards for overall efficiency without sacrificing cycle time.
TBR=asiva@google.com
Change-Id: Ib8b58a03f9c40d0e8f288cde6e148a54fc1ed1e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138300
Reviewed-by: Alexander Thomas <athom@google.com >
2020-03-04 09:07:55 +00:00
asiva
23106da62e
[VM/Testing] - Added co19_2 tests to vm-precompiled-linux-release-x64 builds
...
Change-Id: I93b799c0c3db12a3e4755ee8c55006ec77855301
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138052
Reviewed-by: Alexander Thomas <athom@google.com >
2020-03-04 09:07:55 +00:00
Régis Crelier
5701c4fd3b
[VM/nnbd] Remove propagation of library mode to runtime after spec change.
...
On 1/27/20, the nnbd specification changed weak and strong mode instance checks
to make them behave uniformly across legacy and opted-in libraries.
Therefore, it is not necessary anymore to propagate the library mode in
generated code to the runtime.
Change-Id: I42d3ddc6e9a921899aeac21be6374c7893a6d27c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138111
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2020-03-03 20:30:32 +00:00
Paul Berry
d0826bdbd5
Add current-version field to tools/experimental_features.yaml.
...
Previously, each top level key/value pair in the file represented a
feature, so in order to make room for the new field, these were all
moved under a "features:" header.
Code generators have been updated to produce the same result as they
did before; in future CLs I'll update them to generate code based on
the new field.
Change-Id: Ia2266dd0d92796f15460127742eb2b56f64438e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-03-03 19:25:44 +00:00
Alexander Thomas
817d0650b9
[infra] Add ffi-qemu builder to the test matrix
...
Change-Id: Ic6d2547fc144bf0452d6b32ffa754d858ebacec7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137967
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2020-03-03 13:33:29 +00:00
Srujan Gaddam
5b23373f7e
Modify fields in some abstract and native classes
...
Since we transitioned to natives for dart:html, manually written native
fields should be rewritten. Similarly, if there are fields in abstract
classes that represent interfaces, they should be converted. Fields in
abstract classes that are used in that class are left alone.
Change-Id: I924363639a4430b88b810b7348815bbc3f040e7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137642
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2020-02-29 01:29:35 +00:00
Srujan Gaddam
9f79dfc37d
Address analyzer errors in golden files in dart:html
...
New analyzer errors are reported for dart:html around nullability.
Non-nullable fields are translated to native getters and setters if part
of a concrete class and normal getters and setters if abstract.
Change-Id: I2fd87803a08872b2a7eae4de0af704f184997c7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137481
Reviewed-by: Stephen Adams <sra@google.com >
2020-02-29 01:29:35 +00:00
Srujan Gaddam
80f84e1942
Change all fields to native getters/setters
...
Bug: https://github.com/dart-lang/sdk/issues/40772
Attributes are translated to native getters and setters regardless of
NNBD. Some logic was removed for fields that no longer apply due to this
change.
Change-Id: Ia1a05778ff8c6f082506a1c95a3057a7c5f7f896
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136880
Reviewed-by: Stephen Adams <sra@google.com >
2020-02-29 01:29:35 +00:00
Srujan Gaddam
3ec6ec2a2d
Change getters/setters to native for nnbd
...
NNBD fields that were non-nullable or final were transformed to getters
so that they were compilable. They need to be transformed to natives now
for performance.
Change-Id: Ice0082f9468c542098a6d12083a826438d15eba4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135860
Reviewed-by: Stephen Adams <sra@google.com >
2020-02-29 01:29:35 +00:00
Robert Nystrom
4f01e01d1f
Sort the tests needing migration work.
...
Got tired of hopping around the lists of tests randomly.
Change-Id: If8e5f915b7871d8ae916e565d9d4e787a44c6a50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137724
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2020-02-28 01:00:34 +00:00
Ryan Macnak
60c86a4009
[vm, gc] Fix races related to Scavenger::AddAbandonedInBytes and UsedInWords.
...
[infra] Run fewer tests under TSAN. TSAN has a significantly higher overhead than the other sanitizers.
Change-Id: I92b69923e93fa4634168352bdbe30d6ee7e7f72d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137402
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-02-27 18:01:13 +00:00
Robert Nystrom
4b7ba5a72f
Add a script to generate a package_config.json for the SDK.
...
Also include the generated output.
Change-Id: Ic2818f544972c737f69913122e366ea48375e950
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135795
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-02-27 17:52:23 +00:00
Sigmund Cherem
5055c98bee
[dart2js] switch bot to use hostaserts once again
...
This changes how we used String.fromEnvironment to enable tracing.
With null-safety http://dartbug.com/40678 means that these constants are
never null, so we were accidentally enabling tracing by default.
I was only able to see this when running dart2js from source
(which affects the hostasserts configuration), but I wasn't seeing this
when running from snapshot. We need to investigate that separately.
Change-Id: Ic362967d2f0daf5f9c0e1659c6a024ca9a44358f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137286
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2020-02-26 21:41:47 +00:00
William Hesse
fb9efd4b68
[infra] Send a tryjob's base commit hash when publishing results to pubsub
...
Change-Id: I2813a6a180d8be8e55c1c49f2686e53e533c6bc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137105
Reviewed-by: Alexander Thomas <athom@google.com >
2020-02-26 09:55:59 +00:00
Alexander Thomas
f304dac144
[infra] Add strong mode testing to the CFE builder
...
Change-Id: I0add8fdb5aeb768c52f6140f838ee2987ac4d132
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137060
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-02-26 01:48:57 +00:00
Alexander Markov
55cc495451
[vm/nnbd] Rename --strong-non-nullable-type-checks to --null-safety and pass it to CFE
...
Issue: https://github.com/dart-lang/sdk/issues/38845
Change-Id: I9baeb4a384a6b2de79df9f97e82c127ae4f611c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137120
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Liam Appelbe <liama@google.com >
2020-02-25 20:05:39 +00:00
Alexander Markov
aa2c1a4950
[vm/nnbd] Add --null-safety option to VM's kernel compilers
...
This change adds --null-safety option to the front-end server and
gen_kernel tools. This option is forwarded to CFE via
CompilerOptions.nnbdMode.
Issue: https://github.com/dart-lang/sdk/issues/38845
Change-Id: I410b1d5466d93d9514cb7571bf37b32c848f136c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137106
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-02-25 19:04:43 +00:00
Martin Kustermann
767943850f
[vm] Enable check_initialization_order for ASAN, ensure tools/test.py always passes ASAN options, make Random be initialized during VM startup
...
Running tools/test.py locally behaves differently than on the bots
because the bots will have special environment variables set.
=> We want also local runs of tools/test.py to report ASAN errors, so
this CL moves the setting of environment variables to tools/test.py
Furthermore we enable "additional check_initialization_order=true" asan
option to detect ordering issues when initializing global state.
Make the IsolateGroup::isolate_group_random_ heap allocated on VM
startup to avoid initialization ordering issue (turns out our `Random`
can depend on embedder entropy source callback being available)
Also add locking around assigning of isolate group ids -- without it we
could have two threads racing and possibly getting the same id.
See b/149978682
Change-Id: I41b9a34c66934dcc0d3804233f5acf09004ba3bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136630
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2020-02-25 10:32:01 +00:00
Clement Skau
6a90bf5d54
[Cleanup] Removes deprecated --(no-)enable-malloc-hooks from test_matrix.json.
...
Change-Id: I5d7d9b3e75b878d78e905934afed8b9327863766
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136200
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Clement Skau <cskau@google.com >
2020-02-25 09:34:40 +00:00
Nicholas Shahan
330711ab69
[tests] Add dart2js nnbd SDK analysis test to analyzer bot
...
Run this test on the dart2js patched SDK too until the CFE
starts reporting all errors.
Change-Id: Ib943d6516382a3edc5dfe9906d4d0d6fb97fe076
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136808
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-02-24 22:47:58 +00:00
Ryan Macnak
73f6d15665
[build] Update clang and gn to match Fuchsia.
...
This new version has functional TSAN.
Bug: https://github.com/dart-lang/sdk/issues/39611
Change-Id: Ia9835fb6ad6de73f43faea695f893ed0c62fffa7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136380
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-02-24 21:04:18 +00:00
Alexander Markov
070f67a05b
[gardening] Remove obsolete Flutter HHH patch
...
This change was submitted into Flutter/flutter already
(https://github.com/flutter/flutter/commit/6f9ed76faf9fe7f254291cc5bf9c5ffe4c459487 ),
so removing this patch as it cannot be applied anymore and causes
Flutter HHH to fail.
Change-Id: Ic1b44f0ec0c85b9d343079f8a067cd59ebf37170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137040
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2020-02-24 20:34:46 +00:00
Samir Jindel
17ec4a8433
[vm] Fix 3xH bot.
...
The corresponding Flutter change is made in https://github.com/flutter/flutter/pull/51330 .
Change-Id: Ib3f233cd4153c04b22ba10e30eb532186fc9fb97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136961
Reviewed-by: Clement Skau <cskau@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
2020-02-24 11:37:37 +00:00