Commit Graph

6631 Commits

Author SHA1 Message Date
Terry Lucas 3cbacefbe3 Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken without this annotation.
R=alanknight@google.com,sigmund@google.com

Review-Url: https://codereview.chromium.org/2932793002 .
2017-06-08 20:44:30 -07:00
Bob Nystrom 8bc4e89219 Remove unused record and replay functionality.
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2920633002 .
2017-06-08 09:18:03 -07:00
Sigmund Cherem 9c32854d44 Use the correct sources for dartium in patched_sdk for vm
BUG=
R=ahe@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2923043004 .
2017-06-06 12:03:16 -07:00
William Hesse 33fe148c51 Update checked-in SDK to 1.24.0-dev.6.8
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2922273003 .
2017-06-06 17:05:09 +02:00
Martin Kustermann 2c41c608f1 Roll dartium to pull in changes art_SaveCompilationTrace/_Dart_LoadCompilationTrace
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2927553002 .
2017-06-06 13:36:46 +02:00
Terry Lucas ffa45b00fe Updated to latest WebKit change. Support --dump-render-tree switch.
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2923673002 .
2017-06-05 13:45:15 -07:00
Ryan Macnak b69b3e58f0 Update test.py's --arch=all to match that of build.py.
R=zra@google.com

Review-Url: https://codereview.chromium.org/2918403002 .
2017-06-05 13:07:30 -07:00
Terry Lucas c630b89171 Update to latest WebKit
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2913993005 .
2017-06-02 12:11:48 -07:00
Alexander Aprelev 6573c74301 Reenable vm tests with -cdartk DFE parser.
This was accidentally disabled in 7e2d9ac85d.

BUG=#28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2920733004 .
2017-06-02 09:34:11 -07:00
William Hesse ae4c38bf54 Fix versionchecker script
BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2919933003 .
2017-06-02 11:28:57 +02:00
Lasse R.H. Nielsen 5720e3556c Add negation to single-identifier tests in status files.
Optimize some regegps too.

Fixes #29756

BUG= http://dartbug.com/29756
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2913963002 .
2017-06-02 10:38:14 +02:00
Bob Nystrom db06324975 Remove temp code to ignore "--failure-summary".
Now that the BuildBots aren't passing it, we don't need to accept it.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2916123002 .
2017-06-01 15:45:55 -07:00
William Hesse e161ad12ac Allow test.py to run dartdoc tests. Run dartdoc tests on pub bots.
BUG=
R=jcollins@google.com

Review-Url: https://codereview.chromium.org/2914233002 .
2017-06-01 18:53:04 +02:00
Erik Ernst 80c5b67980 Added find-shard to bot.dart.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2915043002 .
2017-06-01 16:25:29 +02:00
William Hesse dfbce8f779 Start working on version 1.25 of Dart SDK
BUG=
R=kasperl@google.com

Review-Url: https://codereview.chromium.org/2920753003 .
2017-06-01 13:54:22 +02:00
Johnni Winther f1472ed8bb Fix gardening/bot help messages
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2919693003 .
2017-06-01 11:32:58 +02:00
Johnni Winther 0e61716730 Add BuildBotClient to abstract http/logdog access
+ support error handling for logdog

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2912343002 .
2017-06-01 10:02:04 +02:00
Ryan Macnak 189dafd99f Roll Dartium to "Add _Dart_CreateCoreJITSnapshotAsBlobs to framework.order for MacOS."
Review-Url: https://codereview.chromium.org/2919673002 .
2017-05-31 17:55:08 -07:00
Bob Nystrom a9d4afc077 Handle "ff" as a runtime name in status files.
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2917843002 .
2017-05-31 17:49:22 -07:00
Bob Nystrom 7e2d9ac85d Revert "Revert "Replace the configuration map with a typed object.""
This reverts commit 8bada4873a.

R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2919573003 .
2017-05-31 15:39:23 -07:00
Bob Nystrom 8bada4873a Revert "Replace the configuration map with a typed object."
This reverts commit 06f75fe5cd.

Review-Url: https://codereview.chromium.org/2914893003 .
2017-05-31 15:08:21 -07:00
Bob Nystrom 06f75fe5cd Replace the configuration map with a typed object.
This is a pretty massive change but my hope is it will make
test.dart easier to maintain going forward. Instead of
passing around a stringly-typed Map<String, dynamic> all
throughout the program, we parse the options and then create
a Configuration object that has typed getters for all of the
various bits of configuration data.

This is a little tedious because it means declaring a new
option requires also declaring a corresponding field in the
Configuration class and passing it through the constructor.
I think it's worth it.

Also, enum-like configuration properties like architecture
and runtime now have their own classes as well. Moved a
bunch of stuff from TestUtil into those classes now that
there is an object to hang those methods off of.

In the process, I found a few typos in string literals where
the code wasn't correctly looking up a configuration
property.

Added more sanity checking and validation to status file
parsing. You will get an error at parse time if you try to
refer to a variable that isn't in the whitelist of known
variables. Also, you'll get an error if you try to compare
a variable to a value that it isn't expected to have.

Many other small-scale cleanups.

Aside from the status file validation, this should behave
mostly the same as current test.dart except that tests
may be enqueued in a slightly different order. The
rewritten code for expanding configurations iterates
through the architecture, runtime, etc. options in a
slightly different order.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2901923003 .
2017-05-31 14:47:31 -07:00
Ryan Macnak 76df24b076 CoreJIT snapshots without training.
Only include OSR and field guards in the features descriptor for JIT code to avoid gen_snapshot and dart having different default values.

Disabled since core snapshots with code break tests with non-default flags for type checks, assertions, strict errors, OSR, or field guards.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2902313004 .
2017-05-31 13:49:12 -07:00
Florian Loitsch 5aa5295e08 Add a 'bot.dart' executable to the gardening tools.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2908403002 .
2017-05-31 16:36:37 +02:00
William Hesse 499cb29c70 Roll Dartium's buildtools to a version with valid DEPS
BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=727587
R=ahe@google.com, terry@google.com

Review-Url: https://codereview.chromium.org/2912383003 .
2017-05-31 16:11:52 +02:00
Terry Lucas b987a126c5 Update Dartium specific DEPS inline in the vars, deps, hooks and deps_os.
More updates to get Dartium to build properly on bots (latest gclient update has removed functionality).

TBR=whesse@google.com

Review-Url: https://codereview.chromium.org/2912183002 .
2017-05-30 17:50:59 -07:00
Alan Knight 75a1eaef7e Fix dataTransfer getter
BUG=

Review-Url: https://codereview.chromium.org/2907273003 .
2017-05-30 15:14:40 -07:00
Bob Nystrom 7ce978bf91 Tighten types in test.dart even more.
This removes all implicit casts and many implicit uses of dynamic. It
adds a gratuitous number of explicit "as" casts and arguably makes the
code worse.

This is an interim step towards replacing the big configuration map
with an actual typed object. These "as" casts should help catch places
where the configuration object is being used and where the code will
need to be changed to use a new object.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2903703002 .
2017-05-30 14:02:24 -07:00
William Hesse 74907cc891 Import DEPS.chromium into Dartium DEPS by copying
The new DEPS file validator does not support the python code
we use to import this file from the same directory.

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=727587
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2912913002 .
2017-05-30 11:53:14 +02:00
Bob Nystrom c296f75d10 Revert "Revert "Revert "Revert "Refactor test option parsing code.""""
This reverts commit 02547656cc.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2904313002 .
2017-05-26 15:04:55 -07:00
Bob Nystrom 02547656cc Revert "Revert "Revert "Refactor test option parsing code."""
This reverts commit 79af418430.

Review-Url: https://codereview.chromium.org/2912563002 .
2017-05-26 14:46:04 -07:00
Bob Nystrom 79af418430 Revert "Revert "Refactor test option parsing code.""
This reverts commit d03835783c.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2908833002 .
2017-05-26 14:18:13 -07:00
Bob Nystrom d03835783c Revert "Refactor test option parsing code."
This reverts commit 9c2dff8ebc.

R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2909723002 .
2017-05-26 13:51:26 -07:00
Bob Nystrom 9c2dff8ebc Refactor test option parsing code.
This doesn’t touch the resulting configuration map, which is what this
is leading up to, but it cleans up the specification and parsing of the
options and removes a lot of redundancy.

Behavior should be the same as it was before, except that all options
now allow both their underscore-separated and hyphen-separated names.
So this is now valid:

test.py --hot_reload --append-logs

Where before, you use to have to do --hot-reload (OK) and
--append_logs (bad, since almost all other options expect hyphens).

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2902023002 .
2017-05-26 13:36:44 -07:00
Alan Knight d21cc80a54 Add a dataTransfer member to MouseEvent
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2899393004 .
2017-05-25 14:05:10 -07:00
Terry Lucas 20dc749844 Suppress Scale interface - unused.
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2901213006 .
2017-05-25 12:54:38 -07:00
Alan Knight 6f71f9c80b Revert "[Experiment] Stop suppressing DragEvent"
This reverts commit fbbb974670.

Also updates the cached_patches.dart file.

BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2907563003 .
2017-05-25 11:16:10 -07:00
Peter von der Ahé 27761fd369 Read SDK and patches from a JSON file.
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2895983002 .
2017-05-25 15:57:57 +02:00
Alexander Aprelev 16c0db1022 Revert "Revert "With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend parser.""
This reverts commit e0cdea811a.

Update status of vm tests, that don't work with DFE yet.

BUG=https://github.com/dart-lang/sdk/issues/28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2895153005 .
2017-05-24 20:16:48 -07:00
Ryan Macnak 14ec8fa979 Use assembly instead of C array literals to link the core snapshot into the VM.
Allows for including instructions.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2901163002 .
2017-05-24 14:38:15 -07:00
Alan Knight b4b02daade Include DDC fixes to dart:html in the main version
BUG=
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2899173002 .
2017-05-24 12:49:13 -07:00
William Hesse b2e445c13a Add missing comma to DEPS file
This fixes an error in commit
0fa3c6e179
https://codereview.chromium.org/2901773005

TBR=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2897173004 .
2017-05-24 12:18:41 +02:00
William Hesse 0fa3c6e179 Update Dartium source with build fix for MacOS
BUG=

Review-Url: https://codereview.chromium.org/2901773005 .
2017-05-24 11:20:59 +02:00
Alan Knight e6c38ea30f Remove JS_CONST from CssStyleDeclaration, causes DDC problems
BUG=
R=sra@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2896393002 .
2017-05-23 14:48:08 -07:00
William Hesse 737a55cc63 Fix some issues with buildbot recipe change.
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2903603002 .
2017-05-23 16:51:37 +02:00
William Hesse a4adc426e1 Remove old annotated_steps buildbot scripts and dispatcher
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2895973002 .
2017-05-23 16:17:02 +02:00
Alexander Aprelev e0cdea811a Revert "With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend parser."
This reverts commit f62a2a9562.

Commit above [expectedly] broke runtime/vm tests since it uses DFE
instead of vm parser, but I didn't realize we actually test -cdartk
configuration. This has to be resubmitted with status file update to
mark 235 vm tests failing with DFE.

TBR=siva
BUG=

Review-Url: https://codereview.chromium.org/2901733002 .
2017-05-22 19:42:53 -07:00
Alexander Aprelev f62a2a9562 With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend parser.
BUG=https://github.com/dart-lang/sdk/issues/28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2881833003 .
2017-05-22 17:24:38 -07:00
Alan Knight fbbb974670 [Experiment] Stop suppressing DragEvent
BUG=
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2898673003 .
2017-05-22 14:10:05 -07:00
Zachary Anderson 467dad857e Adds deprecation messages for MIPS cross-builds
fixes #29678

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2899803002 .
2017-05-22 13:35:23 -07:00