dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6631 Commits

Author SHA1 Message Date
Vyacheslav Egorov 2fbc6b9a2e [gardening] Make apply.sh script force update git cache used by bots 
R=kustermann@google.com

Change-Id: Id03377dbe4a294032d41a612076b933b447fd2f6
Reviewed-on: https://dart-review.googlesource.com/c/85287
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-11-23 15:03:57 +00:00
Vyacheslav Egorov 1ed5f78e9c [gardening] Make apply.sh script fetch before trying to checkout. 
TBR=kustermann@google.com

Change-Id: I195100218b7d83eee4647d5baf254c075e7492df
Reviewed-on: https://dart-review.googlesource.com/c/85286
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-23 13:48:08 +00:00
Vyacheslav Egorov c62af758ee [gardening] Switch apply.sh script to use bash instead of sh 
R=sortie@google.com

Change-Id: I30d39d4edf864d0307d18c8fd095649cfe3ed17c
Reviewed-on: https://dart-review.googlesource.com/c/85284
Reviewed-by: Jonas Termansen <sortie@google.com>
 2018-11-23 13:31:15 +00:00
Vyacheslav Egorov 01380ede49 [gardening] Expand 3xHEAD Flutter patch mechanism to support DEPS file changes. 
We don't rerun gclient sync after applying patches so changes to Dart
dependencies were not picked up.

Change-Id: I4360ddf7f906ab0552bd3ae8abbe9210a785845a
Reviewed-on: https://dart-review.googlesource.com/c/85282
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-11-23 13:10:25 +00:00
Vyacheslav Egorov ba0222df78 [flutter] Update flutter-engine-linux 3xHEAD patch. 
dart2js_info dependency is upgraded to 0.5.15 from 0.5.13

Change-Id: I3077c7953af17c610864d309e9f17e350a560fba
Reviewed-on: https://dart-review.googlesource.com/c/85262
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-23 11:37:36 +00:00
Paul Berry e649ed1aa3 Merge commit 'c1daa3276566e48dac6f52742264578092c56a35' into analyzer 2018-11-21 08:47:55 -08:00
Martin Kustermann 8044e32fc5 [infra] Blacklist android device id in attempt to make buildbot builder more stable 
This particular device sometimes fails with errors such as:

  * "protocol error"
  * "protocol error (no status)"
  * "device not found"

Change-Id: Iced97ae8f5e891c43436a3d745004517dc59b42c
Reviewed-on: https://dart-review.googlesource.com/c/84905
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-11-20 21:25:04 +00:00
Alexander Aprelev c8372c00dc Patch hhh flutter flutter as follow-up to https://dart-review.googlesource.com/c/sdk/+/84688 
Change-Id: I392ad11684eedee143cab9e90227c6b886e09c12
Reviewed-on: https://dart-review.googlesource.com/c/84960
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-11-20 20:15:51 +00:00
Alexander Aprelev 57a4f11b64 [gardening] Patch flutter engine post 0ca1c57 
Change-Id: I92d9589850fa4b95c4be454a48e9e9782f90b908
Reviewed-on: https://dart-review.googlesource.com/c/84926
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-11-20 18:50:06 +00:00
Paul Berry 6d8e14c9db Merge commit 'f56fea3e6389727df2cae5c6feebcdd49437b12a' into analyzer 2018-11-19 08:24:02 -08:00
Alexander Thomas 52d1a2b29b [release] Prepare changelog and version for 2.2.0-dev.0.0 
TBR=whesse@google.com

Change-Id: I4e168ef4c48597d6a5eeabcfcece32044eccc3a8
Reviewed-on: https://dart-review.googlesource.com/c/84634
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-11-19 11:02:51 +00:00
Paul Berry 32a6032f03 Merge commit 'ddbe22190c41b1993a3c93b67f1bfa57287348f8' into analyzer 2018-11-16 12:01:38 -08:00
Martin Kustermann 79b85ae944 Add --write_logs to set of blacklisted objects, so they do not appear on reproduction commands 
Change-Id: Id4031192d220ab82429cab895cf4121913231a54
Reviewed-on: https://dart-review.googlesource.com/c/84534
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-11-16 09:33:52 +00:00
Paul Berry b14b19e13c Merge commit '9e3d3cf765ba3f761b2507950039bcdd2dd3ece8' into analyzer 2018-11-15 09:17:48 -08:00
Alexander Thomas bc2294c004 [infra] Shard reload builders 
Change-Id: I6e1577ec7a8f0d7aec73bbee71d8d3a3a0febdd8
Reviewed-on: https://dart-review.googlesource.com/c/84520
Reviewed-by: Samir Jindel <sjindel@google.com>
 2018-11-15 14:01:18 +00:00
Alexander Markov ed48cfeb47 [vm/bytecode] Support source positions when executing bytecode 
This includes both interpreted and compiled bytecode.

Change-Id: I6309ec4f0687f68caf6260cc57dacf94f027177d
Reviewed-on: https://dart-review.googlesource.com/c/84481
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-11-15 00:48:04 +00:00
Paul Berry 1b5996ae67 Merge commit '30c5b39d4e0e7672d05df6aebba73254dd7ee770' into analyzer 2018-11-14 09:37:06 -08:00
Alexander Thomas 1ade3b624f [infra] Switch cross-arm64 builder to use a single shard 
Triggering on arm64 fails because some kitchen CIPD packages
are unavailable on arm64.

TBR=whesse@google.com

Change-Id: I26b05d000dde712ab1b1d55a33be1e4a02f22247
Reviewed-on: https://dart-review.googlesource.com/c/84424
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-11-14 15:45:08 +00:00
Alexander Thomas eb4f9290de [infra] Add arm64 builders to the test matrix 
TBR=whesse@google.com

Change-Id: If432f9fe2c12ed5a0d7a5af8b15e4daaa13e68f5
Reviewed-on: https://dart-review.googlesource.com/c/84420
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-11-14 11:08:00 +00:00
Paul Berry fc2888982c Merge commit 'c92f9dce2357d0da7909c0c5f630ad59882ccf29' into analyzer 2018-11-13 12:35:13 -08:00
Jonas Termansen 927f0937bd [infra] Add test.dart script for local testing. 
test.dart locates where the current branch branched off master and compares
the local testing results with the appropriate mainline builder results,
letting you know how the current change compares without the need for status
files.

Bug: https://github.com/dart-lang/sdk/issues/35086
Change-Id: Ib79479b867c5ac131302fea1bdf7effd0422a83a
Reviewed-on: https://dart-review.googlesource.com/c/83281
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-11-12 21:51:48 +00:00
Konstantin Shcheglov 2079620a53 Issue 34733. Expand 'implicit-casts' controlled casts, and deprecate more of 'declaration-casts'. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/34733
Change-Id: Ifda5cbd8cc8d81a7e3ad8133d68c056b869bb588
Reviewed-on: https://dart-review.googlesource.com/c/84122
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-12 21:04:59 +00:00
Aart Bik c60cff1d33 [dart/fuzzer] Introduce time-based test runs 
Rationale:
To maximize CPU utilitization during fuzzing runs,
we now use a time-out on all the individual fuzz
testing runs (rather than repeat based). This way,
the "faster" tests will cover more ground, while
the "slower" straggler tests will not break the test
with unnecessary time-outs at cluster level.
Change-Id: I5f0f9646da3fbd8b361a7ea43444b1896a45b57f
Reviewed-on: https://dart-review.googlesource.com/c/84047
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-11-12 18:47:59 +00:00
Jonas Termansen 8043e9851c [infra] Fix test matrix path logic in approve_results. 
Change-Id: Id84365b760d61e01e06f7c5c1377eae456c15441
Reviewed-on: https://dart-review.googlesource.com/c/83764
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-11-12 18:47:10 +00:00
Paul Berry 3ae0dcaa18 Merge commit '5ef1465c55be601f601e1f565c9b9d2f94d76aff' into analyzer 
Conflicts:
	pkg/analysis_server/lib/src/analysis_server.dart
	pkg/analysis_server/lib/src/server/driver.dart
 2018-11-12 06:39:27 -08:00
Aart Bik a20986b299 [dart/fuzzer] Reduce number of runs to avoid timeouts 
Rationale:
Now that we are running on multiple shards, worker
timeouts are becoming a bit more frequent due to
(1) file copying overhead
(2) more stragglers due to law of larger numbers.
Change-Id: I36169c0b2033390b1c577f1dbafb1b34c3dd382d
Reviewed-on: https://dart-review.googlesource.com/c/84040
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-11-09 18:05:08 +00:00
William Hesse 0caf8dd8ed Add logs.json file to results from test.py, output of failing tests 
Change-Id: I18287dd6a435074dd3ff88d17aa5757109b4e9a1
Reviewed-on: https://dart-review.googlesource.com/c/83280
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2018-11-09 01:16:34 +00:00
Alexander Thomas fd5928e97e [dart/fuzzer] Reduce number of runs to avoid timeouts 
Change-Id: I582dbe87a84511c63aeb6dc0cfa52156d33c015a
Reviewed-on: https://dart-review.googlesource.com/c/83660
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-11-08 19:24:11 +00:00
Jonas Termansen c52a38c4ad [infra] Use new approved results bucket in approve_results.dart 
Change-Id: Ia20e682c542edba8b606276124e9f8fd78785680
Reviewed-on: https://dart-review.googlesource.com/c/83620
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-11-08 18:53:19 +00:00
Paul Berry d076571cd9 Merge commit '35c6c79ebc052ab28efcaf045b38ff71c6ed5f3e' into analyzer 2018-11-08 09:32:18 -08:00
Sam Rawlins 1a5f5e4caf Fix doc comment in HttpRequest.getString and other tweaks 
Bug: https://github.com/dart-lang/sdk/issues/21578
Change-Id: I9ec333319922f27a216c1804d889198baf7e579b
Reviewed-on: https://dart-review.googlesource.com/c/82789
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2018-11-07 23:31:14 +00:00
Paul Berry be7983e148 Merge commit 'c24073f442e7c7b789894ad8210aff8accc36702' into analyzer 2018-11-07 07:37:12 -08:00
Vyacheslav Egorov 73a5809c19 [testing] Path absolute path to kernel service snapshot to run_vm_tests. 
There are tests that change current working directory, while kernel
service is trying to start so we can't pass relative paths to --dfe.

Fixes https://github.com/dart-lang/sdk/issues/35093

R=kustermann@google.com

Change-Id: I40fc44243c3011d1d787523b8fc427ec1fde3fea
Reviewed-on: https://dart-review.googlesource.com/c/83404
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-11-07 15:27:57 +00:00
Alexander Thomas e679101211 [infra] Update debian package metadata 
Change-Id: I73696171a6d118c39ef485f0456898f789596876
Reviewed-on: https://dart-review.googlesource.com/c/82993
Reviewed-by: William Hesse <whesse@google.com>
 2018-11-07 09:54:46 +00:00
Jonas Termansen c46202a387 [infra] Fix approve_results using wrong name. 
Change-Id: I1b39d69ebd859b29aeb1b217097f0be69b55341b
Reviewed-on: https://dart-review.googlesource.com/c/83260
Reviewed-by: William Hesse <whesse@google.com>
 2018-11-07 00:05:57 +00:00
Paul Berry 8b87e73428 Merge commit 'f7dab643ff254ead592d7bd038d858ebc9f2570c' into analyzer 2018-11-06 15:16:04 -08:00
Paul Berry 4b1870307d Merge commit '8d12600b16bcc9ae113c47fb6a3d5b68b1388c5c' into analyzer 2018-11-06 14:59:15 -08:00
Sam Rawlins f7dab643ff Remove discontinued webproject.org links. Fixes #21482 
Bug: https://github.com/dart-lang/sdk/issues/21482
Change-Id: Ie3becfa7eb9f233186629cf97bfcabe51efc8794
Reviewed-on: https://dart-review.googlesource.com/c/82790
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2018-11-06 22:20:51 +00:00
Alexander Thomas a6bb2e5fac [dart/fuzzer] Shard fuzzer 
Change-Id: I75df5c9db920331a56b27c2e457bd3b4ce1efd64
Reviewed-on: https://dart-review.googlesource.com/c/78125
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
 2018-11-06 20:23:58 +00:00
Alexander Thomas 8d12600b16 [infra] Make IE work on Luci (closes #30505) 
Change-Id: I0ebf9645247320104246d867ad87dc35542e74de
Reviewed-on: https://dart-review.googlesource.com/c/68364
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-11-06 20:07:13 +00:00
Jonas Termansen 51f815f7f3 [infra] Support configurations in compare_results and update_flakiness. 
Change-Id: I640486957a40ebd178a0d7d06a7a81af758536c8
Reviewed-on: https://dart-review.googlesource.com/c/82980
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-11-06 19:57:08 +00:00
Alexander Thomas 54a3e11d5b [infra] Upload core dumps if BUILDBOT_BUILDERNAME is set 
Recipes pass output_dir to local shards as well but it points to a temp
directory that isn't accessible to users.

Change-Id: I0618abf78cf03957dd5cb8c9a10150bc4964684e
Reviewed-on: https://dart-review.googlesource.com/c/82985
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-11-06 11:56:11 +00:00
Jonas Termansen af63ea79a1 [infra] Add approve_results.dart script for approving test result changes. 
The approve_results program downloads the current results, the approved
results, and flakiness information for the specified bots. It presents
tables of the tests that have been fixed and the ones that have broken since
the last approval. Finally, it provides the option to approve the new
changes.

The approve_results program is part of the new workflow and only affects the
greenness of bots enrolled in it.

You can list the available bots by running:

    dart tools/approve_results.dart -l

You can approve the results on a bot by running:

    dart tools/approve_results.dart -b vm-kernel-linux-release-x64

Globs are supported, e.g. to approve all vm linux bots on ia32 and x64:

    dart tools/approve_results.dart -b 'vm-*linux*{ia32,x64}*'

By default the tool is interactive and asks whether the changes should be
approved. Approving the results turns the bots green on the next commit.
It's assumed that bugs have been filed prior to approving the test changes.
The -y option approves the changes non-interactively while the -n option
does a try run and shows what needs to be approved.

This tool is meant to be used early and often to turn the bot green. Emails
are not set about additional failures until the regressions has been
approved.

Bug: https://github.com/dart-lang/sdk/issues/35000
Change-Id: I6479edaa76556aa5ef499509c04b92ae770d1727
Reviewed-on: https://dart-review.googlesource.com/c/82222
Reviewed-by: William Hesse <whesse@google.com>
 2018-11-06 01:08:50 +00:00
Paul Berry 2e52420a56 Merge commit '4324bd1fd1ab52b4b74073fd9ca11cbdf0596454' into analyzer 2018-11-02 10:26:19 -07:00
William Hesse 5f0df32646 Dummy commit to analyzer branch, to trigger builders 
Change-Id: If2f94e6572ff01ffb642cb2e4e9e056f25d27ed3
Reviewed-on: https://dart-review.googlesource.com/c/82503
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-02 16:51:33 +00:00
Erik Ernst 33c321892c Cleaned up some terminology, whitespace, and added index. 
Changed "compile-time warning" to "static warning"; eliminated spurious
space at the beginning of each normative paragraph; added index and
changed all `{\em ..}` containing defining occurrences of words and
phrases such that they are added to the index and marked with a
diamond in the margin (to make it easy to spot definitions).

Change-Id: I688561a24d2b9955f383d6c8db2c913353d41b4b
Reviewed-on: https://dart-review.googlesource.com/c/82501
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-11-02 12:11:41 +00:00
Paul Berry b3312238ac Merge commit '2bb05234a801ceea8a240c581ba55007c2337568' into analyzer 2018-11-01 06:01:05 -07:00
Ben Konyi 5d7eaaf2e0 [ VM / buildtools ] Allow for downloading of clang-format.exe on Windows 
Change-Id: Id73479468ecff28b60545191d8cd655fbfe277db
Reviewed-on: https://dart-review.googlesource.com/c/82301
Commit-Queue: Zach Anderson <zra@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-11-01 04:09:20 +00:00
William Hesse 7a4e142d00 Add analyzer-linux-release-analyzer-new builder to test matrix on analyzer branch 
Change-Id: I6f7476e8f299bac79684c670184f1d46970bb451
Reviewed-on: https://dart-review.googlesource.com/c/82440
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-10-31 23:37:36 +00:00
Paul Berry 0b96b06ef9 Merge commit 'cf73e08b71ccbed85e2e6a14a7499341c0e15b0d' into analyzer 2018-10-31 07:25:10 -07:00