dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6631 Commits

Author SHA1 Message Date
Martin Kustermann 10a8663e74 [VM/Flutter] Disabled golden tests until next engine -> flutter roll (which probably fixes it) 
Change-Id: I16cb739cf33af3b357b242a1b02ae48515e00dbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96900
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-14 10:47:46 +00:00
Liam Appelbe e7562917f1 Reland https://dart-review.googlesource.com/c/sdk/+/96500 
Rather than creating the abiversions directory during gclient update,
check in an (almost) empty directory. This fixes the flutter build.

Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: Ied74210bfc1c8fda998f58f754eac3949ebe0718
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96846
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-13 21:03:01 +00:00
Konstantin Shcheglov 2ddb2d2d20 Change 'analyze tests co19_2' to use '-asserts'. 
Change-Id: I9ed20ff353fcbdc8042589e619b275e84d5dc7e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96820
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-13 16:25:42 +00:00
William Hesse b10a6bd5ce [testing] Multitests' copied imports should not be read-only 
Change-Id: I4f2957385336f5f56fa804360aca902b019aac58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96801
Auto-Submit: William Hesse <whesse@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2019-03-13 14:11:12 +00:00
Liam Appelbe 1db664764a Revert "Copy abi dills in create_sdk build rule" 
This reverts commit 49a0502f49.

Reason for revert: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919160881488492768/+/steps/build_host_debug/0/stdout

Original change's description:
> Copy abi dills in create_sdk build rule
> 
> Bug: https://github.com/dart-lang/sdk/issues/36047
> Change-Id: If73dbe5a62eff54ac0f712dada14ccd4c68c293e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96500
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,asiva@google.com,liama@google.com

Change-Id: I90610bc43606a8cb148c9a3d9a1cab532176df8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96665
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-12 20:48:56 +00:00
Liam Appelbe 49a0502f49 Copy abi dills in create_sdk build rule 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: If73dbe5a62eff54ac0f712dada14ccd4c68c293e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96500
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-12 20:24:07 +00:00
Alexander Thomas e2b5559c77 [infra] Use gclient.py to apply patches to bypass update_depot_tools 
apply.sh calls gclient, but the default gclient script always runs
update_depot_tools but that is not available on bots. Calling
gclient.py directly avoids that.

Change-Id: Ief80b4822277aa5a0d075c324eed0ef15a81359d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96682
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-12 18:18:14 +00:00
Alexander Thomas b89d08355b [infra] Only move coredump files on shards 
On shards, the files don't need to be tar.gz'ed because the isolate
server will zip them and there aren't many files so tar'ing them doesn't
add much.

Change-Id: I696fe4c64fcee879bb9240e9d1990d2053aa8346
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96655
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2019-03-12 17:43:16 +00:00
Jonas Termansen 1edc6d4b4d [infra] Fix approve_results not erroring properly if tryjobs lack results. 
Fixes https://github.com/dart-lang/sdk/issues/36157

Change-Id: I9c85cc9e54a5c09353c74897f39d01b0784ab2b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96650
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-12 14:51:24 +00:00
Martin Kustermann d3d077090d [VM/FrontendServer] Add 3head patch to frontend server after breaking API changes 
This CL

  https://dart-review.googlesource.com/c/sdk/+/95683

changed the names of named, optional parameters of methods which are
overridden by code in flutter/engine.

Change-Id: I09d054b33297c0eaaf00928d0c69761abb57082a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96581
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-12 09:05:42 +00:00
Liam Appelbe ed1f956991 Fix the abi dills download script 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: Ic8b6cb0b1b5cb026bc06dd2ff414c026700a7c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96133
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-03-11 18:12:09 +00:00
Jonas Termansen 8f03ae05ff [infra] Add --list-configurations option to test.dart. 
This option makes the available named configurations much more discoverable.

Additionally this change expands the available named configurations by
generalizing the operating system and processor architecture patterns
in the named configurations. This change should ensure that nobody is doing
any local testing that isn't covered by a named configuration.

Change-Id: I776105955a86e9f0403ce07a3cdf971e4213646f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96320
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-11 18:04:59 +00:00
Jonas Termansen def0b21225 [infra] Fix test.dart saying untested configurations don't exist. 
There are more named configurations in existance than the ones that actually
run on the builders.

Change-Id: Ie91e71fcec6014830fe286b33c856177fb30c2a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96380
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-11 17:43:03 +00:00
Alexander Thomas 567d552de8 [infra] Add versionchecker and debianpackage to test matrix 
* Run Debian package creation in a Docker container.
* Upload archives from Docker host (the container lacks credentials).
* Remove BUILDBOT_BUILDERNAME environment variables from test matrix:
  They are overwritten in the recipe.

Change-Id: I90d7747e64231bdb745c85030a9cecf256adbaf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94542
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-11 12:52:03 +00:00
Jonas Termansen 6c8dbd84a0 [infra] Support different local named configurations in tools/test.dart. 
This change lets one download the results for one named configuration but do
the local testing with another named configuration. This change addresses
the issue of developers needing to do local testing where there is no
builder matching their local environment. This allows e.g. a dart2js
developer on Windows to use the results for the Linux variant of the same
named configuration, which should be identical or close enough for the
comparison to be meaningful.

Fixes https://github.com/dart-lang/sdk/issues/36151

Change-Id: I1a387a9767cdf5ba99964535478201c0142f15e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96102
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-08 16:56:40 +00:00
Vyacheslav Egorov 95b0e57ac5 [gardening] Disable ASAN's coredump suppression via ASAN_OPTIONS. 
Change-Id: I4dd48fa14261b3a25e7f3abce5bd55a4c0f4111d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96100
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-08 12:06:35 +00:00
Jonas Termansen 283cabf1a1 [infra] Reject unexpected extra arguments in approve_results. 
Change-Id: I441572d5e6d99aa3f3ff3427f8562fa417405d09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95643
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-08 09:39:12 +00:00
Liam Appelbe e1dfad1f2c Attempt 4 at the upload abi dills script 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I89ddbcbd91d09f6a86a01e6d0b66798784a8c0eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95882
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-07 21:43:46 +00:00
Liam Appelbe 48ac0bdd72 Revert "Attempt 3 at the upload abi dill script" 
This reverts commit 94a382bfb8.

Reason for revert: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919623995548729328/+/steps/upload_abi_dills/0/stdout

Original change's description:
> Attempt 3 at the upload abi dill script
> 
> Bug: https://github.com/dart-lang/sdk/issues/36047
> Change-Id: I1e8c28b30485e745fe773c2acfb334f4ef3aa1be
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95707
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,liama@google.com

Change-Id: I9eec3ca373ade1a7573eaa9999521c45213b060f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95881
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-07 18:43:39 +00:00
Liam Appelbe 94a382bfb8 Attempt 3 at the upload abi dill script 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I1e8c28b30485e745fe773c2acfb334f4ef3aa1be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95707
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-07 17:33:09 +00:00
Martin Kustermann b4e9e46f81 [Gardening] Add tools/diff_results.dart which can query the test results database and report a diff in test results from two commits 
The tool can be used to diff the results of two commits on a set of builders.
The user has to pick the revisions to ensure that both of them have results for the given revisions.

Unfortunately it currently seems to also give false-positive because of flaky tests.


Usage:

    sdk % dart tools/diff_results.dart -b 'vm-*' 6cf71022a8 \
                                                 7df88e5755

      ...

      language_2/control_flow_collections/if_promotion_test/none null -> (expected: Pass, actual: CompileTimeError)
	 on vm-dartkb-linux-{debug,release}-x64
	 on vm-kernel-asan-linux-release-x64
	 on vm-kernel-checked-linux-release-x64
	 on vm-kernel-linux-release-{simarm,simarm64}
	 on vm-kernel-optcounter-threshold-linux-release-{ia32,x64}
	 on vm-kernel-precomp-android-release-arm
	 on vm-kernel-precomp-bare-linux-release-{x64,simarm,simarm64}
	 on vm-kernel-precomp-linux-release-simarm
	 on vm-kernel-precomp-linux-{debug,release,product}-x64
	 on vm-kernel-precomp-obfuscate-linux-release-x64
	 on vm-kernel-precomp-win-release-x64
	 on vm-kernel-precomp-{mac,linux,win}-release-simarm64
	 on vm-kernel-reload-linux-{debug,release}-x64
	 on vm-kernel-reload-mac-{debug,release}-simdbc64
	 on vm-kernel-reload-rollback-linux-{debug,release}-x64
	 on vm-kernel-{linux,win}-{debug,release}-ia32
	 on vm-kernel-{mac,linux,win}-{debug,release,product}-x64
	 on vm-kernel-{mac,linux}-{debug,release}-simdbc64

Change-Id: Ibd3a0bdcec238c1fc0d147147b6fe4a7bb74819d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93954
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-03-07 12:50:10 +00:00
Alexander Thomas 1751135fc3 [infra] Increase number of shards on app-* builders 
TBR=whesse@google.com

Change-Id: I4e8ae26d1a90666370f3e678efbd944d5a665f7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95656
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-03-06 21:23:10 +00:00
Liam Appelbe 0c231060f4 Revert "Another attempt to fix the upload script." 
This reverts commit 0e578056e9.

Reason for revert: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919710985306895504/+/steps/upload_abi_dills/0/stdout

Original change's description:
> Another attempt to fix the upload script.
> 
> Bug: https://github.com/dart-lang/sdk/issues/36047
> Change-Id: I2302bd3ee2072651cebcc1179e9778dc4c617965
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95662
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,liama@google.com

Change-Id: Ibe5c52ae0005ea8aa0e69862a19b54cd64864974
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95702
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-06 19:40:39 +00:00
Liam Appelbe 0e578056e9 Another attempt to fix the upload script. 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I2302bd3ee2072651cebcc1179e9778dc4c617965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95662
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-06 18:01:37 +00:00
Jonas Termansen 9645b19060 [infra] Link to the documentation in the new workflow tools. 
Change-Id: Idf8181a1d007fa624e04087a7949f5f04da3b077
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95645
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-06 15:06:40 +00:00
William Hesse 150c58c13f [infra] Shard app-kernel tests that were causing timeouts 
Change-Id: Ia55315278faba496313e6b6b5e041b149780d228
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95401
Reviewed-by: Jonas Termansen <sortie@google.com>
 2019-03-06 13:59:46 +00:00
Alexander Thomas 99d028be77 [infra] Make promote.py work with newer versions of gsutil 
Newer versions of gsutil fail when rm -rf'ing non-existing directories.
Check if the directory exists before trying to remove it.

Change-Id: I57283526f9d13ed5a923b1f5c9d91710ec8d1b60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94861
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2019-03-06 12:43:07 +00:00
Liam Appelbe 7ba8995917 Download ABI dills during gclient sync 
This currently doesn't do anything because ABI_VERSION == OLDEST_SUPPORTED_ABI_VERSION, so there are no versions to download.

Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I5616151dd9dc407d918cbfe9044354f3a41a2e1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95300
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-06 01:07:14 +00:00
Liam Appelbe ef969c8c7e Revert "Update the build bot name restriction in upload_abi_dills.sh" 
This reverts commit 4eedef85a3.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Update the build bot name restriction in upload_abi_dills.sh
> 
> https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919793391094101904/+/steps/upload_abi_dills/0/stdout
> 
> Bug: https://github.com/dart-lang/sdk/issues/36047
> Change-Id: I35c6c6b8365007b681e0daf6e8ef8a5634370dd2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95488
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,liama@google.com

Change-Id: Icce78b35149d9a43dadeedcbfa97eb7153e8b74f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95560
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-06 00:26:36 +00:00
Liam Appelbe 4eedef85a3 Update the build bot name restriction in upload_abi_dills.sh 
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919793391094101904/+/steps/upload_abi_dills/0/stdout

Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I35c6c6b8365007b681e0daf6e8ef8a5634370dd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95488
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-05 22:58:12 +00:00
Liam Appelbe c921716a30 Add upload_abi_dills.sh to dart-sdk-linux in test_matrix.json 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I8e39df90a768ced8ce97d6496e4f411540225fb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95285
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-05 20:48:31 +00:00
Liam Appelbe cc455ecc1d Add use_abi_version flag, and plumb ABI version to version.h 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: Ie810cbd5079e1939bf190e06f6c2494bb4ab0805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95282
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-05 17:16:11 +00:00
Johnni Winther 6227ab0b97 Replace @ForceInline with @pragma in dart:html 
Change-Id: I73afc500438d3fba92f549c8c1955f5ccad47751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95033
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 12:17:18 +00:00
Jonas Termansen f46186ac49 [infra] Fix update_flakiness using wrong key when computing matches. 
It was using the wrong 'expectation' field instead of the correct 'expected'
field. This change uses the right field. However as the matches field has
now been initialized, this change forcefully recomputes it instead of
politely using putIfAbsent. The matches result for the current result will
still take precedence.

Change-Id: I0775c1ff43b8f6691e457b5155ac9335338b209d
Reviewed-on: https://dart-review.googlesource.com/c/95182
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-04 13:38:29 +00:00
Jonas Termansen 03e46ee969 [infra] Add expectation and matches information to flaky.json. 
The expected field can be used to be displayed in the flakiness dashboard.

The matches fields can be used in the flakiness dashboards to decide whether
to include links to logs for a given outcome.

Change-Id: I19454e7cc8fb49871dbb0e7a11478d8888b56662
Reviewed-on: https://dart-review.googlesource.com/c/95024
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-04 13:04:46 +00:00
Liam Appelbe 2f158b9997 Add ABI_VERSION to the version file and a script to upload dills to CPID 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I19d825eb2addaa32680d18a21d237ca172cd4b73
Reviewed-on: https://dart-review.googlesource.com/c/94442
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-03-01 23:00:41 +00:00
Jonas Termansen ce1fb830d0 [infra] Suggest running gsutil.py config in approve_results if needed. 
Fixes https://github.com/dart-lang/sdk/issues/35377.

Change-Id: I2a1a596cda1c5e5565de69ad89f48ab9f1485c41
Reviewed-on: https://dart-review.googlesource.com/c/95020
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
 2019-03-01 16:31:39 +00:00
William Hesse fa8ba53b52 [infra] Add a script that appends fields with previous results to result data 
Change-Id: I19ea044308744c16caee47f4755a18fc19990c77
Reviewed-on: https://dart-review.googlesource.com/c/94544
Reviewed-by: Jonas Termansen <sortie@google.com>
 2019-02-28 16:59:11 +00:00
Alexander Thomas 53ca69ba7e [release] Bump version and update CHANGELOG for 2.2.0 
TBR=whesse@google.com

Change-Id: I29f47436cef8e3e2f082eab351e48d91cdff2f03
Reviewed-on: https://dart-review.googlesource.com/c/94386
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-02-26 17:23:13 +00:00
Stevie Strickland 32eedccdcd [gardening] Fix patches restored in earlier commit. 
Change-Id: I2cc25667fb98982d1bc99bf700d014f6a850fbd5
Reviewed-on: https://dart-review.googlesource.com/c/94262
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
 2019-02-25 15:20:20 +00:00
Stevie Strickland b37de47842 [gardening] Restore flutter '--package' and dartjs_info_tag engine patch 
Change-Id: I2637ccf341e138c56ff4df64b7e7294fc9a1d975
Reviewed-on: https://dart-review.googlesource.com/c/94225
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
 2019-02-25 14:12:27 +00:00
Jonas Termansen 03ee0fea51 [infra] Temporarily support both the old latest build step names. 
Bug: https://github.com/dart-lang/sdk/issues/36015
Change-Id: I2e805ef5ffe3b2bd7e2d88560518e5e92c587ad0
Reviewed-on: https://dart-review.googlesource.com/c/94208
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-02-25 10:02:28 +00:00
William Hesse 944544137b Fix path to step log in approve_results.dart. 
The step "find latest build" moved inside a nested step, so the path to its output log changed.

Change-Id: Iedbadc6abe4cdd35356253efe6a1df7b3ae4fc05
Reviewed-on: https://dart-review.googlesource.com/c/94180
Auto-Submit: William Hesse <whesse@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2019-02-25 09:10:29 +00:00
Sigmund Cherem 5192cd1008 Narrowing improvements in dart2js global inference. 
* no longer narrow by selector use, only narrow by type and non-null
* check for narrow nesting
* add non-null in a couple known places

One large apps, I compared the type-masks in dump-info and all differences were improvements with non-null. We weren't doing any narrowing based on the possible targets of a selector.

Change-Id: I270f360f70fbe3171d09ccd71d10517be9140194
Reviewed-on: https://dart-review.googlesource.com/c/90340
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-02-23 00:10:11 +00:00
Alexander Thomas 0ad7caa5af [testing] Improve multitest error messages 
Previously, messages would contain "Warning:" twice and failed to print
which file the errors came from.

Removed newlines from messages because the logger only prints the first
line.

Fixes #34405

Change-Id: I34d3679a4d769d7c7e2488ca55ffd15f08af9b16
Reviewed-on: https://dart-review.googlesource.com/c/93990
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-02-22 19:44:21 +00:00
Jenny Messerly 627e96c9c1 [dartdevc] simplify microtask scheduling using JS Promise 
All of DDC's supported platforms have Promises, so we can use them
instead of MutationObservers (web) and timers (node.js).

See issue #20055 (same issue, but for dart2js).

Change-Id: Id635a4a9fa104a2ab19dd20824d209f682f831f9
Reviewed-on: https://dart-review.googlesource.com/c/91765
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2019-02-21 20:13:19 +00:00
Alexander Aprelev 0e99581c35 [gardening] Restore flutter '--package' patch, add dartjs_info_tag engine patch 
Change-Id: I19c4ceeca877f99128a733a23bb1ad5abd99e032
Reviewed-on: https://dart-review.googlesource.com/c/93848
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-02-21 19:06:40 +00:00
Martin Kustermann 75ee523f91 [VM] Remove flutter/flutter patch for 3head, the issue has been fixed upstream 
Namely by https://github.com/flutter/flutter/pull/28101

Change-Id: I686927bebffccbb1b575ba488739c38e7de68c9e
Reviewed-on: https://dart-review.googlesource.com/c/93940
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-02-21 09:13:09 +00:00
Alexander Aprelev 4013b0eece [gardening] Add adjusted fix to flutter test patch. 
Follow-up to https://dart-review.googlesource.com/c/sdk/+/93921.

Change-Id: Ic0a38e574964d74e220a544b457a204ab04da2b6
Reviewed-on: https://dart-review.googlesource.com/c/93846
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-02-21 06:30:10 +00:00
Alexander Aprelev 69d46587cf [gardening] Add fix to flutter test patch. 
Follow-up to https://dart-review.googlesource.com/c/sdk/+/93920.

Change-Id: If65340f2d997f6a94b36519fe2d01a16677e9b59
Reviewed-on: https://dart-review.googlesource.com/c/93921
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-02-21 06:15:33 +00:00