Commit Graph

6631 Commits

Author SHA1 Message Date
ager@google.com 2fd60df247 Change test_runner.dart to always move on in the batch runner if the batch runner crashed.
If the batch runner crashes we close the streams and restart a new
process.

The other alternative is to distinguish between a hard crash or the java
process and a soft crash where we throw an exception. On a soft crash
we can put a token in stderr, wait for stderr to drain and then restart
the process. I don't think that adds much. If there is a soft crash the
crash indication is all that really matters and we need to fix that in
any case before moving on.

R=whesse@google.com,zundel@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9638008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5156 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-08 09:16:56 +00:00
turnidge@google.com 7647d8ff7f Add the vm internal dart tests into the test suite.
Review URL: https://chromiumcodereview.appspot.com//9414032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5113 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-07 19:43:59 +00:00
mattsh@google.com d8af601ce4 removed unused 'prefix' line from status files
Review URL: https://chromiumcodereview.appspot.com//9621003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5101 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-07 16:10:57 +00:00
cshapiro@google.com 1ed0c15550 Supress /RTC1 when compiling /O2.
Visual Studio's run-time error checks feature is sometimes enabled in
debug builds.  However, this flag is not compatible with the optimizer
and, in a recent change, I enabled /O2 to decrease the build bot run
times on Win32 builds.  This caused an unintented breakage in Dartium
which seems to enable /RTC1 in its debug build configuration.

Review URL: https://chromiumcodereview.appspot.com//9600054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5046 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-06 19:42:29 +00:00
mattsh@google.com 644f5ba733 create build_frogpad_js.py to help repro bug 1700
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9546015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5041 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-06 18:27:06 +00:00
jacobr@google.com de1d525459 Enable new dart:html wrapperless frog bindings and wrapper dartium bindings.
Split unittest.dart into unittest_html and unittest_dom

Bug fixes to the new dart:html bindings to compile with dartc.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9600035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4998 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-06 00:30:09 +00:00
efortuna@google.com 24340ce51b Clean up temporary directories in buildbot script.
Review URL: https://chromiumcodereview.appspot.com//9600033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4985 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-05 22:15:31 +00:00
efortuna@google.com c82f3462c9 Fix for webdriver_test_setup in Windows, and don't force close of the browsers if we're not running on a buildbot.
Review URL: https://chromiumcodereview.appspot.com//9601023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4984 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-05 22:14:36 +00:00
zundel@google.com a3f451b2ec Removes a redundant mode_arch component from paths for generated tests
Review URL: https://chromiumcodereview.appspot.com//9595022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4979 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-05 20:08:31 +00:00
mattsh@google.com c93f8c7ca5 documented component
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9599015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4968 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-05 18:48:14 +00:00
zundel@google.com 0789695885 Re-apply "Enable use of #import stmts containing relative paths in Dart multitests"
Commit r4858 broke browser tests because of recursive directory handling.

I've removed the reference to the new recursive directory creation routine
from the 'createOutputDirectory()' method.  I don't understand the current
directory structure - it might be a bug, but my attempt to fix it
leaves browser tests in a broken state.

Review URL: https://chromiumcodereview.appspot.com//9583016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4954 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-05 15:07:37 +00:00
ager@google.com b2b123d24b Update Timer API to take the callback as the last parameter.
This makes the code easier to read when the callback actually does
work:

  new Timer(1000, (t) {
    // do
    // lots
    // of
    // stuff
  });

Also, it is more consistent with the rest of the APIs.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9597015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4945 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-05 12:43:41 +00:00
asiva@google.com fd22ae633c Disable build of simarm from the -arch=all configuration.
Review URL: https://chromiumcodereview.appspot.com//9581037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4914 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-03 01:44:24 +00:00
efortuna@google.com 412ffb7f4d Webdriver install script, take 2.
Review URL: https://chromiumcodereview.appspot.com//9581025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4911 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 23:44:26 +00:00
rnystrom@google.com 458908f549 Get dartdoc in the SDK and working correctly.
Review URL: https://chromiumcodereview.appspot.com//9555013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4905 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 22:28:00 +00:00
cshapiro@google.com 4bb75b2828 Enable optimizations for the Win32 debug build.
An equivalent change was recently done for the Macintosh and Linux
targets to eliminate the substantial lag between the execution time
of the release and debug builds.

As the /02 (Maximize Speed) flag implies the /Oy (Frame-Pointer Omission)
flag I have, in the interest of debugging, set OmitFramePointers to false.

Review URL: https://chromiumcodereview.appspot.com//9565047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4899 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 19:29:18 +00:00
zundel@google.com ab603367c0 Update test.dart for detection output of machine formatted errors
This change causes the 'dartc' tests to be more sensitive to the difference
between a static type error and a compilation error.   Instead of
relying on the return value from the test being 0 or non zero, the
code now turns on '--error_format machine' and checks type
error level 'ERROR' or 'WARNING' and the type of error for
'STATIC_TYPE' if there is a static type error.  A new annotation
format adapted from multitests is introduced for standard test cases:

  int foo = "hello";   /// static type error

The above annotation means that a static type error is expected.
Currently enforcement is very lenient.  There must be at least as
many STATIC_TYPE error messages as there are '/// static type error'
annotations (and no ERROR level messages.)

Review URL: https://chromiumcodereview.appspot.com//9559007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4895 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 18:50:09 +00:00
jmesserly@google.com 2190c0a7d0 Revert "Enable use of #import stmts containing relative paths in Dart multitests" This change broke all of the browser tests, including DumpRenderTree.
I'm not exactly sure what went wrong--perhaps something in the copying functions, because the breakage seems to affect all tests.

Review URL: https://chromiumcodereview.appspot.com//9584004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4865 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 10:20:23 +00:00
jmesserly@google.com 4533fbe58d Revert "Adding webdriver setup script."
It seems to have caused Safari bot to not run any tests. See:

http://build.chromium.org/p/client.dart/builders/web-safari-mac/builds/325

vs

http://build.chromium.org/p/client.dart/builders/web-safari-mac/builds/326

Review URL: https://chromiumcodereview.appspot.com//9572007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4863 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 10:06:17 +00:00
zundel@google.com b4d7df19cc Enable use of #import stmts containing relative paths in Dart multitests
This will alow tests like Prefix22NegativeTest an Prefix23Negative
test to be re-written as multitests.

Review URL: https://chromiumcodereview.appspot.com//9565001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4858 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 08:36:47 +00:00
efortuna@google.com a36985cf2b Adding webdriver setup script.
Review URL: https://chromiumcodereview.appspot.com//9480019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4849 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 01:25:28 +00:00
vsm@google.com e3502a1bdb Clean up dom/html files packaged by the sdk.
Review URL: https://chromiumcodereview.appspot.com//9569040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4839 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 23:38:29 +00:00
ager@google.com 986134bee4 Speculative fix for webdriver test issues.
R=jmesserly@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9564005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4791 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 10:25:50 +00:00
ager@google.com 242bba108b Reapply dart:io API changes.
R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9568004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4790 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 10:07:35 +00:00
ngeoffray@google.com 21cba927ca Introduce the legium component in test.dart, and start support for dart:dom and dart:html.
Review URL: https://chromiumcodereview.appspot.com//9535012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4787 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 09:53:54 +00:00
ager@google.com fd31551ca4 Revert "Rename blahHandler to onBlah throughout dart:io."
D'oh! I need to update the test binaries as well. Reverting, building
and putting back in again.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9570004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4785 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 09:43:15 +00:00
ager@google.com 40e0bceab5 Rename blahHandler to onBlah throughout dart:io.
Additionally, change all single-shot methods to take their callback as an argument instead of registering it on the object.

I have attempted to find all uses in the repo but there might
be some firefighting to do when this lands.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9500002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4784 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 09:36:04 +00:00
ager@google.com 6cd0ec3577 Add token to stderr as well as stdout for batch processing.
This makes it easy to tell when a test is completed and we have all
the output. stderr and stdout are independent file descriptors so
this is the only reliable way to know that you have flushed both.

Review URL: https://chromiumcodereview.appspot.com//9569003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4782 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 09:13:47 +00:00
scheglov@google.com c81fcbafde Remove backends.
R=zundel@google.com,brianwilkerson@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9479013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4771 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-29 23:50:01 +00:00
zundel@google.com e2e9ca6c7c test.dart sometimes associates the wrong stderr with a task.
Problem is due to stdout status being processed before
all of stderr is read.

http://code.google.com/p/dart/issues/detail?id=1898

Review URL: https://chromiumcodereview.appspot.com//9538009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4770 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-29 22:52:16 +00:00
efortuna@google.com 06abb8d62c This is the same change as r4644 (that was reverted in 4646), but I had quotes around the final %script% variable in the bat scripts that was causing arguments to be passed to frog incorrectly.
Review URL: https://chromiumcodereview.appspot.com//9532001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4759 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-29 18:07:59 +00:00
sigmund@google.com 80d487a96b test.dart: fix for dartium.
Review URL: https://chromiumcodereview.appspot.com//9513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4719 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 18:40:36 +00:00
sigmund@google.com 8c57d4bd4f test.dart: typo on the batched execution used in safari/ie tests
Review URL: https://chromiumcodereview.appspot.com//9512001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4713 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 18:01:05 +00:00
sigmund@google.com 6cefc269d6 test.dart: add support for compiling multiple scripts for a single test.
Review URL: https://chromiumcodereview.appspot.com//9475038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4708 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 17:47:43 +00:00
antonm@google.com 2c2038cb58 Do not go infinite loop if test fails constantly.
Review URL: https://chromiumcodereview.appspot.com//9501003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4704 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 17:21:15 +00:00
sgjesse@google.com ebfaee7d90 Update checked in binaries to r4683
R=ager@google.com

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9487009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4688 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 14:25:18 +00:00
zundel@google.com f152409954 Update ConstructorNamedArgumentTest to use the 'runtime-error' directive
See 10.13.2 in the spec (Binding Actuals to Formals)

http://code.google.com/p/dart/issues/detail?id=1872

Review URL: https://chromiumcodereview.appspot.com//9477013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4678 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 12:47:22 +00:00
ager@google.com 4d94b5c4d9 Move back to having File.open{Input,Output}Stream return the stream directly.
R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9487005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4677 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 12:28:42 +00:00
whesse@google.com ef198093f8 Fix error introduced when renaming variable in test_suite.dart, in r4671.
TBR=ager@google.com

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9489008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4675 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 11:35:53 +00:00
whesse@google.com b76cd2801d Fix static warnings in test_suite.dart from local variables shadowing parameters or functions.
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9495006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4671 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 11:07:52 +00:00
sigmund@google.com ee6a907611 isolates refactor: this change introduces 'dart:isolate' as a library. This is a
big global change, so let me explain in more detail. This refactoring CL does
the following:
- moves all the dart code for isolates in a common library (lib/isolate)

- changes frog to understand 'dart:isolate' imoprts by loading the code from the
  location above.

- changes the vm to undernstand 'dart:isolate' imports by creating a separate
  library that is part of the bootstrap. This follows the same code-structure
  that Todd suggested in his CL introducing the mirror library

- changes dartc to use the shared isolate library as the source of truth for
  type checking. I left around some of the internal js code in dartc so that the
  backend continues to work for apps that don't use isolates.

- changes all tests that use isolates to import the library explicitly (this is a large bulk of the files in this CL)

- changes test status for tests we can't fix in this repo (e.g. co19)

- splits the isolate library code to make it possible to preserve some tests
  without exposing internal types (e.g. tests about
  serialization/deserialization)

- changes the create_sdk script to copy the isolate library to the sdk

- includes the isolate library in dartdoc

I'll wait for at least one lgtm from each area (dartc, vm, frog, sdk)

There is one important pending thing this CL doesn't do:
- update test_runner.dart: This should be updated next time we upload the new
  binaries to tool/testing/bin
- dartium specific changes: Vijay, is there anything I need to do for dartium?

Review URL: https://chromiumcodereview.appspot.com//9422019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4647 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-27 22:50:44 +00:00
efortuna@google.com 1126a319a0 Undo revision 4644 until I find fix.
TBR=dgrove@google.com
Review URL: https://chromiumcodereview.appspot.com//9475027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4646 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-27 22:43:26 +00:00
efortuna@google.com 4920df5af9 Prettified Windows frog scripts and allowed Windows scripts to handle paths that have spaces. Also moved frogc to be with the other scripts.
Addresses issues raised in Issue 1737.
Review URL: https://chromiumcodereview.appspot.com//9465034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4644 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-27 22:32:44 +00:00
zundel@google.com 1d6d0fc624 Removes dependency on d8/v8 from dartc
Review URL: https://chromiumcodereview.appspot.com//9466041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4616 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-27 14:32:11 +00:00
ngeoffray@google.com 8ab300cd91 Remove unused parameter.
Review URL: https://chromiumcodereview.appspot.com//9463047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4605 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-27 11:57:41 +00:00
zundel@google.com c8d34435fd Backout change in test.dart from -batch to --batch.
Review URL: https://chromiumcodereview.appspot.com//9447094

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4594 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-26 14:20:08 +00:00
zundel@google.com 564d6c5cc1 Incremental build is now off by default
Also got rid of some legacy flag settings.

Review URL: https://chromiumcodereview.appspot.com//9447057

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4593 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-26 13:33:02 +00:00
ngeoffray@google.com 06ce0a4528 Use the component information when the test is being scheduled instead of when it's being created.
Review URL: https://chromiumcodereview.appspot.com//9466008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4572 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-24 14:09:21 +00:00
mattsh@google.com 04eeeaaa3f improved comments
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9454015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4543 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-23 17:27:34 +00:00
ngeoffray@google.com 740d3b7419 Sicne dartc has no backend anymore, a runtime error in a multitest does *not* make it a negative test.
Review URL: https://chromiumcodereview.appspot.com//9442015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4531 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-23 13:57:07 +00:00