efortuna@google.com
412ffb7f4d
Webdriver install script, take 2.
...
Review URL: https://chromiumcodereview.appspot.com//9581025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4911 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 23:44:26 +00:00
zundel@google.com
ab603367c0
Update test.dart for detection output of machine formatted errors
...
This change causes the 'dartc' tests to be more sensitive to the difference
between a static type error and a compilation error. Instead of
relying on the return value from the test being 0 or non zero, the
code now turns on '--error_format machine' and checks type
error level 'ERROR' or 'WARNING' and the type of error for
'STATIC_TYPE' if there is a static type error. A new annotation
format adapted from multitests is introduced for standard test cases:
int foo = "hello"; /// static type error
The above annotation means that a static type error is expected.
Currently enforcement is very lenient. There must be at least as
many STATIC_TYPE error messages as there are '/// static type error'
annotations (and no ERROR level messages.)
Review URL: https://chromiumcodereview.appspot.com//9559007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4895 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 18:50:09 +00:00
jmesserly@google.com
2190c0a7d0
Revert "Enable use of #import stmts containing relative paths in Dart multitests" This change broke all of the browser tests, including DumpRenderTree.
...
I'm not exactly sure what went wrong--perhaps something in the copying functions, because the breakage seems to affect all tests.
Review URL: https://chromiumcodereview.appspot.com//9584004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4865 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 10:20:23 +00:00
jmesserly@google.com
4533fbe58d
Revert "Adding webdriver setup script."
...
It seems to have caused Safari bot to not run any tests. See:
http://build.chromium.org/p/client.dart/builders/web-safari-mac/builds/325
vs
http://build.chromium.org/p/client.dart/builders/web-safari-mac/builds/326
Review URL: https://chromiumcodereview.appspot.com//9572007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4863 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 10:06:17 +00:00
zundel@google.com
b4d7df19cc
Enable use of #import stmts containing relative paths in Dart multitests
...
This will alow tests like Prefix22NegativeTest an Prefix23Negative
test to be re-written as multitests.
Review URL: https://chromiumcodereview.appspot.com//9565001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4858 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 08:36:47 +00:00
efortuna@google.com
a36985cf2b
Adding webdriver setup script.
...
Review URL: https://chromiumcodereview.appspot.com//9480019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4849 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 01:25:28 +00:00
ager@google.com
986134bee4
Speculative fix for webdriver test issues.
...
R=jmesserly@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9564005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4791 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 10:25:50 +00:00
ager@google.com
242bba108b
Reapply dart:io API changes.
...
R=sgjesse@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9568004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4790 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 10:07:35 +00:00
ngeoffray@google.com
21cba927ca
Introduce the legium component in test.dart, and start support for dart:dom and dart:html.
...
Review URL: https://chromiumcodereview.appspot.com//9535012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4787 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 09:53:54 +00:00
ager@google.com
fd31551ca4
Revert "Rename blahHandler to onBlah throughout dart:io."
...
D'oh! I need to update the test binaries as well. Reverting, building
and putting back in again.
R=sgjesse@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9570004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4785 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 09:43:15 +00:00
ager@google.com
40e0bceab5
Rename blahHandler to onBlah throughout dart:io.
...
Additionally, change all single-shot methods to take their callback as an argument instead of registering it on the object.
I have attempted to find all uses in the repo but there might
be some firefighting to do when this lands.
R=sgjesse@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9500002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4784 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 09:36:04 +00:00
ager@google.com
6cd0ec3577
Add token to stderr as well as stdout for batch processing.
...
This makes it easy to tell when a test is completed and we have all
the output. stderr and stdout are independent file descriptors so
this is the only reliable way to know that you have flushed both.
Review URL: https://chromiumcodereview.appspot.com//9569003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4782 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-01 09:13:47 +00:00
scheglov@google.com
c81fcbafde
Remove backends.
...
R=zundel@google.com ,brianwilkerson@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9479013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4771 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-29 23:50:01 +00:00
zundel@google.com
e2e9ca6c7c
test.dart sometimes associates the wrong stderr with a task.
...
Problem is due to stdout status being processed before
all of stderr is read.
http://code.google.com/p/dart/issues/detail?id=1898
Review URL: https://chromiumcodereview.appspot.com//9538009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4770 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-29 22:52:16 +00:00
sigmund@google.com
80d487a96b
test.dart: fix for dartium.
...
Review URL: https://chromiumcodereview.appspot.com//9513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4719 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 18:40:36 +00:00
sigmund@google.com
8c57d4bd4f
test.dart: typo on the batched execution used in safari/ie tests
...
Review URL: https://chromiumcodereview.appspot.com//9512001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4713 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 18:01:05 +00:00
sigmund@google.com
6cefc269d6
test.dart: add support for compiling multiple scripts for a single test.
...
Review URL: https://chromiumcodereview.appspot.com//9475038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4708 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 17:47:43 +00:00
antonm@google.com
2c2038cb58
Do not go infinite loop if test fails constantly.
...
Review URL: https://chromiumcodereview.appspot.com//9501003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4704 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 17:21:15 +00:00
sgjesse@google.com
ebfaee7d90
Update checked in binaries to r4683
...
R=ager@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9487009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4688 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 14:25:18 +00:00
zundel@google.com
f152409954
Update ConstructorNamedArgumentTest to use the 'runtime-error' directive
...
See 10.13.2 in the spec (Binding Actuals to Formals)
http://code.google.com/p/dart/issues/detail?id=1872
Review URL: https://chromiumcodereview.appspot.com//9477013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4678 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 12:47:22 +00:00
ager@google.com
4d94b5c4d9
Move back to having File.open{Input,Output}Stream return the stream directly.
...
R=sgjesse@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9487005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4677 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 12:28:42 +00:00
whesse@google.com
ef198093f8
Fix error introduced when renaming variable in test_suite.dart, in r4671.
...
TBR=ager@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9489008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4675 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 11:35:53 +00:00
whesse@google.com
b76cd2801d
Fix static warnings in test_suite.dart from local variables shadowing parameters or functions.
...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9495006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4671 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-28 11:07:52 +00:00
sigmund@google.com
ee6a907611
isolates refactor: this change introduces 'dart:isolate' as a library. This is a
...
big global change, so let me explain in more detail. This refactoring CL does
the following:
- moves all the dart code for isolates in a common library (lib/isolate)
- changes frog to understand 'dart:isolate' imoprts by loading the code from the
location above.
- changes the vm to undernstand 'dart:isolate' imports by creating a separate
library that is part of the bootstrap. This follows the same code-structure
that Todd suggested in his CL introducing the mirror library
- changes dartc to use the shared isolate library as the source of truth for
type checking. I left around some of the internal js code in dartc so that the
backend continues to work for apps that don't use isolates.
- changes all tests that use isolates to import the library explicitly (this is a large bulk of the files in this CL)
- changes test status for tests we can't fix in this repo (e.g. co19)
- splits the isolate library code to make it possible to preserve some tests
without exposing internal types (e.g. tests about
serialization/deserialization)
- changes the create_sdk script to copy the isolate library to the sdk
- includes the isolate library in dartdoc
I'll wait for at least one lgtm from each area (dartc, vm, frog, sdk)
There is one important pending thing this CL doesn't do:
- update test_runner.dart: This should be updated next time we upload the new
binaries to tool/testing/bin
- dartium specific changes: Vijay, is there anything I need to do for dartium?
Review URL: https://chromiumcodereview.appspot.com//9422019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4647 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-27 22:50:44 +00:00
zundel@google.com
1d6d0fc624
Removes dependency on d8/v8 from dartc
...
Review URL: https://chromiumcodereview.appspot.com//9466041
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4616 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-27 14:32:11 +00:00
ngeoffray@google.com
8ab300cd91
Remove unused parameter.
...
Review URL: https://chromiumcodereview.appspot.com//9463047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4605 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-27 11:57:41 +00:00
zundel@google.com
c8d34435fd
Backout change in test.dart from -batch to --batch.
...
Review URL: https://chromiumcodereview.appspot.com//9447094
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4594 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-26 14:20:08 +00:00
zundel@google.com
564d6c5cc1
Incremental build is now off by default
...
Also got rid of some legacy flag settings.
Review URL: https://chromiumcodereview.appspot.com//9447057
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4593 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-26 13:33:02 +00:00
ngeoffray@google.com
06ce0a4528
Use the component information when the test is being scheduled instead of when it's being created.
...
Review URL: https://chromiumcodereview.appspot.com//9466008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4572 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-24 14:09:21 +00:00
mattsh@google.com
04eeeaaa3f
improved comments
...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9454015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4543 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-23 17:27:34 +00:00
ngeoffray@google.com
740d3b7419
Sicne dartc has no backend anymore, a runtime error in a multitest does *not* make it a negative test.
...
Review URL: https://chromiumcodereview.appspot.com//9442015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4531 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-23 13:57:07 +00:00
mattsh@google.com
afcf2f7ee7
frogpad now invokes DumpRenderTree
...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9454004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4513 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-23 04:14:18 +00:00
mattsh@google.com
37205ec18f
remove end script tag from comment
...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9416110
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4492 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-22 21:30:39 +00:00
jmesserly@google.com
42972fdec6
This change runs WebDriver tests in batch mode. This means that it keeps N browsers open, where N is the number of jobs in test.dart. It then passes each in-browser test to the next available browser. This is analogous to how DartC tests reuse the java process.
...
It seems to cut about 30-40% off the run time of tests on Mac+Firefox, with roughly similar gains for other browsers. It also might reduce the browser startup flakiness--although this needs more testing.
I reused almost all of the logic and protocol from DartC's batch runner. Most of the changes are in run_selenium.py, which now implements the batch protocol when started with --batch.
A few changes to BatchProcessRunner:
1. it can now pass arguments when starting the batch process. We need this to start "python run_selenium.py --batch"
2. related to #1 , it needs to remove the run_selenium argument when running each individual test.
3. added a graceful shutdown command so run_selenium can shutdown. I would've preferred SIGTERM or SIGINT, but it doesn't look like that's supported in the Process API (sends only SIGKILL).
Changes to run_selenium.py:
1. Add a batch mode
2. Factored the common functionality to preserve "single run" mode
Review URL: https://chromiumcodereview.appspot.com//9420037
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4491 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-22 21:27:46 +00:00
sgjesse@google.com
46e44ecba1
Add both sync and async methods for getting streams for a File
...
The File class used to have two synchronous methods
openInputStream and openOutputStream for getting streams for a
file. These have now been changed to work asynchronously by the
associated callback inputStreamHandler or outputStreamHandler
when the stream is opened and available.
To support the synchronous API two new methods
openInputStreamSync and openOutputStreamSync which returns the
stream directly as before have been added.
The actual implemnetation of the file streams still uses the
synchronous file API internally. However this change
adds "simulated" handling of noPendingWriteHandler and
closeHandler for file output stream.
R=ager@google.com
BUG=dart:1784
TEST=
Review URL: https://chromiumcodereview.appspot.com//9432023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4452 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-22 14:11:04 +00:00
mattsh@google.com
0210231746
frogpad now uses vm to generate initial js
...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9422027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4408 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-21 21:28:01 +00:00
efortuna@google.com
8973618122
Third time's the charm...
...
TBR=sigmund@google.com
Review URL: https://chromiumcodereview.appspot.com//9422011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4372 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-17 21:59:09 +00:00
efortuna@google.com
52d9361aab
Make "should retry" argument optional -- RunningProcess is used by separate VM
...
tests.
TBR=sigmund@google.com
Review URL: https://chromiumcodereview.appspot.com//9424008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4371 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-17 21:50:13 +00:00
efortuna@google.com
36b88ced7a
Don't retry browser tests if the bot is pretty red. Also, retry properly all
...
times that DRT crashes.
Review URL: https://chromiumcodereview.appspot.com//9426005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4370 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-17 21:44:34 +00:00
efortuna@google.com
ac9b48b436
Retry DRT if we crash with core dump.
...
Review URL: https://chromiumcodereview.appspot.com//9426001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4362 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-17 18:11:23 +00:00
jmesserly@google.com
3a1a261452
don't retry if the browser is dumprendertree
...
Review URL: https://chromiumcodereview.appspot.com//9416033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4340 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-16 21:20:16 +00:00
sigmund@google.com
3606f4c98e
vmbot: fix vm bot config
...
Review URL: https://chromiumcodereview.appspot.com//9414014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4329 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-16 18:27:05 +00:00
mattsh@google.com
9d294a77df
initial frogpad
...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9392005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4275 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-15 17:46:32 +00:00
efortuna@google.com
ad9e253501
Force close of browser Windows when complete.
...
Review URL: https://chromiumcodereview.appspot.com//9369051
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4241 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-15 00:54:26 +00:00
sigmund@google.com
c656cc1b62
test.dart progress bar: a small tweak when --report is not used.
...
Review URL: https://chromiumcodereview.appspot.com//9378028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4190 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-13 16:25:26 +00:00
jmesserly@google.com
c0d3b1f2a0
Add opera as an option to --browser
...
Review URL: https://chromiumcodereview.appspot.com//9368056
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4114 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-10 04:15:04 +00:00
efortuna@google.com
306f557107
Additional flakiness reducing changes. Also rerun DRT on false positive tests.
...
Review URL: https://chromiumcodereview.appspot.com//9368008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4104 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-10 00:26:52 +00:00
whesse@google.com
cdb6245f3c
Remove test_wrapper.py, replace with test.py (which calls test.dart).
...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9369026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4088 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-09 16:14:50 +00:00
whesse@google.com
53f18a1e4f
Add dartdoc comments to Dart testing infrastructure.
...
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//9347023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4079 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-09 14:42:05 +00:00
ahe@google.com
d556e26aa7
Frog shouldn't read libraries with --leg_only.
...
Also, simplify leg options.
Also, don't print Frog specific messages when running leg.
Review URL: https://chromiumcodereview.appspot.com//9373019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4074 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-09 10:38:47 +00:00