dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

21 Commits

Author SHA1 Message Date
Alexander Markov 070f67a05b [gardening] Remove obsolete Flutter HHH patch 
This change was submitted into Flutter/flutter already
(https://github.com/flutter/flutter/commit/6f9ed76faf9fe7f254291cc5bf9c5ffe4c459487),
so removing this patch as it cannot be applied anymore and causes
Flutter HHH to fail.

Change-Id: Ic1b44f0ec0c85b9d343079f8a067cd59ebf37170
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137040
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-02-24 20:34:46 +00:00
Samir Jindel 17ec4a8433 [vm] Fix 3xH bot. 
The corresponding Flutter change is made in https://github.com/flutter/flutter/pull/51330.

Change-Id: Ib3f233cd4153c04b22ba10e30eb532186fc9fb97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136961
Reviewed-by: Clement Skau <cskau@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2020-02-24 11:37:37 +00:00
Alexander Markov 250f3d2e56 [gardening] Attempt to repair red HHH bot, take 3 
OK, this time the patch was applied.

However, there are still compile-time errors as HttpClientResponseCompressionState
was not imported into create_test.dart:

org-dartlang-app:///test/commands/create_test.dart:1176:3: Error: Type 'HttpClientResponseCompressionState' not found.
  HttpClientResponseCompressionState get compressionState {
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:///test/commands/create_test.dart:1177:12: Error: Getter not found: 'HttpClientResponseCompressionState'.
    return HttpClientResponseCompressionState.decompressed;
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:///test/commands/create_test.dart:1177:12: Error: The getter 'HttpClientResponseCompressionState' isn't defined for the class 'MockHttpClientResponse'.
 - 'MockHttpClientResponse' is from 'org-dartlang-app:///test/commands/create_test.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'HttpClientResponseCompressionState'.
    return HttpClientResponseCompressionState.decompressed;
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This change should fix these errors.

Change-Id: I58b7ca97b2181fe04b4169a11a47173e63c3b865
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104381
Reviewed-by: Todd Volkert <tvolkert@google.com>
 2019-05-31 22:00:39 +00:00
Alexander Markov 0e07987ccd [gardening] Attempt to repair red HHH bot, take 2 
This is the 2nd attempt to repair HHH bot after
https://dart.googlesource.com/sdk/+/aa2ce7cfbfaca5439b86b6ee4ad503691b8ce0ac

Patch is renamed to the pinned Dart SDK hash, and flutter-flutter/apply.sh
script is changed to pick up patches using both engine and dart hashes.

Change-Id: I5cfbe65aeacb48eb76bcfbcb1eaa97795601c9fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104340
Reviewed-by: Todd Volkert <tvolkert@google.com>
 2019-05-31 19:49:13 +00:00
Alexander Markov 7ae22b9394 [gardening] Attempt to repair red HHH bot 
Moving corresponding patch file from engine hash to Dart SDK hash
as engine gets rolled into Flutter and engine hash becomes outdated.

Change-Id: I910427b8ee2e4ee5356234a7fd94155ea66d7dd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104285
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Todd Volkert <tvolkert@google.com>
 2019-05-31 17:42:04 +00:00
Todd Volkert dc7fa3bae7 Add patch to fix Flutter 
This patch file updates Flutter's mocks of HttpClientResponse to add
a new `compressionState` getter that was added in
https://github.com/dart-lang/sdk/commit/aa2ce7cfbfaca5439b86b6ee4ad503691b8ce0ac

Bug: dartbug.com/36971
Change-Id: I69296ab7a9365f74402975875048cc8d1fec965c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104262
Commit-Queue: Todd Volkert <tvolkert@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2019-05-31 02:28:04 +00:00
Stevie Strickland 231061c15a [gardening] Moving patch to be based on dart hash. 
Change-Id: I220a3be123d976d8de062deea6c48003d8521f72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97119
Auto-Submit: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
 2019-03-18 16:18:55 +00:00
Alexander Aprelev 3dda726bca [gardening] Update flutter patch to reflect engine roll. 
Change-Id: I26a92c1e2be6219fad675b6945add13e8eab7fdf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97141
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-15 21:33:40 +00:00
Alexander Aprelev eb47bc112e [gardening] Rename flutter/flutter patch so it matches engines hash. 
Change-Id: Iacf28ee3096411527dfa263890825e9ffefe513a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97060
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-15 05:14:33 +00:00
Alexander Aprelev de2d83b9e3 [gardening] Fix flutter patch after recent dart roll into engine. 
Change-Id: I452f3b79a9f58deb8ded515f8ce6a4e80fc1f8c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97041
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-15 04:35:00 +00:00
Alexander Aprelev c52e1b83fb [vm/frontend_server] Fix outdated flutter patch. 
This is follow-up to https://dart-review.googlesource.com/c/sdk/+/95920.

Change-Id: Ie9b57f84d38b4acf66b0d03af646f65c69c21b6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96988
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-14 23:00:14 +00:00
Alexander Aprelev 35fb67158b [vm/frontend] Change frontend server interface so compile response contains delta of sources files that were used by the compiler. 
This is needed so that for incremental compilation client knows which files need to be tracked for changes, need to be reported as invalidated for next recompilation cycle(see https://github.com/flutter/flutter/pull/29004)

Change-Id: I8c9e7800b55335497a4cbecfd35cec7390528eb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95920
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-03-14 21:53:08 +00:00
Martin Kustermann 6c5194cfe1 [VM/Flutter] Remove 2 golden-file tests completely to avoid flutter analyze warning about missing copyright header 
This should turn 3head green and hopefully the next engine->flutter roll
fixes the golden expectation files.

Change-Id: Ic52216a965c0981e187d2186653428ee52f1ac47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96943
Auto-Submit: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-14 14:52:12 +00:00
Martin Kustermann 10a8663e74 [VM/Flutter] Disabled golden tests until next engine -> flutter roll (which probably fixes it) 
Change-Id: I16cb739cf33af3b357b242a1b02ae48515e00dbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96900
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-14 10:47:46 +00:00
Martin Kustermann d3d077090d [VM/FrontendServer] Add 3head patch to frontend server after breaking API changes 
This CL

  https://dart-review.googlesource.com/c/sdk/+/95683

changed the names of named, optional parameters of methods which are
overridden by code in flutter/engine.

Change-Id: I09d054b33297c0eaaf00928d0c69761abb57082a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96581
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-12 09:05:42 +00:00
Stevie Strickland 32eedccdcd [gardening] Fix patches restored in earlier commit. 
Change-Id: I2cc25667fb98982d1bc99bf700d014f6a850fbd5
Reviewed-on: https://dart-review.googlesource.com/c/94262
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
 2019-02-25 15:20:20 +00:00
Martin Kustermann 015cf88ef6 Disable set literal warning until engine rolls into flutter/flutter 
Once the roll happens flutter team should see the errors and fix it.

Change-Id: I7ab5cfc67a3bb749cfe69ad4075b0c90998c15e9
Reviewed-on: https://dart-review.googlesource.com/c/93420
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-02-15 17:59:52 +00:00
Samir Jindel 7fe7e28c46 [vm] Fix location of Flutter 3xH patch file. 
Change-Id: Ib055f110ac189cb553e86d86e6a807cae08c0b6d
Reviewed-on: https://dart-review.googlesource.com/c/93083
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-13 15:49:25 +00:00
Samir Jindel 3236ac15a1 Fix flutter-analyze bot. 
Change-Id: I56fa45de16a373b40107baa03a8ebab1ee64ccd2
Reviewed-on: https://dart-review.googlesource.com/c/93027
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-02-13 13:39:52 +00:00
Martin Kustermann d373b2ce9c [gardening] Disable golden test until next engine roll 
Our head-head-head builder doesn't have patch support for the golden
pngs.

Therefore we disable the golden test until next engine roll is in.

Change-Id: I5d2e12c74313d8b7e84bd79052dc5b021b700a20
Reviewed-on: https://dart-review.googlesource.com/c/92284
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-02-07 13:45:37 +00:00
Martin Kustermann 1bfc3816d8 [infra] Extend 3head patching to apply patches for flutter/flutter depending on pinned engine commit 
This also adds a patch to flutter/flutter to fix head-head-head
configuration (until engine is rolled into framework again).

Change-Id: I6dae0983126a6664337834d3c93f1369139f1ac1
Reviewed-on: https://dart-review.googlesource.com/c/91922
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2019-02-04 12:37:10 +00:00