14fcc352cd
[gardening] Try troubleshoot flutter hhh buildbot.
...
This reverts move to appjit for flutter tools (https://github.com/flutter/flutter/pull/27749 ) that is in the range of the changes that broke `pub run build_runner test`
Change-Id: Ia1c1e66031fb7976faf75cf4a9bf95bac3a450a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97640
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-03-22 17:36:14 +00:00
87108efecb
[gardening] Update flutter patch so flutter compile_test passes.
...
Change-Id: Ibf6a31308deac5e4ef388930308774b994feb46d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97285
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-03-19 17:16:24 +00:00
231061c15a
[gardening] Moving patch to be based on dart hash.
...
Change-Id: I220a3be123d976d8de062deea6c48003d8521f72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97119
Auto-Submit: Stevie Strickland <sstrickl@google.com >
Reviewed-by: Stevie Strickland <sstrickl@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Stevie Strickland <sstrickl@google.com >
2019-03-18 16:18:55 +00:00
e6c3bc4ba9
[gardening] update Flutter engine patch file
...
Change-Id: Iba80d75ba342a3e97f35ffea3b394f97e8b86efe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97080
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2019-03-15 10:34:44 +00:00
e2b5559c77
[infra] Use gclient.py to apply patches to bypass update_depot_tools
...
apply.sh calls gclient, but the default gclient script always runs
update_depot_tools but that is not available on bots. Calling
gclient.py directly avoids that.
Change-Id: Ief80b4822277aa5a0d075c324eed0ef15a81359d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96682
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-03-12 18:18:14 +00:00
d3d077090d
[VM/FrontendServer] Add 3head patch to frontend server after breaking API changes
...
This CL
https://dart-review.googlesource.com/c/sdk/+/95683
changed the names of named, optional parameters of methods which are
overridden by code in flutter/engine.
Change-Id: I09d054b33297c0eaaf00928d0c69761abb57082a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96581
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2019-03-12 09:05:42 +00:00
32eedccdcd
[gardening] Fix patches restored in earlier commit.
...
Change-Id: I2cc25667fb98982d1bc99bf700d014f6a850fbd5
Reviewed-on: https://dart-review.googlesource.com/c/94262
Reviewed-by: Stevie Strickland <sstrickl@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Stevie Strickland <sstrickl@google.com >
2019-02-25 15:20:20 +00:00
b37de47842
[gardening] Restore flutter '--package' and dartjs_info_tag engine patch
...
Change-Id: I2637ccf341e138c56ff4df64b7e7294fc9a1d975
Reviewed-on: https://dart-review.googlesource.com/c/94225
Reviewed-by: Stevie Strickland <sstrickl@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Stevie Strickland <sstrickl@google.com >
2019-02-25 14:12:27 +00:00
0e99581c35
[gardening] Restore flutter '--package' patch, add dartjs_info_tag engine patch
...
Change-Id: I19c4ceeca877f99128a733a23bb1ad5abd99e032
Reviewed-on: https://dart-review.googlesource.com/c/93848
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-02-21 19:06:40 +00:00
75ee523f91
[VM] Remove flutter/flutter patch for 3head, the issue has been fixed upstream
...
Namely by https://github.com/flutter/flutter/pull/28101
Change-Id: I686927bebffccbb1b575ba488739c38e7de68c9e
Reviewed-on: https://dart-review.googlesource.com/c/93940
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
Auto-Submit: Martin Kustermann <kustermann@google.com >
2019-02-21 09:13:09 +00:00
4013b0eece
[gardening] Add adjusted fix to flutter test patch.
...
Follow-up to https://dart-review.googlesource.com/c/sdk/+/93921 .
Change-Id: Ic0a38e574964d74e220a544b457a204ab04da2b6
Reviewed-on: https://dart-review.googlesource.com/c/93846
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-02-21 06:30:10 +00:00
69d46587cf
[gardening] Add fix to flutter test patch.
...
Follow-up to https://dart-review.googlesource.com/c/sdk/+/93920 .
Change-Id: If65340f2d997f6a94b36519fe2d01a16677e9b59
Reviewed-on: https://dart-review.googlesource.com/c/93921
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-02-21 06:15:33 +00:00
e58b7cd59e
[gardening] Fix flutter patch.
...
Follow-up to https://dart-review.googlesource.com/c/93845
Change-Id: I6d558e63ab41ed0cb09b5a56af2a9b7d397136ae
Reviewed-on: https://dart-review.googlesource.com/c/93920
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-02-21 03:51:56 +00:00
22e70ed48f
[gardening] Patch flutter/flutter to fix hhh buildbot
...
Change-Id: Ib3a8e03591dd26c83dc9d27d8cef0aaff0279957
Reviewed-on: https://dart-review.googlesource.com/c/93845
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-02-21 01:32:22 +00:00
6846a7c486
Fix flutter analyzer bot by disabling lint prefer_collection_literals.
...
With set literal support enabled, there are many new cases in Flutter hit by this lint.
Change-Id: Ife1e4f9ac5205bdfb74b89ab18a6c36dd9ebcea1
Reviewed-on: https://dart-review.googlesource.com/c/93460
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-02-15 20:40:46 +00:00
7fe7e28c46
[vm] Fix location of Flutter 3xH patch file.
...
Change-Id: Ib055f110ac189cb553e86d86e6a807cae08c0b6d
Reviewed-on: https://dart-review.googlesource.com/c/93083
Reviewed-by: Samir Jindel <sjindel@google.com >
2019-02-13 15:49:25 +00:00
809d8123d3
[vm] Add FFI library to more targets and Flutter file libraries.json (in patch).
...
Change-Id: I65421efbc708b5192f871a0dae5f739352c5c3d9
Reviewed-on: https://dart-review.googlesource.com/c/93080
Reviewed-by: Samir Jindel <sjindel@google.com >
2019-02-13 15:01:23 +00:00
1bfc3816d8
[infra] Extend 3head patching to apply patches for flutter/flutter depending on pinned engine commit
...
This also adds a patch to flutter/flutter to fix head-head-head
configuration (until engine is rolled into framework again).
Change-Id: I6dae0983126a6664337834d3c93f1369139f1ac1
Reviewed-on: https://dart-review.googlesource.com/c/91922
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2019-02-04 12:37:10 +00:00
bcbf47d48f
[gardening] Patch flutter engine to unbreak hhh build.
...
Change-Id: If6fa39703db1bb6307b2eda0f7eafa92cdd18375
Reviewed-on: https://dart-review.googlesource.com/c/88120
Reviewed-by: Alexander Aprelev <aam@google.com >
2018-12-27 17:00:24 +00:00
2219b51b7e
[gardening/flutter] Update 3xH patch to remove --sync-async flag from engine build file.
...
Change-Id: Ib35ddb9b297a69d3e41fd15ef259d326353ad340
Reviewed-on: https://dart-review.googlesource.com/c/87974
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2018-12-21 15:23:32 +00:00
fbd014bc8a
Revert "[gardening] remove sync-async flag use from flutter"
...
This reverts commit 58fd3aaaf2https://dart-review.googlesource.com/c/87971
> Reviewed-by: Samir Jindel <sjindel@google.com >
TBR=sjindel@google.com ,dacoharkes@google.com
Change-Id: If1d4ef50edf6d4ac95cf906a18eafe4af25338cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/87973
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2018-12-21 15:15:05 +00:00
58fd3aaaf2
[gardening] remove sync-async flag use from flutter
...
Change-Id: I3bc54d60507f7234d2e4a14ba58f327fd82cc728
Reviewed-on: https://dart-review.googlesource.com/c/87971
Reviewed-by: Samir Jindel <sjindel@google.com >
2018-12-21 14:55:45 +00:00
3baab294c1
[gardening] Update 3xHEAD patch
...
TBR=paulberry@google.com
Change-Id: I9dffd4709f2817717c42733a608cdcd9bf59e984
Reviewed-on: https://dart-review.googlesource.com/c/86922
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-12-11 13:07:50 +00:00
84420e1ae5
[vm] Roll version of pkg/linter forward in 3xH engine patch.
...
Change-Id: I7f517b467de203bb22ae29a50fe8758f40869f7c
Reviewed-on: https://dart-review.googlesource.com/c/86210
Reviewed-by: Samir Jindel <sjindel@google.com >
2018-12-05 17:43:03 +00:00
4eeebc46cf
[hhh] Patch flutter so it is compatible with latest analyzer
...
Change-Id: I70b9cdb0609e063fa9b0ce1e4a89dac24f87fad9
Reviewed-on: https://dart-review.googlesource.com/c/85730
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2018-12-03 17:10:46 +00:00
1891636db0
[gardening] Final attempt to fix apply.sh.
...
Use git cache fetch correctly
TBR=kustermann@google.com
Change-Id: I9245ebc2bb36e4f80e815b0f4557a34f77cbbe84
Reviewed-on: https://dart-review.googlesource.com/c/85289
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-11-23 15:32:40 +00:00
6300b7e0a0
[gardening] Fix apply.sh syntax (no spaces between variable name and =)
...
TBR=kustermann@google.com
Change-Id: Ia268f69045d91447f5b84ee9a21926b03ecc2f58
Reviewed-on: https://dart-review.googlesource.com/c/85288
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-11-23 15:19:21 +00:00
2fbc6b9a2e
[gardening] Make apply.sh script force update git cache used by bots
...
R=kustermann@google.com
Change-Id: Id03377dbe4a294032d41a612076b933b447fd2f6
Reviewed-on: https://dart-review.googlesource.com/c/85287
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-11-23 15:03:57 +00:00
1ed5f78e9c
[gardening] Make apply.sh script fetch before trying to checkout.
...
TBR=kustermann@google.com
Change-Id: I195100218b7d83eee4647d5baf254c075e7492df
Reviewed-on: https://dart-review.googlesource.com/c/85286
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-11-23 13:48:08 +00:00
c62af758ee
[gardening] Switch apply.sh script to use bash instead of sh
...
R=sortie@google.com
Change-Id: I30d39d4edf864d0307d18c8fd095649cfe3ed17c
Reviewed-on: https://dart-review.googlesource.com/c/85284
Reviewed-by: Jonas Termansen <sortie@google.com >
2018-11-23 13:31:15 +00:00
01380ede49
[gardening] Expand 3xHEAD Flutter patch mechanism to support DEPS file changes.
...
We don't rerun gclient sync after applying patches so changes to Dart
dependencies were not picked up.
Change-Id: I4360ddf7f906ab0552bd3ae8abbe9210a785845a
Reviewed-on: https://dart-review.googlesource.com/c/85282
Auto-Submit: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2018-11-23 13:10:25 +00:00
ba0222df78
[flutter] Update flutter-engine-linux 3xHEAD patch.
...
dart2js_info dependency is upgraded to 0.5.15 from 0.5.13
Change-Id: I3077c7953af17c610864d309e9f17e350a560fba
Reviewed-on: https://dart-review.googlesource.com/c/85262
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-11-23 11:37:36 +00:00
c8372c00dc
Patch hhh flutter flutter as follow-up to https://dart-review.googlesource.com/c/sdk/+/84688
...
Change-Id: I392ad11684eedee143cab9e90227c6b886e09c12
Reviewed-on: https://dart-review.googlesource.com/c/84960
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2018-11-20 20:15:51 +00:00
57a4f11b64
[gardening] Patch flutter engine post 0ca1c57
...
Change-Id: I92d9589850fa4b95c4be454a48e9e9782f90b908
Reviewed-on: https://dart-review.googlesource.com/c/84926
Commit-Queue: Alexander Aprelev <aam@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2018-11-20 18:50:06 +00:00
dcb665fa6d
[hhh] Apply patch to flutter engine to fix hhh buildbot build step.
...
Change-Id: I13cceb1a784092f8c66d151eb8afeac0162a9c7a
Reviewed-on: https://dart-review.googlesource.com/c/80900
Commit-Queue: Alexander Aprelev <aam@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2018-10-19 18:10:44 +00:00
431fd74441
[hhh] Remove flutter patch, since the change actually landed in flutter/flutter repo.
...
Change-Id: I62b1a235d571234009f81a491732b4a6875f7478
Reviewed-on: https://dart-review.googlesource.com/74000
Reviewed-by: Alexander Aprelev <aam@google.com >
2018-09-07 17:11:45 +00:00
fa862aa490
[hhh] Fix string comparison in apply.sh.
...
This is follow-up to https://dart-review.googlesource.com/73686 .
Change-Id: Id2e6d16deef5d3655f7e80ea50181d39173069a5
Reviewed-on: https://dart-review.googlesource.com/73842
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-09-07 07:00:59 +00:00
df1afc516e
[hhh] Add flutter/flutter patching capability to hhh buildbot.
...
Change-Id: I6b7d96a335c7a8f130ad0c2388c7fb6ba38e2c83
Reviewed-on: https://dart-review.googlesource.com/73686
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-09-07 06:00:46 +00:00
a1b1b8dc06
[hhh] Patch engine until next dart roll lands
...
Incompatible change landed https://dart-review.googlesource.com/c/sdk/+/72540 .
Change-Id: I618650964ec953ae8f0efe9c45e59ecd356a2840
Reviewed-on: https://dart-review.googlesource.com/73685
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2018-09-06 21:08:04 +00:00
e8ecb3bc08
Support incompatible Dart SDK changes with patches to the Flutter Engine.
...
The Dart SDK may change incompatibly and require a corresponding update to
the Flutter Engine when Flutter Enginer rolls its Dart SDK. The flutter
targets on Golem uses a 3-way HEAD of the Dart SDK, the Flutter Engine, and
the Flutter Framework, meaning that it needs to apply the corresponding
update to the Flutter Engine immediately. Otherwise the Flutter targets will
be broken and not successfully run benchmarks until the next Flutter roll.
This change lets the Dart SDK make incompatible changes that affects the
Flutter Engine by checking in the corresponding patch into the Dart SDK
along with the incompatible change. The build step will determine what the
latest roll is by looking up which Dart SDK Hash the Flutter Engine has
pinned. If a patch exists for that hash, then that patch is applied to the
Flutter Engine.
For instance, if the Flutter Engine commit ab12 has pinned the Dart SDK
commit cd34, then it the patch tools/patches/flutter-engine/cd34.patch is
applied. Once the Flutter Engine rolls its Dart Engine, usually by
applying an equivalent patch, the roll commit will start refering to an
non-existent patch and the HEADs will be built together pristine again.
Finally cd32.patch can be removed from new versions of the Dart SDK.
The tools/patches/flutter-engine/apply.sh script is applies such patches in
3-way HEAD builds. The create.sh script is meant to be used by developers
when making incompatible changes to the Dart SDK that affects the Flutter
Engine. The top level tools/3xhead_flutter_hooks.sh script is meant to be
used by the CI as forward compatibility if additional hooks are added in the
future.
Change-Id: Ibf8e125b26dac319ba1c5302c003d7668155336a
Reviewed-on: https://dart-review.googlesource.com/64684
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-07-12 15:47:16 +00:00
Alexander Aprelev