Commit Graph

1657 Commits

Author SHA1 Message Date
blois@google.com 0956f1c314 Fixing HttpRequest.upload.onProgress.
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16376006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23658 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 21:09:59 +00:00
blois@google.com 797769e39f Fixing SelectElement.options, adding support for optgroup.
BUG=8115
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16409002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23652 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 19:45:36 +00:00
blois@google.com 320b629f3f Hiding dart:html's Entity
Causing some conflicts with other packages, need to decide what we want to do with it.

BUG=
R=dgrove@google.com

Review URL: https://codereview.chromium.org//16049006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23646 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 17:49:16 +00:00
blois@google.com 58a92ac603 Fixing a number of Dart2JS compiler warnings.
BUG=11039
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16336022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23569 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 21:11:14 +00:00
blois@google.com 0f9bcbe05e Updating Clipboard.setDragImage to accept elements.
This changes the IDL to expose it, but the method is custom in V8 and needs to be custom in Dart.

Basically the spec has changed that setDragImage should accept elements rather than just images:
http://www.w3.org/html/wg/drafts/html/master/editing.html#dom-datatransfer-setdragimage

And V8 (and Firefox) already support this:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/v8/custom/V8ClipboardCustom.cpp&sq=package:chromium&type=cs&l=80&rcl=1369903032

Also, this appears to already have the Dartium code for it-
http://src.chromium.org/multivm/trunk/webkit/Source/bindings/dart/custom/DartClipboardCustom.cpp

Not sure if there are additional changes, but this appears to work for me (requires manual testing).

BUG=10819
R=antonm@google.com

Review URL: https://codereview.chromium.org//15810007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23568 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 21:09:44 +00:00
blois@google.com 5bbd582932 Fixing some of the tests disabled from the chrome IDL roll.
Basically some native constructors were added which are not yet cross-platform, so skipping them for now.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//16335012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23564 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 20:10:48 +00:00
amouravski@google.com 768d611f4e Remove more question marks.
R=antonm@google.com, blois@google.com

Review URL: https://codereview.chromium.org//14976004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23563 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 19:56:58 +00:00
blois@google.com bda041d474 Updating DOM metadata triage list for recent Blink changes.
BUG=
R=efortuna@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//15896022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23554 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 17:45:06 +00:00
vsm@google.com 03de0e182f Remove error throw on bad DEFINES
We need to be forgiving here for Android builds.

R=antonm@google.com

Review URL: https://codereview.chromium.org//16325009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23547 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 15:44:20 +00:00
antonm@google.com 2ebfa26751 Remove now absent interfaces/methods.
R=vsm@google.com

Review URL: https://codereview.chromium.org//16055011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23544 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 15:07:57 +00:00
antonm@google.com 081a2be830 Allow null strings in setters.
V8 generator always allows nulls for Reflect attributes of type
DOMString.  That looks somewhat hairy, but let's just follow the logic
for Dart as well.

R=podivilov@chromium.org
BUG=8189

Review URL: https://codereview.chromium.org//16329002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23541 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 13:26:11 +00:00
antonm@google.com 442b84095e Always return true for ShadowRoot.supported.
R=blois@google.com
BUG=10960

Review URL: https://codereview.chromium.org//15679018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23525 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 08:21:37 +00:00
vsm@google.com ead4d0e00a Removed Console.profiles
This is now gone in Blink.

TBR=blois

Review URL: https://codereview.chromium.org//16311003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23519 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 23:02:13 +00:00
vsm@google.com 1735f7a080 IDL roll and expectations fix
To the latest Blink.

TBR=blois

Review URL: https://codereview.chromium.org//16311002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23516 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 22:46:00 +00:00
vsm@google.com b85b97cbe6 Fixes for Blink roll to r151189
TBR=antonm

Review URL: https://codereview.chromium.org//16308002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23511 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 18:34:36 +00:00
lrn@google.com faa7227cec Make new StreamController be async by default.
Change all instances, except some tests, to be sync still.
Rename Multiplex to Broadcast everywhere.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//16125005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23453 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 06:07:39 +00:00
blois@google.com 9a9db6b3eb Fixing broken tests because of mismatch of suppressed warnings.
Removing additional warnings and fixing the core issues.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16050007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23433 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 18:26:32 +00:00
blois@google.com ca01606620 Fixing dart2js compilation warning.
Was seeing the warnings:
build/ReleaseIA32/dart-sdk/lib/html/dart2js/html_dart2js.dart:15831:21: Warning: no property named _this in class Iterable
      if (identical(newNodes._this, this)) {
                    ^^^^^^^^^^^^^^
build/ReleaseIA32/dart-sdk/lib/html/dart2js/html_dart2js.dart:15838:27: Warning: no operator [] in class Iterable
        this.insertBefore(newNodes[0], refChild);

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//15660010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23428 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 17:47:07 +00:00
blois@google.com 8d750efbfe Suppressing CustomElementConstructor.
Not hiding it yet, but marking it in the metadata as going away.

BUG=9902
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16153009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23424 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 16:34:01 +00:00
blois@google.com 881e456c21 Cleaning up some DOM APIs which were marked as deprecated because they were moved or renamed.
There were basically two issues:
- localName and namespaceUri moved from Node down to Element.
- The transitionEnd event was polyfilled based on the deprecated webkitTransitionEnd event, so it was switched to the standard transtionEnd.

The Attr change was needed because the node map was using localName on Attr (inherited from Node), when it should have been using name. Attr is not actually exposed anywhere, so made it private.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//15814008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23423 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 16:31:09 +00:00
blois@google.com 0c7e06c5cf Fixing type of ApplicationCache.onProgress.
BUG=10317
R=efortuna@google.com

Review URL: https://codereview.chromium.org//15820013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23372 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 00:56:57 +00:00
efortuna@google.com 533a66bdac Reapply removeWhere and retainWhere for elements in dart:html
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//15810006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23371 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 23:40:52 +00:00
efortuna@google.com 54bafa2ebf "Reverting 23366"
BUG=

Review URL: https://codereview.chromium.org//15950008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23369 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 22:25:05 +00:00
efortuna@google.com 942392b7e6 Correctly implemented removeWhere and retainWhere for elements in dart:html.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//16171012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23366 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 21:22:22 +00:00
antonm@google.com 4638137480 Switch from DRT to content shell.
R=kustermann@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//15755017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23328 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 08:34:52 +00:00
efortuna@google.com 1762c5fb0d Change top level queryAll to return ElementList.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//15935007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23316 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 00:52:02 +00:00
efortuna@google.com 34b6083654 Fix up other RTC family mozilla names.
BUG=

Review URL: https://codereview.chromium.org//15879008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23313 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 00:26:47 +00:00
efortuna@google.com c89a0c73c0 Add mozRTCPeerConnection to JS names.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//15901006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23312 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 23:48:14 +00:00
blois@google.com 0942acf5d2 Fixing IndexedDB's deleteDatabase to have the correct future result.
BUG=10648
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16022012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23305 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 19:38:44 +00:00
blois@google.com 4b6f22863a Clarifying EventStreamProvider.forTarget.
BUG=https://code.google.com/p/dart/issues/detail?id=10366
R=efortuna@google.com

Review URL: https://codereview.chromium.org//15762003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23304 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 19:35:49 +00:00
blois@google.com a1f522165f Modernizing HttpRequest documentation.
Also fixing docs so they get applied to Dartium.

BUG=https://code.google.com/p/dart/issues/detail?id=10547
R=efortuna@google.com

Review URL: https://codereview.chromium.org//15819003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23303 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 19:33:06 +00:00
efortuna@google.com 87182ddeac Make RTC work on Firefox (mostly).
BUG=
R=blois@google.com, sra@google.com

Review URL: https://codereview.chromium.org//16023011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23298 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:55:05 +00:00
antonm@google.com fd3c7da1ee Verify that correct number of arguments was passed.
R=amouravski@google.com

Review URL: https://codereview.chromium.org//15850004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23296 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:42:13 +00:00
floitsch@google.com 5d058bb0eb Adding isNotEmpty property to collection and string.
BUG= http://dartbug.com/3074
R=floitsch@google.com

Review URL: https://codereview.chromium.org//15263004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23294 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:30:37 +00:00
lrn@google.com 37b1cd3b3f Optimize internals of multiplex-streams.
Make the multiplex streams broadcast streams.
This allows you to listen twice on the same stream, instead of having to get
a new stream each time.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//16007003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23256 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 12:06:34 +00:00
lrn@google.com 781e84284f Reapply "Active stream subscriptions".
Makes subscriptions the active part of a stream, with the stream
itself being just an inert creator of subscriptions.

This changes the behavior of a "single subscription" stream to match
the documentation: After the subscription is canceled, you can't
resubscribe to the stream. Previously, you could do that, but it was
never documented or intended.
This also makes the stream of a StreamController not be paused while
before it's subscribed - it is always the subscription that is paused
or not, and while there is no subscription, the stream cannot be
paused. Previously the stream was set to paused until the first
subscription in order to prevent events from being lost. That is
handled independently of pauses now.

Adds StreamController.multiplex constructor. This name is tentative,
and likely to change. Its behavior may change as well. It currently
provides a new single-subscription stream each time its "stream"
getter is read, and you can subscribe to these.

Adds StreamIterator class that allows iterating over a stream's data
events using (async) "moveNext()" and "current", like a direct style
Iterator (sorry, it won't work in a for-in loop).

Review URL: https://codereview.chromium.org//16131003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23237 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 07:28:36 +00:00
lrn@google.com cc0d9d57af Revert until Windows crash is debugged.
Reverts r23218, r23217, r23208, r23207, r23206, r23205, r23204.

r23218 | Path observer is listened more than once, so make it multiplex.
r23217 | Add StreamController.multiplex constructor.
r23208 | Fix bug in streamimpl
r23207 | Fix bug in stream iterator.
r23206 | Change expectations for http_parser_test.
r23205 | Fix bug in stream-impl.
r23204 | Make StreamSubscription be the active part of a string.

Review URL: https://codereview.chromium.org//15989006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23221 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 13:03:03 +00:00
lrn@google.com 76178d326a Path observer is listened more than once, so make it multiplex.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//15932005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23218 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 12:38:27 +00:00
blois@google.com ecb5686319 Generating support annotations from DOM triage list.
This is applying the results of the detailed API triage I did to the support annotations for DOM types.

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//15074006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23159 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 17:14:47 +00:00
antonm@google.com 7156616c08 Revert to ? presence checks.
TBR=amouravski@google.com

Review URL: https://codereview.chromium.org//15960004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23127 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 09:02:25 +00:00
amouravski@google.com f968d3465c Added tests to previously broken functionality and added null checks.
R=antonm@google.com

Review URL: https://codereview.chromium.org//15138002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23123 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 08:23:24 +00:00
blois@google.com ba295aaafe Only update dom.json when executing from go.sh.
BUG=
R=antonm@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//15685004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23099 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-23 20:30:43 +00:00
antonm@google.com 6e51015ab7 Remove now unused attribute.
R=vsm@google.com

Review URL: https://codereview.chromium.org//15732002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23033 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-22 18:12:59 +00:00
antonm@google.com 5b9d62c9a9 Migrate to new indexed getter marking scheme.
TBR=blois@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//15706003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22995 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-22 08:52:52 +00:00
antonm@google.com b80cfdce1c Regens after IDL roll.
TBR=blois@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//15697002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22991 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-22 08:05:50 +00:00
blois@google.com ee483c9b6a Cleanup of various DOM dart2js and dart_analyzer warnings
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//15431003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22976 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-22 01:23:28 +00:00
blois@google.com 4284aa2264 Getting html_dart2js and html_dartium a bit more in sync.
I used the analyzer and made a quick API diff app to compare the two libraries, most of these are just minor nits, but good to get them in sync.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//14630016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22963 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-21 21:52:07 +00:00
blois@google.com 77ad8172f3 Exposing a number of new events.
These are all new events which we didn't have naming entries and event types for.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//15434003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22955 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-21 20:46:18 +00:00
antonm@google.com 1d6243bb18 Changes for the roll.
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//15250010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22942 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-21 14:18:00 +00:00
vsm@google.com f1718c5140 Update ENABLE_* flags
Bring this up to date with:

http://src.chromium.org/viewvc/multivm/trunk/webkit/Source/core/features.gypi?revision=1242

Note, this does *not* change any generated code.  Unused flags where
removed.  Added flags are precautionary.  They don't affect generated
code, but they are defined in a Chromium build.

R=antonm@google.com

Review URL: https://codereview.chromium.org//15294015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22890 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-20 15:55:06 +00:00