Commit Graph

746 Commits

Author SHA1 Message Date
Alan Knight 8f35656f9b Fix node_validator xss tests for IE and Firefox
BUG=

Review URL: https://codereview.chromium.org//1365093003 .
2015-09-24 10:43:08 -07:00
Alan Knight 0568fa8679 Omit extra argument to createElement/NS if null
BUG=

Review URL: https://codereview.chromium.org//1345413004 .
2015-09-22 09:28:38 -07:00
Terry L. Lucas bcf8dfe1f1 Merge mistake removed annotations for dart2js; re-added.
TBR=sra@google.com

Review URL: https://codereview.chromium.org//1350063004 .
2015-09-18 07:25:33 -07:00
Terry L. Lucas fc8682ceac Fixed another dart2js code emitting error and enabled tests that now work
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1346203002 .
2015-09-16 08:19:15 -07:00
Terry L. Lucas 7b322c246c Dartium JS Enabled take 2
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1348173002 .
2015-09-16 07:13:53 -07:00
Terry L. Lucas 09c804aa78 Revert "Dartium JS Interop enabled."
This reverts commit 403bd1698d.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1345083002 .
2015-09-15 19:44:26 -07:00
Terry L. Lucas 403bd1698d Dartium JS Interop enabled.
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1349493003 .
2015-09-15 17:36:47 -07:00
Terry L. Lucas 9b0d2582fc Revert "Dartium w/ JsInterop enabled"
This reverts commit 346af54711.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1330163010 .
2015-09-09 17:33:24 -07:00
Terry L. Lucas 346af54711 Dartium w/ JsInterop enabled
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1321613005 .
2015-09-09 17:01:40 -07:00
Terry L. Lucas 012c998f64 Revert "Patched in Dartium JsInterop"
This reverts commit 4bb2e617db.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1327083002 .
2015-09-08 13:35:03 -07:00
Terry L. Lucas 4bb2e617db Patched in Dartium JsInterop
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1310363006 .
2015-09-08 12:46:41 -07:00
Alan Knight 89b99e60bf Remove dart2js-specific annotations from childNodes
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1290263002 .
2015-08-14 09:32:45 -07:00
Alan Knight de3ce04f0a Fix type problem with FilteredElementList._iterable
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1236793006 .
2015-07-17 10:53:19 -07:00
Alan Knight d5599eb63b Restore workaround for old Chrome bug that also affects Safari and in some cases Firefox, fix test suppressions
BUG=

Review URL: https://codereview.chromium.org//1242063002 .
2015-07-16 13:20:26 -07:00
Alan Knight 4e790fef3d appendHtml, when sanitizing, should create document fragment in the right context
BUG=
R=terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/560f12bb21874824788e1f660ca07b8914c8cc4f

Committed: https://github.com/dart-lang/sdk/commit/930a40daa50a93adfce8786f4d7ef25e06324dda

Review URL: https://codereview.chromium.org//1221043003 .
2015-07-16 10:30:51 -07:00
Terry L. Lucas 5e52d8dc5d Updates for dart:js fixes after initial --gen-interop
TBR=vsm@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org//1228093007 .
2015-07-16 09:52:44 -07:00
Terry L. Lucas cec5812335 Fixed Dictionary and Event hookup w/o --gen-interop
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//1233083004 .
2015-07-14 14:18:48 -07:00
Terry L. Lucas 1fa61ee114 Fixed a few more things to make Dartium build w/o --gen-interop
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//1239653003 .
2015-07-14 07:17:59 -07:00
Alan Knight 610edadff2 Revert "appendHtml, when sanitizing, should create document fragment in the right context"
This reverts commit 930a40daa5.

BUG=

Review URL: https://codereview.chromium.org//1230203005 .
2015-07-13 15:32:17 -07:00
Terry L. Lucas 48af868f47 Fixed compilation error
Review URL: https://codereview.chromium.org//1233923003 .
2015-07-13 13:24:08 -07:00
Alan Knight 930a40daa5 appendHtml, when sanitizing, should create document fragment in the right context
BUG=
R=terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/560f12bb21874824788e1f660ca07b8914c8cc4f

Review URL: https://codereview.chromium.org//1221043003 .
2015-07-13 12:50:49 -07:00
Terry L. Lucas 4947e570d4 Changed to use JSInterop
Review URL: https://codereview.chromium.org//1173403004 .
2015-07-13 12:38:16 -07:00
Alan Knight 1e8a275a20 Revert "appendHtml, when sanitizing, should create document fragment in the right context"
This reverts commit 560f12bb21.

	modified:   sdk/lib/html/dart2js/html_dart2js.dart
	modified:   sdk/lib/html/dartium/html_dartium.dart
	modified:   tests/html/element_add_test.dart
	modified:   tools/dom/templates/html/impl/impl_Element.darttemplate

BUG=

Review URL: https://codereview.chromium.org//1230553003 .
2015-07-08 12:19:30 -07:00
Alan Knight 560f12bb21 appendHtml, when sanitizing, should create document fragment in the right context
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1221043003 .
2015-07-08 10:16:37 -07:00
Alan Knight 1d5b657427 Make it easier and more efficient to use trusted HTML text
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1154423009.
2015-06-22 09:41:01 -07:00
Alan Knight efb738f633 Sanitization should reject elements that we can't examine (e.g. embed/object on FF)
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1146753004
2015-05-21 13:54:50 -07:00
alanknight@google.com 1f20842389 Another try at appendHtml and insertAdjacentHtml should be consistently sanitized
BUG=

Review URL: https://codereview.chromium.org//1123173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45818 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 17:59:23 +00:00
alanknight@google.com bfa61f62e0 "Reverting 45815"
BUG=

Review URL: https://codereview.chromium.org//1127403006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45816 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 17:04:53 +00:00
alanknight@google.com 1c69173804 Test Dartium with appendHtml sanitizing. Will immediately revert.
BUG=

Review URL: https://codereview.chromium.org//1133343005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45815 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 16:30:17 +00:00
alanknight@google.com 90a31f8fea "Reverting 45807"
BUG=

Review URL: https://codereview.chromium.org//1139193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45808 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 01:29:49 +00:00
alanknight@google.com 2faa58eb4c Testing for appendHtml and insertAdjacentHtml should be consistently sanitized
BUG=

Review URL: https://codereview.chromium.org//1147473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45807 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-15 01:10:19 +00:00
alanknight@google.com e1c798b0fd "Reverting 45790"
BUG=

Review URL: https://codereview.chromium.org//1138383006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45791 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 19:04:23 +00:00
alanknight@google.com 9453809937 appendHtml and insertAdjacentHtml should be consistently sanitized
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1081973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45790 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 18:04:17 +00:00
alanknight@google.com f777d314b7 Relax the deltaX/Y/Z types in WheelEvent constructor
BUG=

Review URL: https://codereview.chromium.org//1133303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45741 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 18:04:58 +00:00
alanknight@google.com f0136ff1eb Clean up WheelEvent
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1126463005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45740 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 16:34:01 +00:00
alanknight@google.com 4a1b567136 Pass Redirect status higher than 307 through to the user
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1135893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45739 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 16:25:56 +00:00
alanknight@google.com 25c6f198f5 "Reverting 45351"
BUG=

Review URL: https://codereview.chromium.org//1097053006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45353 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 17:51:58 +00:00
alanknight@google.com 7431beaec2 appendHtml and insertAdjacentHtml should be consistently sanitized
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1081973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45351 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 17:16:01 +00:00
alanknight@google.com b13d4f5742 Check for DOM clobbering attacks in sanitizing/node validation
BUG=

Review URL: https://codereview.chromium.org//1077813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45028 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 19:47:34 +00:00
sra@google.com 0b1fb9cda5 Generate fast-path CssStyleDeclaration properties from browser info
We can tell all our suported browsers have style.backgroundColor so we can avoid the detection and vendor prefix logic.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//966803004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44973 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-08 16:18:36 +00:00
sra@google.com 9b2d7cae44 CssStyleDeclaration performance work
Cache browser prefix detection to avoid repeated camelCasing.
Remove IE9 compatibility code.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//1064783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44951 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 21:34:20 +00:00
sra@google.com f8fb9710ee Revert trial commit of "CssStyleDeclaration performance work"
If all goes well, will be recommited after code review.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1062973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44932 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 01:52:05 +00:00
sra@google.com 440f677b46 CssStyleDeclaration performance work
Cache browser prefix detection to avoid repeated camelCasing.
Remove IE9 compatibility code.

Review URL: https://codereview.chromium.org//1064783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44931 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-07 01:22:54 +00:00
sra@google.com 2e42929db9 Don't cache SVG CssClassSet
Separate dart apps loaded into the same page will fight.

Review URL: https://codereview.chromium.org//1057193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44878 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-03 02:31:42 +00:00
alanknight@google.com 5397482fcc Make dartj2s do type conversions on constructor arguments
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1023363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44688 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 17:39:49 +00:00
alanknight@google.com b44058a0d2 Make Element.animate work in dart2js Chrome
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1014843004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44642 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 18:26:06 +00:00
alanknight@google.com 5d2f7f8ae8 Fix notification
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1002953005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44471 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 17:21:31 +00:00
alanknight@google.com 0babe95cba Fix usage of renamed parameter in EventSource
BUG=

Review URL: https://codereview.chromium.org//974553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44146 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 20:15:27 +00:00
alanknight@google.com 1fd8fe6e9c Change EventSource parameter from title to url, to match idl
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//958393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44138 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 18:44:56 +00:00
terry@google.com 68c6b252e4 Fixed tests for DOMPoint support for dart2js.
TBR=asiva@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//968613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44115 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-01 18:01:53 +00:00