dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

120 Commits

Author SHA1 Message Date
Sigmund Cherem d52475c166 [web] deprecate dart:web_sql 
The WebSql was dropped 5+ years ago and this library is unsupported.

This change adds the `@deprecated` annotation on the library and APIs in
dart:html that expose it (`window.openDatabase`). It also indicates to dartdoc
to skip it for the api.dart.dev site.

I run a `pub_crawl` process to verify that this is not in use. I checked 15K
packages, and only found 2 occurrances of an import to this library:
  * One in a package marked as discontinued (used for migrating constants back
  in Dart 2)
  * Another in an example mock test (generated by mockito for mocking dart:html)
Also no library uses `window.openDatabase` either.

We will send a breaking change announcement soon and plan to delete this in a
future Dart release (possibly 2.15).

Fixes https://github.com/dart-lang/sdk/issues/45687
Fixes https://github.com/dart-lang/sdk/issues/45688

Change-Id: I8cd2bfa0ce64892c3f108bd6e24b8a0a3ec7c6ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196461
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2021-04-23 19:04:42 +00:00
Srujan Gaddam 63a57a76ce [dart:html] Revert "[dart:html] Revert commits using MDN compatibility info" 
This reverts commit f8ff12008e.

This CL is a revert of the initial revert and should be landed once
Flutter changes have been merged to handle the changes here.

Change-Id: I300a5efd776bf2a596743971f4e15ad62da77f5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153368
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-07-14 23:18:43 +00:00
Srujan Gaddam f8ff12008e [dart:html] Revert commits using MDN compatibility info 
This reverts commits aff77e7e..e24f205d.

Due to a breakage in a Flutter roll, this CL stack needs to be
reverted. It should be reintroduced with changes to Flutter code to
compile with the changes in dart:html.

Breakage: https://github.com/flutter/engine/runs/828631927

Change-Id: I9c93c4eab823337d09d2e347015ad9ec402f2038
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152910
Auto-Submit: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
 2020-07-02 01:33:18 +00:00
Srujan Gaddam e24f205d16 [dart:html] Mark setters nullable if incompatible as well 
Getter types need to be a subtype of the setter type, so if getters
are nullable due to incompatibility, the setter needs to be as well.
This change makes those changes, updates documentation, and modifies
a template and test file.

Change-Id: I2130538bb4005b3553eb7951af022c1c2ed59c1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152607
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-07-01 22:06:34 +00:00
Srujan Gaddam b0d35855d8 [dart:html] Add nullability to node signature 
Closes https://github.com/dart-lang/sdk/issues/41616

When merging interfaces, nullable and non-nullable types
should not be treated as the same. This also fixes some nullability
information that was not included in dart.idl but is part of the
Chromium IDL.

Change-Id: I6e94176d905b63364bc93dc2120d194452cf05f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144464
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-23 04:56:28 +00:00
Srujan Gaddam 01da93f053 [dart:html] Change visualViewport to be nullable 
Closes https://github.com/dart-lang/sdk/issues/41612

visualViewport can be nullable on Firefox. This is a workaround
until https://github.com/dart-lang/sdk/issues/41616 is addressed.

Change-Id: I386d8fc8716026191bace912e46a2c56358d079a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144350
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
Auto-Submit: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2020-04-22 02:34:54 +00:00
Srujan Gaddam b213b4ff58 [dart:html] Nullability fixes based on JS call 
Changes types of return values depending on if the
call allows a Null type.

Change-Id: Id9b3d69eee1008d46a6b3b16f217a6b9c892fc6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141260
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2020-03-30 22:06:01 +00:00
Srujan Gaddam 6d051311b6 Add back in null assertions for legacy weak mode 
These assertions need to be added back into the nnbd sdk in order to be
compatible with weak mode.

Change-Id: Ie774fffda1fb0e79dbc7fe13cb75b9d28e4268fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136720
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2020-02-21 19:13:31 +00:00
Srujan Gaddam 3776313e65 Change dart:html templates to generate null-safe code 
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.

Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-02-06 23:18:24 +00:00
Vijay Menon 1eaa7d2902 [html] cleanup JS types 
This ensures JS calls in the SDK are statically typed (or, at least, don't
inadvertently trigger dynamic calls).

Analyzer has a hack where `JS('String', ...)` is typed as `String`.  Kernel
doesn't, but we get the same effect (in DDK) via `JS<String>('String', ...)`.

This should not affect dart2js which specially interprets the type string
itself.

Change-Id: I63c5f199e2c51da2beca72659261acf1faff66e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112937
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2019-08-14 18:02:09 +00:00
Sam Rawlins bb293ef8cf Fix docs for Window.close() and Window.location= 
* `closed` is not a method.
* `location` is not a method.
* `location=` does _not_ take a String; only a Location object.

Fixes #16893

Change-Id: Ia5389ae80c39c5c7d9eebdd0cd04cb994a27fd7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111965
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-08-08 15:20:41 +00:00
Sam Rawlins f7dab643ff Remove discontinued webproject.org links. Fixes #21482 
Bug: https://github.com/dart-lang/sdk/issues/21482
Change-Id: Ie3becfa7eb9f233186629cf97bfcabe51efc8794
Reviewed-on: https://dart-review.googlesource.com/c/82790
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2018-11-06 22:20:51 +00:00
Sam Rawlins 29dc5fc4c2 doc - Add units info to requestFileSystem docs 
Bug: https://github.com/dart-lang/sdk/issues/20008
Change-Id: I7bd846ac546fa53a948e99cf2d054726c6d71692
Reviewed-on: https://dart-review.googlesource.com/61824
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2018-06-29 16:28:18 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-18 18:48:03 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs. 
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 09:41:04 +00:00
Terry Lucas 476b1e02a9 Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test. 
Also, updated status files to correctly fix failures in FF, IE and removed other spurious status entries.

R=alanknight@google.com,vsm@google.com

Change-Id: Ic965103d892ff4d5d119712e3187e829f57cd022
Reviewed-on: https://dart-review.googlesource.com/31800
Reviewed-by: Terry Lucas <terry@google.com>
 2017-12-29 23:51:02 +00:00
Terry Lucas 0af98266ab Revert "Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test." 
This reverts commit 0c8294e4a0.

Bug:
Change-Id: Idb35c64fd5365f2669e8aff45765fed74e0f0766
Reviewed-on: https://dart-review.googlesource.com/31440
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-12-23 01:59:38 +00:00
Terry Lucas 0c8294e4a0 Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test. 
R=alanknight@google.com,vsm@google.com

Change-Id: I80e82f5aaa3c9748740031d8da139f79e2c0ab70
Reviewed-on: https://dart-review.googlesource.com/31080
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
 2017-12-22 22:57:34 +00:00
Vijay Menon b8cd835bb9 Workaround CFE instantiate-to-bounds bug 
This avoids #31566 for now.

Change-Id: I5f2ea0cf0ad15a534c1c62182bdca36fc3b0b103
Reviewed-on: https://dart-review.googlesource.com/26760
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2017-12-06 21:34:11 +00:00
Florian Loitsch 38bf70d7ac Use generic functions in zones. 
Migrated from https://chromiumcodereview.appspot.com/2893893002/

Change-Id: I0bd6dc1438eb1e6762e7760a08b5a760b07d4b10
Reviewed-on: https://dart-review.googlesource.com/4942
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:46:06 +00:00
Terry Lucas 621b12f324 Removed DARTIUM codegen for IDLS (sdk/lib/dartium) 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2978213002 .
 2017-07-18 11:02:02 -07:00
Florian Loitsch 978213d427 Revert "Make Zone API strong mode clean." 
This reverts commit 0b35711d48.

BUG=

Review-Url: https://codereview.chromium.org/2963743002 .
 2017-06-28 13:31:32 +02:00
Florian Loitsch 0b35711d48 Make Zone API strong mode clean. 
Review-Url: https://codereview.chromium.org/2959163002 .
 2017-06-28 13:16:39 +02:00
William Hesse bde8d3efc6 Revert "Don't call _ensureRequestAnimationFrame in Dartium." 
This reverts commit bf8eeef6a0.

Revert "Fix animationFrameRequest for dartium."

This reverts commit 3daaf3849f.

BUG=https://github.com/dart-lang/sdk/issues/26906

Review URL: https://codereview.chromium.org/2159183003 .
 2016-07-19 13:56:36 +02:00
Alan Knight 30b489578d Revert "Reapply zone tasks." 
This reverts commit 6a7c037aa6.

BUG=

Review URL: https://codereview.chromium.org/2162643002 .
 2016-07-18 13:12:36 -07:00
Florian Loitsch bf8eeef6a0 Don't call _ensureRequestAnimationFrame in Dartium. 
Review URL: https://codereview.chromium.org/2117103004 .
 2016-07-05 19:50:49 +02:00
Florian Loitsch 3daaf3849f Fix animationFrameRequest for dartium. 
Review URL: https://codereview.chromium.org/2124863002 .
 2016-07-05 19:22:27 +02:00
Florian Loitsch 6a7c037aa6 Reapply zone tasks. 
This reverts commit 34d3c37233.

Committed: https://github.com/dart-lang/sdk/commit/f746f8f77e93fd93cb4ff3b4ed644c96a432947a

R=lrn@google.com

Review URL: https://codereview.chromium.org/2119243002 .

Reverted: https://github.com/dart-lang/sdk/commit/dae392291595fa394d601d2d0baa77b66d85533f
 2016-07-05 17:33:09 +02:00
Florian Loitsch dae3922915 Revert "Reapply zone tasks." 
This reverts commit f746f8f77e.

Review URL: https://codereview.chromium.org/2123593002 .
 2016-07-04 21:58:15 +02:00
Florian Loitsch f746f8f77e Reapply zone tasks. 
This reverts commit 34d3c37233.

Review URL: https://codereview.chromium.org/2119243002 .
 2016-07-04 19:55:58 +02:00
Florian Loitsch 34d3c37233 Revert zone tasks. 
Revert "Add tasks to zones."

This reverts commit 85cccde717.

Revert "Make Dom events run through zone tasks."

This reverts commit 6d1f6b2af6.

Revert "Add zone task support for request-anim."

This reverts commit 726b9f8dc7.

Revert "Add zone task support to http-requests."

This reverts commit b40cfcb57f.

Revert "Update status file for jsshell."

This reverts commit 5e05ee9b5f.

Review URL: https://codereview.chromium.org/2120063002 .
 2016-07-01 22:36:52 -07:00
Florian Loitsch 726b9f8dc7 Add zone task support for request-anim. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/2039963003 .
 2016-07-01 19:43:36 -07:00
Florian Loitsch 6d1f6b2af6 Make Dom events run through zone tasks. 
R=jacobr@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2022263002 .
 2016-07-01 19:43:06 -07:00
Jacob Richman f26e522f84 Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1987073002 .
 2016-05-18 12:49:09 -07:00
Jacob Richman 864b64fd5e Strong html 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1894713002 .
 2016-04-19 15:08:45 -07:00
Jacob Richman c65854d2e4 Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X. 
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
 2016-03-29 18:32:52 -07:00
Alan Knight ce744f6222 Some dart2js fixes with new IDL. RequestCallback name and web_sql import 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1729813002 .
 2016-02-23 16:27:59 -08:00
Alan Knight 7f80dbbbe1 Revert "Mark supportsPointConversions deprecated and always true rather than testing DOMPoint" 
This reverts commit 2dfdfe554e.

BUG=

Review URL: https://codereview.chromium.org/1583673002 .
 2016-01-12 16:24:12 -08:00
Alan Knight 2dfdfe554e Mark supportsPointConversions deprecated and always true rather than testing DOMPoint 
BUG=

Review URL: https://codereview.chromium.org/1580203002 .
 2016-01-12 13:52:38 -08:00
Alan Knight ced1e5d1e7 Allow Window.open to return null in dart2js 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1540333002 .
 2015-12-21 13:32:29 -08:00
Sam Rawlins 931ceef9b2 Fixing dart:html links _not_ found in docs.json 
BUG= https://github.com/dart-lang/sdk/issues/23601
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1448963002 .
 2015-11-16 10:18:23 -08:00
Terry L. Lucas 7b322c246c Dartium JS Enabled take 2 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1348173002 .
 2015-09-16 07:13:53 -07:00
Terry L. Lucas 09c804aa78 Revert "Dartium JS Interop enabled." 
This reverts commit 403bd1698d.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1345083002 .
 2015-09-15 19:44:26 -07:00
Terry L. Lucas 403bd1698d Dartium JS Interop enabled. 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1349493003 .
 2015-09-15 17:36:47 -07:00
Terry L. Lucas 9b0d2582fc Revert "Dartium w/ JsInterop enabled" 
This reverts commit 346af54711.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1330163010 .
 2015-09-09 17:33:24 -07:00
Terry L. Lucas 346af54711 Dartium w/ JsInterop enabled 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1321613005 .
 2015-09-09 17:01:40 -07:00
Terry L. Lucas 012c998f64 Revert "Patched in Dartium JsInterop" 
This reverts commit 4bb2e617db.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1327083002 .
 2015-09-08 13:35:03 -07:00
Terry L. Lucas 4bb2e617db Patched in Dartium JsInterop 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1310363006 .
 2015-09-08 12:46:41 -07:00
Terry L. Lucas 4947e570d4 Changed to use JSInterop 
Review URL: https://codereview.chromium.org//1173403004 .
 2015-07-13 12:38:16 -07:00
terry@google.com 68c6b252e4 Fixed tests for DOMPoint support for dart2js. 
TBR=asiva@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//968613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44115 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-01 18:01:53 +00:00