Commit Graph

48 Commits

Author SHA1 Message Date
Srujan Gaddam 63a57a76ce [dart:html] Revert "[dart:html] Revert commits using MDN compatibility info"
This reverts commit f8ff12008e.

This CL is a revert of the initial revert and should be landed once
Flutter changes have been merged to handle the changes here.

Change-Id: I300a5efd776bf2a596743971f4e15ad62da77f5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153368
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-07-14 23:18:43 +00:00
Srujan Gaddam f8ff12008e [dart:html] Revert commits using MDN compatibility info
This reverts commits aff77e7e..e24f205d.

Due to a breakage in a Flutter roll, this CL stack needs to be
reverted. It should be reintroduced with changes to Flutter code to
compile with the changes in dart:html.

Breakage: https://github.com/flutter/engine/runs/828631927

Change-Id: I9c93c4eab823337d09d2e347015ad9ec402f2038
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152910
Auto-Submit: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
2020-07-02 01:33:18 +00:00
Srujan Gaddam 7349385185 [dart:html] Changes to template/src to handle compat data
Mostly null-assertions to make code compatible with compat
data changes.

Change-Id: I8f7c6c2421d6427851a44588978910deae8440bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152047
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-07-01 22:06:34 +00:00
Srujan Gaddam 3776313e65 Change dart:html templates to generate null-safe code
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.

Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-02-06 23:18:24 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused.
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-06-18 18:48:03 +00:00
Terry Lucas 621b12f324 Removed DARTIUM codegen for IDLS (sdk/lib/dartium)
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2978213002 .
2017-07-18 11:02:02 -07:00
Jacob Richman c65854d2e4 Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X.
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
2016-03-29 18:32:52 -07:00
Terry L. Lucas 7b322c246c Dartium JS Enabled take 2
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1348173002 .
2015-09-16 07:13:53 -07:00
Terry L. Lucas 09c804aa78 Revert "Dartium JS Interop enabled."
This reverts commit 403bd1698d.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1345083002 .
2015-09-15 19:44:26 -07:00
Terry L. Lucas 403bd1698d Dartium JS Interop enabled.
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1349493003 .
2015-09-15 17:36:47 -07:00
Terry L. Lucas 9b0d2582fc Revert "Dartium w/ JsInterop enabled"
This reverts commit 346af54711.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1330163010 .
2015-09-09 17:33:24 -07:00
Terry L. Lucas 346af54711 Dartium w/ JsInterop enabled
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1321613005 .
2015-09-09 17:01:40 -07:00
Terry L. Lucas 012c998f64 Revert "Patched in Dartium JsInterop"
This reverts commit 4bb2e617db.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1327083002 .
2015-09-08 13:35:03 -07:00
Terry L. Lucas 4bb2e617db Patched in Dartium JsInterop
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1310363006 .
2015-09-08 12:46:41 -07:00
alanknight@google.com f777d314b7 Relax the deltaX/Y/Z types in WheelEvent constructor
BUG=

Review URL: https://codereview.chromium.org//1133303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45741 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 18:04:58 +00:00
alanknight@google.com f0136ff1eb Clean up WheelEvent
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1126463005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45740 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 16:34:01 +00:00
leafp@google.com 78e328a2f2 More dart:html and dart:blink tweaks
Methods with no arguments mangled properly (python None and 0 are both false...).

Abstract classes generated from pure interfaces have no method bodies.

Add missing pure interfaces.

Emit dart:blink methods in sorted order.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//671023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41288 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 17:47:14 +00:00
vsm@google.com 94095d64a2 Merge 38 changes to bleeding edge
TBR=terry@google.com,leafp@google.com
BUG=

Review URL: https://codereview.chromium.org//605083004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40774 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-29 15:56:25 +00:00
vsm@google.com 1c4bb5f363 Revert "Chrome 38 script changes from integration branch"
This reverts commit r40567.

TBR=leafp@google.com

Review URL: https://codereview.chromium.org//589253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40570 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 21:11:34 +00:00
vsm@google.com 9e25106514 Chrome 38 script changes from integration branch
TBR=leafp@google.com

Review URL: https://codereview.chromium.org//593853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40567 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 20:45:57 +00:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes"
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes"
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
blois@google.com 128a95f0a4 Fixing wheel event on Dart2js
Proper fix of doing the new constructor were thwarted by inconsistencies between latest Chrome and stable branch.

TBR
BUG=

Review URL: https://codereview.chromium.org//23837003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26960 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 23:56:10 +00:00
jacobr@google.com c9378836aa Remove obsolete manually defined _deltaX and _deltaY members.
BUG=

Review URL: https://codereview.chromium.org//23532023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26949 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:37:09 +00:00
jacobr@google.com 013e3bb062 Dart binding changes to along with Blink merge 155942-156717
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23829002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26948 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:24:02 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors.
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors.
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
blois@google.com 9a9db6b3eb Fixing broken tests because of mismatch of suppressed warnings.
Removing additional warnings and fixing the core issues.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16050007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23433 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 18:26:32 +00:00
blois@google.com 4284aa2264 Getting html_dart2js and html_dartium a bit more in sync.
I used the analyzer and made a quick API diff app to compare the two libraries, most of these are just minor nits, but good to get them in sync.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//14630016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22963 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-21 21:52:07 +00:00
blois@google.com 8d97ac7099 Resubmit of:
Flipping the direction of WheelEvent.deltaX/Y to follow standards

We're trying to follow the W3C spec for WheelEvent, but the standard has the direction in the opposite direction from what we have it now.

BUG=6215

BUG=

Review URL: https://codereview.chromium.org//13571003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20946 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 00:44:02 +00:00
blois@google.com 7a46dae8b9 Revert "Flipping the direction of WheelEvent.deltaX/Y to follow standards"
This reverts commit ottp://code.google.com/p/dart/source/detail?r=20879.

Broke Dartium & FF, will follow up with fix shortly.

BUG=

Review URL: https://codereview.chromium.org//13567002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20880 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-03 18:12:09 +00:00
blois@google.com 2d63fad211 Flipping the direction of WheelEvent.deltaX/Y to follow standards
We're trying to follow the W3C spec for WheelEvent, but the standard has the direction in the opposite direction from what we have it now.

BUG=6215

Review URL: https://codereview.chromium.org//13465021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20879 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-03 17:52:15 +00:00
blois@google.com 3dc9e79521 Consolidating platform code into dart:html_common
Basically a number of our platform checks are only accessible from dart:html and not other libs. Moved Device class over to html_common and added more platform logic which was distributed elsewhere.

Also fixing up Device to cache the platform checks.

BUG=

Review URL: https://codereview.chromium.org//12541020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19833 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 00:49:27 +00:00
blois@google.com 0f8df99a73 Fixing WheelEvent.deltaMode polyfill after IDL update.
BUG=8713

Review URL: https://codereview.chromium.org//12335036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18904 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 18:32:19 +00:00
ager@google.com 8594f56bbf Update WebKit idl files after chrome roll
R=antonm@google.com,blois@google.com
BUG=

Review URL: https://codereview.chromium.org//12316066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18889 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 13:15:56 +00:00
ager@google.com 51527e2115 WheelEvent template changes for chrome rool.
R=antonm@google.com
BUG=

Review URL: https://codereview.chromium.org//12321076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18881 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 11:52:14 +00:00
blois@google.com de9fbf0e90 Renaming dart:html library from 'html' to 'dart.html'
This should be invisible to end users, but basically brings dart:html in-line with the core libraries.

BUG=

Review URL: https://codereview.chromium.org//12061008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17929 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 17:25:55 +00:00
blois@google.com edf1d5149f - Changing event constructors to use named parameters.
- Making more parameters optional.
- Converting remaining init*Event calls to constructors.

BUG=

Review URL: https://codereview.chromium.org//12025027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17488 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 19:43:21 +00:00
blois@google.com 049efc4fe8 Fixing cleanup of dart:html annotation generation.
This is an update of https://codereview.chromium.org/11968047/

BUG=

Review URL: https://codereview.chromium.org//12024002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 22:11:21 +00:00
blois@google.com bda6df30df Revert "Fixing formatting of dart:html's dart2js annotations."
This reverts commit 11508.

BUG=

Review URL: https://codereview.chromium.org//11962049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:16:31 +00:00
blois@google.com b6f3ecaa2c Fixing formatting of dart:html's dart2js annotations.
Also unifying formatting of attributes.

BUG=7808

Review URL: https://codereview.chromium.org//11968047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:12:36 +00:00
blois@google.com a4fd4b1888 Fixing dartc error about not using ~/ operator and FF test error.
TBR=siggi
BUG=

Review URL: https://codereview.chromium.org//11956030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17173 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 23:31:18 +00:00
blois@google.com b97af1c4f3 Adding support for the MouseWheel event in Streams.
In order to test this I also needed to add a constructor for the MouseWheel event, which complicated things.

In general, wheel events are incredibly fragmented across browsers.

BUG=7919

Review URL: https://codereview.chromium.org//11931009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17172 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 23:06:35 +00:00
amouravski@google.com 038af964dc Changed @domName annotation in comment to full fledge @DomName annotation.
Review URL: https://codereview.chromium.org//11887006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 19:01:07 +00:00
efortuna@google.com 01fb2bbc86 Moved most of html lib generating scripts into tools.
BUG=

Review URL: https://codereview.chromium.org//11691009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 22:26:48 +00:00