Srujan Gaddam
3776313e65
Change dart:html templates to generate null-safe code
...
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.
Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-06 23:18:24 +00:00
Alan Knight
a718c8dac9
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Committed: https://github.com/dart-lang/sdk/commit/65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 15:13:31 -07:00
Alan Knight
3fd7e32b65
Revert "Fix a few strong mode errors in dart:html"
...
This reverts commit 65fe0a5383 .
BUG=
Review URL: https://codereview.chromium.org/1879253004 .
2016-04-13 14:56:42 -07:00
Alan Knight
65fe0a5383
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 14:41:10 -07:00
Terry Lucas
5d77c0e83c
More UIEvent attribute movement in 45 roll.
...
TBR=alanknight@google.com ,sigmund@google.com
Review URL: https://codereview.chromium.org/1771113002 .
2016-03-07 16:12:28 -08:00
sra@google.com
7516e95066
Redo "Use @Native annotation on dart2js DOM native classes"
...
BUG=
Review URL: https://codereview.chromium.org//410863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
sra@google.com
9a4f73207e
Revert "Use @Native annotation on dart2js DOM native classes"
...
TBR=blois@google.com
BUG=
Review URL: https://codereview.chromium.org//410823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
sra@google.com
11a19d95be
Use @Native annotation on dart2js DOM native classes
...
This is one of many steps to removing non-standard syntax from the dart2js libraries.
R=blois@google.com
Review URL: https://codereview.chromium.org//409053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
blois@google.com
63f250a430
Removing a number of deprecated members
...
Mostly left over from previous refactoring
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//33423004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29023 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:53:36 +00:00
efortuna@google.com
9c5078b378
"Reverting 28321"
...
BUG=
Review URL: https://codereview.chromium.org//26334002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28323 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 20:11:16 +00:00
efortuna@google.com
c5fe58c61c
Fully polyfill KeyEvent so that you can programmatically create your own "keyboard" events.
...
Added some test cases as well.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//23455033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28321 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 19:40:17 +00:00
efortuna@google.com
90873051ad
Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
...
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23055008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
blois@google.com
9dd81d94a7
Fixing up DOM constructors.
...
This is a continuation of https://codereview.chromium.org/17063007/
Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//18054021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
blois@google.com
6b44f65407
Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
...
This reverts commit http://code.google.com/p/dart/source/detail?r=24241 .
Compiler error, not sure of best fix.
BUG=
Review URL: https://codereview.chromium.org//17508002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
blois@google.com
c3547d4e9b
Making all DOM types abstract and removing superfluous Dartium constructors.
...
Adding factory constructors to all classes to suppress missing generative constructor warnings.
Adding a throw to Dartium's base DOM class to prevent construction of native objects.
This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//17063007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
blois@google.com
2fcae75253
Exposing Point & Rect types
...
This exposes ClientRects as Rects and exposes UIEvent.clientX/Y properties as Points.
This also deprecates the UIEvent.clientX/Y properties.
BUG=
Review URL: https://codereview.chromium.org//12493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19659 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 22:17:04 +00:00
blois@google.com
de9fbf0e90
Renaming dart:html library from 'html' to 'dart.html'
...
This should be invisible to end users, but basically brings dart:html in-line with the core libraries.
BUG=
Review URL: https://codereview.chromium.org//12061008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17929 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 17:25:55 +00:00
blois@google.com
edf1d5149f
- Changing event constructors to use named parameters.
...
- Making more parameters optional.
- Converting remaining init*Event calls to constructors.
BUG=
Review URL: https://codereview.chromium.org//12025027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17488 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 19:43:21 +00:00
blois@google.com
049efc4fe8
Fixing cleanup of dart:html annotation generation.
...
This is an update of https://codereview.chromium.org/11968047/
BUG=
Review URL: https://codereview.chromium.org//12024002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 22:11:21 +00:00
blois@google.com
bda6df30df
Revert "Fixing formatting of dart:html's dart2js annotations."
...
This reverts commit 11508.
BUG=
Review URL: https://codereview.chromium.org//11962049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:16:31 +00:00
blois@google.com
b6f3ecaa2c
Fixing formatting of dart:html's dart2js annotations.
...
Also unifying formatting of attributes.
BUG=7808
Review URL: https://codereview.chromium.org//11968047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:12:36 +00:00
amouravski@google.com
038af964dc
Changed @domName annotation in comment to full fledge @DomName annotation.
...
Review URL: https://codereview.chromium.org//11887006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 19:01:07 +00:00
efortuna@google.com
01fb2bbc86
Moved most of html lib generating scripts into tools.
...
BUG=
Review URL: https://codereview.chromium.org//11691009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 22:26:48 +00:00