Srujan Gaddam
3776313e65
Change dart:html templates to generate null-safe code
...
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.
Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-06 23:18:24 +00:00
Terry Lucas
8fedfc7f8c
Removed DomName, DosEditable, and experimental annoations they are unused.
...
R=kevmoo@google.com ,vsm@google.com
Fixes #32304
Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-06-18 18:48:03 +00:00
Terry Lucas
bc75856e54
Update getClientRects, removed xtab, removed bogus entry in dom.json,
...
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.
Fixed all tests using query and queryAll.
Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675
R=kevmoo@google.com
Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-03-27 20:45:33 +00:00
Terry Lucas
581c512345
Fixed DOMRectList not having a prototype field.
...
TBR=vsm@google.com
Change-Id: I6cbc38bbb2123b914d5b5511774425c403e614ed
Reviewed-on: https://dart-review.googlesource.com/47183
Reviewed-by: Terry Lucas <terry@google.com >
Commit-Queue: Terry Lucas <terry@google.com >
2018-03-20 01:08:47 +00:00
Terry Lucas
621b12f324
Removed DARTIUM codegen for IDLS (sdk/lib/dartium)
...
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2978213002 .
2017-07-18 11:02:02 -07:00
Alan Knight
b1552f9ef9
Revert "Re-submit Range.toString() and test status changes"
...
This reverts commit 95d409e3ed .
BUG=
Review URL: https://codereview.chromium.org/2678543002 .
2017-02-03 13:05:18 -08:00
Alan Knight
95d409e3ed
Re-submit Range.toString() and test status changes
...
https://codereview.chromium.org/2632363002
https://github.com/dart-lang/sdk/pull/28376
R=whesse@google.com
Review URL: https://codereview.chromium.org/2672843003 .
2017-02-03 09:55:59 -08:00
Asger Feldthaus
8701dbf147
Revert "added Range.toString() to dart:html ( #28376 )" +1 more
...
Revert "dart2js status updates after Range.toString was added to dart:html"
This reverts commit 226a7e7177 .
This reverts commit c279a951f4 .
The test
co19/LayoutTests/fast/filesystem/file-writer-abort-continue_t01
broke after the inital commit. The second commit being reverted
is one that updated the status files for tests that now pass.
BUG=
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2635033004 .
2017-01-17 17:21:46 +01:00
Lex Berezhny
226a7e7177
added Range.toString() to dart:html ( #28376 )
...
* added Range.toString() to dart:html
* added Range.toString to impl_range.darttemplate as well
2017-01-13 14:13:07 -08:00
sra@google.com
7516e95066
Redo "Use @Native annotation on dart2js DOM native classes"
...
BUG=
Review URL: https://codereview.chromium.org//410863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
sra@google.com
9a4f73207e
Revert "Use @Native annotation on dart2js DOM native classes"
...
TBR=blois@google.com
BUG=
Review URL: https://codereview.chromium.org//410823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
sra@google.com
11a19d95be
Use @Native annotation on dart2js DOM native classes
...
This is one of many steps to removing non-standard syntax from the dart2js libraries.
R=blois@google.com
Review URL: https://codereview.chromium.org//409053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
efortuna@google.com
47dcd084f3
Removing more dom_ methods (dom_getAttribute and dom_setAttribute.).
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23189014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26928 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:18:40 +00:00
efortuna@google.com
90873051ad
Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
...
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23055008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
blois@google.com
9dd81d94a7
Fixing up DOM constructors.
...
This is a continuation of https://codereview.chromium.org/17063007/
Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//18054021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
blois@google.com
6b44f65407
Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
...
This reverts commit http://code.google.com/p/dart/source/detail?r=24241 .
Compiler error, not sure of best fix.
BUG=
Review URL: https://codereview.chromium.org//17508002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
blois@google.com
c3547d4e9b
Making all DOM types abstract and removing superfluous Dartium constructors.
...
Adding factory constructors to all classes to suppress missing generative constructor warnings.
Adding a throw to Dartium's base DOM class to prevent construction of native objects.
This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//17063007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
blois@google.com
25178b1217
Adding Range constructor for document.caretRangeFromPoint.
...
BUG=9227
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16975002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24004 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 18:41:48 +00:00
blois@google.com
5bbd582932
Fixing some of the tests disabled from the chrome IDL roll.
...
Basically some native constructors were added which are not yet cross-platform, so skipping them for now.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//16335012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23564 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 20:10:48 +00:00
vsm@google.com
b85b97cbe6
Fixes for Blink roll to r151189
...
TBR=antonm
Review URL: https://codereview.chromium.org//16308002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23511 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 18:34:36 +00:00
blois@google.com
93dedc90ab
Adding tests for experimental Safe DOM creation technique.
...
This is just the underlying DOM creation code which should be able to parse HTML with no script execution. I'd like to get this in so we can make sure it works across all supported platforms. This does not do any sanitization or validation.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//14839006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22473 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-07 18:32:47 +00:00
blois@google.com
049efc4fe8
Fixing cleanup of dart:html annotation generation.
...
This is an update of https://codereview.chromium.org/11968047/
BUG=
Review URL: https://codereview.chromium.org//12024002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 22:11:21 +00:00
blois@google.com
bda6df30df
Revert "Fixing formatting of dart:html's dart2js annotations."
...
This reverts commit 11508.
BUG=
Review URL: https://codereview.chromium.org//11962049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:16:31 +00:00
blois@google.com
b6f3ecaa2c
Fixing formatting of dart:html's dart2js annotations.
...
Also unifying formatting of attributes.
BUG=7808
Review URL: https://codereview.chromium.org//11968047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:12:36 +00:00
amouravski@google.com
038af964dc
Changed @domName annotation in comment to full fledge @DomName annotation.
...
Review URL: https://codereview.chromium.org//11887006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 19:01:07 +00:00
efortuna@google.com
01fb2bbc86
Moved most of html lib generating scripts into tools.
...
BUG=
Review URL: https://codereview.chromium.org//11691009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 22:26:48 +00:00