Commit Graph

23 Commits

Author SHA1 Message Date
Srujan Gaddam b96cd6d755 [dart:html] Add nullability to item type for lists
Needed to type nullability for List parameters correctly.

Change-Id: I55732a34f9e221324a15312985cb83b49a6811a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142211
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2020-04-06 21:37:44 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused.
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-06-18 18:48:03 +00:00
Terry Lucas 3e6b8717fe Fixed GamePadList not working in DDC and hide MessagePort.start operation.
Fixes https://github.com/dart-lang/sdk/issues/31029

R=vsm@google.com

Change-Id: I757538eec1ebcf42204e7de0807a48a4757f3faf
Reviewed-on: https://dart-review.googlesource.com/49740
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-04-05 15:13:17 +00:00
Terry Lucas 621b12f324 Removed DARTIUM codegen for IDLS (sdk/lib/dartium)
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2978213002 .
2017-07-18 11:02:02 -07:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes"
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes"
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
efortuna@google.com f81052f2c8 Reapply expanding overloaded functions into separate functions.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//18577002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24709 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 22:32:44 +00:00
efortuna@google.com 3629744086 "Reverting 24655"
BUG=

Review URL: https://codereview.chromium.org//18277003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24656 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 21:09:19 +00:00
efortuna@google.com fc0df10d8b Expand overloaded methods and optional parameters in the html library.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//16494002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24655 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 20:49:07 +00:00
amouravski@google.com c0a39d0412 Make html metadata follow the spec.
Per https://code.google.com/p/dart/issues/detail?id=11568

R=scheglov@google.com

Review URL: https://codereview.chromium.org//18182010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24638 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 18:34:30 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors.
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors.
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
vsm@google.com 8379279dc0 Retry "Changes for webkit roll 148757-149482"
TBR=antonm

Review URL: https://codereview.chromium.org//14948011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22801 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 16:39:09 +00:00
vsm@google.com 45fc399cf7 Revert "Changes for webkit roll 148757-149482"
TBR=antonm

Review URL: https://codereview.chromium.org//14636013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22769 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 06:06:49 +00:00
vsm@google.com da46c65d3b Changes for webkit roll 148757-149482
Review URL: https://codereview.chromium.org//14954007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22765 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 05:37:13 +00:00
efortuna@google.com aedcf9eb32 Enable getUserMedia to take constraints for its parameters.
BUG=

Review URL: https://codereview.chromium.org//12695014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20245 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 21:07:24 +00:00
amouravski@google.com 33e91c55be Changed how Experimental annotation works. No longer is a constructor.
Review URL: https://codereview.chromium.org//12041090

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17619 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 23:50:59 +00:00
blois@google.com 049efc4fe8 Fixing cleanup of dart:html annotation generation.
This is an update of https://codereview.chromium.org/11968047/

BUG=

Review URL: https://codereview.chromium.org//12024002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 22:11:21 +00:00
blois@google.com ccd052a508 Fixup of reverted CL- Fixing up Navigator.getUserMedia.
- Fixes Navigator.getUserMedia to be cross-platform.
- Adds supported checks.
- Dartifies the API.

First patch is the original, second is the fix.

Issue was that I used = for separating named parameters, rather than : (but it works on dart2js!). I think this distinction is lame, and opened a bug that these should use the same separator.

Review URL: https://codereview.chromium.org//12022027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17311 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 20:54:05 +00:00
blois@google.com 9cca892004 Revert "Fixing up Navigator.getUserMedia."
This reverts commit 17304. It broke dartium.

TBR
BUG=

Review URL: https://codereview.chromium.org//11871018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17306 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 19:17:48 +00:00
blois@google.com b9b0ffd533 Fixing up Navigator.getUserMedia.
- Fixes Navigator.getUserMedia to be cross-platform.
- Adds supported checks.
- Dartifies the API.

BUG=

Review URL: https://codereview.chromium.org//11818066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17304 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 18:55:17 +00:00