Commit Graph

40 Commits

Author SHA1 Message Date
Srujan Gaddam 3776313e65 Change dart:html templates to generate null-safe code
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.

Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-02-06 23:18:24 +00:00
Srujan Gaddam 7db61c6b01 Changing the dart:html generator scripts to generate null-safe/nnbd code
Change-Id: I4a8b097b126864366076b1e73cf3e0296600380e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128376
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2020-01-29 00:20:42 +00:00
Terry Lucas 621b12f324 Removed DARTIUM codegen for IDLS (sdk/lib/dartium)
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2978213002 .
2017-07-18 11:02:02 -07:00
Jacob Richman c65854d2e4 Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X.
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
2016-03-29 18:32:52 -07:00
Alan Knight 110b579b8a wrap_jso should wrap JsArray as well, not always call wrap on its contents
BUG=

Committed: https://github.com/dart-lang/sdk/commit/f0e52e4e9175c10739645b6a1f72d551f6b9fd06

Review URL: https://codereview.chromium.org/1383903002 .
2015-10-02 12:48:06 -07:00
Alan Knight da7d6379cc Revert "wrap_jso should wrap JsArray as well, not always call wrap on its contents"
This reverts commit f0e52e4e91.

BUG=

Review URL: https://codereview.chromium.org/1378183003 .
2015-10-01 17:51:51 -07:00
Alan Knight f0e52e4e91 wrap_jso should wrap JsArray as well, not always call wrap on its contents
BUG=

Review URL: https://codereview.chromium.org/1383903002 .
2015-10-01 16:22:17 -07:00
Terry L. Lucas 7b322c246c Dartium JS Enabled take 2
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1348173002 .
2015-09-16 07:13:53 -07:00
Terry L. Lucas 09c804aa78 Revert "Dartium JS Interop enabled."
This reverts commit 403bd1698d.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1345083002 .
2015-09-15 19:44:26 -07:00
Terry L. Lucas 403bd1698d Dartium JS Interop enabled.
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1349493003 .
2015-09-15 17:36:47 -07:00
Terry L. Lucas 9b0d2582fc Revert "Dartium w/ JsInterop enabled"
This reverts commit 346af54711.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1330163010 .
2015-09-09 17:33:24 -07:00
Terry L. Lucas 346af54711 Dartium w/ JsInterop enabled
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1321613005 .
2015-09-09 17:01:40 -07:00
Terry L. Lucas 012c998f64 Revert "Patched in Dartium JsInterop"
This reverts commit 4bb2e617db.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1327083002 .
2015-09-08 13:35:03 -07:00
Terry L. Lucas 4bb2e617db Patched in Dartium JsInterop
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1310363006 .
2015-09-08 12:46:41 -07:00
Terry L. Lucas cec5812335 Fixed Dictionary and Event hookup w/o --gen-interop
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//1233083004 .
2015-07-14 14:18:48 -07:00
Terry L. Lucas 4947e570d4 Changed to use JSInterop
Review URL: https://codereview.chromium.org//1173403004 .
2015-07-13 12:38:16 -07:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes"
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes"
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
blois@google.com f41e99e1ed Updating MutationObserver.observe documentation.
TBR
BUG=14375

Review URL: https://codereview.chromium.org//40703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29181 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 17:01:08 +00:00
blois@google.com 4c06ef7fb8 Dartium build issue w/ mutation observers
Last fix for mutation observers had a typo in Dartium (wish I could build both from the same enlistment!).

TBR
BUG=

Review URL: https://codereview.chromium.org//26539014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28683 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 21:06:54 +00:00
blois@google.com ea5d14dd91 MutationObserver changes for zones (again)
Missed that the _wrap only takes one arg, added the two arg version. Unfortunately the tests for this are around upgrading and is really flaky (often passing on my machine).

TBR
BUG=

Review URL: https://codereview.chromium.org//27403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28680 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 20:39:14 +00:00
blois@google.com 4e01232e26 Fixing MutationObserver constructor from zones change
TBR
BUG=

Review URL: https://codereview.chromium.org//26442003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28679 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 19:59:45 +00:00
blois@google.com 9baacafa7a Making all callbacks use zones (take 2)
Changes: fixed parameter ordering for RTCPeerConnection.getStats and fixed error for StorageInfo.

Revert "Revert "Making all callbacks use zones""

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//27240004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28674 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 19:07:22 +00:00
blois@google.com e1d441b22f Revert "Making all callbacks use zones"
This reverts commit 28607, running into analyzer issues.

TBR
BUG=

Review URL: https://codereview.chromium.org//27232003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28609 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 20:23:11 +00:00
blois@google.com 84a3415e82 Making all callbacks use zones
This was primarily converting APIs to use Futures, all appear to be new ones since we did the last pass.

MutationObserver and Window.requestAnimationFrame had to be fixed manually.

BUG=
R=efortuna@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//27082002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28607 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 19:49:17 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors.
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors.
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
efortuna@google.com c4437b9274 Reapply the expanded names with the correct form of requestFileSystem on the
test.

BUG=

Review URL: https://codereview.chromium.org//12663017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20136 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-16 01:02:25 +00:00
efortuna@google.com 26c5c48fe2 Revert 20127
TBR

BUG=

Review URL: https://codereview.chromium.org//12474007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20133 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-16 00:14:27 +00:00
efortuna@google.com 3e1f5ce451 Expanded map options to named parameters.
BUG=

Review URL: https://codereview.chromium.org//12531013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20127 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:46:13 +00:00
blois@google.com de9fbf0e90 Renaming dart:html library from 'html' to 'dart.html'
This should be invisible to end users, but basically brings dart:html in-line with the core libraries.

BUG=

Review URL: https://codereview.chromium.org//12061008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17929 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 17:25:55 +00:00
antonm@google.com 5d50a592a3 Support overloaded constructors.
R=blois@google.com,efortuna@google.com,podivilov@chromium.org

Review URL: https://codereview.chromium.org//12052076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17754 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 12:18:28 +00:00
blois@google.com 049efc4fe8 Fixing cleanup of dart:html annotation generation.
This is an update of https://codereview.chromium.org/11968047/

BUG=

Review URL: https://codereview.chromium.org//12024002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 22:11:21 +00:00
blois@google.com bda6df30df Revert "Fixing formatting of dart:html's dart2js annotations."
This reverts commit 11508.

BUG=

Review URL: https://codereview.chromium.org//11962049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:16:31 +00:00
blois@google.com b6f3ecaa2c Fixing formatting of dart:html's dart2js annotations.
Also unifying formatting of attributes.

BUG=7808

Review URL: https://codereview.chromium.org//11968047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:12:36 +00:00
amouravski@google.com 038af964dc Changed @domName annotation in comment to full fledge @DomName annotation.
Review URL: https://codereview.chromium.org//11887006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 19:01:07 +00:00
antonm@google.com dae2d52af7 Nuke custom factory providers.
R=blois@google.com,podivilov@chromium.org,sra@google.com

Review URL: https://codereview.chromium.org//11719003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16917 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-10 12:11:59 +00:00
efortuna@google.com 01fb2bbc86 Moved most of html lib generating scripts into tools.
BUG=

Review URL: https://codereview.chromium.org//11691009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 22:26:48 +00:00