dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

25 Commits

Author SHA1 Message Date
Srujan Gaddam bc65eafd3b [dart:html] Fix nullability for vars with null checks 
There are several instances where there are non-nullable
variables with null checks associated with them that should
be converted back to nullable. Attribute functions in Element
are clarified as well.

Change-Id: I23cf020f02f3d4b512e041f0339daafb46fdd7f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140909
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-02 19:28:59 +00:00
Srujan Gaddam 3776313e65 Change dart:html templates to generate null-safe code 
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.

Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-02-06 23:18:24 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-18 18:48:03 +00:00
Stephen Adams 7686dce346 Replace _downcast and _cast with local downcasts (dart:html) 
Change-Id: I4282b20aac07da125805a2654da072742dbbdd0b
Reviewed-on: https://dart-review.googlesource.com/20300
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-11 00:09:38 +00:00
Jacob Richman 7fdce7a2f0 Use _downcast and _cast instead of "as" to reduce dart2js output size. 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1914583002 .
 2016-04-22 11:09:01 -07:00
Jacob Richman 25b88eabe5 Fix indexed_db strong mode warnings. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1903973002 .
 2016-04-21 10:03:53 -07:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes" 
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes" 
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes 
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 00:23:17 +00:00
floitsch@google.com 8882916b21 Update dom streams with new signatures. 
Review URL: https://codereview.chromium.org//27036002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28517 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-11 14:44:52 +00:00
jacobr@google.com f59872ee07 Missed one template from the previous CL to unbreak indexed_db. 
Remove invalid calls to the _count method. This is a short term fix to make the build green.  Blois will be submitting the correct fix.

BUG=

Review URL: https://codereview.chromium.org//23523008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26958 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-30 23:12:59 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL. 
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-23 18:25:40 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors. 
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors." 
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors. 
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 17:31:36 +00:00
lrn@google.com faa7227cec Make new StreamController be async by default. 
Change all instances, except some tests, to be sync still.
Rename Multiplex to Broadcast everywhere.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//16125005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23453 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-31 06:07:39 +00:00
floitsch@google.com 466d6670c1 Refactor Future constructors. 
BUG=

Review URL: https://codereview.chromium.org//14070010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21517 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-15 21:24:27 +00:00
floitsch@google.com 285849c801 Change hasSubscribers to hasListener. 
Review URL: https://codereview.chromium.org//14103010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21337 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-12 09:30:05 +00:00
blois@google.com 639cab021b Changing the IDL DartName= annotation to only operate on a per-member basis, allowing overloaded methods to be renamed independently. 
This also includes a change to rename one overload of CanvasRenderingContext2D.createImageData as a test case.

The remaining changes are to address differences between old semantics of DartName and new semantics, as well as some ordering differences of generated code.

BUG=

Review URL: https://codereview.chromium.org//12964003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20355 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-21 21:50:15 +00:00
lrn@google.com bead146749 Renamed StreamSink to EventSink. Renamed signalError to addError. 
Review URL: https://codereview.chromium.org//12610006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19683 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-08 11:31:19 +00:00
blois@google.com dad0804d7b Making Indexed DB's cursor stream not auto-advance if no subscribers 
BUG=8552

Review URL: https://codereview.chromium.org//12644004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19667 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-08 01:37:02 +00:00
blois@google.com bc4f90bd09 Dartifying remainder of Index DB APIs. 
BUG=

Review URL: https://codereview.chromium.org//12313015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18992 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-25 18:59:34 +00:00
blois@google.com cb8af97da5 Fixing IndexedDB Dartium Checked Mode tests 
A type check for the Stream<Cursor> was failing on Dartium. Basically the helper method is intended to work for both Cursor and CursorWithValue, but it was creating a StreamController<Cursor>. Just removed the type so it works acceptably with both.

BUG=

Review URL: https://codereview.chromium.org//12258022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18486 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-13 21:55:25 +00:00
blois@google.com 8eb3de4f72 Fixing Indexed DB's CursorWithValue.value 
CursorWithValue.value was not getting converted from a JS type to a Dart type.

BUG=8254

Review URL: https://codereview.chromium.org//12226134

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18476 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-13 20:50:12 +00:00
blois@google.com e780a771d3 Dartifying some IndexedDB APIs. 
BUG=

Review URL: https://codereview.chromium.org//12159005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18338 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-11 21:24:50 +00:00