c41b69ed77
[html] update templates for code accidentally changed in the generated code
...
These were updated in the dart:html output code in
https://dart-review.googlesource.com/c/sdk/+/163681
We may want to look into adding a presubmit that let us notify developers when a
change was made in one place but not the other (similar to how we used to check
for sdk and sdk_nnbd in the past).
Change-Id: I280315a5bb07971d0c0077498eb3c59944db0650
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164640
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2020-09-25 21:34:54 +00:00
3776313e65
Change dart:html templates to generate null-safe code
...
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.
Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-06 23:18:24 +00:00
8fedfc7f8c
Removed DomName, DosEditable, and experimental annoations they are unused.
...
R=kevmoo@google.com ,vsm@google.com
Fixes #32304
Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-06-18 18:48:03 +00:00
ef6273cba0
Dart Web Libraries re-generated based on Chrome 63 WebIDLs.
...
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.
Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#
Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
2018-03-18 09:41:04 +00:00
9f09ef0af3
- Fixed callback signatures with indexed_db open method to expose VersionChangeEvent and
...
Event type parameters instead of dynamic.
- Fixed missing interceptor in dart2js for MutationEvent (even though its deprecated
and should not be used). The MutationEvent is created when a node is deleted. Enabled
Dart MutationEvent class generation.
- Fixed/re-enabled all indexed_db tests to run and pass successfully.
Stephen please take a look - target in VersionChangeEvent is a final field, per your suggestion,
instead of a getter. The MutationEvent is returned in the browser and without the MutationEvent
Dart class the error:
Uncaught TypeError: t1.get$target is not a function
R=vsm@google.com ,gabrielchow@google.com ,sra@google.com
Change-Id: Ic36aea8c33b4263a32ff9d047ba3e6b979e03b10
Reviewed-on: https://dart-review.googlesource.com/41569
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
Commit-Queue: Terry Lucas <terry@google.com >
2018-02-23 14:29:45 +00:00
8f199377fa
Remove generic method comment syntax from dart:html.
...
This removes the last uses of the generic method comment syntax from
the SDK. There are no additional explicit casts or reified generics
(other than those implied by reifying generic methods) in this CL.
Bug:
Change-Id: Icae23cac60869243cb3ba441f86d70422f68178f
Reviewed-on: https://dart-review.googlesource.com/26081
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Jacob Richman <jacobr@google.com >
2017-12-06 21:26:04 +00:00
7686dce346
Replace _downcast and _cast with local downcasts (dart:html)
...
Change-Id: I4282b20aac07da125805a2654da072742dbbdd0b
Reviewed-on: https://dart-review.googlesource.com/20300
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-11-11 00:09:38 +00:00
621b12f324
Removed DARTIUM codegen for IDLS (sdk/lib/dartium)
...
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2978213002 .
2017-07-18 11:02:02 -07:00
7fdce7a2f0
Use _downcast and _cast instead of "as" to reduce dart2js output size.
...
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org/1914583002 .
2016-04-22 11:09:01 -07:00
25b88eabe5
Fix indexed_db strong mode warnings.
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1903973002 .
2016-04-21 10:03:53 -07:00
7516e95066
Redo "Use @Native annotation on dart2js DOM native classes"
...
BUG=
Review URL: https://codereview.chromium.org//410863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
9a4f73207e
Revert "Use @Native annotation on dart2js DOM native classes"
...
TBR=blois@google.com
BUG=
Review URL: https://codereview.chromium.org//410823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
11a19d95be
Use @Native annotation on dart2js DOM native classes
...
This is one of many steps to removing non-standard syntax from the dart2js libraries.
R=blois@google.com
Review URL: https://codereview.chromium.org//409053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
8882916b21
Update dom streams with new signatures.
...
Review URL: https://codereview.chromium.org//27036002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28517 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 14:44:52 +00:00
90873051ad
Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
...
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23055008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
c0a39d0412
Make html metadata follow the spec.
...
Per https://code.google.com/p/dart/issues/detail?id=11568
R=scheglov@google.com
Review URL: https://codereview.chromium.org//18182010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24638 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 18:34:30 +00:00
9dd81d94a7
Fixing up DOM constructors.
...
This is a continuation of https://codereview.chromium.org/17063007/
Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//18054021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
6b44f65407
Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
...
This reverts commit http://code.google.com/p/dart/source/detail?r=24241 .
Compiler error, not sure of best fix.
BUG=
Review URL: https://codereview.chromium.org//17508002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
c3547d4e9b
Making all DOM types abstract and removing superfluous Dartium constructors.
...
Adding factory constructors to all classes to suppress missing generative constructor warnings.
Adding a throw to Dartium's base DOM class to prevent construction of native objects.
This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//17063007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
0942acf5d2
Fixing IndexedDB's deleteDatabase to have the correct future result.
...
BUG=10648
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16022012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23305 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 19:38:44 +00:00
fc31fb12b4
More fixes.
...
Review URL: https://codereview.chromium.org//14992002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22423 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-06 16:26:29 +00:00
466d6670c1
Refactor Future constructors.
...
BUG=
Review URL: https://codereview.chromium.org//14070010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21517 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 21:24:27 +00:00
0d2c7ea397
Fixing Indexed DB supported check.
...
The test was incorrectly passing on platforms which do not support IndexedDB.
BUG=
Review URL: https://codereview.chromium.org//12320101
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18998 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 20:59:12 +00:00
bc4f90bd09
Dartifying remainder of Index DB APIs.
...
BUG=
Review URL: https://codereview.chromium.org//12313015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18992 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 18:59:34 +00:00
e780a771d3
Dartifying some IndexedDB APIs.
...
BUG=
Review URL: https://codereview.chromium.org//12159005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18338 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 21:24:50 +00:00
049efc4fe8
Fixing cleanup of dart:html annotation generation.
...
This is an update of https://codereview.chromium.org/11968047/
BUG=
Review URL: https://codereview.chromium.org//12024002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 22:11:21 +00:00
bda6df30df
Revert "Fixing formatting of dart:html's dart2js annotations."
...
This reverts commit 11508.
BUG=
Review URL: https://codereview.chromium.org//11962049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:16:31 +00:00
b6f3ecaa2c
Fixing formatting of dart:html's dart2js annotations.
...
Also unifying formatting of attributes.
BUG=7808
Review URL: https://codereview.chromium.org//11968047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:12:36 +00:00
038af964dc
Changed @domName annotation in comment to full fledge @DomName annotation.
...
Review URL: https://codereview.chromium.org//11887006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 19:01:07 +00:00
01fb2bbc86
Moved most of html lib generating scripts into tools.
...
BUG=
Review URL: https://codereview.chromium.org//11691009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 22:26:48 +00:00
Sigmund Cherem