dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

31 Commits

Author SHA1 Message Date
Srujan Gaddam bd58cea90b [dart:html] Fix getContext3d nullability 
Closes https://github.com/dart-lang/sdk/issues/45572

getContext3d should return a nullable value since getContext can
return a nullable.

Change-Id: Iaefff781976656db3765d526ec95305f2acfeecf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194503
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2021-04-09 19:03:43 +00:00
Srujan Gaddam e2ff83724b Fix nullability for some templates 
Addresses discrepancies between IDL and template files for some
operations. There's probably more I'm missing since this was
from a cursory check through all the templates.

Change-Id: Id79710b343f4a5fe0b5529f64c341d4f63d69b9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135222
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-02-11 20:28:54 +00:00
Srujan Gaddam 3776313e65 Change dart:html templates to generate null-safe code 
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.

Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-02-06 23:18:24 +00:00
Srujan Gaddam 7db61c6b01 Changing the dart:html generator scripts to generate null-safe/nnbd code 
Change-Id: I4a8b097b126864366076b1e73cf3e0296600380e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128376
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-01-29 00:20:42 +00:00
Terry Lucas edca6169c1 Fixed a number of dart:html P1 issues. 
- Fixed HTML API's with callback typedef to correctly convert Dart function to JS function.
- Expose HttpStatus from dart:html
- Expose DomName ondblclick and dblclickEvent for Angular analyzer.
- Fixed removeAll should be Iterable<Object> to match Set's removeAll not Iterable<E>.
- Fixed a number of DataTransferItem, Entry, FileEntry and DiretoryEntry returning NativeJavaScriptObject needed type registered in DDC.
- Added ability to allow local file access from Chrome browser added -local in ddb.

R=vsm@google.com

Fixes #30278
Fixes #35484
Fixes #34318
Fixes #35510

Change-Id: Ide8c04716c54045e837781d489562f27b694b109
Reviewed-on: https://dart-review.googlesource.com/c/89340
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-01-15 17:21:50 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-18 18:48:03 +00:00
Terry Lucas 621b12f324 Removed DARTIUM codegen for IDLS (sdk/lib/dartium) 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2978213002 .
 2017-07-18 11:02:02 -07:00
Sam Rawlins 931ceef9b2 Fixing dart:html links _not_ found in docs.json 
BUG= https://github.com/dart-lang/sdk/issues/23601
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1448963002 .
 2015-11-16 10:18:23 -08:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes" 
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes" 
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes 
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 00:23:17 +00:00
amouravski@google.com ea80298177 Added docs to canvaselement. Giving it docs for all members. 
Review URL: https://codereview.chromium.org//74013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30309 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-15 18:55:30 +00:00
blois@google.com 63f250a430 Removing a number of deprecated members 
Mostly left over from previous refactoring

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//33423004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29023 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 18:53:36 +00:00
blois@google.com fc0158645a Bringing back CanvasElement.toDataUrl docs. 
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23332021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26669 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-26 21:33:02 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL. 
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-23 18:25:40 +00:00
efortuna@google.com 842b1f41c3 Make type parameter in toDataUrl have an optional default value as per the spec. 
BUG=
R=amouravski@google.com

Review URL: https://codereview.chromium.org//18500010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24753 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-03 21:19:16 +00:00
amouravski@google.com c0a39d0412 Make html metadata follow the spec. 
Per https://code.google.com/p/dart/issues/detail?id=11568

R=scheglov@google.com

Review URL: https://codereview.chromium.org//18182010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24638 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-01 18:34:30 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors. 
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors." 
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors. 
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 17:31:36 +00:00
sra@google.com c3baf62826 More precise native type for context2D 
Trims 3k off spirodraw

Review URL: https://codereview.chromium.org//13913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21174 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-09 22:21:45 +00:00
efortuna@google.com ae82b45193 Rename context2d to context2D. 
BUG=

Review URL: https://codereview.chromium.org//13726010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21006 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-05 23:16:48 +00:00
blois@google.com 50e1cf4927 Adding web_gl library. 
BUG=

Review URL: https://codereview.chromium.org//12851013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20833 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-03 00:45:20 +00:00
amouravski@google.com ad74dd0131 Added the CanvasImageSource interface, which all types that a canvas can draw 
with drawImage implements.

Review URL: https://codereview.chromium.org//12775010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20108 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-15 20:54:50 +00:00
blois@google.com de9fbf0e90 Renaming dart:html library from 'html' to 'dart.html' 
This should be invisible to end users, but basically brings dart:html in-line with the core libraries.

BUG=

Review URL: https://codereview.chromium.org//12061008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17929 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 17:25:55 +00:00
blois@google.com 8cb540948f Adding supported checks for WebGL 
Also fixed the getContext method to have the proper signature (bug 4883).

Also adding an easy accessor for context3d.

Not sure if additional Dartium changes will be needed, Anton?

BUG=

Review URL: https://codereview.chromium.org//12077039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17860 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-30 17:45:13 +00:00
blois@google.com 049efc4fe8 Fixing cleanup of dart:html annotation generation. 
This is an update of https://codereview.chromium.org/11968047/

BUG=

Review URL: https://codereview.chromium.org//12024002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-18 22:11:21 +00:00
blois@google.com bda6df30df Revert "Fixing formatting of dart:html's dart2js annotations." 
This reverts commit 11508.

BUG=

Review URL: https://codereview.chromium.org//11962049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-17 22:16:31 +00:00
blois@google.com b6f3ecaa2c Fixing formatting of dart:html's dart2js annotations. 
Also unifying formatting of attributes.

BUG=7808

Review URL: https://codereview.chromium.org//11968047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-17 22:12:36 +00:00
amouravski@google.com 038af964dc Changed @domName annotation in comment to full fledge @DomName annotation. 
Review URL: https://codereview.chromium.org//11887006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-16 19:01:07 +00:00
efortuna@google.com 01fb2bbc86 Moved most of html lib generating scripts into tools. 
BUG=

Review URL: https://codereview.chromium.org//11691009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-28 22:26:48 +00:00