Commit Graph

33 Commits

Author SHA1 Message Date
Srujan Gaddam 3776313e65 Change dart:html templates to generate null-safe code
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.

Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-02-06 23:18:24 +00:00
Terry Lucas 621b12f324 Removed DARTIUM codegen for IDLS (sdk/lib/dartium)
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2978213002 .
2017-07-18 11:02:02 -07:00
Alan Knight b4b02daade Include DDC fixes to dart:html in the main version
BUG=
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2899173002 .
2017-05-24 12:49:13 -07:00
Alan Knight a718c8dac9 Fix a few strong mode errors in dart:html
BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847

Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 15:13:31 -07:00
Alan Knight 3fd7e32b65 Revert "Fix a few strong mode errors in dart:html"
This reverts commit 65fe0a5383.

BUG=

Review URL: https://codereview.chromium.org/1879253004 .
2016-04-13 14:56:42 -07:00
Alan Knight 65fe0a5383 Fix a few strong mode errors in dart:html
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 14:41:10 -07:00
Terry L. Lucas 7b322c246c Dartium JS Enabled take 2
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1348173002 .
2015-09-16 07:13:53 -07:00
Terry L. Lucas 09c804aa78 Revert "Dartium JS Interop enabled."
This reverts commit 403bd1698d.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1345083002 .
2015-09-15 19:44:26 -07:00
Terry L. Lucas 403bd1698d Dartium JS Interop enabled.
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1349493003 .
2015-09-15 17:36:47 -07:00
Terry L. Lucas 9b0d2582fc Revert "Dartium w/ JsInterop enabled"
This reverts commit 346af54711.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1330163010 .
2015-09-09 17:33:24 -07:00
Terry L. Lucas 346af54711 Dartium w/ JsInterop enabled
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1321613005 .
2015-09-09 17:01:40 -07:00
vsm@google.com e379d380bc Migrate to Chrome 37 IDL
This enables terry's new scripts with fixes from vsm and leafp (tested in the dartium_integration branch).

R=leafp@google.com

Review URL: https://codereview.chromium.org//569783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40219 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 21:18:06 +00:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes"
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes"
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
kevmoo@google.com bc4c2eba68 Fixed example in dart:html Events
BUG= https://code.google.com/p/dart/issues/detail?id=19641
R=efortuna@google.com

Review URL: https://codereview.chromium.org//365083006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37990 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 19:03:13 +00:00
blois@google.com 15e086338d Revert "Revert "Removing some deprecated members""
Take-two of https://code.google.com/p/dart/source/detail?r=29022

The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//35013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29051 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:44:10 +00:00
blois@google.com 3aef09e008 Revert "Removing some deprecated members"
For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing.

TBR
BUG=

Review URL: https://codereview.chromium.org//32523007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29033 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 20:20:32 +00:00
blois@google.com e2c4716609 Removing some deprecated members
These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//30353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29022 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:42:01 +00:00
efortuna@google.com 7da21ce566 Allow all events to be accessed via on[foo] instead of just onFoo
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//29843004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28966 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 23:07:18 +00:00
blois@google.com 358392883c Adding ElementEventStream.capture
Also making Element.on[] return an ElementStream.

BUG=13214
R=efortuna@google.com

Review URL: https://codereview.chromium.org//26135004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28819 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 20:19:46 +00:00
blois@google.com 1aa8a7be0e Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses.
This is for post-construction custom element creation.

Element.created is public, then the base classes of that get private ._created constructors.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24653006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 21:26:06 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors.
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors.
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
blois@google.com 6735b55710 Removing deprecated events syntax.
BUG=

Review URL: https://codereview.chromium.org//12217124

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18459 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 17:43:57 +00:00
blois@google.com de9fbf0e90 Renaming dart:html library from 'html' to 'dart.html'
This should be invisible to end users, but basically brings dart:html in-line with the core libraries.

BUG=

Review URL: https://codereview.chromium.org//12061008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17929 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 17:25:55 +00:00
blois@google.com d2aa044d2b Deprecating old DOM event APIs.
This also exposes EventTarget.dispatchEvent. We had discussed naming this as 'dispatch', but it seems a bit safer to use 'dispatchEvent' to avoid potential name conflicts.

BUG=

Review URL: https://codereview.chromium.org//12047054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17595 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 19:42:02 +00:00
blois@google.com 049efc4fe8 Fixing cleanup of dart:html annotation generation.
This is an update of https://codereview.chromium.org/11968047/

BUG=

Review URL: https://codereview.chromium.org//12024002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 22:11:21 +00:00
blois@google.com bda6df30df Revert "Fixing formatting of dart:html's dart2js annotations."
This reverts commit 11508.

BUG=

Review URL: https://codereview.chromium.org//11962049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:16:31 +00:00
blois@google.com b6f3ecaa2c Fixing formatting of dart:html's dart2js annotations.
Also unifying formatting of attributes.

BUG=7808

Review URL: https://codereview.chromium.org//11968047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:12:36 +00:00
amouravski@google.com 038af964dc Changed @domName annotation in comment to full fledge @DomName annotation.
Review URL: https://codereview.chromium.org//11887006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 19:01:07 +00:00
efortuna@google.com 01fb2bbc86 Moved most of html lib generating scripts into tools.
BUG=

Review URL: https://codereview.chromium.org//11691009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 22:26:48 +00:00