dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

34 Commits

Author SHA1 Message Date
Srujan Gaddam 5b23373f7e Modify fields in some abstract and native classes 
Since we transitioned to natives for dart:html, manually written native
fields should be rewritten. Similarly, if there are fields in abstract
classes that represent interfaces, they should be converted. Fields in
abstract classes that are used in that class are left alone.

Change-Id: I924363639a4430b88b810b7348815bbc3f040e7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137642
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2020-02-29 01:29:35 +00:00
Srujan Gaddam 8c0d72db1d Fix how composedPath is called 
Bug: b/149075352

Event.path should call composedPath if the result of the inline is
True. As it is, it only calls it if the result is null, which is
erroneous.

Change-Id: Idacc9ccddafc4374aca10de84265bf82cfbd0ab9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134887
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-02-07 23:25:22 +00:00
Srujan Gaddam 3776313e65 Change dart:html templates to generate null-safe code 
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.

Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-02-06 23:18:24 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-18 18:48:03 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs. 
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 09:41:04 +00:00
Alan Knight a718c8dac9 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 15:13:31 -07:00
Alan Knight 3fd7e32b65 Revert "Fix a few strong mode errors in dart:html" 
This reverts commit 65fe0a5383.

BUG=

Review URL: https://codereview.chromium.org/1879253004 .
 2016-04-13 14:56:42 -07:00
Alan Knight 65fe0a5383 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 14:41:10 -07:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes" 
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes" 
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes 
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 00:23:17 +00:00
efortuna@google.com 502c7c29c8 Allow matchingTarget to also include the currentTarget. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//52443007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29609 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-30 23:32:39 +00:00
efortuna@google.com a8f1004971 Add "matchingTarget" function to Event, which is the Element that matched the CSS value selector. 
Bug fix for https://code.google.com/p/dart/issues/detail?id=12931

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//26722002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28430 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-09 23:43:20 +00:00
efortuna@google.com 79d6ca8285 Reapply KeyEvent improvements. 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//26279008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28370 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-08 18:10:24 +00:00
efortuna@google.com 9c5078b378 "Reverting 28321" 
BUG=

Review URL: https://codereview.chromium.org//26334002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28323 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-07 20:11:16 +00:00
efortuna@google.com c5fe58c61c Fully polyfill KeyEvent so that you can programmatically create your own "keyboard" events. 
Added some test cases as well.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//23455033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28321 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-07 19:40:17 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL. 
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-23 18:25:40 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors. 
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors." 
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors. 
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 17:31:36 +00:00
jmesserly@google.com 6f85889ab7 fix a bug in the Event constructor 
R=blois@google.com

Review URL: https://codereview.chromium.org//14387011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22130 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-29 17:18:55 +00:00
blois@google.com 3dc9e79521 Consolidating platform code into dart:html_common 
Basically a number of our platform checks are only accessible from dart:html and not other libs. Moved Device class over to html_common and added more platform logic which was distributed elsewhere.

Also fixing up Device to cache the platform checks.

BUG=

Review URL: https://codereview.chromium.org//12541020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19833 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-12 00:49:27 +00:00
blois@google.com de9fbf0e90 Renaming dart:html library from 'html' to 'dart.html' 
This should be invisible to end users, but basically brings dart:html in-line with the core libraries.

BUG=

Review URL: https://codereview.chromium.org//12061008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17929 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 17:25:55 +00:00
blois@google.com edf1d5149f - Changing event constructors to use named parameters. 
- Making more parameters optional.
- Converting remaining init*Event calls to constructors.

BUG=

Review URL: https://codereview.chromium.org//12025027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17488 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-23 19:43:21 +00:00
blois@google.com c63ae60625 Adding supported checks to media events. 
BUG=

Review URL: https://codereview.chromium.org//12047020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17431 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-22 22:50:18 +00:00
blois@google.com 299ec70b31 Adding supported checks & test for SpeechRecognition APIs. 
This is a re-submission of https://codereview.chromium.org/12026032/, the problem was that Dartium does not allow factory constructors with the same name as members.

Had to rename Event.type constructor to Event.eventType.
BUG=

Review URL: https://codereview.chromium.org//12045033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17430 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-22 22:42:01 +00:00
blois@google.com b0e5d99712 Reverting 17420 "Speech recognition APIs" which broke dartium. 
TBR
BUG=

Review URL: https://codereview.chromium.org//12039026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17427 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-22 21:55:12 +00:00
blois@google.com 23b8686f50 Fixing Dartium build issue with speechrecognition API. 
Dartium doesn't like params with same name as constructor.

TBR
BUG=

Review URL: https://codereview.chromium.org//12047028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17422 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-22 21:04:16 +00:00
blois@google.com a492a08eb2 Adding supported checks & test for SpeechRecognition APIs. 
BUG=

Review URL: https://codereview.chromium.org//12026032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17420 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-22 20:41:38 +00:00
blois@google.com 049efc4fe8 Fixing cleanup of dart:html annotation generation. 
This is an update of https://codereview.chromium.org/11968047/

BUG=

Review URL: https://codereview.chromium.org//12024002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-18 22:11:21 +00:00
blois@google.com bda6df30df Revert "Fixing formatting of dart:html's dart2js annotations." 
This reverts commit 11508.

BUG=

Review URL: https://codereview.chromium.org//11962049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-17 22:16:31 +00:00
blois@google.com b6f3ecaa2c Fixing formatting of dart:html's dart2js annotations. 
Also unifying formatting of attributes.

BUG=7808

Review URL: https://codereview.chromium.org//11968047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-17 22:12:36 +00:00
amouravski@google.com 038af964dc Changed @domName annotation in comment to full fledge @DomName annotation. 
Review URL: https://codereview.chromium.org//11887006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-16 19:01:07 +00:00
efortuna@google.com 01fb2bbc86 Moved most of html lib generating scripts into tools. 
BUG=

Review URL: https://codereview.chromium.org//11691009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-28 22:26:48 +00:00