dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

58 Commits

Author SHA1 Message Date
Srujan Gaddam 3776313e65 Change dart:html templates to generate null-safe code 
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.

Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-02-06 23:18:24 +00:00
Johnni Winther 6227ab0b97 Replace @ForceInline with @pragma in dart:html 
Change-Id: I73afc500438d3fba92f549c8c1955f5ccad47751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95033
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 12:17:18 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-18 18:48:03 +00:00
Terry Lucas bc75856e54 Update getClientRects, removed xtab, removed bogus entry in dom.json, 
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.

Fixed all tests using query and queryAll.

Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675

R=kevmoo@google.com

Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-03-27 20:45:33 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs. 
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 09:41:04 +00:00
Stephen Adams 109316c484 Force inlining to match AST version 
These are a couple of cases where inlining differs from the previous
version and makes a difference in angular code.

Change-Id: Ibc8ba0d720b8bb49481c41e1332fc6a4a0292d9d
Reviewed-on: https://dart-review.googlesource.com/44701
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-03-02 20:10:49 +00:00
Leaf Petersen 8f199377fa Remove generic method comment syntax from dart:html. 
This removes the last uses of the generic method comment syntax from
the SDK.  There are no additional explicit casts or reified generics
(other than those implied by reifying generic methods) in this CL.

Bug:
Change-Id: Icae23cac60869243cb3ba441f86d70422f68178f
Reviewed-on: https://dart-review.googlesource.com/26081
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
 2017-12-06 21:26:04 +00:00
Terry Lucas 621b12f324 Removed DARTIUM codegen for IDLS (sdk/lib/dartium) 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2978213002 .
 2017-07-18 11:02:02 -07:00
Jacob Richman 9ffe1c2450 Make querySelectorAll a generic method so that checked mode behavior is consistent with existing behavior and strong mode behavior is strong for the case of List<InputElement> elems = document.querySelector("input"); 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1904903003 .
 2016-04-21 09:54:18 -07:00
Jacob Richman 864b64fd5e Strong html 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1894713002 .
 2016-04-19 15:08:45 -07:00
Alan Knight 3fd7e32b65 Revert "Fix a few strong mode errors in dart:html" 
This reverts commit 65fe0a5383.

BUG=

Review URL: https://codereview.chromium.org/1879253004 .
 2016-04-13 14:56:42 -07:00
Alan Knight 65fe0a5383 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 14:41:10 -07:00
Jacob Richman c65854d2e4 Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X. 
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
 2016-03-29 18:32:52 -07:00
Stephen Adams ceaa0bdcc4 Use proper type in _createElement_2 
Without the annotation it is possible for a (small) program to tree-shake Element.

BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1486803002 .
 2015-11-30 15:10:54 -08:00
Stephen Adams 0b9cdccf1c Tweak Document.createElement for better inlining 
Single return statement lets the current optimizer inline the function.

R=alanknight@google.com

Review URL: https://codereview.chromium.org/1488793002 .
 2015-11-30 13:36:19 -08:00
Jacob Richman 8d793ca758 Dartium typed js interop work dart repo side of the change. Also tries to get 
BUG=

Review URL: https://codereview.chromium.org/1391353002 .
 2015-10-07 11:44:50 -07:00
Terry L. Lucas ecfad36ac7 Fixed custom elements to work in Polymer 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1389683002 .
 2015-10-05 08:55:52 -07:00
Alan Knight 0568fa8679 Omit extra argument to createElement/NS if null 
BUG=

Review URL: https://codereview.chromium.org//1345413004 .
 2015-09-22 09:28:38 -07:00
Terry L. Lucas 7b322c246c Dartium JS Enabled take 2 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1348173002 .
 2015-09-16 07:13:53 -07:00
Terry L. Lucas 09c804aa78 Revert "Dartium JS Interop enabled." 
This reverts commit 403bd1698d.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1345083002 .
 2015-09-15 19:44:26 -07:00
Terry L. Lucas 403bd1698d Dartium JS Interop enabled. 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1349493003 .
 2015-09-15 17:36:47 -07:00
Terry L. Lucas 9b0d2582fc Revert "Dartium w/ JsInterop enabled" 
This reverts commit 346af54711.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1330163010 .
 2015-09-09 17:33:24 -07:00
Terry L. Lucas 346af54711 Dartium w/ JsInterop enabled 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1321613005 .
 2015-09-09 17:01:40 -07:00
Terry L. Lucas 012c998f64 Revert "Patched in Dartium JsInterop" 
This reverts commit 4bb2e617db.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1327083002 .
 2015-09-08 13:35:03 -07:00
Terry L. Lucas 4bb2e617db Patched in Dartium JsInterop 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1310363006 .
 2015-09-08 12:46:41 -07:00
Terry L. Lucas 4947e570d4 Changed to use JSInterop 
Review URL: https://codereview.chromium.org//1173403004 .
 2015-07-13 12:38:16 -07:00
jacobr@google.com 60bae5bb5d Cleanup method signatures that were incorrect due to a lack of understanding about how Dart generics work. 
BUG=
R=alanknight@google.com, terry@google.com

Review URL: https://codereview.chromium.org//896293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43562 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 19:15:49 +00:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes" 
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes" 
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes 
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 00:23:17 +00:00
jmesserly@google.com 1102849f15 [dart:html] rename register to registerElement per spec 
BUG= https://code.google.com/p/dart/issues/detail?id=18621
R=jacobr@google.com

Review URL: https://codereview.chromium.org//268313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35829 260f80e4-7a28-3924-810f-c04153c831b5
 2014-05-06 20:41:07 +00:00
blois@google.com bff7179948 Fixing issues from IDL upgrade 
* CustomElement update to match new Element syntax fixes analyzer issue
* Document.createTreeWalker/createNodeIterator change to pass in last argument for IE11.

TBR
BUG=

Review URL: https://codereview.chromium.org//153603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32513 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-10 19:39:50 +00:00
jmesserly@google.com 0f277224e8 update custom elements and shadow dom 
R=blois@google.com

Review URL: https://codereview.chromium.org//140853005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32171 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-30 20:56:22 +00:00
amouravski@google.com 82fb93d181 Update selector docs. 
Review URL: https://codereview.chromium.org//65333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30069 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-07 20:49:32 +00:00
blois@google.com 679c9ed699 Fixing mirrors on Window, Document and Element 
BUG=13654
R=efortuna@google.com

Review URL: https://codereview.chromium.org//27429002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28772 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 01:27:20 +00:00
efortuna@google.com 951dca71cb Deprecate query and queryAll, also add back querySelector and querySelectorAll. 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//27223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28699 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-16 00:44:47 +00:00
blois@google.com 1aa8a7be0e Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses. 
This is for post-construction custom element creation.

Element.created is public, then the base classes of that get private ._created constructors.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24653006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-01 21:26:06 +00:00
blois@google.com 354c4dd5ad Revert "Revert "Start of dartium custom element lifecycle event support."" 
Primary changes are that a fast-path has been added for the single-argument Document.createElement and the systemnative.py changes were split out to CL https://codereview.chromium.org/24661002/.

This is dependent on https://codereview.chromium.org/24677002/

First patch is the original, second is the updates.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24491003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27921 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-25 23:15:09 +00:00
blois@google.com 5f2320dea7 Making Document, Element and Window documentable via @DocsEditable 
TBR
BUG=13291

Review URL: https://codereview.chromium.org//23591046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27503 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-13 21:23:07 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL. 
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-23 18:25:40 +00:00
blois@google.com ec11e52f62 Revert "Revert "Adding polyfill support for custom elements."" 
This fixes the issues in the custom elements polyfills.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23301012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26412 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-21 00:08:46 +00:00
blois@google.com 508affefed Revert "Adding polyfill support for custom elements." 
Caused issues with DocumentFragment and some lingering changes from the blink roll.

BUG=

Review URL: https://codereview.chromium.org//22957010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26410 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 23:28:22 +00:00
blois@google.com 72651260aa Adding polyfill support for custom elements. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//22967006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26405 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 22:56:08 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors. 
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors." 
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors. 
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 17:31:36 +00:00
efortuna@google.com 6f7ef4126d Reapply "Aggregate CSS manipulation functions in html lib." (r22400) 
BUG=

Review URL: https://codereview.chromium.org//14931008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22424 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-06 16:27:16 +00:00
efortuna@google.com 33b4567f83 "Reverting 22400" 
BUG=

Review URL: https://codereview.chromium.org//14965003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22401 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-06 00:12:34 +00:00
efortuna@google.com 5e07799aba Aggregate CSS manipulation functions in html lib. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//14941002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22400 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-06 00:04:15 +00:00
blois@google.com 30764d4a5b Was benchmarking the differences between document.query and using the native DOM methods when available, and document.query is significantly worse in almost all scenarios. 
Our current document.query can be optimized about 2x by caching the RegExps being used, but this is still not enough to get close to what they should be.

We special-cased a couple of queries to optimize those, but it appears that the browsers are optimizing those now as well and our optimizations are getting in the way, overall.

From my tests so far, this CL brings a speed improvement to document.query for all scenarios except for the name test:
document.queryAll('[name="test"]') which takes a fairly significant performance hit (runs close to 1/2 speed with this CL). This is mitigated by exposing getElementsByName which if used brings a 2x performance gain over queryAll.

BUG=

Review URL: https://codereview.chromium.org//12715003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19831 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-12 00:39:38 +00:00