Commit Graph

24 Commits

Author SHA1 Message Date
Sigmund Cherem d52475c166 [web] deprecate dart:web_sql
The WebSql was dropped 5+ years ago and this library is unsupported.

This change adds the `@deprecated` annotation on the library and APIs in
dart:html that expose it (`window.openDatabase`). It also indicates to dartdoc
to skip it for the api.dart.dev site.

I run a `pub_crawl` process to verify that this is not in use. I checked 15K
packages, and only found 2 occurrances of an import to this library:
  * One in a package marked as discontinued (used for migrating constants back
  in Dart 2)
  * Another in an example mock test (generated by mockito for mocking dart:html)
Also no library uses `window.openDatabase` either.

We will send a breaking change announcement soon and plan to delete this in a
future Dart release (possibly 2.15).

Fixes https://github.com/dart-lang/sdk/issues/45687
Fixes https://github.com/dart-lang/sdk/issues/45688

Change-Id: I8cd2bfa0ce64892c3f108bd6e24b8a0a3ec7c6ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196461
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2021-04-23 19:04:42 +00:00
Srujan Gaddam 3776313e65 Change dart:html templates to generate null-safe code
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.

Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-02-06 23:18:24 +00:00
Terry Lucas 8e02ff92db Added @category annotation for Web libraries and removed createCustomUpgrader.
TBR=jcollins@google.com

Change-Id: I151e8d8af4bc647bdf47399c11f83b1625dabcf6
Reviewed-on: https://dart-review.googlesource.com/48523
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-27 23:53:14 +00:00
Terry Lucas 476b1e02a9 Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
Also, updated status files to correctly fix failures in FF, IE and removed other spurious status entries.

R=alanknight@google.com,vsm@google.com

Change-Id: Ic965103d892ff4d5d119712e3187e829f57cd022
Reviewed-on: https://dart-review.googlesource.com/31800
Reviewed-by: Terry Lucas <terry@google.com>
2017-12-29 23:51:02 +00:00
Terry Lucas 0af98266ab Revert "Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test."
This reverts commit 0c8294e4a0.

Bug:
Change-Id: Idb35c64fd5365f2669e8aff45765fed74e0f0766
Reviewed-on: https://dart-review.googlesource.com/31440
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2017-12-23 01:59:38 +00:00
Terry Lucas 0c8294e4a0 Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
R=alanknight@google.com,vsm@google.com

Change-Id: I80e82f5aaa3c9748740031d8da139f79e2c0ab70
Reviewed-on: https://dart-review.googlesource.com/31080
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
2017-12-22 22:57:34 +00:00
Florian Loitsch ee46026671 Don't use LinkedList in the core libraries anymore.
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/fe17b5b2bc24454dd2f596d8ce6e2e7661e87f10
Reverted: https://github.com/dart-lang/sdk/commit/5d4a786f4466ebcb06c36ed44f262c9e120a7273
Review-Url: https://codereview.chromium.org/2975443002 .
2017-07-28 21:14:11 +02:00
Stephen Adams 8623950864 Change imports to clean up irritating warning
This gets rid of the following messages in the build:

patched_dart2js_sdk/lib/_internal/js_runtime/lib/native_typed_data.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/svg/dart2js/svg_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/web_audio/dart2js/web_audio_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/web_gl/dart2js/web_gl_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.
patched_dart2js_sdk/lib/web_sql/dart2js/web_sql_dart2js.dart: Nit: 'Symbol' is imported from both 'dart:_internal' and 'dart:core'.

BUG=
R=ahe@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2982503002 .
2017-07-12 14:37:40 -07:00
Alan Knight ce744f6222 Some dart2js fixes with new IDL. RequestCallback name and web_sql import
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1729813002 .
2016-02-23 16:27:59 -08:00
Johnni Winther ecb1e33a7f Report hint on unmatched show and hide combinators.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1346133002.
2015-09-17 12:33:17 +02:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes"
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes"
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
lrn@google.com 3b3e87cabc Revert "Rename internal library dart:_collection-dev to dart:_internal."
Dartium needs updating too.

Committed: https://code.google.com/p/dart/source/detail?r=31827

R=floitsch@google.com

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31877 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 12:06:38 +00:00
lrn@google.com ead87f47e9 Revert "Rename internal library dart:_collection-dev to dart:_internal."
Dartium needs updating too.

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31827 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 12:27:44 +00:00
lrn@google.com 0098710559 Rename internal library dart:_collection-dev to dart:_internal.
BUG= http://dartbug.com/14140
R=floitsch@google.com

Review URL: https://codereview.chromium.org//133893007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31823 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 09:24:46 +00:00
ngeoffray@google.com 944aca6de7 HTML types that don't have [] do not implement JavaScriptIndexingBehavior, that is, the items cannot be accessed through [] in JavaScript.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23499007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26911 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 13:27:27 +00:00
blois@google.com ef9f4e7973 Properly hiding import of deprecate from collection-dev.
CL https://codereview.chromium.org//18692002 modified the generated files but missed the source files. Also skipped Dartium files which have the same conflicts.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//18342003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24814 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 18:40:10 +00:00
sra@google.com 5a2d284a38 Revert "Revert "dart2js native mixin application should extend 'Interface', not 'Object'""
Review URL: https://codereview.chromium.org//15007011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22610 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-11 02:29:49 +00:00
sra@google.com e413e4ef0c Revert "dart2js native mixin application should extend 'Interface', not 'Object'"
BUG=

Review URL: https://codereview.chromium.org//15039023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22604 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 22:40:09 +00:00
sra@google.com a24c4034b8 dart2js native mixin application should extend 'Interface', not 'Object'
R=blois@google.com

Review URL: https://codereview.chromium.org//14619026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22602 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 22:13:51 +00:00
lrn@google.com bcaa04109e Move IterableMixinWorkaround to internal library.
From here we can remove it in stages after M4 without risking breaking
the VM, dart2js or the HTML library right now.

Review URL: https://codereview.chromium.org//13811019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21443 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 12:34:44 +00:00
amouravski@google.com 89b1a828db Added library comment and warning message to web_sql.
Review URL: https://codereview.chromium.org//12334098

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19092 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 22:36:55 +00:00
blois@google.com 51cd64501d Separating Web SQL into dart:web_sql.
These APIs are essentially deprecated as standardization as ceased for them, but they are also the only DBs available for mobile devices.

Separating out so it's easier to disable later.

BUG=

Review URL: https://codereview.chromium.org//12218185

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18782 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:05:24 +00:00