dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

35 Commits

Author SHA1 Message Date
Srujan Gaddam 63a57a76ce [dart:html] Revert "[dart:html] Revert commits using MDN compatibility info" 
This reverts commit f8ff12008e.

This CL is a revert of the initial revert and should be landed once
Flutter changes have been merged to handle the changes here.

Change-Id: I300a5efd776bf2a596743971f4e15ad62da77f5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153368
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-07-14 23:18:43 +00:00
Srujan Gaddam f8ff12008e [dart:html] Revert commits using MDN compatibility info 
This reverts commits aff77e7e..e24f205d.

Due to a breakage in a Flutter roll, this CL stack needs to be
reverted. It should be reintroduced with changes to Flutter code to
compile with the changes in dart:html.

Breakage: https://github.com/flutter/engine/runs/828631927

Change-Id: I9c93c4eab823337d09d2e347015ad9ec402f2038
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152910
Auto-Submit: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
 2020-07-02 01:33:18 +00:00
Srujan Gaddam 7349385185 [dart:html] Changes to template/src to handle compat data 
Mostly null-assertions to make code compatible with compat
data changes.

Change-Id: I8f7c6c2421d6427851a44588978910deae8440bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152047
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-07-01 22:06:34 +00:00
Srujan Gaddam 3776313e65 Change dart:html templates to generate null-safe code 
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.

Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-02-06 23:18:24 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-18 18:48:03 +00:00
Leaf Petersen 8f199377fa Remove generic method comment syntax from dart:html. 
This removes the last uses of the generic method comment syntax from
the SDK.  There are no additional explicit casts or reified generics
(other than those implied by reifying generic methods) in this CL.

Bug:
Change-Id: Icae23cac60869243cb3ba441f86d70422f68178f
Reviewed-on: https://dart-review.googlesource.com/26081
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
 2017-12-06 21:26:04 +00:00
Alan Knight d21cc80a54 Add a dataTransfer member to MouseEvent 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2899393004 .
 2017-05-25 14:05:10 -07:00
Jacob Richman 36c9514f04 Use Point<num> in dart:html for strong mode 
Strong mode is (as of recently) inferring a stricter type (e.g., Point<double>) and causing breaking changes.

patch from issue 2211493003 at patchset 1 (http://crrev.com/2211493003#ps1)

BUG=

Review URL: https://codereview.chromium.org/2211563002 .
 2016-08-03 14:09:10 -07:00
Alan Knight dad1a74d2e Oops, movementX/Y are private. Fix template 
BUG=

Review URL: https://codereview.chromium.org/1916203002 .
 2016-04-25 13:26:14 -07:00
Alan Knight 5542568adc Fix MouseEvent.movement to not use old webkit prefix 
BUG=

Review URL: https://codereview.chromium.org/1921823002 .
 2016-04-25 12:35:03 -07:00
Alan Knight a718c8dac9 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 15:13:31 -07:00
Alan Knight 3fd7e32b65 Revert "Fix a few strong mode errors in dart:html" 
This reverts commit 65fe0a5383.

BUG=

Review URL: https://codereview.chromium.org/1879253004 .
 2016-04-13 14:56:42 -07:00
Alan Knight 65fe0a5383 Fix a few strong mode errors in dart:html 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1876363006 .
 2016-04-13 14:41:10 -07:00
Terry Lucas 5d77c0e83c More UIEvent attribute movement in 45 roll. 
TBR=alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1771113002 .
 2016-03-07 16:12:28 -08:00
sra@google.com 7516e95066 Redo "Use @Native annotation on dart2js DOM native classes" 
BUG=

Review URL: https://codereview.chromium.org//410863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 04:27:48 +00:00
sra@google.com 9a4f73207e Revert "Use @Native annotation on dart2js DOM native classes" 
TBR=blois@google.com

BUG=

Review URL: https://codereview.chromium.org//410823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 01:44:13 +00:00
sra@google.com 11a19d95be Use @Native annotation on dart2js DOM native classes 
This is one of many steps to removing non-standard syntax from the dart2js libraries.

R=blois@google.com

Review URL: https://codereview.chromium.org//409053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-23 00:23:17 +00:00
blois@google.com 63f250a430 Removing a number of deprecated members 
Mostly left over from previous refactoring

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//33423004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29023 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 18:53:36 +00:00
efortuna@google.com eaa854b258 Move Rectangle and Point into dart:math. 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//25808002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28272 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-04 17:47:39 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL. 
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-23 18:25:40 +00:00
amouravski@google.com c0a39d0412 Make html metadata follow the spec. 
Per https://code.google.com/p/dart/issues/detail?id=11568

R=scheglov@google.com

Review URL: https://codereview.chromium.org//18182010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24638 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-01 18:34:30 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors. 
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors." 
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors. 
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 17:31:36 +00:00
blois@google.com ee483c9b6a Cleanup of various DOM dart2js and dart_analyzer warnings 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//15431003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22976 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-22 01:23:28 +00:00
floitsch@google.com 075be16ffd Fix typo (offsetX instead of offsetY). 
BUG= http://dartbug.com/9261

Review URL: https://codereview.chromium.org//12573008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20205 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-19 13:37:52 +00:00
blois@google.com 2fcae75253 Exposing Point & Rect types 
This exposes ClientRects as Rects and exposes UIEvent.clientX/Y properties as Points.

This also deprecates the UIEvent.clientX/Y properties.

BUG=

Review URL: https://codereview.chromium.org//12493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19659 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-07 22:17:04 +00:00
amouravski@google.com f05f2c77cc 'Moved all documentation from old .dartdoc files.' 
BUG=

Review URL: https://codereview.chromium.org//12219002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18111 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-05 03:04:59 +00:00
blois@google.com de9fbf0e90 Renaming dart:html library from 'html' to 'dart.html' 
This should be invisible to end users, but basically brings dart:html in-line with the core libraries.

BUG=

Review URL: https://codereview.chromium.org//12061008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17929 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 17:25:55 +00:00
blois@google.com edf1d5149f - Changing event constructors to use named parameters. 
- Making more parameters optional.
- Converting remaining init*Event calls to constructors.

BUG=

Review URL: https://codereview.chromium.org//12025027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17488 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-23 19:43:21 +00:00
blois@google.com 049efc4fe8 Fixing cleanup of dart:html annotation generation. 
This is an update of https://codereview.chromium.org/11968047/

BUG=

Review URL: https://codereview.chromium.org//12024002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-18 22:11:21 +00:00
blois@google.com bda6df30df Revert "Fixing formatting of dart:html's dart2js annotations." 
This reverts commit 11508.

BUG=

Review URL: https://codereview.chromium.org//11962049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-17 22:16:31 +00:00
blois@google.com b6f3ecaa2c Fixing formatting of dart:html's dart2js annotations. 
Also unifying formatting of attributes.

BUG=7808

Review URL: https://codereview.chromium.org//11968047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-17 22:12:36 +00:00
amouravski@google.com 038af964dc Changed @domName annotation in comment to full fledge @DomName annotation. 
Review URL: https://codereview.chromium.org//11887006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-16 19:01:07 +00:00
efortuna@google.com 01fb2bbc86 Moved most of html lib generating scripts into tools. 
BUG=

Review URL: https://codereview.chromium.org//11691009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-28 22:26:48 +00:00