63a57a76ce
[dart:html] Revert "[dart:html] Revert commits using MDN compatibility info"
...
This reverts commit f8ff12008ehttps://dart-review.googlesource.com/c/sdk/+/153368
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-07-14 23:18:43 +00:00
f8ff12008e
[dart:html] Revert commits using MDN compatibility info
...
This reverts commits aff77e7e..e24f205d.
Due to a breakage in a Flutter roll, this CL stack needs to be
reverted. It should be reintroduced with changes to Flutter code to
compile with the changes in dart:html.
Breakage: https://github.com/flutter/engine/runs/828631927
Change-Id: I9c93c4eab823337d09d2e347015ad9ec402f2038
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152910
Auto-Submit: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2020-07-02 01:33:18 +00:00
7349385185
[dart:html] Changes to template/src to handle compat data
...
Mostly null-assertions to make code compatible with compat
data changes.
Change-Id: I8f7c6c2421d6427851a44588978910deae8440bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152047
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-07-01 22:06:34 +00:00
9f79dfc37d
Address analyzer errors in golden files in dart:html
...
New analyzer errors are reported for dart:html around nullability.
Non-nullable fields are translated to native getters and setters if part
of a concrete class and normal getters and setters if abstract.
Change-Id: I2fd87803a08872b2a7eae4de0af704f184997c7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137481
Reviewed-by: Stephen Adams <sra@google.com >
2020-02-29 01:29:35 +00:00
3776313e65
Change dart:html templates to generate null-safe code
...
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.
Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-06 23:18:24 +00:00
8fedfc7f8c
Removed DomName, DosEditable, and experimental annoations they are unused.
...
R=kevmoo@google.com ,vsm@google.com
Fixes #32304
Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-06-18 18:48:03 +00:00
9e0297f49e
Make KeyboardEvent have direct fields for keyCode/charCode, as they're no longer inherited from UIEvent
...
BUG=
R=terry@google.com
Review-Url: https://codereview.chromium.org/2896653003 .
2017-05-22 10:29:24 -07:00
35979c3205
Add keyLocation to KeyboardEvent constructor for backwards compatibility
...
BUG=
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2884713002 .
2017-05-15 10:58:24 -07:00
01ba5f8d74
fix KeyEvent and KeyboardEvent
...
Some keyboard specific properties moved in the IDL from UIEvent to
KeyboardEvent. We has done work to hide them on UIEvent; this needed
to be updated.
TBR=terry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2883623004 .
2017-05-12 16:03:01 -07:00
a718c8dac9
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Committed: https://github.com/dart-lang/sdk/commit/65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 15:13:31 -07:00
3fd7e32b65
Revert "Fix a few strong mode errors in dart:html"
...
This reverts commit 65fe0a5383https://codereview.chromium.org/1879253004 .
2016-04-13 14:56:42 -07:00
65fe0a5383
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 14:41:10 -07:00
5c3728b067
Fix for KeyEvent,KeyboardEvent and UIEvent changes in roll 45
...
TBR=jacobr@google.com ,alanknight@google.com ,sigmund@google.com
Review URL: https://codereview.chromium.org/1754523006 .
2016-03-07 07:51:50 -08:00
94095d64a2
Merge 38 changes to bleeding edge
...
TBR=terry@google.com ,leafp@google.com
BUG=
Review URL: https://codereview.chromium.org//605083004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40774 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-29 15:56:25 +00:00
1c4bb5f363
Revert "Chrome 38 script changes from integration branch"
...
This reverts commit r40567.
TBR=leafp@google.com
Review URL: https://codereview.chromium.org//589253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40570 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 21:11:34 +00:00
9e25106514
Chrome 38 script changes from integration branch
...
TBR=leafp@google.com
Review URL: https://codereview.chromium.org//593853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40567 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 20:45:57 +00:00
7516e95066
Redo "Use @Native annotation on dart2js DOM native classes"
...
BUG=
Review URL: https://codereview.chromium.org//410863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38488 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 04:27:48 +00:00
9a4f73207e
Revert "Use @Native annotation on dart2js DOM native classes"
...
TBR=blois@google.com
BUG=
Review URL: https://codereview.chromium.org//410823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38486 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 01:44:13 +00:00
11a19d95be
Use @Native annotation on dart2js DOM native classes
...
This is one of many steps to removing non-standard syntax from the dart2js libraries.
R=blois@google.com
Review URL: https://codereview.chromium.org//409053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38484 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 00:23:17 +00:00
9c5078b378
"Reverting 28321"
...
BUG=
Review URL: https://codereview.chromium.org//26334002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28323 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 20:11:16 +00:00
c5fe58c61c
Fully polyfill KeyEvent so that you can programmatically create your own "keyboard" events.
...
Added some test cases as well.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//23455033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28321 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 19:40:17 +00:00
788716ff03
Remove keyIdentifier from KeyboardEvent factory constructor.
...
The new abilitity to specify a keycode/charcode/keyIdentifier will be allowed in
our custom KeyEvent implementation coming in a subsequent CL.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23004009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26656 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 16:43:55 +00:00
90873051ad
Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
...
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23055008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
9dd81d94a7
Fixing up DOM constructors.
...
This is a continuation of https://codereview.chromium.org/17063007/
Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//18054021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
67ab947580
Added minimal documentation to the KeyboardEvent class.
...
Bug: https://code.google.com/p/dart/issues/detail?id=11483
R=efortuna@google.com
Review URL: https://codereview.chromium.org//17759006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24450 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 06:15:18 +00:00
6b44f65407
Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
...
This reverts commit http://code.google.com/p/dart/source/detail?r=24241 .
Compiler error, not sure of best fix.
BUG=
Review URL: https://codereview.chromium.org//17508002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
c3547d4e9b
Making all DOM types abstract and removing superfluous Dartium constructors.
...
Adding factory constructors to all classes to suppress missing generative constructor warnings.
Adding a throw to Dartium's base DOM class to prevent construction of native objects.
This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//17063007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
0b765012a4
Updating KeyboardEvent constructor to use named parameters.
...
BUG=
Review URL: https://codereview.chromium.org//12061004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17585 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 18:07:59 +00:00
049efc4fe8
Fixing cleanup of dart:html annotation generation.
...
This is an update of https://codereview.chromium.org/11968047/
BUG=
Review URL: https://codereview.chromium.org//12024002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17323 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 22:11:21 +00:00
bda6df30df
Revert "Fixing formatting of dart:html's dart2js annotations."
...
This reverts commit 11508.
BUG=
Review URL: https://codereview.chromium.org//11962049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17239 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:16:31 +00:00
b6f3ecaa2c
Fixing formatting of dart:html's dart2js annotations.
...
Also unifying formatting of attributes.
BUG=7808
Review URL: https://codereview.chromium.org//11968047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17238 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-17 22:12:36 +00:00
038af964dc
Changed @domName annotation in comment to full fledge @DomName annotation.
...
Review URL: https://codereview.chromium.org//11887006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17154 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 19:01:07 +00:00
01fb2bbc86
Moved most of html lib generating scripts into tools.
...
BUG=
Review URL: https://codereview.chromium.org//11691009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16557 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 22:26:48 +00:00
Srujan Gaddam