Commit Graph

134 Commits

Author SHA1 Message Date
terry@google.com ecceb75d35 Begin hookup of Blink IDL parser for dart:* libraries.
BUG=
R=vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39948

Review URL: https://codereview.chromium.org//444743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40026 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 13:18:24 +00:00
leafp@google.com 8e3aaa4e75 Blink uses types in entry points
This CL changes the way that blink entry points are named to
use the type signature uniformly.  This makes us somewhat
more robust against changes in the idl.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//552533004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40006 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 00:17:15 +00:00
terry@google.com ac72bce2f1 "Reverting 39948"
BUG=

Review URL: https://codereview.chromium.org//554853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39999 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 20:58:19 +00:00
terry@google.com cf0c6a3565 Begin hookup of Blink IDL parser for dart:* libraries.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//444743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39948 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 02:33:50 +00:00
leafp@google.com 445e8fda3d Eliminate the old non blink code paths from idl generation
During the transition to the dart:html dart:blink split, we needed to support generating the old style and the new style.  This CL eliminates the code paths for the old style generation now that they're no longer needed.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//450693005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39005 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 20:04:18 +00:00
leafp@google.com a20d4b09d2 Remove dart:blink dependency on dart:html. This CL moves all of the
overload resolution (dependent on dart specific types) over to the
dart:html side, along with the type resolution maps.  This is a first
step to generating dart:blink from the dartium idl.  There is a paired
blink CL which switches the type map lookup from dart:blink to dart:html.

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//446193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38993 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 16:12:50 +00:00
leafp@google.com 851e41a408 Fix overloading for IDBDatabase transaction
Use the underlying dart implementation class in overloading resolution
checks, rather than the dart interface which is presented to the
user.  This resolves an issue with IDBDatabase in which DOMStringList
and sequence<DOMString> have the same Dart interface type
(List<String>), even though the underlying implementation types differ
(List<String> vs DomStringList).

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//368433004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37883 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 17:24:47 +00:00
leafp@google.com 476278985c Refactor dart:_blink into classes to improve startup time.
This CL reduces the snapshot size by about 20% (580kb).

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//319283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37189 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 17:38:29 +00:00
vsm@google.com b8464a3dde Suppress cloning EventTarget methods in subtypes when using blink
I have an forthcoming Blink CL to safely cast to EventTarget*.

Not sure this is the right path long term.

Review URL: https://codereview.chromium.org//283043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36166 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 13:46:10 +00:00
leafp@google.com d1f0594840 Initial overloading implementation in _blink
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//260893007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35662 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 22:03:06 +00:00
leafp@google.com 5e0688e1ec This CL contains all of the changes for splitting off all of the native
calls from dart:html into dart:blink.  As currently configured, the
dart:blink library will be empty and unused.  The only changes in the
idl generated dart and C++ code in the default configuration should
be cosmetic.  The global variable "dart_use_blink" in systemnative.py
currently controls whether or not the real blink library is
generated.  Enabling this requires as yet unchecked in changes to
blink.  These changes are expected to land as part of the chrome
35 roll.

Support for building with/without blink
DOM changes for checked receivers
Dartium native call generation refactor

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//254463006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35430 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 16:22:08 +00:00
jacobr@google.com e9bcf2ddca Make the Dart code generators handle the Image constructor specified in the IDL without crashing or generating multiple constructors.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//142563006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32621 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 20:47:13 +00:00
vsm@google.com eebdf4ccf9 Revert "Revert "Revert "Fix dart2js type warnings"""
Hitting layout test failures in Dartium now....

TBR=blois@google.com
BUG=

Review URL: https://codereview.chromium.org//134623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31702 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 19:27:09 +00:00
vsm@google.com f236af9969 Revert "Revert "Fix dart2js type warnings""
Retrying with a fix.  Patch 1 is initial change.

BUG=15954
R=blois@google.com

Review URL: https://codereview.chromium.org//126873003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31699 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 19:00:03 +00:00
kasperl@google.com 1bbe4d5452 Make sure that classes in dart:html do not implement both List and List<E>.
R=johnniwinther@google.com, blois@google.com
BUG=

Review URL: https://codereview.chromium.org//50263004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29417 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 08:37:10 +00:00
efortuna@google.com 7e685302b9 Add back unseparated out version of method overloads in dart:html.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//34733007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29135 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:07:45 +00:00
blois@google.com 15e086338d Revert "Revert "Removing some deprecated members""
Take-two of https://code.google.com/p/dart/source/detail?r=29022

The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//35013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29051 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:44:10 +00:00
blois@google.com 3aef09e008 Revert "Removing some deprecated members"
For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing.

TBR
BUG=

Review URL: https://codereview.chromium.org//32523007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29033 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 20:20:32 +00:00
blois@google.com e2c4716609 Removing some deprecated members
These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//30353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29022 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:42:01 +00:00
efortuna@google.com 035e04fb2d Making all base class DOM types throw as well (to prevent a default constructor for DOM types that are not constructable).
BUG=https://code.google.com/p/dart/issues/detail?id=11620
R=blois@google.com

Review URL: https://codereview.chromium.org//27033009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28615 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 21:58:46 +00:00
blois@google.com f51dad91fd Untyping List types
Making all DOM lists implement List rather than List<T>. This is primarily for NodeList which is used in cases where it's just a list of Elements and allows us to assign it to List<Element> without type checks.

BUG=
R=sra@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//27227002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28597 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 18:36:59 +00:00
efortuna@google.com d5212a6ac0 Make OptionElement construtor arguments named optional parameters.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//25585002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28115 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 20:33:49 +00:00
blois@google.com d312cbbd08 Exposing document.createElement
As part of removing all $dom_ APIs, making this one public. There are valid scenarios for creating elements in other documents.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//24084004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27415 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 00:00:39 +00:00
asiva@google.com 4d8651f8af 1. Make direct calls to _nativeIndexedGetter in "get last" "get first" "get single" instead of calling the "[]" operator. This avoids one additional native call to the length method for each call to "last" "first" or "single"
2. Fix templateloader to deal with nested 'if' conditions

R=vsm@google.com

Review URL: https://codereview.chromium.org//23534050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27270 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 23:22:31 +00:00
blois@google.com 87e39090a1 Exposing native doubles as doubles when they are read-only or method return values.
This keeps num for parameters of operations and fields which are settable. Requested because some DOM APIs (such as Performance.now) don't really make sense returning ints.

BUG=11133
R=vsm@google.com

Review URL: https://codereview.chromium.org//21555003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26817 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 21:07:13 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
jacobr@google.com 339b0bdd70 Attempt to land Dartium roll a second time.
BUG=

Review URL: https://codereview.chromium.org//23064024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26363 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 15:54:49 +00:00
jacobr@google.com c6ebe4e4e0 rollback problem blink merge cl
Review URL: https://codereview.chromium.org//23163010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26339 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:22:24 +00:00
jacobr@google.com 785c8416bc Changes required for Dartium roll
Merge checkpoint. Everything compiles.

BUG=

Review URL: https://codereview.chromium.org//22886009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26335 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 01:50:17 +00:00
blois@google.com 59c29150b4 Removing overloaded operations in dart2js.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//22933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26041 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 22:23:42 +00:00
vsm@google.com 992776552a Fixes for Blink roll.
TBR=jacobr@google.com,asiva@google.com

Review URL: https://codereview.chromium.org//19820007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25395 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 04:46:29 +00:00
efortuna@google.com f81052f2c8 Reapply expanding overloaded functions into separate functions.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//18577002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24709 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 22:32:44 +00:00
efortuna@google.com 3629744086 "Reverting 24655"
BUG=

Review URL: https://codereview.chromium.org//18277003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24656 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 21:09:19 +00:00
efortuna@google.com fc0df10d8b Expand overloaded methods and optional parameters in the html library.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//16494002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24655 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 20:49:07 +00:00
amouravski@google.com c0a39d0412 Make html metadata follow the spec.
Per https://code.google.com/p/dart/issues/detail?id=11568

R=scheglov@google.com

Review URL: https://codereview.chromium.org//18182010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24638 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 18:34:30 +00:00
blois@google.com 9dd81d94a7 Fixing up DOM constructors.
This is a continuation of https://codereview.chromium.org/17063007/

Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//18054021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
blois@google.com 6b44f65407 Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
This reverts commit http://code.google.com/p/dart/source/detail?r=24241.

Compiler error, not sure of best fix.

BUG=

Review URL: https://codereview.chromium.org//17508002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
blois@google.com c3547d4e9b Making all DOM types abstract and removing superfluous Dartium constructors.
Adding factory constructors to all classes to suppress missing generative constructor warnings.

Adding a throw to Dartium's base DOM class to prevent construction of native objects.

This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//17063007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
blois@google.com ab50cfcc68 Adding annotations for native types of type Object or dynamic.
Also added generation warnings to try to detect these.

BUG=10946
R=sra@google.com

Review URL: https://codereview.chromium.org//16638013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23875 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 19:46:57 +00:00
amouravski@google.com 768d611f4e Remove more question marks.
R=antonm@google.com, blois@google.com

Review URL: https://codereview.chromium.org//14976004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23563 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 19:56:58 +00:00
antonm@google.com fd3c7da1ee Verify that correct number of arguments was passed.
R=amouravski@google.com

Review URL: https://codereview.chromium.org//15850004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23296 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:42:13 +00:00
antonm@google.com 7156616c08 Revert to ? presence checks.
TBR=amouravski@google.com

Review URL: https://codereview.chromium.org//15960004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23127 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 09:02:25 +00:00
amouravski@google.com f968d3465c Added tests to previously broken functionality and added null checks.
R=antonm@google.com

Review URL: https://codereview.chromium.org//15138002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23123 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 08:23:24 +00:00
blois@google.com f297525d5a Adding annotations to DOM constants.
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//15043005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22589 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 17:39:40 +00:00
amouravski@google.com bc44aa444e Changed the order of optional parameter creation so that they're created from
last to first.

R=blois@google.com

Review URL: https://codereview.chromium.org//14863011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22578 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 00:02:58 +00:00
blois@google.com 75770524fa Changing metadata lookup to always use interface.id
We had some discrepancies where interface lookup was using interface.doc_js_name but member lookup was using interface.id.

Standardized on interface.id.

Also updated the @DomName annotation to always use the JS interface name, which should help with MDN fallback documentation.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//14651019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22556 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-09 18:41:07 +00:00
blois@google.com 0c48687c86 Updating DOM code to use list mixins
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//14036014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22512 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-08 15:45:30 +00:00
blois@google.com 585621924c Remove outdated DOM generation check
This doesn't appear to be used any more (removing it had no effect), other than to drive John nuts when he tries to rename a member.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//14708003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22296 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-02 00:21:52 +00:00
blois@google.com 72cf63c068 Refactoring DOM annotations and comment generation, adding DOM API triage list
This pulls the annotation and comment code out of generator.py and into a Metadata class, which is also tracking new APIs from the IDLs.

Right now the API triage list is being updated when new members appear, but is not adding any metadata to the Dart APIs. Of note for the triage list is that there are currently 437 untriaged members- these are all of the APIs which have either been introduced, renamed or moved in the past week.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//14455007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22193 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-30 18:35:30 +00:00
amouravski@google.com 98f022a003 First try at removing ? from HTML.
R=blois@google.com

Review URL: https://codereview.chromium.org//14400004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22163 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-30 02:29:32 +00:00