* Migrate to python3; drop python support.
* Update Windows toolchain support.
* Remove some unused methods.
* Python 2.7 is still needed on Windows.
* Update gsutil to a version that supports python3.
Fixes: https://github.com/dart-lang/sdk/issues/28793
TEST=Manually tested common user journeys.
Change-Id: I663a22b237a548bb82dc2e601e399e3bc3649211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192182
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Since the sdk has been unforked, scripts should be updated to
generate files by always using NNBD. As such, nnbd_src has been
moved to src and the old src has been deleted. This does not address
the nnbd tokens e.g. $NULLABLE. That will be done in a future CL.
Change-Id: I00bead16a9d19569b07ad0601f581fc14400fdce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151864
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
- Add `.style.yapf` with configuration to use Google style.
- Run `yapf` on all `.py` files in this repo.
- Manually fix one trailing space in a doc string.
- Run `git cl format runtime` to satisfy presubmit.
Change-Id: I7e6bd11e91f07926b9188362599af398551eed79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111600
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Made a number of optimizations to reduce load time from 8 secs to 1 sec. The changes involved:
- No longer dynamically generate patch files on startup for dart:* libraries (created from WebKits IDL e.g., html, svg, web_audio, web_gl, indexed_db, web_sql). Instead create a cache of patch files.
- Comparison of @JS refelctedType not by library and symbol name comparison.
- In addition, a VM mirror change see CL https://codereview.chromium.org/1834673003/ gives us the remaining speedup.
This cache of interop patch files, for Dartium only, requires a manual re-gen after go.sh run is:
> cd tools/dom/scripts
> run go.sh
The steps after (for Dartium) are:
1. build Dartium
2. cd tools/dartium
3. run generate_patches.sh
4. build Dartium
R=jacobr@google.com, alanknight@google.com
Review URL: https://codereview.chromium.org/1833373002 .
This removes the dart:blink generation code from the dart html scripts. The _blink_dartium template is removed, and the blink_nativeDOMImplementation html_nativeDOMImplementation split is eliminated, with the code for the former in the dartium generated code, and the latter moved back to native_DOMImplementation.dart.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//680913006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41346 260f80e4-7a28-3924-810f-c04153c831b5
calls from dart:html into dart:blink. As currently configured, the
dart:blink library will be empty and unused. The only changes in the
idl generated dart and C++ code in the default configuration should
be cosmetic. The global variable "dart_use_blink" in systemnative.py
currently controls whether or not the real blink library is
generated. Enabling this requires as yet unchecked in changes to
blink. These changes are expected to land as part of the chrome
35 roll.
Support for building with/without blink
DOM changes for checked receivers
Dartium native call generation refactor
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//254463006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35430 260f80e4-7a28-3924-810f-c04153c831b5
to access the C++ class hierachy information to do a proper subtype of check.
The new subtype of check improves the following benchmarks
Dromaeo-drt dom-modify appendChild runs-per-second from 889.0 to 1575.0
Dromaeo-drt dom-modify insertBefore runs-per-second from 592.4075924075925 to 1298.0
The generated class table is as follows:
enum {
_HistoryCrossFrameClassId = 0,
_LocationCrossFrameClassId,
_DOMWindowCrossFrameClassId,
_DateTimeClassId,
// New types that are not auto-generated should be added here.
ANGLEInstancedArraysClassId,
AbstractWorkerClassId,
....
....
};
typedef struct {
const char* class_name;
int library_id;
int base_class_id;
bool is_node;
bool is_active;
bool is_event;
} _Classinfo;
typedef _Classinfo _DartWebkitClassInfo[NumWebkitClassIds];
_DartWebkitClassInfo DartWebkitClassInfo = {
{ "_HistoryCrossFrame", DartHtmlLibraryId, -1, false, false, false },
{ "_LocationCrossFrame", DartHtmlLibraryId, -1, false, false, false },
{ "_DOMWindowCrossFrame", DartHtmlLibraryId, -1, false, false, true },
{ "DateTime", DartCoreLibraryId, -1, false, false, false },
// New types that are not auto-generated should be added here.
{ "AngleInstancedArrays", DartWebGlLibraryId, -1, false, false, false, },
{ "AbstractWorker", DartHtmlLibraryId, -1, false, false, false, },
.....
.....
};
R=rmacnak@google.com, vsm@google.com
Review URL: https://codereview.chromium.org//27358002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28821 260f80e4-7a28-3924-810f-c04153c831b5
This pulls the annotation and comment code out of generator.py and into a Metadata class, which is also tracking new APIs from the IDLs.
Right now the API triage list is being updated when new members appear, but is not adding any metadata to the Dart APIs. Of note for the triage list is that there are currently 437 untriaged members- these are all of the APIs which have either been introduced, renamed or moved in the past week.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//14455007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22193 260f80e4-7a28-3924-810f-c04153c831b5
Alexander Thomas