f236af9969
Revert "Revert "Fix dart2js type warnings""
...
Retrying with a fix. Patch 1 is initial change.
BUG=15954
R=blois@google.com
Review URL: https://codereview.chromium.org//126873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31699 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 19:00:03 +00:00
0a7a4e8646
Revert "Fix dart2js type warnings"
...
This is breaking the Dartium build. Will investigate and hopefully resubmit.
TBR=blois@google.com
Review URL: https://codereview.chromium.org//126883003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31588 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 23:13:20 +00:00
5755d7d28a
Fix dart2js type warnings
...
This should fix the errors reported here:
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-linux-release-checked-5-5-be/builds/2126/steps/dart2js_unit%20tests%20--checked/logs/stdio
Should we make these types private?
R=blois@google.com
Review URL: https://codereview.chromium.org//126793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31587 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 22:49:38 +00:00
1436645a1b
Rerun go.sh
...
Regenerating with Chrome 32 IDL.
TBR=blois@google.com ,efortuna@google.com
Review URL: https://codereview.chromium.org//94043006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31558 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 17:58:22 +00:00
3ed4c8dfd7
Remove use of deprecated mirror functions from Dartium's dart:html.
...
BUG=http://dartbug.com/14931
R=vsm@google.com
Review URL: https://codereview.chromium.org//71453008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30259 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-13 23:50:05 +00:00
239d152949
Way more documentation blanks filled in.
...
Review URL: https://codereview.chromium.org//66193010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30134 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-09 01:19:44 +00:00
cb0fa66a9b
Fixing BeforeUnloadEvent.returnValue
...
This is an update of https://codereview.chromium.org/54913005/ which was failing on the Dartium bots.
Original is patch #1 , fix is #2 (re-ordering the parts in html_dartium).
Issue with the original appears to be that parts have some order-dependency in the VM when executing with --error_on_bad_type, which is used in snapshotting.
Opened bug https://code.google.com/p/dart/issues/detail?id=14721
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//55903004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29766 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 19:53:45 +00:00
7046fc201e
Revert "Fixing the BeforeUnloadEvent"
...
Causing problems with build on Dartium:
class _CustomEventStreamImpl<T extends Event> extends Stream<T>
^
'file:///mnt/data/b/build/slave/dartium-lucid32-full-be/build/src/dart/tools/dom/src/EventStreamProvider.dart': Error: line 334 pos 41: type '_CustomEventStreamImpl<KeyEvent>' has an out of bound type argument
class _CustomKeyEventStreamImpl extends _CustomEventStreamImpl<KeyEvent>
TBR
BUG=
Review URL: https://codereview.chromium.org//54923006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29754 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 16:37:33 +00:00
a948d4384a
Fixing the BeforeUnloadEvent
...
Basically the last Blink upgrade introduced the BeforeUnloadEvent which conflicted with our previous polyfill. Our definition was removed, but the suppression remained for Event.returnValue.
The suppression is still needed since that's the incorrect type and on the wrong class, so I modified our metadata lookup to allow it to only target exact class matches (and not super classes).
BUG=
R=efortuna@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//54913005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29752 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 16:17:38 +00:00
7e685302b9
Add back unseparated out version of method overloads in dart:html.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//34733007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29135 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:07:45 +00:00
1787f36d42
Rerun go.sh
...
BUG=
Review URL: https://codereview.chromium.org//37943002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29120 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 20:54:41 +00:00
15e086338d
Revert "Revert "Removing some deprecated members""
...
Take-two of https://code.google.com/p/dart/source/detail?r=29022
The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//35013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29051 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:44:10 +00:00
3aef09e008
Revert "Removing some deprecated members"
...
For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing.
TBR
BUG=
Review URL: https://codereview.chromium.org//32523007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29033 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 20:20:32 +00:00
e2c4716609
Removing some deprecated members
...
These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//30353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29022 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:42:01 +00:00
333054ee75
Supporting non-SSVs in CustomEvent.detail
...
BUG=12641
R=vsm@google.com
Review URL: https://codereview.chromium.org//27308006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28758 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 23:09:33 +00:00
9f52a2969c
Added back childNodes and getAttribute and setAttribute.
...
This is a quick check to verify that it was this CL:
https://codereview.chromium.org/23189014/ was the cause of the performance
regression. If it is, I have some ideas of potential performance improvements
going forward that we should investigate, and I'll also investigate why I wasn't
getting this performance behavior on my machine locally. Either way, expect at
least one additional change on these APIs going forward.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23808005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27139 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 19:34:39 +00:00
b14e379d94
Cleaning up a bunch of DOM generation tables
...
Many unused keys and missing events, etc.
BUG=
R=efortuna@google.com , jacobr@google.com
Review URL: https://codereview.chromium.org//23889005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27137 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 18:30:54 +00:00
0bea9648e1
Fixing console.
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//23496029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26955 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 22:32:32 +00:00
013e3bb062
Dart binding changes to along with Blink merge 155942-156717
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23829002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26948 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:24:02 +00:00
90873051ad
Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
...
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23055008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
339b0bdd70
Attempt to land Dartium roll a second time.
...
BUG=
Review URL: https://codereview.chromium.org//23064024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26363 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 15:54:49 +00:00
c6ebe4e4e0
rollback problem blink merge cl
...
Review URL: https://codereview.chromium.org//23163010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26339 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:22:24 +00:00
785c8416bc
Changes required for Dartium roll
...
Merge checkpoint. Everything compiles.
BUG=
Review URL: https://codereview.chromium.org//22886009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26335 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 01:50:17 +00:00
83415ddfbb
Rerun go.sh
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//22682004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25957 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 00:52:30 +00:00
0094164ae8
Regenerating DOM types from IDL roll.
...
TBR=vsm
BUG=
Review URL: https://codereview.chromium.org//22352004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25849 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 00:57:08 +00:00
913b32693d
Regenerate dart_html after https://codereview.chromium.org/20174003/
...
BUG=
Review URL: https://codereview.chromium.org//20463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25494 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 20:14:36 +00:00
28541ed31f
Regenerate dart:html from new Blink IDL files
...
This includes some script updates. See:
https://codereview.chromium.org/19605006
for the IDL roll.
R=efortuna@google.com
Review URL: https://codereview.chromium.org//19789017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25456 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 00:08:44 +00:00
992776552a
Fixes for Blink roll.
...
TBR=jacobr@google.com ,asiva@google.com
Review URL: https://codereview.chromium.org//19820007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25395 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 04:46:29 +00:00
cc9f39dfba
Add back appendBlob and send variants in WebSocket.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//18850007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24854 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 17:26:51 +00:00
f81052f2c8
Reapply expanding overloaded functions into separate functions.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//18577002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24709 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 22:32:44 +00:00
3629744086
"Reverting 24655"
...
BUG=
Review URL: https://codereview.chromium.org//18277003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24656 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 21:09:19 +00:00
fc0df10d8b
Expand overloaded methods and optional parameters in the html library.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//16494002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24655 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 20:49:07 +00:00
e1221d88fc
Running go.sh
...
TBR
BUG=
Review URL: https://codereview.chromium.org//17572018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24376 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 23:32:58 +00:00
c0f342adcd
Fixing up previous CL to fix Dartium issues.
...
patch from issue 17453003
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//17550014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24354 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 17:49:25 +00:00
9a55dad88e
This is causing a build error on Dartium (conversion from unsigned long to GLenum).
...
TBR
BUG=
Review URL: https://codereview.chromium.org//17141011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24298 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 18:18:17 +00:00
7b4bd8fef5
Fixing an issue where EXTDrawBuffers.drawBuffersEXT was not getting generated.
...
Core issue is that sequences of typedefs aren't getting resolved properly, so it was treated as an unknown type.
Did a workaround, opened bug 11395 to track the core IDL parser issue.
BUG=11029
R=vsm@google.com
Review URL: https://codereview.chromium.org//17453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24296 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 17:34:21 +00:00
28560f4a06
Adding WebGL context events to Canvas.
...
BUG=9482
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16997002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24006 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 20:12:01 +00:00
c3636dc560
Mark canPlayType as unstable.
...
BUG=
R=amouravski@google.com
Review URL: https://codereview.chromium.org//16705005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23928 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 19:43:15 +00:00
d72387b95a
Updating metadata after Chrome rolls.
...
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16677011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23888 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 23:47:09 +00:00
09dab7ecf3
Fixing up element_types_test to work properly in checked mode, adding a few more element constructors.
...
Basically the constructors were failing in checked mode when they returned UnknownElement rather than the expected type. I adjusted the tests to account for this.
BUG=10796
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16409016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23885 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 22:42:12 +00:00
f1677b76c9
Blink IDL roll.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//16636003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23752 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-07 16:34:31 +00:00
7629d7f4d4
Partial support for new getters/setters declaration.
...
TBR=blois@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//16636002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23742 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-07 12:07:54 +00:00
bda041d474
Updating DOM metadata triage list for recent Blink changes.
...
BUG=
R=efortuna@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//15896022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23554 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 17:45:06 +00:00
1735f7a080
IDL roll and expectations fix
...
To the latest Blink.
TBR=blois
Review URL: https://codereview.chromium.org//16311002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23516 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 22:46:00 +00:00
8d750efbfe
Suppressing CustomElementConstructor.
...
Not hiding it yet, but marking it in the metadata as going away.
BUG=9902
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16153009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23424 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 16:34:01 +00:00
881e456c21
Cleaning up some DOM APIs which were marked as deprecated because they were moved or renamed.
...
There were basically two issues:
- localName and namespaceUri moved from Node down to Element.
- The transitionEnd event was polyfilled based on the deprecated webkitTransitionEnd event, so it was switched to the standard transtionEnd.
The Attr change was needed because the node map was using localName on Attr (inherited from Node), when it should have been using name. Attr is not actually exposed anywhere, so made it private.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//15814008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23423 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 16:31:09 +00:00
a1f522165f
Modernizing HttpRequest documentation.
...
Also fixing docs so they get applied to Dartium.
BUG=https://code.google.com/p/dart/issues/detail?id=10547
R=efortuna@google.com
Review URL: https://codereview.chromium.org//15819003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23303 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 19:33:06 +00:00
ecb5686319
Generating support annotations from DOM triage list.
...
This is applying the results of the detailed API triage I did to the support annotations for DOM types.
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//15074006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23159 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 17:14:47 +00:00
77ad8172f3
Exposing a number of new events.
...
These are all new events which we didn't have naming entries and event types for.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//15434003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22955 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-21 20:46:18 +00:00
1d6243bb18
Changes for the roll.
...
TBR=vsm@google.com
Review URL: https://codereview.chromium.org//15250010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22942 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-21 14:18:00 +00:00
vsm@google.com