38c0287019
[infra] Add vm-kernel-checked builder to the test matrix
...
Change-Id: If83bc9f95cf02f44d4cf88d8076fa490f78e6cd5
Reviewed-on: https://dart-review.googlesource.com/73200
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-09-05 15:31:58 +00:00
14dda998dc
[infra] Add dartkp-obfuscate builder to the test matrix ( #32229 )
...
Change-Id: I866e0ac6a4ce848d31d36667c712b381a5723098
Reviewed-on: https://dart-review.googlesource.com/72600
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-09-03 08:04:21 +00:00
9a243b35eb
Remove summary-related code from pkg/front_end/tool/perf.dart.
...
This was needed back when we thought the front end would be based on
the analyzer, and so we thought its performance characteristics would
depend on those of the analyzer summary mechanism. But since the
front end is not based on the analyzer, and the performance of the
analyzer summary mechanism is performance tested elsewhere, we can
remove this code. Removing it will make it easier to do some re-work
of summaries that is needed for Dart 2.1 support.
Change-Id: I4aa8b5251f26ba7fd59b99d325c66da642d410ed
Reviewed-on: https://dart-review.googlesource.com/71661
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-30 00:09:55 +00:00
f40ff153a9
Enable --use-fasta-parser with the analyzer by default.
...
Based on Devon's change at:
https://dart-review.googlesource.com/c/sdk/+/67090
Change-Id: I80b7943826e248bf37d9bbbb769330d24b0dd6ae
Reviewed-on: https://dart-review.googlesource.com/70160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
2018-08-28 19:29:17 +00:00
28f902744b
Disable the analyzer cfe bots.
...
Change-Id: I4cbe50cd552347a2be9098f1f583fae4a3a3daaa
Reviewed-on: https://dart-review.googlesource.com/71880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-08-28 16:25:16 +00:00
0a29264117
[VM] Remove vm_platform from the dart binary
...
- Remove vm_platform from the dart binary
- kernel isolate always compiles in strong mode
Change-Id: I4e3973fdaee0bda1c43244ea04673f253eaae249
Reviewed-on: https://dart-review.googlesource.com/65788
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2018-08-24 15:45:04 +00:00
51bed8a0ed
[test matrix] Add back --compiler=dartkb
...
This was removed by https://dart-review.googlesource.com/c/sdk/+/69970
but the --compiler flag isn't being picked up automatically. See e.g.:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8937641495482850608/+/steps/vm_tests/0/stdout
Change-Id: Ia0bd7d708c8e7f8ada536915b9147423b37bc4cf
Reviewed-on: https://dart-review.googlesource.com/70783
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2018-08-20 21:45:09 +00:00
e29176ea0d
Add --use-cfe and --analyzer-use-fasta-parser flags to smith:configuration
...
Use them in test_matrix.json for the analyzer builders.
Bug: https://github.com/dart-lang/sdk/issues/34151
Change-Id: I4abe0bcc8b62ee372df32c0402fad3cd9042cb27
Reviewed-on: https://dart-review.googlesource.com/70282
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2018-08-17 14:42:43 +00:00
a558e71b19
[infra] Re-add --dart2js-batch to dart2js builders in the test matrix
...
TBR=whesse@google.com
Change-Id: Icb64186f3fe9b6a2b7319334ec7e2b9e169fac66
Reviewed-on: https://dart-review.googlesource.com/70341
Reviewed-by: Alexander Thomas <athom@google.com >
2018-08-16 20:32:10 +00:00
54fc71ddca
[infra] Fix dart2js-csp-chrome builder
...
TBR=whesse@google.com
Change-Id: I9da1267d27e017ff4e13b27e823a7f27640c4561
Reviewed-on: https://dart-review.googlesource.com/70240
Reviewed-by: Alexander Thomas <athom@google.com >
2018-08-16 07:23:01 +00:00
e5dd9c44b4
Remove test.py flags from builders in test_matrix, use configuration instead.
...
The -n<named configuration> flag is being used instead of the
command-line flags in the test.py builder steps. Remove the unused flags.
Bug: https://github.com/dart-lang/sdk/issues/34066
Change-Id: I07a451273741618e23f85e900eac040e29c84c0a
Reviewed-on: https://dart-review.googlesource.com/69970
Reviewed-by: Alexander Thomas <athom@google.com >
2018-08-15 15:26:42 +00:00
59a68b5310
Merge the analyzer-use-cfe-linux, analyzer-use-cfe-mac, and analyzer-use-cfe-win bots.
...
Change-Id: I72c3e4c8154b5950793f8df9bcc3d48a793f73eb
Reviewed-on: https://dart-review.googlesource.com/70142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-08-15 14:35:11 +00:00
94f80d6ee5
[infra] Remove Dart 1 front-end builder from the test matrix
...
TBR=whesse@google.com
Change-Id: I55598120c81083cb83caa497d7792bb0438bf5d8
Reviewed-on: https://dart-review.googlesource.com/69964
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-08-15 10:29:01 +00:00
14f6fbb457
Fix test_matrix.json for dartkp product mode builder.
...
Mark a test slow that otherwise times out on dartdevc kernel mode.
Change-Id: Id27683c54982f9a6afd1e41f566dd12aa67040de
Reviewed-on: https://dart-review.googlesource.com/69962
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2018-08-14 17:18:02 +00:00
580f809949
Convert the current analyzer --use-cfe test results to language2 status file entries.
...
Change-Id: I39a1573b0c0e5c85524cb654a5febea09fb9577a
Reviewed-on: https://dart-review.googlesource.com/69720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-08-13 19:46:56 +00:00
d8e01be7d5
Update named configurations to agree with builder flags
...
Change-Id: I437c741ebeb684ce1660b3fcd80ab2aa756e501b
Reviewed-on: https://dart-review.googlesource.com/68882
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2018-08-13 12:09:47 +00:00
ba10df6611
[infra] Switch pkg bots to Dart 2
...
* Update named configs for unit tests to Dart 2.
* Bump json_rpc_2 in front_end package.
* Use named configurations in unit tests.
* Fix typing issues.
Change-Id: Id3b393a0d2abe92c8eaec10fa8057fb35d18a4c6
Reviewed-on: https://dart-review.googlesource.com/67341
Reviewed-by: Jens Johansen <jensj@google.com >
2018-08-13 07:04:06 +00:00
be6309690f
Analyze pkg/dart2js_tools on the bots.
...
Change-Id: I727012f8584a4d92d5333da303147a1c947d4fb6
Reviewed-on: https://dart-review.googlesource.com/69247
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-08-10 06:04:10 +00:00
af02ccae83
[infra] Fix filesets for new vm-kernel-precomp builders
...
TBR=whesse@google.com
Change-Id: I81a836d532a355db5e3a74a244af71605e0c04c3
Reviewed-on: https://dart-review.googlesource.com/69102
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2018-08-09 11:50:36 +00:00
7eda513405
[infra] Add new vm-kernel-precomp builders to the test matrix
...
TBR=whesse@google.com
Change-Id: Ia88f17cee0fb1f69d4bf17eb35dbdaa606aee71b
Reviewed-on: https://dart-review.googlesource.com/68942
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2018-08-08 17:19:27 +00:00
0986b2bfa2
Clean up test.py named configurations code
...
Drops the debug printing of configurations, and the checking
that the named configurations agree with the flags passed.
Change-Id: Id19ca002668a757d44017873a5d0c8bb06472564
Reviewed-on: https://dart-review.googlesource.com/68680
Reviewed-by: William Hesse <whesse@google.com >
2018-08-07 13:53:37 +00:00
e0f6fdfff1
Refactor testing:TestConfiguration to use smith:Configuration by inclusion.
...
Change-Id: I5c116ad082a24c25a07b9ceb6aaf8c9cbe3f11e3
Reviewed-on: https://dart-review.googlesource.com/68361
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2018-08-06 16:19:08 +00:00
42b02e02e7
Add more test steps to the analyzer --use-cfe bots.
...
Change-Id: Ifb756a9faf4c57bd8426b8d94a88e69d9cb890a0
Reviewed-on: https://dart-review.googlesource.com/68421
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-04 06:35:53 +00:00
5313553961
Run the analysis server 'analysis-server-cold' with --use-cfe.
...
Change-Id: Ia4774d9f01b723f36a9728487ddcabcdac854bdd
Reviewed-on: https://dart-review.googlesource.com/67940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-08-02 19:50:48 +00:00
b1c9b67b68
Add initial content for the analyzer --use-cfe builders.
...
Change-Id: Ic44cb58bcf664d244c510b52800eaebfbef9b391
Reviewed-on: https://dart-review.googlesource.com/67580
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2018-08-01 19:45:39 +00:00
2a23bc2e0b
Update named configurations on builders, turn off checking temporarily.
...
The named configurations aren't used yet, and checking that they agree
with the existing flags will now just print error messages, not make
the builder fail.
Change-Id: Ia0778855d3c45da8e3314f9cff0967ec1fc7893b
Reviewed-on: https://dart-review.googlesource.com/67807
Reviewed-by: William Hesse <whesse@google.com >
2018-08-01 16:50:41 +00:00
0fd93a5c6e
Test.dart exits with non-zero exit code if named configuration disagrees with flags.
...
Change-Id: I05e869c3f37aa786cd39185b51dda627133aa5e9
Reviewed-on: https://dart-review.googlesource.com/67805
Reviewed-by: Alexander Thomas <athom@google.com >
2018-08-01 16:01:16 +00:00
f10b4005cd
Code to load a named configuration and check it against the existing options.
...
First stab at loading named configuration, plus temporary test code
Change-Id: I5835fe34a024a6052021c8189629a1578bed2355
Reviewed-on: https://dart-review.googlesource.com/63880
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2018-08-01 12:55:13 +00:00
7413644de8
Change builder names from -ff- to -firefox-
...
Change-Id: I69317cb92364de2b38f7967cb3ce9e3b307c7678
Reviewed-on: https://dart-review.googlesource.com/67780
Reviewed-by: Alexander Thomas <athom@google.com >
2018-08-01 12:28:13 +00:00
cf77a3b00f
[Test.dart] Use Compiler, Runtime, etc. classes from pkg:smith.
...
Change-Id: I1251c94e87fe6953f7604b5ef8f6ae5c49ab36d3
Reviewed-on: https://dart-review.googlesource.com/67522
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2018-08-01 09:45:17 +00:00
3dc201e168
Update ChangeBuilder to not include empty edits (Take 2)
...
Combination of Brian's change:
https://dart-review.googlesource.com/c/sdk/+/63901
and Devon's change:
https://dart-review.googlesource.com/c/sdk/+/66405
Change-Id: I57e5d1f7d3a653f225aba2d690190fe1ff18a5b1
Reviewed-on: https://dart-review.googlesource.com/67344
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-07-31 13:44:06 +00:00
21db860271
Remove non-strong dart2js builders from test_matrix.json
...
Change-Id: I76c4a1f0df8f6e8f6ddd03fd35c9a069845687ef
Reviewed-on: https://dart-review.googlesource.com/67346
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-07-30 17:47:44 +00:00
3665cad81c
[infra] Shard analyzer unit tests
...
TBR=whesse@google.com
Change-Id: I8616b3674258cb4406ace7bd81d4a91df124ff83
Reviewed-on: https://dart-review.googlesource.com/66960
Reviewed-by: Alexander Thomas <athom@google.com >
2018-07-27 08:24:12 +00:00
1336802dee
[test] Adds a KBC configuration to the test matrix
...
This is to run on FYI
Change-Id: Ic62e858853a3ccb67d844ec454fd1819aa35b87d
Reviewed-on: https://dart-review.googlesource.com/65780
Commit-Queue: Zach Anderson <zra@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-07-26 22:05:06 +00:00
11784f6ef9
Run the dartanalyzer with --use-cfe.
...
Change-Id: Ib87c04d3469d0546ebbc6a5c903d5f022e9fb224
Reviewed-on: https://dart-review.googlesource.com/66342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-07-24 14:07:33 +00:00
c4d92dc5cf
Analyze the observatory on the bots.
...
Change-Id: I5e5992310b3886c95cfb0e7b13f177e09e721541
Reviewed-on: https://dart-review.googlesource.com/66182
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2018-07-23 18:15:49 +00:00
188ef5e3d5
Analyze all the pkg/ code on the bots.
...
Bug: https://github.com/dart-lang/sdk/issues/29318
Change-Id: Iccb16ddbccbb43fa7a12eb818c2dde3a75700b97
Reviewed-on: https://dart-review.googlesource.com/64663
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-07-12 16:35:03 +00:00
6b01ba7112
Update status for vm --checked (enable asserts) tests.
...
Remove accidental legacy test section from front_end bots.
Remove no-op --strong arg from test matrix.
Change-Id: Icafc7eeb3c25f5816596affeaf8f75a7328fb907
Reviewed-on: https://dart-review.googlesource.com/64520
Reviewed-by: Jonas Termansen <sortie@google.com >
2018-07-12 09:31:10 +00:00
54f66eebf2
[co19] co19 roll: DEPS and test_matrix update
...
Cq-Include-Trybots:luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Change-Id: I37f3b78180133c31f6267b76c3eeb16f8c00325a
Reviewed-on: https://dart-review.googlesource.com/63623
Reviewed-by: Erik Ernst <eernst@google.com >
2018-07-10 11:07:36 +00:00
550f294dfc
Move some analysis to analyzer-analysis-server-linux and make analyzer-analysis-server-linux a try bot.
...
Change-Id: Iabac78eb7bdbb3b1bc3ff83ae4ba241af1c8a6ec
Reviewed-on: https://dart-review.googlesource.com/64020
Reviewed-by: William Hesse <whesse@google.com >
2018-07-09 20:18:20 +00:00
c1f6c9d8c5
Fix dart2js-hostassert configuration and enable it on the CQ
...
TBR=athom@google.com ,whesse@google.com
Change-Id: I1dec1386b823bc72bc8f482c7400a129a3037b4a
Reviewed-on: https://dart-review.googlesource.com/63704
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-07-07 00:15:37 +00:00
1a08800dd6
Run analyzer --use-fasta-parser on the language2 tests; update status file.
...
Change-Id: I35ca9dceb211a30f7e211177956e3e62575f7e57
Reviewed-on: https://dart-review.googlesource.com/63686
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-07-06 14:20:26 +00:00
5b5e36f0be
Remove use of deprecated methods and constants.
...
Change-Id: Ic6867233dd7d432eaa0973dbfca13d53f15cc80a
Reviewed-on: https://dart-review.googlesource.com/63663
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-07-04 17:18:06 +00:00
1400cf66e7
Add named configurations to test matrix.
...
Change-Id: I259cd854a6ceb2ab2c2813184bfaae1fbc7b3f4e
Reviewed-on: https://dart-review.googlesource.com/62140
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2018-07-04 13:57:19 +00:00
9871ad23c9
[infra] Move fasta legacy mode SDK tests to their own builder
...
* This will take them of the CQ and lower CQ cycle time by ~15mins.
* The new builder will be enabled by:
https://dart-review.googlesource.com/c/sdk/+/63627
Change-Id: I9318f73a670aee1c67ae9ed19a1bc0a100c14411
Reviewed-on: https://dart-review.googlesource.com/63626
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-07-04 11:08:48 +00:00
6e8332bf77
Remove older analyzer bots.
...
Change-Id: I375f6a3f76bdb1fd8e9000e5edbc6bf21a148490
Reviewed-on: https://dart-review.googlesource.com/63643
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-07-04 03:43:07 +00:00
7007137dd0
Adjustments to dart2js test matrix.
...
* uses 6 shards for try bots like the recipes used to do
* add a strong-hostasserts configuration. Currently the test.py flag is called
--host-checked, but all it does is enable assertions (no more checked mode in
Dart2)
Change-Id: I50c565bb210fbb98334b7d84556c3ab98c38b22a
Reviewed-on: https://dart-review.googlesource.com/63682
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-07-03 20:30:56 +00:00
46bfa7297e
Have the regular analyzer bots test in dart 2 mode.
...
Change-Id: I91bf09600d0e5f099737be0363228cad6d0b5329
Reviewed-on: https://dart-review.googlesource.com/63642
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2018-07-03 19:12:36 +00:00
aa009339b3
Update test matrix for dart2js
...
After reviewing all recipes, we needed a few changes to bring the test matrix to parity:
- we needed to add strong-mode coverage (mostly in d8 at this time)
- we needed to add fast-startup coverage on all browsers
This however includes a bit more coverage than the existing recipes:
- strong-mode coverage in d8 now includes all suites, not just language_2 and corelib_2
- legacy coverage in ie11 includes all suites, not just html and co19
Next steps:
- move the remaining dart2js bots to the test matrix using the existing and new builders
- fix .status files on builders that include more suites (d8-strong + ie11)
- fix .status files on new Dart 2.0 builders
- add new Dart 2.0 builders to the waterfall
- eventually remove Dart1 builders.
Change-Id: Iec0a7fef7176cc81d3ced5e34c8dd63d33b7079e
Reviewed-on: https://dart-review.googlesource.com/61086
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2018-07-03 18:32:53 +00:00
c407e83d0e
Delete duplicate key "configurations" in test_matrix.json
...
The builder configurations have been moved to the "builder_configurations" key,
and the "configurations" key will be used for test configurations.
Change-Id: Ic61f1646378a13526dc59b713f272cea51d9781b
Reviewed-on: https://dart-review.googlesource.com/63580
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2018-07-03 12:02:31 +00:00
Alexander Thomas