Commit Graph

17 Commits

Author SHA1 Message Date
Alexander Thomas 04e7766ffb [infra] Use set -x in flutter scripts
Change-Id: I3f938b4279aee7d4cd19e08e7c90c3ddba570e5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192747
Reviewed-by: Jonas Jensen <jonasfj@google.com>
2021-04-13 07:24:44 +00:00
Jens Johansen 8270944c5d [CFE] Extend weekly test - fuzz tests and advanced invalidation leak test
We currently run our leak tests weekly.
This extends it so we also run leak tests with advanced invalidation,
as well as our strong and weak tests with fuzzing enabled.

Change-Id: I2c941f58594791d1981c6b6612db2205b68f5e19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192682
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2021-03-24 14:44:51 +00:00
Lasse R.H. Nielsen d352bc28b8 Remove (most) uses of the "non-nullable" experiment flag.
Since the flag is now enabled by default, there should be no mention of it.
There are still some uses in front_end/testcases that are not just removable
(it also uses `no-non-nullable`). There migth be more uses that are not
as easily found as grepping for `--enable-experiment

Removes two VM tests where fixing them meant they were just duplicating
the corresponding non *_2/ tests.
Fixes #44941

TEST= Large number of tests chaged.=(no-)?non-nullable`.

Change-Id: Ief755981ccde9a5482fcdf408c2929c74433a710
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183688
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2021-02-12 17:16:54 +00:00
Clement Skau 2d36c85ff8 [vm] Removes support for --causal-async-stacks
All existing embedders have been opted into --lazy-async-stacks, the
VM also uses it as it's default in all configurations.

After this CL, any user of --causal-async-stacks will get an error
message when trying to use it.
=> In any such case, please simply remove the flag.

TEST=Exhaustive CQ.

Bug: https://github.com/dart-lang/sdk/issues/37668
Change-Id: Ia440afcf2dba464aa8b8cf381b93bbac8eb9f8dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172564
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Clement Skau <cskau@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2020-12-01 07:27:14 +00:00
Jens Johansen 29fa4e8148 [CFE et al] Compile flutter platform as agnostic for test; set component mode more
Bug: dartbug.com/43844 dartbug.com/43807
Change-Id: Iba662f0955897244aaac86ceace73b213fa06319
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168482
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2020-10-21 10:04:41 +00:00
Alexander Thomas 7309343e5c [infra] Checkout Flutter buildroot in flutter-frontend as well
Fixes https://github.com/dart-lang/sdk/issues/43807

Change-Id: Idacc71c2c165af768274e4f40ce61b78c2d46ba0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167806
Reviewed-by: Jonas Termansen <sortie@google.com>
2020-10-16 12:18:25 +00:00
Jens Johansen 13de7e7560 [CFE] Add first stab at weekly leak test
Change-Id: Ib0307a4d82414e8387f65a9010a6f0f91827c3bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157962
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2020-08-11 09:01:29 +00:00
Leaf Petersen d44457f79d [Core Libraries] Eliminate the fork in the core libraries.
Move the nnbd core libraries from sdk_nnbd to sdk, and updates
references in build files and elsewhere accordingly.

Change-Id: I09760fe1e006657aacdfe80f3b22fdf6f7e30a9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151121
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-06-16 23:37:36 +00:00
Clement Skau f599b7951f [SDK] Clean up compile_flutter.sh a bit for readability and robustness.
Change-Id: If45661582f108c64dbf08b7f9e755ad6bff10344
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147910
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2020-05-18 09:25:34 +00:00
William Hesse 2fd798ed5c Change flutter builder to build flutter libraries in weak mode
The flutter libraries are not yet null-safe, and the --null-agnostic
flag gives the error:
flutter/lib/ui/ui.dart:12:1: Error: A library can't opt out of non-nullable by default, when in nnbd-strong mode.

Change-Id: I3cc64205a1c7ae2e77a0ff2ae88f9187d1880926
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148125
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2020-05-15 07:13:50 +00:00
Jens Johansen 658feaca7c Fix flutter-frontend bot by updating script to NNBD
Change-Id: I733674466f0dfd91ae96d0246a804a7d06335824
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147904
Reviewed-by: Clement Skau <cskau@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2020-05-13 14:12:41 +00:00
Jens Johansen 8652404193 [flutter-frontend-test] Run flutter-frontend compile tests in custom test runner
Change-Id: Iecf2f40dd1bc8c0fffd877911e81ccd6055d9dc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136121
Reviewed-by: Karl Klose <karlklose@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2020-02-18 10:58:59 +00:00
Jens Johansen 128771af8a [CFE] Version 2 of incremental compiler invalidation strategy
Change-Id: Iff860e2665dee64fc005a50237ae890986ddb0f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127896
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2020-01-16 07:50:39 +00:00
Alexander Thomas cb94390c63 [infra] Improve efficiency of cloning the Flutter repositories
Sometimes the flutter-analyze builder is flaky because cloning Flutter
exhausts the "short term ls-remote rate limit". "--single-branch"
reduces how many remotes need to be fetched.

Also in this CL:
* Use dart.googlesource.com.
* Apply the same changes to the flutter-frontend builder.

Error example:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8894556948308224672/+/steps/analyze_flutter/0/stdout

Change-Id: I50df781a652602c7dd1b40b938c558b04bd3f86f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127642
Reviewed-by: Jonas Termansen <sortie@google.com>
2019-12-09 17:50:04 +00:00
Jens Johansen aece1c1e92 Update compile_flutter.sh after vm -> frontend_server rename
This will hopefully make the flutter-frontend bot green again.
This can be seen as a follow up to
https://dart-review.googlesource.com/c/sdk/+/120321
where the test was moved.

TBR.

Change-Id: Ia5915dfdf29ac2d6b8b15c8eb976e590dc3e3d37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120640
Reviewed-by: Jens Johansen <jensj@google.com>
2019-10-08 06:56:21 +00:00
Jens Johansen 2a94546f94 Fix flutter-frontend bot and future problems in flutter HHH bot
Two things before this CL was wrong:
* The script didn't apply paches
* The patch we needed to apply wasn't applied because a dart roll in the
  engine was done basically at the same time that the change requiring
  the patch was landed. The dart-roll did not include it, but the change
  applied the patch the the before-dart-roll-dart-version.

This CL fixes it by applying patches in the flutter-frontend script,
and copying the patch to apply to both dart-revisions.

Change-Id: If3187090778c59cf0ebdf7ab4858189c6b8904b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117941
Reviewed-by: Jens Johansen <jensj@google.com>
2019-09-19 06:59:21 +00:00
Jens Johansen 51433e65cc Compile flutter tests via the sdk
This CL includes:
* A dart script that - given a flutter checkout - finds and compiles
  tests to ensure we actually can.
* A shell script that checks out flutter, compiles the platform
  (to cope with any changes to the kernel format) and runs the above
  script.

Change-Id: I02806a375943361c3c111d9aa12a76d745391ca3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98140
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2019-04-11 08:38:53 +00:00