dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

21307 Commits

Author SHA1 Message Date
Zichang Guo 18bf8c3560 [dart:io] Fix empty Process.run arguments on Windows 
Closes https://github.com/dart-lang/sdk/issues/40060
Change-Id: I3d8c15efea3b24a628846b090701ffd245f09651
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143700
Commit-Queue: Zichang Guo <zichangguo@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2020-04-17 20:12:54 +00:00
Liam Appelbe 0d1b98f325 [nnbd] Fix some corelib/list strong mode tests 
Change-Id: Ibc2d58ad384e08794d27c96dd0a8c1de56c343ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143842
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2020-04-17 19:29:24 +00:00
Mayank Patke 4e0c699cc4 [dart2js] Update DartType printing of generic function type parameter 
bounds to match runtime behavior.

Change-Id: I745a6a84b6d9fc1e0d9c3cc0ded673bafa6ddcd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143863
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2020-04-17 11:14:36 +00:00
Johnni Winther 29ac98ea46 [test] Remove use of List constructor in corelib tests 
Change-Id: I00777f1db859d075f7dfda21a72e7982d155747e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142371
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2020-04-17 08:45:46 +00:00
Liam Appelbe 2e75c3d7ca [nnbd] Fix remaining async tests in strong mode. 
stream_controller_async_test and stream_join_test are built on
async_minitest, so most of the issues were fixed by migrating it to use
Never as the bottom type rather than Null.

Change-Id: I6f43e818a7a8d6793844166c8f9fc07b3b0f7a16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143562
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2020-04-16 21:15:45 +00:00
Nate Bosch 0416cfd075 Add a static error test for default catch type 
Static error test for https://github.com/dart-lang/language/issues/922

If the type of the error argument was `dynamic` there would be no error
for calling a method that does not exist.

If the type of the error argument was `Object?` there would be an error
for the call to `_takesObject`.

Change-Id: I3cec1a8ae2903887e5da086cdeecd4008ef5d667
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143329
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-16 20:52:45 +00:00
Alexander Markov 12c8b02c84 Reland "[vm/aot/tfa] Tree shake write-only fields" 
This relands commit ff34fd8110,
but puts tree shaking of write-only fields under the flag which is
disabled by default.

So far tree shaking was removing fields which are not used at all.
This change improves tree shaking of fields so fields
which are only written or used as interface targets can be removed.

The following limitations apply:

* Field is not removed if there is a constant object with that field, as
  it may impact identity of constant objects which is an observable
  behavior.
* Instance field is not removed if it has a non-trivial initializer as
  it may have side-effects when executed by constructors.
* Late final fields are not removed, as writing such fields may have
  side-effect.
* When field is removed, we may need to introduce an abstract getter
  or abstract setter if field is used as a target of an interface call.
  If a field was written, then setter would be non-abstract (but empty).

Issue https://github.com/dart-lang/sdk/issues/35310

Change-Id: Iec75b8301892664f4f955a01e5960b17e6620531
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143286
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2020-04-16 18:24:05 +00:00
Johnni Winther 2d12821cba [test] Fix various static errors in corelib tests 
Change-Id: I762538437b8f68f20c149b737cbe65f212c5c3b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142370
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2020-04-16 09:20:21 +00:00
Srujan Gaddam 983f882180 [dart:html] Play videos in draw_image_video_element_test 
draw_image_video_element_test creates VideoElements, which the current
frame is taken from when drawing to a CanvasElement. The test was
waiting on the onCanPlay event of the VideoElement before drawing,
although this might mean the video won't actually start playing. This
fixes that issue by enabling autoplay and then awaiting the play Event.

Change-Id: I100a552a1eb8e88b6b368d88e499f62f2db8e831
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143621
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-16 00:23:23 +00:00
Joshua Litt 1ffc11c7dc [dart2js] Fix for generic_method_type_test. 
Change-Id: Icfe460e2abd01a6e2cd4b0bf67709ab44be3881f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143560
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2020-04-15 19:42:04 +00:00
Liam Appelbe 8829ddc992 [nnbd] Fix the remaining futures tests in strong mode 
Change-Id: I5c388b3321a18f62b225d68c295b8d55ab2651fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142994
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-04-15 18:30:23 +00:00
Johnni Winther da95c79901 [cfe] Handle nnbd is-test in constant evaluation 
+ detect ~/ evaluation errors

Change-Id: Ic3f979c7516ed9aa2da0eab8b8d902987107c189
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142982
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-04-15 17:29:43 +00:00
Leaf Petersen 6d88b04a89 Fix incorrect instance checks. 
Several instance checks added during the null safety core library
migration were incorrectly rejecting null values in places where null
values can still flow in legacy mode.  This eliminates the instance
checks in favor of casts which will behave as desired.

Bug: https://github.com/dart-lang/sdk/issues/41465
Change-Id: I50fb9e6cef41d645d5312871932c7168f2d80c29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143333
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2020-04-14 19:25:45 +00:00
Liam Appelbe 3083050258 [nnbd] Fix some IO strong mode tests 
Fixes:
standalone/io/directory_test
standalone/io/file_test
standalone/io/http_read_test/*
standalone/io/http_reuse_server_port_test/*
standalone/io/http_server_early_client_close_test/*
standalone/io/regress_8828_test/*
standalone/io/socket_cancel_connect_test/*
standalone/io/socket_finalizer_test/*
standalone/io/web_socket_typed_data_test/*

Change-Id: I46b7d8691b66222b61b72bfe4d29ce81fadf511f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143182
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-04-14 18:03:55 +00:00
Johnni Winther dc97454b63 [analyzer,cfe,dart2js] Add pretty printing to id testing 
Adds support for pretty printing verbose annotations.
Adds support for force updating annotation texts useful for applying
the pretty printing to valid annotations.

Change-Id: I8fe9b6d2f8198bd5e160854053c8d964ef832a8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129710
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-04-14 13:24:09 +00:00
Srujan Gaddam 53296536de [dart:html] Add back lib/html/input_element_attributes_test 
Now that TextInputElement.value accepts a nullable value, this test
can be added back to test null behavior.

Change-Id: Ia17554314f25c5d09e113bb5c9c0a6b6f1cb1c03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143190
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-14 00:37:41 +00:00
Srujan Gaddam 09e47b6177 [dart:html] Copy test resources from lib_2 to lib 
Some none Dart files were not copied over in the migration. Tests
are refactored to use the lib version over lib_2.

Change-Id: I21053d81770c4f83b01f27af99cec11f08577c7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143330
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-04-13 23:56:08 +00:00
Liam Appelbe b65704e817 [nnbd] Fix lib/async/future_test in strong mode 
Change-Id: Idaa06e9824c81009a0c719b9c1f8f698af104309
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143306
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-04-13 23:43:58 +00:00
Riley Porter 17f5dcb336 [tests] Fix CompileTimeErrors in migrated tests. 
Fixes:
lib/math/rectangle_test
lib/convert/utf8_test
lib/convert/utf8_encode_test
lib/convert/streamed_conversion_utf8_encode_test
lib/convert/streamed_conversion_utf8_decode_test
lib/convert/streamed_conversion_json_utf8_encode_test
lib/convert/streamed_conversion_json_utf8_decode_test
lib/convert/json_lib_test
lib/convert/encoding_test
lib/convert/chunked_conversion_utf8_test
lib/convert/chunked_conversion_utf85_test
lib/convert/chunked_conversion_utf84_test
lib/convert/base64_test/none
Change-Id: I9d540e2bc908ac2ac74e42fc1b2eb4c729371c96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143183
Commit-Queue: Riley Porter <rileyporter@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-04-13 22:42:51 +00:00
Ben Konyi dc9f500960 Reland "[ VM / DartDev ] Fixed issue where trying to find the directory of the Dart executable would fail if we encountered a relative symlink while trying to determine the absolute path." 
This reland contains fixes related to: https://github.com/dart-lang/sdk/issues/41329

This reverts commit 05e43cff92.

Fixes: https://github.com/dart-lang/sdk/issues/41329
Change-Id: I1abef994cf6ffbac7e5c6bddd6de15f4f53535ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142440
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2020-04-13 21:11:52 +00:00
Konstantin Shcheglov 21f42b4305 Fix covariant/return_type_test 
Change-Id: Ie71d0579ed52af187dacc8f642425866da6a2d2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143246
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 18:18:22 +00:00
Konstantin Shcheglov 7ed155ff49 Update analyzer expected error range for language/operator/invalid_operators_test. 
Change-Id: I1acbbfd8dd173f90a49231577c67678d94040c8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143247
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 18:00:37 +00:00
Konstantin Shcheglov ec3dd52462 The type 'dynamic' is defined in dart:core. 
This makes fixes to analyzer and update the test for updated spec.

Change-Id: Ie5222bcf9056d5cbb7f18437dec04d5af21ff314
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 17:55:36 +00:00
Sam Rawlins 638523c3e1 analyzer: Fix addtional language test 
which was broken by https://dart-review.googlesource.com/c/sdk/+/143248

Change-Id: Id14c6583a2838f85d21da56575aa2ecaf538160a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-04-13 17:27:51 +00:00
Sam Rawlins c9710e5059 analyzer: Do not report on a bad type of return expression if function has illegal return type 
Fixes #38188 and fixes #41439

Change-Id: Id6339529afba331750858fb34771bed627ece0be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143248
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-13 03:42:35 +00:00
Konstantin Shcheglov 23a8788f6a Issue 41378. Update on-catch and throw for the spec changes. 
Now it is not an error to use a potentially nullable type in on-catch.

But it is an error for throw an expression of type that is not
assignable to Object.

Bug: https://github.com/dart-lang/sdk/issues/41378
Change-Id: If0a198ae618cd01d03f45a46aa1efa6179df76ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-11 20:08:03 +00:00
Stephen Adams 9e2c8ef000 [dart2js] Add --dump-ssa option 
The dart2js option --dump-ssa=pattern outputs the SSA CFGs for methods
with names matching the RegExp 'pattern' to a '.cfg' file alongside
the javascript output, e.g. 'main.js.cfg'.

To dump all CFGs, use --dump-ssa=.

Change-Id: I8227232d9950bf3d30df0c87709b0c24e8944759
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143082
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-04-10 21:02:14 +00:00
Ryan Macnak 4978dcc928 Reland "[vm, gc] Parallel scavenge." 
Fix ScavengeVisitorBase::HasWork to account for undone allocations.

Bug: b/153524644
Change-Id: Ifc30017a411c5b65716d4e38752f2edeeb80a77e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142908
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2020-04-10 19:27:04 +00:00
Leaf Petersen b135aab6d7 Fix bad test expectation, convert to static error test 
Change-Id: I821dd3af8c1be346d983bd41bb80efefba176cd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143102
Auto-Submit: Leaf Petersen <leafp@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-04-10 18:07:44 +00:00
Konstantin Shcheglov 450ae848f6 Applying a mixin replaces corresponding names in the interface. 
Change-Id: I5e2ada71af50aa580f5d236773ccb122fca5591c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 15:57:44 +00:00
Konstantin Shcheglov 2854d6f4c0 Add the analyzer error on return in language/async/or_generator_return_type_stacktrace_test 
Change-Id: If3e6b9c62c53389c428149ef6ff267b4cf6cfaf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143010
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-10 15:54:24 +00:00
Leaf Petersen 9a51d7003d Fix top_merge tests. 
Fix several issues causing spurious errors in the top_merge tests and
remove one test file for which there is not a sensible resolution of
the issues.

Change-Id: Ia7fcdc02c0461980bae99cdbdc78bfac18d3efb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142887
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
 2020-04-10 01:05:41 +00:00
Leaf Petersen e8ff0c884e Add tests for null safety boolean conversion. 
Tests for the null safety spec clarification landed in
https://github.com/dart-lang/language/pull/917 .

Change-Id: Ieafe5315c31919c01ff816a26d29fa0d1cbc8c9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142782
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-10 00:46:06 +00:00
Liam Appelbe 428b3c4473 [nnbd] Fix some async tests in strong mode 
Fixes:
lib/async/catch_errors6_test
lib/async/catch_errors7_test
lib/async/catch_errors8_test
lib/async/catch_errors_test
lib/async/intercept_print1_test
lib/async/intercept_schedule_microtask1_test
lib/async/intercept_schedule_microtask2_test
lib/async/intercept_schedule_microtask3_test
lib/async/intercept_schedule_microtask4_test
lib/async/intercept_schedule_microtask5_test
lib/async/intercept_schedule_microtask6_test
lib/async/run_zoned7_test
lib/async/run_zoned8_test
lib/async/stream_controller_test
lib/async/stream_event_transformed_test
lib/async/stream_from_iterable_test
lib/async/stream_single_test
lib/async/stream_single_to_multi_subscriber_test
lib/async/stream_state_nonzero_timer_test
lib/async/stream_state_test
lib/async/stream_transform_test
lib/async/stream_transformation_broadcast_test
lib/async/stream_transformer_from_bind_test
lib/async/stream_transformer_from_handlers_test
lib/async/zone_future_schedule_microtask_test
lib/async_star/await_for_test
lib/async_star/await_pauses_test
Change-Id: I9d5d92938c28cc8131c70665ead4d44ffcff6bc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143001
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-09 22:01:42 +00:00
Robert Nystrom 07e606ec65 Migrate language_2/dynamic to NNBD. 
Change-Id: I51434a653b5b9ef65a185dc11cdff2aa9ab3e359
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142546
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-04-09 21:27:22 +00:00
Robert Nystrom bcf8a7fc51 Migrate language_2/enum to NNBD. 
Change-Id: I6d1045d95d0ea1c7e9a1f9fa8524687ed4dd8480
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142562
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-09 14:47:19 +00:00
David Morgan fb0902a05d Revert "[dart:io] Preserve header case in http header _builds()" 
This reverts commit af19f9638d.

Reason for revert: Breaks package:shelf tests.

Original change's description:
> [dart:io] Preserve header case in http header _builds()
> 
> Bug: https://github.com/dart-lang/sdk/issues/33501
> Change-Id: I57d9bba251b76314bf40b81d1b09bd4643dce4d2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141911
> Commit-Queue: Zichang Guo <zichangguo@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Reviewed-by: Jonas Termansen <sortie@google.com>

TBR=sortie@google.com,asiva@google.com,zichangguo@google.com

Change-Id: I9c0418a256cb53e415ed0d5aeab84c4b0b4a161d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/33501
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142980
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
 2020-04-09 10:38:29 +00:00
Zichang Guo af19f9638d [dart:io] Preserve header case in http header _builds() 
Bug: https://github.com/dart-lang/sdk/issues/33501
Change-Id: I57d9bba251b76314bf40b81d1b09bd4643dce4d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141911
Commit-Queue: Zichang Guo <zichangguo@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2020-04-09 06:37:28 +00:00
Robert Nystrom a7e3c5507f Migrate language_2/final to NNBD. 
Change-Id: I20328968f057658d4cb25e2a51a02745af3af211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142885
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2020-04-09 00:00:26 +00:00
Liam Appelbe b6fe74234b [nnbd] Fix a mirrors test in strong mode. 
Change-Id: I5d11e6b8d3662f9ff57f4720b2554b57391a4e4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142903
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2020-04-08 21:14:14 +00:00
Zichang Guo 8f7b40be77 [dart:io] Throw a FormatException when filters receive bad data. 
Bug: https://github.com/dart-lang/sdk/issues/41270
Change-Id: Ie4de46129d6fe6ba00fde27f6c1c96cc3f42c888
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141914
Commit-Queue: Zichang Guo <zichangguo@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2020-04-08 20:38:34 +00:00
Leaf Petersen 8e5e74e7c9 Test TOP_MERGE on super-interfaces. 
Test that TOP_MERGE correctly resolves multiple super-interfaces.

Change-Id: Iba7b4c63cb21ce8ffe1c82b235668c3c3f0f0e05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141847
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-08 20:21:08 +00:00
Leaf Petersen 5ba1b3f904 TOP_MERGE member override tests. 
Tests for member signature resolution as specified in this change:
https://github.com/dart-lang/language/pull/904

Change-Id: I7ee81dd1927b8f9419082f9bd2cbec14f0a5c0f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142802
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-08 20:19:52 +00:00
Srujan Gaddam 114752421d [dart:html] Remove multitest usage in some js tests 
Multitest usage that didn't involve separating out failures is
removed. Static errors are changed to static error tests.

Change-Id: I81d7409ead0005b9788ac80d229ac534279f1658
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142543
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-08 20:05:36 +00:00
Robert Nystrom a1e2a2c76a Migrate language_2/factory to NNBD. 
Change-Id: Icc5193e503d8f7d9da240cb2ba4b22edc7290dbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142801
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-04-08 19:18:14 +00:00
Robert Nystrom 8e9d1445dd Migrate language_2/field to NNBD. 
Change-Id: Ic0c7e51d6be12dba4500f0fc41378466c6043245
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142803
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-08 19:16:25 +00:00
Nicholas Shahan aa47d74666 [ddc] Run modular test suite in weak mode 
Preparation to unfork the SDK.

- Added the test suite to run in weak mode. Need to assess how we
  want to migrate these tests in the future.
- Updated one test to be legacy/nnbd agnostic.
- Update step names from DDK to DDC.

Change-Id: I0d2f1218c9acad82ab70dd525b0a0ad3cdc2ca92

Issue: https://github.com/dart-lang/sdk/issues/40266
Change-Id: If92e7778984de6a5a049faaf421a069c6f492b36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142557
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-04-08 18:25:14 +00:00
Martin Kustermann 13c84d8794 Revert "Reland "[vm, gc] Parallel scavenge."" 
This reverts commit 898b080d09.

Reason for revert: Seems to cause crashes in g3, see b/153524644.

Original change's description:
> Reland "[vm, gc] Parallel scavenge."
> 
> Remove header access from typed data case in RawObject::HeapSizeFromClass.
> 
> Address data race between visiting remembered cards and allocating new large pages for promotion.
> 
> Change-Id: I92cc4604ed38ab8f42b87b140a26a8118e7030d4
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142565
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>

TBR=kustermann@google.com,aam@google.com,rmacnak@google.com,asiva@google.com

Change-Id: I3ef7bd5c3d0ca575f33cf5f712f58476037d2d90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142861
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2020-04-08 14:21:32 +00:00
Nicholas Shahan 8064c1c342 [ddc] Add typeRep<T>() to inline an unwrapped type directly 
Also add `legacyTypeRep<T>()` that is similar but performs
a shallow conversion to a legacy type.

Using this in compiler/dartdevc_native/ tests gives a better usability
instead of constantly wrapping and unwrapping types. It allows us to
avoid stripping off the legacy from a type when calling `wrapType()`.

Issue: https://github.com/dart-lang/sdk/issues/40266
Change-Id: I07225f18c253222b31203b0b110233a3e018a7d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142547
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-04-08 00:03:38 +00:00
Nicholas Shahan 652dc2d0d6 [ddc] Rename test so it actually runs as a test 
This test isn't running in any configuration because the filename
doesn't end with "_test.dart".

Change-Id: Idf38c9dd643da36ce6b6cc587d609d7d9e707af2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142781
Reviewed-by: Riley Porter <rileyporter@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-04-07 23:41:18 +00:00