a5f8ddac99
[VM/runtime] Introduce a trail in IsSubtypeOf() to avoid cycles.
...
Clean up signatures of runtime functions in object.{cc,h} using the trail to avoid cycles. Move the trail to the last parameter of these functions.
Introduce a trail in IsSubtypeOf() to avoid cycles introduced by bounds of F-bounded types. Issue uncovered by the new normalization tests.
Change-Id: I3241c7e4023a09c122e1594b7aff90b5b103f4f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150180
Commit-Queue: Régis Crelier <regis@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2020-06-05 19:57:46 +00:00
99564b09b4
Migrate language_2/null to NNBD.
...
Change-Id: I9336b7fa58c144c8b946e7aac3128a9d9925d7d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149787
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-06-05 18:59:56 +00:00
062cd60ee2
Migrate language_2/number to NNBD.
...
Change-Id: Ie2bdcec491603f231a762ad211ba1d087a4c5c94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150000
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-06-04 23:07:53 +00:00
451694e855
[dart2js] Move dart2js_native to dart2js/native.
...
Change-Id: I2f879fe18376b8c1b82fc201d488425dc154d2b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149341
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Joshua Litt <joshualitt@google.com >
2020-06-04 18:11:49 +00:00
7112027a9d
Unlink file before Unix socket binds
...
Previously, an unix domain socket will be cleaned up within Socket's
finalizer. But if processes are killed, the file(socket) will remain and
prevent following bind().
Throw an exception when the file exists and no
active sockets has the same path.
Closes https://github.com/dart-lang/sdk/issues/42103
Change-Id: Ieb04b9e1b197064531ab6361c027b374c3d44411
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149081
Commit-Queue: Zichang Guo <zichangguo@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2020-06-03 22:10:40 +00:00
d6595b3f7c
Migrate language_2/nosuchmethod_forwarding to NNBD.
...
Change-Id: I1837a9ed07ad538960d58025440f0017bed4fd21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149786
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-06-03 19:55:36 +00:00
6ab36f85b0
Migrate language_2/mixin_constructor_forwarding to NNBD.
...
Change-Id: Iaebf433596e3849c9e7dd9c9e066234c8db738e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149621
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2020-06-03 17:35:05 +00:00
65032b4e4e
Migrate language_2/no_such_method to NNBD.
...
Change-Id: I5bae11c115c7ee2c9a581ce71f2d29203b92f923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149783
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2020-06-03 17:15:10 +00:00
05ca544f15
[dart2js] Move tests/compiler/dart2js_extra to tests/dart2js_2.
...
Change-Id: Iaa0ca2b4f2d1b15f79ddca37834d3ed2497bc068
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149242
Commit-Queue: Joshua Litt <joshualitt@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-06-03 15:15:30 +00:00
c10e96ba2f
Migrate void tests to Null Safety.
...
Change-Id: I9daeebde586a00169bdaf069c7dc2fdc5d3d97f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147160
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-06-03 13:22:10 +00:00
14bff8387c
Migrate language_2/malbounded to NNBD.
...
Change-Id: Id54702f10e5f0eb22de0e57533d20d158a9a4b23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149560
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-06-03 01:17:26 +00:00
44914f5eba
Migrate language_2/new to NNBD.
...
Change-Id: Id3a078523127c19b525423d27923efab7c2a0139
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149782
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2020-06-03 01:01:08 +00:00
ad0695e418
Migrate language_2/method to NNBD.
...
Change-Id: Iebd7e251849c807eda98976dd20542b8b4206950
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149491
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-06-03 00:56:28 +00:00
9370281400
Migrate language_2/list to NNBD.
...
Change-Id: Ia12f714f41ad9bd9e6c0ddf051a8e05ab2d6282b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149392
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-06-03 00:14:48 +00:00
d839eb7bf9
Migrate language_2/mixin to NNBD.
...
Change-Id: I4501e9a9d2d958cecf21460b628d2ac50a5135bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149492
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-06-03 00:05:18 +00:00
b2756b0580
[tests/nnbd] Remove mixed mode test cases from language/nnbd/subtyping/type_casts_strong_test
...
Now we cannot have a mix of opted-out and opted-in libraries in
strong mode, so we can remove all test cases for mixing legacy
types with nullables and non-nullable types from type_casts_strong_test.
Fixes https://github.com/dart-lang/sdk/issues/42108
Change-Id: I4a4eb5af732575e9a5b20b0029812852759dd15a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149740
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-06-02 19:46:38 +00:00
4489805956
Revert "[dart:io] Fixes the FileIO performance regression"
...
This reverts commit ba25fd190ehttps://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8878578963299042720/+/steps/build_dart/0/stdout?format=raw .
Unimplemented handling of missing static target.
Original change's description:
> [dart:io] Fixes the FileIO performance regression
>
> Previous CL (https://dart-review.googlesource.com/c/sdk/+/139881 ) causes
> performance regression.
>
> Improves:
> FileIO_readwrite_512kb: 196.5%, 224.1%
> FileIO_readwrite_verify_512kb: 38.28% 46.71%
>
>
> Change-Id: I5fb7752f14a2b39238e82bf45b059fe145b9087f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148563
> Commit-Queue: Zichang Guo <zichangguo@google.com >
> Reviewed-by: Martin Kustermann <kustermann@google.com >
> Reviewed-by: Jonas Termansen <sortie@google.com >
TBR=sortie@google.com ,kustermann@google.com ,zichangguo@google.com
Change-Id: I170eeed56484f2ece3c3b7f1b93f54edf5ae2736
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149743
Reviewed-by: Zichang Guo <zichangguo@google.com >
Commit-Queue: Zichang Guo <zichangguo@google.com >
2020-06-02 19:14:05 +00:00
ba25fd190e
[dart:io] Fixes the FileIO performance regression
...
Previous CL (https://dart-review.googlesource.com/c/sdk/+/139881 ) causes
performance regression.
Improves:
FileIO_readwrite_512kb: 196.5%, 224.1%
FileIO_readwrite_verify_512kb: 38.28% 46.71%
Change-Id: I5fb7752f14a2b39238e82bf45b059fe145b9087f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148563
Commit-Queue: Zichang Guo <zichangguo@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2020-06-02 17:47:05 +00:00
9d6fd6e25d
Migrate language_2/metadata to NNBD.
...
Change-Id: I0243e6112ea3dc31e69a2c1395e08575ab5cb276
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149561
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-06-02 16:45:26 +00:00
e1ece8fcbc
Migrate language_2/malformed to NNBD.
...
Change-Id: I5680d43fd7128ea3c8d95d86bf62bbb21f4273a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149489
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-06-02 16:41:11 +00:00
665c58aa1a
[cfe] Disallow void in await expression
...
Closes #41602
Change-Id: I29b8880e3fdb769b2acdf2c82a9ced038d7b0d94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149287
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-06-02 08:20:31 +00:00
0f94cff912
[dartk] Mark regress41983 as slow on debug reload bot; copy test to language too
...
Fixes https://github.com/dart-lang/sdk/issues/42051
Change-Id: I7d40f3d2c86acf76ee6c7251b45480aef72228b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149425
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-06-02 07:29:31 +00:00
407428311f
Remove extension method opt-in in many language tests
...
Change-Id: I277a4f29d39c2c4d2669931b5f4837db65589167
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149522
Auto-Submit: Kevin Moore <kevmoo@google.com >
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-05-31 18:46:23 +00:00
d3959945f7
Skip unicode surrogate test on android
...
This test crashes the android test runner, and should be fixed
when issue https://github.com/dart-lang/sdk/issues/42094 is rolled
to the checked-in SDK.
BUG=https://github.com/dart-lang/sdk/issues/42094
Change-Id: I91e5ea5358b08d3776ae485b90aff7cd01d02322
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149580
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2020-05-30 23:29:02 +00:00
0429dda6d2
Migrate language_2/map to NNBD.
...
Change-Id: I7567d8f705b84a286e4091ece850ccbf5966e6b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149490
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2020-05-30 01:39:28 +00:00
0cc78c340e
Migrate language_2/library to NNBD.
...
Change-Id: I59b0b611c2e7a6cf779eb1c1df7ceb0d199e88be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149390
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-05-30 01:10:44 +00:00
1b8f589d3c
Migrate language_2/least_upper_bound to NNBD.
...
Change-Id: Id1cffba25214323478af50a8ae539236377d53c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149047
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-05-30 00:55:26 +00:00
319ae89bec
[package:js] Filter out tests on CSP that use eval
...
Closes https://github.com/dart-lang/sdk/issues/42085
Tests that use eval rely on injecting JS code which will fail on
CSP try bots and therefore should be skipped by design.
Change-Id: I4d1299b1315817c38da61f572c59d95f505db0d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149541
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-05-30 00:14:48 +00:00
3218ba8412
Migrate language_2/loop to NNBD.
...
Change-Id: Id8fee2221036b8dca12675ba3e4fc1c0ab7a09b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149393
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-05-29 23:48:57 +00:00
7bc496951e
[dartdevc] Fixing issue whereby async generators would not resume properly after yielding from within a catch block.
...
Presubmits at cl/297164263
Fixes #39994
Change-Id: I2fff5db716f1b3e4f125ec9ae5f018a7edbbed67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136846
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2020-05-29 20:37:06 +00:00
359023d699
Migrate language_2/is to NNBD.
...
Change-Id: I915bc1adde6ef377a5043aab07ba0519cc03164f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149040
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-05-29 19:47:44 +00:00
39fbdcd2c9
Migrate language_2/inference to NNBD.
...
Change-Id: Iea8e8826b41d3996916dd24153ab846ef49eeda4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148945
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-05-29 19:24:14 +00:00
89c7c0b6e0
Migrate language_2/lazy to NNBD.
...
Change-Id: Icd7ea40455f207eca1dc817ff86823cfabed3de0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149042
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-05-29 19:23:24 +00:00
8680ff91e2
Migrate language_2/main to NNBD.
...
Change-Id: I902365b92bba4b84159375bda9243012f009c16d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149394
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-05-29 19:15:34 +00:00
42c3d21756
[infra] Run all migrated co19 tests on nnbd configurations
...
co19 test migration has started, and these tests will be unskipped
folder by folder now.
Change-Id: I7dad1a97d1a676042512a8a19e1403849e039f97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149002
Reviewed-by: William Hesse <whesse@google.com >
2020-05-29 11:35:04 +00:00
f585be5af2
Update language/invalid_returns tests, cf. SDK #41803
...
Change-Id: I36661c955b9e033fce92481033307525028a5dc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149163
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-05-29 08:07:18 +00:00
72e559929f
[ddc] Add --sound-null-safety flag and pass to CFE
...
https://dart-review.googlesource.com/c/sdk/+/149080 is required to
get errors if you try use weak .dill files when passing the
--sound-null-safety flag.
Added a new build target to copy the sound SDK outline .dill to
dart-sdk/lib/_internal. This is only part of dartdevc_test right
now. We will decide in the future if we are going to include this
in the released SDK or if we will have the build systems create
them as needed. For now in testing scenarios it appears to be part
of the SDK.
Change-Id: I3b31a894841f59b437658104e7ee9443ee67db93
Fixes: https://github.com/dart-lang/sdk/issues/41694
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146962
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-05-29 01:16:18 +00:00
107862e2bf
[dart2js] Fix bug in modular_test_suite.
...
Change-Id: I37954e14e8b53e70e0cfc4c3bcfb216e9f4d482f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148000
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-05-28 21:30:36 +00:00
1ab2d95105
Migrate language_2/implicit_downcast_during to NNBD.
...
Change-Id: Ie6631ecd6e597c09ef7e7a94709c3e4d9587e1a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148286
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-05-28 18:59:48 +00:00
20faaa5d94
[dart2js] Move dart2js unit tests to pkg/compiler/test.
...
Change-Id: Ib18f554c1076f27a3f7c0df5a36410da41a1f467
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148784
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-05-28 18:51:11 +00:00
b718209dfd
Revert "[co19] Enable tests migrated to null-safety"
...
This reverts commit 9a588de9f4https://dart-review.googlesource.com/c/sdk/+/148527
> Reviewed-by: Sergey Grekhov <sgrekhov@unipro.ru >
> Reviewed-by: William Hesse <whesse@google.com >
> Commit-Queue: William Hesse <whesse@google.com >
TBR=whesse@google.com ,athom@google.com ,sgrekhov@unipro.ru
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: If758a0041214693aa6cd90f76b3e1a4f4db78c5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149283
Reviewed-by: Alexander Thomas <athom@google.com >
2020-05-28 09:42:56 +00:00
521acb17e4
[dart2js ddc] make paths of dart2js and ddc platform files agnostic of nnbd.
...
Our platform .dill files show machine agnostic paths of the form:
org-dartlang-sdk:///sdk/lib/foo/
and with the unfork:
org-dartlang-sdk:///sdk_nnbd/lib/foo/
This change makes the path agnostic of the sdk_nnbd sources as well:
org-dartlang-sdk:///lib/foo/
So that source-mapping tools can find the sources if needed (our sdk_nnbd vs sdk
is not visible on published sdks).
Fixes https://github.com/dart-lang/sdk/issues/41949
Change-Id: Iceea8a917fb9a6e5f305d22ba6ee0927354d4d8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148881
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2020-05-28 00:31:13 +00:00
df36449d72
[package:js] Add JS test for function parameters
...
Adds tests for JS objects with functions with positional and
optional parameters. It does not include named arguments as those
should be statically disallowed.
Change-Id: I24acadc8160d3515bb79b00dc6ab28b528e2b039
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148221
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-05-28 00:00:04 +00:00
765cdc169c
Update language/interface/interface2_test after analyzer changes.
...
Bug: https://github.com/dart-lang/sdk/issues/42076
Change-Id: Ia2d4d42540a702301c76ef35e05a9c86e2cee3d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-27 19:07:20 +00:00
10e8d5d1a6
Try to clarify the RangeError.range message
...
The old RangeError.range message was confusing:
RangeError (index): Invalid value: Not in range 0..2, inclusive: 9
The comma makes the message hard to parse. I've seen a number of
people misinterpret "inclusive" as describing the invalid value (9)
instead of acting as a modifier on the range.
https://github.com/dart-lang/sdk/issues/29586 has a lot of
bikeshedding about this, but in the interest of mitigating confusion
sooner, I propose changing it to:
RangeError (index): Invalid value: Not in inclusive range 0..2: 9
I'm intentionally trying to improve the message with minimal
disruption to the structure of the error message. Although I'd much
prefer that "Invalid value" and the actual value be adjacent instead
of being interrupted by the explanation, such restructuring is rather
non-trivial. RangeError allows the "Invalid value" message to be
customized, and rearranging terms could produce even worse
constructions.
I also considered:
RangeError (index): Invalid value: Not in range [0, 2]: 9
And while I like that that is brief and clear, I chose not to use it
for people who are unfamiliar with interval notation and who might
mistake it as a Dart List.
Bug: https://github.com/dart-lang/sdk/issues/29586
Change-Id: I0f23b195437e4053ae5f76b5d303123979a8c9fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146024
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-05-27 14:59:39 +00:00
bbb8923ebb
[dart2js] Ensure all top/raw type predicates go through DartTypes.
...
Conceptually, this makes sense because a type is not intrinsically top
or bottom or raw, but only in the context of a type system. This also
makes these predicates much more maintainable and puts them in a form
identical to the one at the RTI level.
Change-Id: I83154a82cef6cbaa9c4d0f27cb95f01473c1e015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149049
Commit-Queue: Mayank Patke <fishythefish@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2020-05-27 05:28:03 +00:00
d1546cac87
[dart2js] Make diagnostic message arguments strongly typed.
...
We were passing arguments as just a `Map` and forcing the Message to
handle the String conversion, but the caller is much better equipped to
do it and prevents the dynamic typing.
Change-Id: Icc4ab91edf233b81a64aa3b03462b541349fa751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149048
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-05-27 05:28:03 +00:00
570de5884f
[dart2js] Run some units tests in weak mode.
...
If we don't pass the flag explicitly, the code in these tests will be
compiled in NNBD strong mode due to the language version of the
entrypoint.
Change-Id: Id6ed574ad932cf7fb6d9681e1d514e79fb3cbe04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148647
Commit-Queue: Mayank Patke <fishythefish@google.com >
Reviewed-by: Joshua Litt <joshualitt@google.com >
2020-05-26 22:08:52 +00:00
571f564eda
Rewrite TypeName to ConstructorName in one place, consolidate error reporting.
...
Change-Id: I5ea1369d65c5eb47e920f68806d28f34931d372e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-26 21:32:22 +00:00
a25ee6adc5
Migrate language_2/label to NNBD.
...
Change-Id: I9ec3a68c392c533ed9e766b1233ea9a672a9f5cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149041
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Srujan Gaddam <srujzs@google.com >
2020-05-26 20:56:30 +00:00
Regis Crelier