4 Commits

Author	SHA1	Message	Date
Alexander Aprelev	60bea3003d	Reland "[tests] rewrite and format several tests on http" ... This reverts commit af4330d382, relands original e35120cfd14ed09302596e9fa20d8e845e8e2668(in patchset 1) with fixes for the tests(in subsequent patchsets). Change-Id: I025022d242a75ad94b3616ff78aef28b7b5f372b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180603 Commit-Queue: Alexander Aprelev <aam@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>	2021-01-22 23:49:17 +00:00
Siva Annamalai	af4330d382	Revert "[tests] rewrite and format several tests on http" ... This reverts commit e35120cfd1. Reason for revert: This CL caused some breakages in the bot. Original change's description: > [tests] rewrite and format several tests on http > > Resolve comments in previous cls. > https://dart-review.googlesource.com/c/sdk/+/140564 > https://dart-review.googlesource.com/c/sdk/+/136322 > https://dart-review.googlesource.com/c/sdk/+/138860 > > Change-Id: I9549019fe871f35187af5ff75df320748792498b > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141845 > Commit-Queue: Zichang Guo <zichangguo@google.com> > Reviewed-by: Jonas Termansen <sortie@google.com> TBR=sortie@google.com,rmacnak@google.com,zichangguo@google.com Change-Id: I1ae183dcc4b202b7b1e21d30a1407f9b038791ba No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144306 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Siva Annamalai <asiva@google.com>	2020-04-22 03:27:36 +00:00
Zichang Guo	e35120cfd1	[tests] rewrite and format several tests on http ... Resolve comments in previous cls. https://dart-review.googlesource.com/c/sdk/+/140564 https://dart-review.googlesource.com/c/sdk/+/136322 https://dart-review.googlesource.com/c/sdk/+/138860 Change-Id: I9549019fe871f35187af5ff75df320748792498b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141845 Commit-Queue: Zichang Guo <zichangguo@google.com> Reviewed-by: Jonas Termansen <sortie@google.com>	2020-04-21 21:41:08 +00:00
Zichang Guo	94009bf980	[dart:io] issue another read in _NativeSocket.read to drain pipe ... if NativeSocket.read() has not specified `len`, I will expect caller wants all bytes(this is not documented, correct me if I'm wrong). Check the available bytes after read(), if there are leftover, issue another read(). This will eventually drain the pipe. Bug: https://github.com/dart-lang/sdk/issues/40589 Change-Id: I3b0be9ef8258defd1f71f85b3154702401e0f31c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136322 Reviewed-by: Siva Annamalai <asiva@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Commit-Queue: Zichang Guo <zichangguo@google.com>	2020-02-25 18:40:21 +00:00