Commit Graph

2501 Commits

Author SHA1 Message Date
Dmitry Olshansky 1b4ea20236 Gardening: giving more time for timing out test
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2660813003 .
2017-01-30 13:31:52 +01:00
Zachary Anderson 63c4b6b1cb Revert "Remove package:unittest from some tests"
This reverts commit dde47b2aad.

Revert "Update Dartium status for passing test"

This reverts commit d71c70d56d.

Tests failing on dart2js and async_star_pause_test is
passing on Dartium. Need to think about how to update the
status files.

Review-Url: https://codereview.chromium.org/2656503004 .
2017-01-25 11:06:58 -08:00
Zachary Anderson dde47b2aad Remove package:unittest from some tests
package:unittest is deprecated in favor of package:test.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2656743002 .
2017-01-25 08:50:02 -08:00
Ben Konyi f2a097b9c8 Gardening: Updated status file to account for timeout in standalone/io/socket_close_test. Test times out on Linux release IA32. Issue: 28502.
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2656703002 .
2017-01-24 17:21:41 -08:00
Ben Konyi 0f92d38fbf Fix for vm.status file being updated incorrectly.
BUG=

Committed: https://github.com/dart-lang/sdk/commit/529da7d291c0db516e1ac0a329e0a8dddc68570a
Review-Url: https://codereview.chromium.org/2653103002 .
2017-01-24 17:17:20 -08:00
Ben Konyi 529da7d291 Fix for vm.status file being updated incorrectly.
BUG=

Review-Url: https://codereview.chromium.org/2653103002 .
2017-01-24 17:14:12 -08:00
Martin Kustermann a9fbe2004d VM: Tell lsan about mmap()ed regions used for our heap
The mmap()ed pages hold pointers to `VirtualMemory` objects. So we tell
lsan that the mmap()ed regions are roots.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2646363005 .
2017-01-24 12:47:36 +01:00
keertip 1d6bd5255d Revert "Make HTTP headers use a growing buffer, not a fixed-size 8K one."
This reverts commit 5119795422.

BUG=
R=dgrove@google.com

Review-Url: https://codereview.chromium.org/2650583005 .
2017-01-23 14:57:27 -08:00
Martin Kustermann 3f0ea0f50e VM: Fix asan memory leak in some standalone tests
Fixes #28350

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2653583002 .
2017-01-23 19:45:28 +01:00
Matthias Hausner 2449686d95 Mark http_(basic|launch)_test as flaky.
These tests time out occasionally. Issue 28046 tracks this.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2642113005 .
2017-01-20 13:04:19 -08:00
Vyacheslav Egorov 5143f12685 Gardening: Fix standalone/io/process_start_exception_test.dart.
It assumed that an attempt to start a non-existent binary on POSIX always
results in ENOENT (2). However this is not true: we are using execvp(...)
which attempts to find binaries through PATH (as long as the given filename
does not contain `/`) if binary is not found anywhere in the PATH and
some folder in PATH is inaccessible then execvp(...) fails with EACCES (13).

This caused the test to fail on Android whenever PATH contained /sbin which
is inaccessible.

We fix the test by clearing PATH for child processes.

Fixes issue https://github.com/dart-lang/sdk/issues/28299

R=kustermann@google.com
BUG=https://github.com/dart-lang/sdk/issues/28299

Review-Url: https://codereview.chromium.org/2639043003 .
2017-01-18 13:23:31 +01:00
Ryan Macnak 87bfb40dea Remove recently added --checked flag from named_pipe_script_test to make it compatible with product mode.
TBR=zra@google.com

Review-Url: https://codereview.chromium.org/2638023004 .
2017-01-17 16:47:42 -08:00
Zachary Anderson 4ee6dad6c6 Gardening: Fix previous fix
TBR

Review-Url: https://codereview.chromium.org/2641673002 .
2017-01-17 16:10:19 -08:00
Zachary Anderson 4d956bfe9e Try to make named_pipe_script_test less flaky
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2632123008 .
2017-01-17 15:51:07 -08:00
Zach Anderson c22bee4c0e Gardening: Update status file for timeout
related #28426

Review-Url: https://codereview.chromium.org/2643513002 .
2017-01-17 13:53:28 -08:00
Zach Anderson 10b2ca0746 Gardening: update x64 asan status for io/process_detached_test
Review-Url: https://codereview.chromium.org/2636223002 .
2017-01-17 10:48:42 -08:00
Vyacheslav Egorov fe47282e9b Gardening: Mark io/http_basic_test slow. Add debug prints into io/process_start_exception_test.
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2631223003 .
2017-01-16 18:50:02 +01:00
Ben Konyi 511e710553 Gardening: updating status file to handle occassional timeout of io/regress_7191_test on vm-win-release-x64-be.
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2629283002 .
2017-01-13 09:11:09 -08:00
Kevin Millikin 23d79ba6f9 Mark a test that has become flaky
BUG=https://github.com/dart-lang/sdk/issues/28380

Review-Url: https://codereview.chromium.org/2628343002 .
2017-01-13 14:04:29 +01:00
Lasse R.H. Nielsen 5119795422 Make HTTP headers use a growing buffer, not a fixed-size 8K one.
Issue #28251

BUG= http://dartbug.com/28251
R=sgjesse@google.com

Review-Url: https://codereview.chromium.org/2618523005 .
2017-01-13 10:12:19 +01:00
Ben Konyi b0d99a2620 Gardening: updating status file to skip http_server_close_response_after_error_test on vm-win-release-x64-be due to flakiness. See issue #28370.
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2626193003 .
2017-01-12 12:59:30 -08:00
Martin Kustermann 65483c7694 VM: Mark tests as passing after asan fixes
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2629153002 .
2017-01-12 16:41:24 +01:00
Ryan Macnak 2e6478a35c Further triage new ASAN failures.
Issue #28353
Issue #28354

Review-Url: https://codereview.chromium.org/2622413002 .
2017-01-11 17:25:39 -08:00
Florian Schneider bef4967ea1 Remove dart_noopt and related parts from the VM.
dart_noopt is not needed anymore because we have testing
and builbot integration of the real precompilation pipeline in place now.

Fixes #24569
Fixes #25726
Fixes #25845

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624393002 .
2017-01-11 16:55:55 -08:00
Ryan Macnak 59116d212b Triage more memory leaks.
Issue #28350

Review-Url: https://codereview.chromium.org/2625033004 .
2017-01-11 15:58:57 -08:00
Dmitry Olshansky aa583a0ec2 Gardening: mark flaky test on SIMMIPS
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2622933002 .
2017-01-10 16:50:30 +01:00
Jennifer Messerly 816592a941 fixes #28236, generic methods should not cause warnings in Dart 1
Instantiate universal functions in subtype tests & tear-offs. Also updates the status files and one Analyzer test that covered the tear-off type.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2621433003 .
2017-01-09 12:46:20 -08:00
John McCutchan bd5e949226 Mark io/raw_socket_test as flakey
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2610893006 .
2017-01-09 07:39:52 -08:00
Zach Anderson 8d709c279d Gardening: Tighten status update, adjust flaky test
related #28276

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2613713006 .
2017-01-05 10:30:43 -08:00
Vyacheslav Egorov f3f70fea5f Gardening: improve debug output in standalone/io/socket_ipv6_test.dart.
This test is flaky on the bot - we need to better understand why it times out.

(See issue #28266)

R=kustermann@google.com
BUG=http://dartbug.com/28266

Review-Url: https://codereview.chromium.org/2613893003 .
2017-01-05 15:32:39 +01:00
Zachary Anderson 5c8510bca5 Make RandomAccessFile.writeFrom use the correct starting offset
fixes #28174

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2615673002 .
2017-01-04 09:33:28 -08:00
Zachary Anderson 1f6c914d67 Signal an error for File.lastModified on a directory
fixes #28173

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2616463004 .
2017-01-04 07:50:35 -08:00
Zachary Anderson 128313ec3c Signal an error for File.length on a directory
fixes #28172

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2615473002 .
2017-01-03 15:06:23 -08:00
Lasse R.H. Nielsen 44594277e1 Make core libraries use generic method syntax.
Removes comment syntax where possible for the following platform libraries:
* async
* collection
* convert
* core
* internal
* io
* math

The HTML related libraries are not changed. The templates used to build them
must be changed as well.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/68818315b5cc6c63fea0e10e90f515f6083ec095
Committed: https://github.com/dart-lang/sdk/commit/3f74b8d82edca8c342c43306714e68ddf84548e1
Review-Url: https://codereview.chromium.org/2529393002 .
2017-01-03 12:05:40 +01:00
Florian Schneider f995513880 Temorarily update status for two flaky tests
Filed issues #28198 and #28197.

Review-Url: https://codereview.chromium.org/2600543003 .
2016-12-23 14:05:59 +01:00
Zachary Anderson 2ad9b921be Reland: Make File.create() fail when a directory exists at the same path
related #28170

Review-Url: https://codereview.chromium.org/2594413002 .
2016-12-22 08:12:53 -08:00
Kasper Lund 3ecfa62385 Widen marker. Flakiness is also present on simdbc.
TBR'ed.

R=whesse@google.com
BUG=

Review-Url: https://codereview.chromium.org/2597183002 .
2016-12-22 14:19:50 +01:00
Kasper Lund 4e4e2eed4c Skip test that sometimes hangs on Mac.
TBR'ed.

R=asiva@google.com, zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2597973002 .
2016-12-22 11:49:39 +01:00
Kasper Lund 101552b033 Revert "Make File.create() fail when a directory exists at the same path"
The added test case fails in non-English locales.

This reverts commit f2604a3647.

TBR'ed.

R=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2599723002 .
2016-12-22 09:56:45 +01:00
Zach Anderson f2604a3647 Make File.create() fail when a directory exists at the same path
fixes #28170

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2593913003 .
2016-12-21 15:19:23 -08:00
Zachary Anderson a919399031 Fix directory existence query error
fixes #28147

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2580133002 .
2016-12-16 20:58:52 -08:00
Florian Schneider 8cb4b5adfb Fix flaky timeouts of socket_ipv6_test.
It seems there is no way of guaranteeing that there is always an error in those two cases, because it depends on other processes running on the system.

Related to #28046.

R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2566273007 .
2016-12-13 15:33:03 -08:00
Florian Loitsch f1ae158a2a Add debugging information to raw_secure_server_socket_test.
R=fschneider@google.com, kustermann@google.com

Review-Url: https://codereview.chromium.org/2571603004 .
2016-12-13 21:29:24 +01:00
Florian Schneider 1ca079a472 Reduce flakiness of http_client_stays_alive_test.
Give it more time before failing.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2566263002 .
2016-12-12 13:50:33 -08:00
Zachary Anderson a0f4b3616c Mark io/socket_test Pass, Timeout on macos.
related #27453

Review-Url: https://codereview.chromium.org/2565133002 .
2016-12-09 22:27:48 -08:00
Martin Kustermann 4d3af00382 Attempt to reduce flakiness rate of io test
BUG=https://github.com/dart-lang/sdk/issues/27951
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2546733002 .
2016-12-05 14:39:25 +01:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'.
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
2016-12-01 16:47:33 -08:00
William Hesse 0bb0386634 Increase subprocess timeout in standalone/io/test_runner_test.
A passing subtest was sometimes taking more than 10 seconds, and
timing out.

BUG=https://github.com/dart-lang/sdk/issues/20351
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2535773003 .
2016-11-28 17:42:47 +01:00
Ryan Macnak f98363b118 Mark standalone/io/socket_info_ipv6_test as failing on Windows.
Issue #27876

Review URL: https://codereview.chromium.org/2523813002 .
2016-11-22 11:14:46 -08:00
Ryan Macnak 6c45f24fa6 Report a peer address over IPv4 as IPv4.
R=asiva@google.com

Review URL: https://codereview.chromium.org/2518263002 .
2016-11-22 09:19:08 -08:00