dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2501 Commits

Author SHA1 Message Date
Siva Annamalai f1689b6eb0 Migrate first block of tests in standalone to standalone_2 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2984363004 .
 2017-08-01 09:05:01 -07:00
William Hesse 8fe8b5042c Disable Multicast Loopback test for Linux IPv6, temporarily 
BUG=https://github.com/dart-lang/sdk/issues/30306
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2991133002 .
 2017-08-01 14:51:46 +02:00
Siva Annamalai 8751f704d5 Remove references to 'dartium' and 'drt' in status files. 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2986693002 .
 2017-07-26 15:59:38 -07:00
Bob Nystrom 796eb21071 Move the status file parser into its own package. 
This required munging a bit of test.dart code too to tease out some
dependencies, but the changes are minor. I considered moving all of
test.dart out into a package and making the status file library a
public one that other packages in the repo could import but this seemed
like the less intrusive change.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2984203002 .
 2017-07-25 15:29:59 -07:00
Zachary Anderson 8d6bc876f0 Reland "Remove fields from Isolate in Product mode" 
In my reordering of the fields in Isolate, I omitted the initialization
of a few fields in the constroctor. This CL will reland the change with
the initialization added back.

R=danunez@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2983403002 .
 2017-07-25 13:24:30 -07:00
Alexander Markov 277f22329f Adjust some tests for limited 64-bit integers 
In preparation for limiting Dart integers to 64 bits, certain tests
are corrected to avoid large integer literal or computations with
overflow.

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Review-Url: https://codereview.chromium.org/2988803002 .
 2017-07-25 13:19:30 -07:00
Zachary Anderson 211604d7a0 Revert "Remove fields from Isolate in Product mode" 
This reverts commit 13558442ab.

The above change caused a timeout in a vm test:

FAILED: none-vm-checked release_x64 vm/cc/SafepointTestDart
Expected: Pass
Actual: Timeout
CommandOutput[run_vm_unittest]:
diagnostics: Process list including children: [28397]
    Trying to capture stack trace for pid 28397
    PID 28397 - process
    TID 28397:
    #0  0x00007efedf216404 pthread_cond_wait@@GLIBC_2.3.2
    #1  0x0000000002b9a315 dart::Monitor::WaitMicros(long)
    #2  0x0000000002af3496 dart::MonitorLocker::WaitWithSafepointCheck(dart::Thread*, long)
    #3  0x0000000002a8724d dart::Heap::AllocateOld(long, dart::HeapPage::PageType)
    #4  0x0000000002b07de3 dart::Object::Allocate(long, long, dart::Heap::Space)
    #5  0x0000000002b26eab dart::UnresolvedClass::New(dart::Object const&, dart::String const&, dart::TokenPosition)
    #6  0x0000000002be6358 dart::Parser::ParseType(dart::ClassFinalizer::FinalizationKind, bool, bool, dart::LibraryPrefix*)
    #7  0x0000000002ba9cc4 dart::Parser::ParseNewOperator(dart::Token::Kind)
    #8  0x0000000002bac7dc dart::Parser::ParsePrimary()
    #9  0x0000000002be19c1 dart::Parser::ParsePostfixExpr()
    #10 0x0000000002bdf1c4 dart::Parser::ParseUnaryExpr()
    #11 0x0000000002bb618c dart::Parser::ParseBinaryExpr(int)
    #12 0x0000000002bb869f dart::Parser::ParseConditionalExpr()
    #13 0x0000000002bae224 dart::Parser::ParseExpr(bool, bool)
    #14 0x0000000002bbeb79 dart::Parser::ParseAwaitableExpr(bool, bool, dart::SequenceNode**)
    #15 0x0000000002bd5273 dart::Parser::ParseStatement()
    #16 0x0000000002bbcce0 dart::Parser::ParseStatementSequence()
    #17 0x0000000002ba64e8 dart::Parser::ParseFunc(dart::Function const&, bool)
    #18 0x0000000002ba3e31 dart::Parser::ParseFunction(dart::ParsedFunction*)
    #19 0x00000000029e0725 dart::DartCompilationPipeline::ParseFunction(dart::ParsedFunction*)
    #20 0x00000000029e4898 dart::CompileFunctionHelper(dart::CompilationPipeline*, dart::Function const&, bool, long)
    #21 0x00000000029e5716 dart::Compiler::CompileOptimizedFunction(dart::Thread*, dart::Function const&, long)
    #22 0x0000000002c8d3a4 dart::DRT_StackOverflow(dart::NativeArguments)
    #23 0x00007efedf6ad61b
    TID 28421:
    #0  0x00007efedf2167be pthread_cond_timedwait@@GLIBC_2.3.2
    #1  0x0000000002b9a2ff dart::Monitor::WaitMicros(long)
    #2  0x0000000002cc6f8f dart::ThreadInterrupter::ThreadMain(unsigned long)
    #3  0x0000000002b999d9 dart::ThreadStart(void*)
    #4  0x00007efedf212184 start_thread
    #5  0x00007efede51737d __clone
    TID 28430:
    #0  0x00007efedf216404 pthread_cond_wait@@GLIBC_2.3.2
    #1  0x0000000002b9a315 dart::Monitor::WaitMicros(long)
    #2  0x0000000002af3496 dart::MonitorLocker::WaitWithSafepointCheck(dart::Thread*, long)
    #3  0x0000000002a8789e dart::HeapIterationScope::HeapIterationScope(bool)
    #4  0x0000000002ad4966 dart::Isolate::IterateObjectPointers(dart::ObjectPointerVisitor*, bool)
    #5  0x00000000027ed02a dart::SafepointTestTask::Run()
    #6  0x0000000002cc7cbd dart::ThreadPool::Worker::Loop()
    #7  0x0000000002cc7b6a dart::ThreadPool::Worker::Main(unsigned long)
    #8  0x0000000002b999d9 dart::ThreadStart(void*)
    #9  0x00007efedf212184 start_thread
    #10 0x00007efede51737d __clone
    TID 28431:
    #0  0x00007efedf216404 pthread_cond_wait@@GLIBC_2.3.2
    #1  0x0000000002b9a315 dart::Monitor::WaitMicros(long)
    #2  0x0000000002ad66fa dart::Isolate::ScheduleThread(bool, bool)
    #3  0x0000000002cc53ea dart::Thread::EnterIsolateAsHelper(dart::Isolate*, dart::Thread::TaskKind, bool)
    #4  0x0000000002a86317 dart::SweeperTask::Run()
    #5  0x0000000002cc7cbd dart::ThreadPool::Worker::Loop()
    #6  0x0000000002cc7b6a dart::ThreadPool::Worker::Main(unsigned long)
    #7  0x0000000002b999d9 dart::ThreadStart(void*)
    #8  0x00007efedf212184 start_thread
    #9  0x00007efede51737d __clone
    TID 28444:
    #0  0x00007efedf216404 pthread_cond_wait@@GLIBC_2.3.2
    #1  0x0000000002b9a315 dart::Monitor::WaitMicros(long)
    #2  0x0000000002af3496 dart::MonitorLocker::WaitWithSafepointCheck(dart::Thread*, long)
    #3  0x0000000002a8724d dart::Heap::AllocateOld(long, dart::HeapPage::PageType)
    #4  0x0000000002b07de3 dart::Object::Allocate(long, long, dart::Heap::Space)
    #5  0x0000000002b26eab dart::UnresolvedClass::New(dart::Object const&, dart::String const&, dart::TokenPosition)
    #6  0x0000000002be6358 dart::Parser::ParseType(dart::ClassFinalizer::FinalizationKind, bool, bool, dart::LibraryPrefix*)
    #7  0x0000000002bb19bb dart::Parser::ParseTypeOrFunctionType(bool, dart::ClassFinalizer::FinalizationKind)
    #8  0x0000000002bb204c dart::Parser::ParseFormalParameter(bool, bool, dart::ParamList*)
    #9  0x0000000002bb43b3 dart::Parser::ParseFormalParameters(bool, bool, bool, dart::ParamList*)
    #10 0x0000000002ba368b dart::Parser::ParseFormalParameterList(bool, bool, bool, dart::ParamList*)
    #11 0x0000000002ba5a8f dart::Parser::ParseFunc(dart::Function const&, bool)
    #12 0x0000000002ba3e31 dart::Parser::ParseFunction(dart::ParsedFunction*)
    #13 0x00000000029e0725 dart::DartCompilationPipeline::ParseFunction(dart::ParsedFunction*)
    #14 0x00000000029e4898 dart::CompileFunctionHelper(dart::CompilationPipeline*, dart::Function const&, bool, long)
    #15 0x00000000029e5716 dart::Compiler::CompileOptimizedFunction(dart::Thread*, dart::Function const&, long)
    #16 0x00000000029e7036 dart::BackgroundCompiler::Run()
    #17 0x0000000002cc7cbd dart::ThreadPool::Worker::Loop()
    #18 0x0000000002cc7b6a dart::ThreadPool::Worker::Main(unsigned long)
    #19 0x0000000002b999d9 dart::ThreadStart(void*)
    #20 0x00007efedf212184 start_thread
    #21 0x00007efede51737d __clone
Review-Url: https://codereview.chromium.org/2988703002 .
 2017-07-24 14:17:53 -07:00
Zachary Anderson 13558442ab Remove fields from Isolate in Product mode 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2984883002 .
 2017-07-24 13:22:44 -07:00
Terry Lucas d0d5d6cc25 Revert "Revert "Removed Dartium test exceptions"" 
This reverts commit b85f66253c.

TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2984613002 .
 2017-07-19 05:51:54 -07:00
Johnni Winther b85f66253c Revert "Removed Dartium test exceptions" 
This reverts commit 84f079f24c.

Review-Url: https://codereview.chromium.org/2983073002 .
 2017-07-19 13:31:32 +02:00
Terry Lucas 84f079f24c Removed Dartium test exceptions 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2983033002 .
 2017-07-18 13:18:14 -07:00
Sigmund Cherem ebd9440b18 support resolving .packages in FE 
BUG=
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2979003002 .
 2017-07-14 12:54:35 -07:00
Sigmund Cherem d844dc8226 Move forward rolling FE public APIS (make bots green) 
There were a couple issues found in the bots:
 - dart2js unit tests I accidentally missed earlier.
 - vmservice issues only show up in the debug-vm, I was testing locally with the
   release vm.
 - a small regression in detecting invalid .packages files. I marked the test
 failing for now and plan to follow up on this on Monday.

TBR=ahe@google.com,paulberry@google.com

Review-Url: https://codereview.chromium.org/2974703002 .
 2017-07-07 21:15:07 -07:00
Ryan Macnak 1bfd01c1f7 Revert "Use relative URIs for core library part-of statements." 
This reverts commit 62bc61b367.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2968413002 .
 2017-07-07 11:18:24 -07:00
Lasse R.H. Nielsen 62bc61b367 Use relative URIs for core library part-of statements. 
Reapply "Change some platform libraries to use `part of URI`."
Change to used relative URIs in the part-of declarations.

R=brianwilkerson@google.com, floitsch@google.com

Review-Url: https://codereview.chromium.org/2911903002 .
 2017-07-03 10:04:06 +02:00
Zachary Anderson 4ecf748d5e [dart:io] Fixes a crash in VM shutdown when signals are watched 
This CL fixes a crash in VM shutdown which is triggered by Dart programs
that throw unhandled exceptions while watching OS signals.

fixes #30033

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2961993002 .
 2017-06-28 11:05:07 -07:00
Bob Nystrom 82df163eca Refactor dependency_graph.dart. 
It multiplexed a bunch of different events onto a single stream. But
every single listener on that stream immediately demuxed them and only
cared about a subset of the events.

So I made separate streams for each event. Other minor clean-ups too.

R=sigmund@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2957703002 .
 2017-06-26 17:07:37 -07:00
Devon Carew 0ac0c8d2e2 Reduce the scope of a status exclusion - this passes on vm-product, and only seems to fail on dart_precompiled. 
BUG=

Review-Url: https://codereview.chromium.org/2961623002 .
 2017-06-26 07:36:48 -07:00
Devon Carew e38488aa0d Status file update for skipping_dart2js_compilations. 
BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2954283002 .
 2017-06-26 06:50:48 -07:00
Erik Corry 029b1cb948 Spelling fixes e to i. 
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
 2017-06-24 13:41:39 +02:00
Bob Nystrom dd5c779b43 Update statuses for tests that don't touch dart:mirrors anymore. 
BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2957613003 .
 2017-06-23 14:44:52 -07:00
Ben Konyi 06456e83d8 Added timeout parameter to RawSecureSocket and SecureSocket connect methods. Also updated CHANGELOG and SecureSocket tests to reflect this change. Issue 19120. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2950413002 .
 2017-06-22 13:45:26 -07:00
Zachary Anderson ac16656161 Remove MIPS support 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2858623002 .
 2017-06-22 08:49:22 -07:00
Ben Konyi 86fdbde70a Added timeout parameter to RawSocket and Socket connect, which allows for the specification of a maximum time to wait for a valid connection to be established. 
fixes #19120

R=zra@google.com

Review-Url: https://codereview.chromium.org/2946333002 .
 2017-06-21 14:31:52 -07:00
Bob Nystrom 47aa77f139 Fix test.dart test. 
R=zra@google.com

Review-Url: https://codereview.chromium.org/2951163002 .
 2017-06-21 14:09:21 -07:00
Jens Johansen d03a0d798e Re-insert linebreak in dwarf_stack_trace_test 
This file was auto-formatted 2 months ago.
This - among other things - removed a linebreak which shifted linenumbers
by one, but didn't update the expected linenumbers from a throw accordingly.
Somehow the testserver has claimed that this has passed until now.
I have no idea how that happened.

This CL re-introduces the linebreak by inserting a comment,
which (currently) forces dartfmt to have the wanted linebreak.

BUG=
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2945273002 .
 2017-06-21 13:47:38 +02:00
Ryan Macnak 9cb92858f7 Do not run standalone tests on dart2js. 
Review-Url: https://codereview.chromium.org/2939223002 .
 2017-06-15 16:52:07 -07:00
Bob Nystrom 5ee0f27725 Fix static errors (and hints) in test. 
BUG=
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2942083002 .
 2017-06-15 15:56:43 -07:00
Ben Konyi b57f7b4c12 [Gardening] fixing bad test. 
TBR=rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/2944543002 .
 2017-06-15 15:38:24 -07:00
Bob Nystrom 0a8475e26e Fix test.dart tests. 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2942073002 .
 2017-06-15 14:55:38 -07:00
Ryan Macnak 26336b47a3 Allow enabling --causal-async-stacks in AOT. 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2944483002 .
 2017-06-15 11:09:51 -07:00
Peter von der Ahé 369560f6b9 More flaky tests. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2932253002 .
 2017-06-12 10:34:27 +02:00
Bob Nystrom 7a28d5a310 Disable dependency_graph_test on some platforms. 
Do to reorganizing some code, it now transitively imports mirrors, so
don't run it on platforms that don't have mirrors.

We only really care about this test on the standalone VM anyway.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2930153002 .
 2017-06-09 17:06:10 -07:00
Bob Nystrom 19cb0cafb7 Simplify test_suite.dart. 
- Get rid of baseCommand, which is only ever an empty list.
- Move some utility classes out of the giant test_suite.dart.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2915843003 .
 2017-06-09 16:46:49 -07:00
Ben Konyi 1862b9871d Updated status file to skip http_loopback_test on systems that don't support IPv6 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2923343006 .
 2017-06-08 16:20:30 -07:00
Ben Konyi 4a15b0b602 Updated HttpServer documentation to specify that only IPv6 connections can be made when specifying InternetAddress.LOOPBACK_IP_V6 as the address for a HttpServer. Refer to buganizer issue 38306174 for context. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2931623003 .
 2017-06-08 15:53:07 -07:00
Peter von der Ahé f73e2ecf28 Clean up status files. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2928903002 .
 2017-06-08 13:50:30 +02:00
Ben Konyi 4b6fa0d5fb Removed SecurityContext.alpnSupported, as ALPN is now supported on all platforms. Also updated CHANGELOG.md to announce its removal. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2926153004 .
 2017-06-07 15:15:58 -07:00
Lasse R.H. Nielsen 5720e3556c Add negation to single-identifier tests in status files. 
Optimize some regegps too.

Fixes #29756

BUG= http://dartbug.com/29756
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2913963002 .
 2017-06-02 10:38:14 +02:00
Bob Nystrom e091fbf82a Make test version of forEachTest() return a future. 
Making it async seemed like the natural way to do it.

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2921763002 .
 2017-06-01 16:08:13 -07:00
Ryan Macnak 2109cc53bf Remember deopt-id -> context-level mappings in var descriptors. 
- Add deopt ids to DebugStepInstr and StrictCompareInstr since the debugger can stop there.
 - Add missing pc descriptor in DBC's StringInterpolateInstr.

Re-enable async_debugger, which had been crashing flakily from context mismatches.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2903993002 .
 2017-06-01 12:33:33 -07:00
Bob Nystrom a783fdc44c Disable some tests that shouldn't run on platforms without dart:mirrors. 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2914143002 .
 2017-05-31 17:14:51 -07:00
Bob Nystrom 7e2d9ac85d Revert "Revert "Replace the configuration map with a typed object."" 
This reverts commit 8bada4873a.

R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2919573003 .
 2017-05-31 15:39:23 -07:00
Bob Nystrom 8bada4873a Revert "Replace the configuration map with a typed object." 
This reverts commit 06f75fe5cd.

Review-Url: https://codereview.chromium.org/2914893003 .
 2017-05-31 15:08:21 -07:00
Bob Nystrom 06f75fe5cd Replace the configuration map with a typed object. 
This is a pretty massive change but my hope is it will make
test.dart easier to maintain going forward. Instead of
passing around a stringly-typed Map<String, dynamic> all
throughout the program, we parse the options and then create
a Configuration object that has typed getters for all of the
various bits of configuration data.

This is a little tedious because it means declaring a new
option requires also declaring a corresponding field in the
Configuration class and passing it through the constructor.
I think it's worth it.

Also, enum-like configuration properties like architecture
and runtime now have their own classes as well. Moved a
bunch of stuff from TestUtil into those classes now that
there is an object to hang those methods off of.

In the process, I found a few typos in string literals where
the code wasn't correctly looking up a configuration
property.

Added more sanity checking and validation to status file
parsing. You will get an error at parse time if you try to
refer to a variable that isn't in the whitelist of known
variables. Also, you'll get an error if you try to compare
a variable to a value that it isn't expected to have.

Many other small-scale cleanups.

Aside from the status file validation, this should behave
mostly the same as current test.dart except that tests
may be enqueued in a slightly different order. The
rewritten code for expanding configurations iterates
through the architecture, runtime, etc. options in a
slightly different order.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2901923003 .
 2017-05-31 14:47:31 -07:00
Peter von der Ahé 1cbe09bbd3 Mark more standalone/io tests as flaky. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2918493002 .
 2017-05-31 14:12:29 +02:00
Bob Nystrom 027eaca77e Fix static error in test_runner_test. 
Review-Url: https://codereview.chromium.org/2907403005 .
 2017-05-30 15:25:54 -07:00
Erik Corry 8619cb6387 Reapply "Fix misoptimization of 'is' test"" 
This also moves some common code from jit_optimizer.cc and
aot_optimizer.cc to a new common file, optimizer.cc. The code is almost
unchanged from the aot_optimizer.cc version, apart from the calls to
PurgeNegativeTestCidsEntries.  A flag emulates the behaviour of the
simpler jit_optimizer.cc version.  Benchmark tests are running to see
which is better.

Originally reviewed at https://codereview.chromium.org/2904543002/

R=vegorov@google.com
BUG=

Review-Url: https://codereview.chromium.org/2912903002 .
 2017-05-30 14:17:06 +02:00
Erik Corry 2a5fa6441e Revert "Fix misoptimization of 'is' test" 
R=johnniwinther@google.com
BUG=

This really reverts commit b7797ac45f
code review at
https://codereview.chromium.org/2904543002.  Revert is due to
an AOT failure.
Review-Url: https://codereview.chromium.org/2914483002 .
 2017-05-29 15:56:44 +02:00
Erik Corry 1839f6375b Revert "Fix misoptimization of 'is' test" 
R=johnniwinther@google.com
BUG=

This reverts commits fc693153d1
and b7797ac45f, code review at
https://codereview.chromium.org/2904543002.  Revert is due to
an AOT failure.
Review-Url: https://codereview.chromium.org/2908153002 .
 2017-05-29 15:25:41 +02:00