Commit Graph

2501 Commits

Author SHA1 Message Date
srdjan@google.com 518f44fa75 Throwing type check errors is very slow compared to other checks (e.g., value check error in typed arrays). Take those checks out of the loop, whihc is there only to force optimization.
Review URL: https://codereview.chromium.org//11366071

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14503 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 22:32:25 +00:00
dgrove@google.com 7897a78551 Changes outside pkg/ and lib/ for directory refactoring
Review URL: https://codereview.chromium.org//11358024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14475 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 15:18:11 +00:00
ahe@google.com dd97952351 Mark io/http_basic_test as flaky
Review URL: https://codereview.chromium.org//11275123

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14459 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 09:19:41 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
lrn@google.com 7e6ae8ea09 Renaming IndexOutOfRangeException to RangeError.
It now extends ArgumentError.

Review URL: https://codereview.chromium.org//11275042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14405 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 13:46:30 +00:00
ricow@google.com 5dddb4432e Do error propagation for decoder errors in string stream.
Currently only the ascii decoder will throw errors.
Review URL: https://codereview.chromium.org//11345027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14331 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-31 11:56:37 +00:00
rnystrom@google.com 61068e9183 Use command on Windows that ends quickly.
Review URL: https://codereview.chromium.org//11339051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14311 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 21:18:22 +00:00
rnystrom@google.com 314555d49c Disable process PATH tests on windows.
Investigating now.

Review URL: https://codereview.chromium.org//11343047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14302 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 18:30:54 +00:00
rnystrom@google.com 908b045578 Look up executable on PATH when given environment variables.
Fixes http://code.google.com/p/dart/issues/detail?id=4402

Review URL: https://codereview.chromium.org//11260048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14300 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 18:17:51 +00:00
ager@google.com 57d91e3cdc Use the encoding parameter for writeString on RandomAccessFile objects.
R=sgjesse@google.com
BUG=dartbug.com/6392

Review URL: https://codereview.chromium.org//11345025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14268 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 11:59:29 +00:00
ager@google.com 4fafaeefe2 Fix issues found by analyzer.
R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//11348032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14263 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 11:13:51 +00:00
ager@google.com aac030e777 Use patching for dart:io.
This allows the tools such as dartdoc to operate on dart:io
in the same way as it does with other code and allows the
implemenation of parts of dart:io for dart2js if we ever
want to do that.

The current patching is very VM specific. I have only moved
stuff to patch files when they actually need to be. For
Process and Socket everything has to be moved because they
use native fields. For the rest, only the individual native
calls have been put in patch files.

R=sgjesse@google.com,ajohnsen@google.com
BUG=

Review URL: https://codereview.chromium.org//11337019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14259 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 10:32:30 +00:00
antonm@google.com 4344b9579b Switch to old library syntax.
Alas, our current testing framework cannot cope with new syntax.

TBR=asiva@google.com

Review URL: https://codereview.chromium.org//11343037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14255 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 10:20:02 +00:00
sgjesse@google.com b641a8d79a Add flush to HTTP output streams
The flush method was missing on the HTTP output streams and was
wrongly on the HTTP input streams. The call to flush is forwarded to
the socket output stream (on which is is actually a noop).

R=ager@google.com

BUG=dart:6384
TEST=tests/standalone/io/http_advanced_test.dart

Review URL: https://codereview.chromium.org//11301034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14246 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 08:30:05 +00:00
asiva@google.com 2e4a7504ff Skip typed_array_test on drt as the new library syntax is not recognized as
valid. Issue 6383 has been created to track this.
Review URL: https://codereview.chromium.org//11348023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14232 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 23:43:28 +00:00
asiva@google.com 974bf9fbdd Fix test case,
Can't mix and match old syntax of library with new syntax of import.
Review URL: https://codereview.chromium.org//11338021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14230 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 22:46:12 +00:00
asiva@google.com 454e8d0e73 Add library tag so that this test will run in dartium.
Review URL: https://codereview.chromium.org//11344025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14229 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 22:24:45 +00:00
asiva@google.com a90d66b304 Fix build break, skip test under dart2js
Review URL: https://codereview.chromium.org//11273094

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14227 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 21:52:54 +00:00
asiva@google.com a101ecfd4d Added some new tests for issue 6311
Review URL: https://codereview.chromium.org//11341012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14226 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 21:37:43 +00:00
sgjesse@google.com db3d6358f2 Remove public SocketInputStream and SocketOutputStream clases
The socket streams only implement the streams interfaces so no
explicit classes are needed for these.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//11336012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14204 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 15:04:54 +00:00
sgjesse@google.com 77edd718c2 Add support for authorization of HTTP client requests
This implements the infrastructure for authorization of HTTP client
requests. Currently only basic authentication is fully implemented,
but the infrastructure to support digest is there.

Please focus on the developer facing API with the authenticate callback and
addCredentials method.

R=ager@google.com,ajohnsen@google.com

BUG=dart:2788
TEST=tests/standalone/io/http_auth_test.dart

Review URL: https://codereview.chromium.org//11118021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14189 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 12:13:07 +00:00
ager@google.com 83f2cfa4c1 Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your streams.
When using an interactive process started with Process.start you have
to drain the stdout and stderr streams to make sure that all resources
are freed. If you do that the dart:io library will make sure to free
all system resources for you.

R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//11343009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14187 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 11:59:09 +00:00
sgjesse@google.com b40fd41222 Change the handling og the HTTP content length
This change should make the indicated HTTP message content length be
as described in RFC 2616.

For requests the content length is 0 if neither Content-Length nor
Transfer-Encoding headers are set. If the content length of a request
is set to 0 the Content-Length header is not sent with a value of
0. For GET and HEAD the content length is set to 0 by default.

For responses content length needs to be set to 0 to indicate an empty
response (unless it is a HEAD response where the content length
indicate the size of the body expected). Otherwise a body is assumed
and if no content length is set chunked transfer encoding is used.

For HTTP 1.0 chunked transfer encoding is not supported. So for HTTP
1.0 requests needs content length if they have a body and responses
without a content length will indicate end of body by closing the
connection.

R=ager@google.com

BUG=dart:6309

Review URL: https://codereview.chromium.org//11348005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14184 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 11:30:17 +00:00
floitsch@google.com 14ae358714 Update status file.
Review URL: https://codereview.chromium.org//11273073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14181 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 10:03:43 +00:00
ager@google.com 7f04c40b2d Land update to tools directory with new binaries.
BUG=

Review URL: https://codereview.chromium.org//11343008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14176 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 09:21:14 +00:00
floitsch@google.com 2e778387b3 Make getKeys, getValues getters (keys, values).
Review URL: https://codereview.chromium.org//11267018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14093 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:22:11 +00:00
floitsch@google.com 3300f91153 Make first and last getters.
Review URL: https://codereview.chromium.org//11273041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14082 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 15:19:31 +00:00
floitsch@google.com e7c5e69beb Make String.charCodes a getter.
Review URL: https://codereview.chromium.org//11263040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14078 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 14:25:43 +00:00
ricow@google.com 873c7baa06 Update status for jsshell to make the builders green.
Review URL: https://codereview.chromium.org//11194052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14073 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 12:45:22 +00:00
floitsch@google.com 312c4a241f Update status file.
Review URL: https://codereview.chromium.org//11266010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14024 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:22:31 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter.
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
floitsch@google.com 0af6548e68 Update status file.
Review URL: https://codereview.chromium.org//11273010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14018 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 14:25:40 +00:00
floitsch@google.com 0e47b363ae Make hasNext a getter instead of a method.
Review URL: https://codereview.chromium.org//11230011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14015 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 13:05:11 +00:00
lrn@google.com a083c1a108 Removed IllegalAccessException and UnsupportedOperationException.
Both were converted to StateError.

Review URL: https://codereview.chromium.org//11235054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:36:10 +00:00
ager@google.com 79a0089d38 Change Process.kill to return a boolean instead of throwing an exception when kill fails.
If the program wants to kill the process after a given time, it is
possible that the process is already dead but has not yet been
reaped. Therefore, there is no way for the programmer to test if the
process is already dead before killing it. Throwing an exception from
kill is not helpful as you will most often have to catch it and do
nothing because you cannot prevent the exception occasionally and
there is nothing you can do as a result of the exception since it
usually means that the process is already dead.

R=ahe@google.com,sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//11238057

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13956 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 12:40:53 +00:00
sgjesse@google.com 9c707dff5f Fix bug in HTTP client request generation
If an HTTP request with an empty path was done using the HttpClient
(either for normal HTTP or for upgrading to web sockets) the generated
HTTP request line was invalid. The empty path was used in the request
line e.g.

GET  HTTP/1.1

instead of

GET / HTTP/1.1

This is now fixed by using / if no path is specified. This is
specified in RFC 2616 section 3.2.2.

BUG=6185

R=ager@google.com

Review URL: https://codereview.chromium.org//11231070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13939 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 09:39:17 +00:00
ager@google.com ccced31671 Change Directory.create to not fail on existing directory with that name.
The new semantics is to ensure that a directory with that name
exists. There is no way to reliably guard a create call against
existing directories in an async program.

R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//11175054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13933 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 09:15:01 +00:00
ajohnsen@google.com 0ef4ef2f84 Add sessions to HttpServer.
A session is started when HttpRequest.getSession() is called. The
session will then be added to the session manager. The session manager
then controls timeouts.

The session id is create by using the a crypto-random sequence of 16
bytes. These are extracted by using /dev/urandom on posix and
CryptGenRandom on windows.

BUG=

Review URL: https://codereview.chromium.org//11175030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13870 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 13:08:42 +00:00
floitsch@google.com 9074fd0178 Make hashCode a getter and not a method.
Review URL: https://codereview.chromium.org//11191078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13866 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 12:41:04 +00:00
lrn@google.com 89f5daea9e Rename OutOfMemoryException to OutOfMemoryError.
This is a reapply with missing status file changes.

TBR=kasperl@google.com

Review URL: https://codereview.chromium.org//11233004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13822 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 14:01:24 +00:00
kasperl@google.com f7a56d3f70 Revert "Rename OutOfMemoryException to OutOfMemoryError."
This reverts r13818.

TBR'ed.

R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//11229003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13820 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 13:11:15 +00:00
lrn@google.com 58f3453267 Rename OutOfMemoryException to OutOfMemoryError.
Also move ExceptionImplementation to core.

Review URL: https://codereview.chromium.org//11228002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13818 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 12:20:52 +00:00
justinfagnani@google.com eccacec370 Skip package_isolate_test in dart2js
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=13754

Review URL: https://codereview.chromium.org//11192038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13797 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 20:34:30 +00:00
regis@google.com 8c3cfbb381 Second round of cleanups for new optional parameter semantics.
Review URL: https://codereview.chromium.org//11194025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13759 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 20:58:19 +00:00
justinfagnani@google.com 7922339ee4 Skip package_isolate_test in dart2js
BUG=

Review URL: https://codereview.chromium.org//11192038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13754 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 19:25:17 +00:00
justinfagnani@google.com 1dfb9473c1 Allow package: imports inside isolates
BUG=http://dartbug/5915

Review URL: https://codereview.chromium.org//11195017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13752 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 18:14:38 +00:00
ager@google.com ff9e0f75fb Change Process.start to return a future that completes with a
Process object only when the process has been successfully started.

This is less error prone since you can use all the methods on a
Process object as soon as you can get your hands on it. Unfortunately,
this change leads to quite a few changes in test.dart. Some of those
changes will fix bugs as well. We used to have a problem with a
timeout that could fire just in between two steps in a chain of
commands that constitute one test run. This change should address
that issue as well.

BUG=dartbug.com/5305

Review URL: https://codereview.chromium.org//11091070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13729 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 10:57:45 +00:00
srdjan@google.com 0fbac5fea6 Disable int_array_test for dart2js since scalarlists are not yet supported in dart2js.
Review URL: https://codereview.chromium.org//11184009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13705 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 21:59:45 +00:00
johnmccutchan@google.com 64da247024 Intrinsify writing to Uint8 and Int8 arrays on IA32.
Review URL: https://codereview.chromium.org//11074016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13703 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 21:39:18 +00:00
johnmccutchan@google.com 180917268a Intrinsify natural world typed array getters
Review URL: https://codereview.chromium.org//11139004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13696 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 18:52:14 +00:00