Commit Graph

2501 Commits

Author SHA1 Message Date
sgjesse@google.com 09452722cf Update status file
The test standalone/io/https_client_test does not exist any more

The test standalone/io/web_socket_test can still fail on Windows

The test standalone/io/http_content_length_test is seen failing
on Windows

The rest is re-organizing the order.

TBR=ajohnsen@google.com

BUG=

Review URL: https://codereview.chromium.org//12379038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19275 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 07:49:45 +00:00
ajohnsen@google.com 9cf108141b Close HttpServer in WebSocket tests.
BUG=

Review URL: https://codereview.chromium.org//12386026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19250 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 17:43:37 +00:00
ajohnsen@google.com ba6eee87c1 Keep track of closing socket, in WebSocket, so we don't write once the socket is closed.
BUG=

Review URL: https://codereview.chromium.org//12380029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19248 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 17:19:57 +00:00
sgjesse@google.com 7b36502d77 Make sure that no decrypted text gets stuck in the plaintext buffer
When read events are enabled on a raw secure sockets, we need to fire
off a read event if there is data in the plaintext buffer. We cannot
rely on the underlying raw socket firing off another read event even
if it is open.

R=whesse@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=8824

Review URL: https://codereview.chromium.org//12385024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19247 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 17:16:03 +00:00
whesse@google.com 1c17911963 dart:io | Split raw_server_socket_cancel test off from raw_socket_test.
BUG=standalone/io/raw_server_socket_cancel_test

Review URL: https://codereview.chromium.org//12381013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19241 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 16:02:03 +00:00
ajohnsen@google.com a49bab52c7 Mark stdout_bad_argument_test as failing in checked mode, on purpose.
BUG=

Review URL: https://codereview.chromium.org//12386020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19233 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 14:33:01 +00:00
ajohnsen@google.com b6f9a3e395 Correctly close done future with an error, before a normal complete can happen.
BUG=

Review URL: https://codereview.chromium.org//12387014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19229 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 14:16:05 +00:00
floitsch@google.com 51212d24ed Remove deprecated ms arguments for Timer and Future.
Review URL: https://codereview.chromium.org//12342014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19220 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 13:24:12 +00:00
whesse@google.com 1574509be5 dart:io | Remove some test supressions, restore a macos supression section.
BUG=dartbug.com/8795

Review URL: https://codereview.chromium.org//12381010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19214 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 12:14:44 +00:00
ajohnsen@google.com 4ce60f302e Implement addStream for HttpClientRequest/HttpResponse and propegate all write-errors from the socket.
BUG=https://code.google.com/p/dart/issues/detail?id=8821

Review URL: https://codereview.chromium.org//12317147

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19213 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 11:55:03 +00:00
sgjesse@google.com a6bea0c569 Fix errors in checked mode
TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12314156

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19147 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 15:54:10 +00:00
sgjesse@google.com a1ffe8a451 Make File.readSync return only the bytes read
R=ager@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=8831
TEST=tests/standalone/io/file_test.dart

Review URL: https://codereview.chromium.org//12315129

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19145 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 15:33:08 +00:00
whesse@google.com 6ef35edef1 dart:io | Rename File.name to File.path.
BUG=dartbug.com/8790

Review URL: https://codereview.chromium.org//12314153

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19144 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 15:26:11 +00:00
whesse@google.com 88aea12de7 dart:io | Fix issue 8795, (Raw)SecureSocket loses data when close() is called.
BUG=dartbug.com/8795

Review URL: https://codereview.chromium.org//12313146

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19133 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 13:23:13 +00:00
sgjesse@google.com c1698fb54f Fix issue 8828
R=ajohnsen@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=8828
TEST=tests/standalone/io/regress_8828_test.dart

Review URL: https://codereview.chromium.org//12334119

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19126 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 12:49:22 +00:00
sgjesse@google.com 6c380026a9 Issue 5071 is now fixed
Added test

R=ajohnsen@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=5071

Review URL: https://codereview.chromium.org//12340103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19124 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 11:39:59 +00:00
ajohnsen@google.com 4cd2ec277e Fix http_close_test to wait for server close.
The client can receive data before the server is aware the data is sent.

BUG=

Review URL: https://codereview.chromium.org//12334117

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19113 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 08:57:54 +00:00
lrn@google.com 6b4f4b1bab Change new List(n) to return fixed length list.
Deprecate List.fixedLength, add List.filled.

Make Iterable.toList and List.from take "growable" argument,
defaulting to false.

Review URL: https://codereview.chromium.org//12328104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 08:45:04 +00:00
ajohnsen@google.com 7912f3f1bd Rewrite the Future-pipeline from the Socket to the HttpClientRequest/HttpResponse.
Before we had two future, HttpClientRequest/HttpResponse.done and
Socket.addStream's return valud(stored as _writeDoneFuture in
    http_impl). Many issues in our code was based on the futures not
being the same, that the user will get a done event, while the socket is
still writing data on the socket.

Immidiate calls to HttpServer/HttpClient.close, after e.g. pipe, would
then destroy the socket while still having data in dart buffers.

The new approach makes sure that there is a direct future link between
the socket and the user.

BUG=

Review URL: https://codereview.chromium.org//12328114

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19111 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 08:27:12 +00:00
sgjesse@google.com 9ade1e4617 Update status file
TBR=ajohnsen@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=8824

Review URL: https://codereview.chromium.org//12328133

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19109 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 07:41:52 +00:00
whesse@google.com 02f82f5ab0 dart:io | Enable tests of secure websocket connections.
BUG=

Review URL: https://codereview.chromium.org//12340072

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19049 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 16:02:48 +00:00
sgjesse@google.com 993865a051 Fix subscription handling in stream decoder
The _StringDecoder did not handle unsubscribe correctly (the added
test did not terminate as the unsubscribe did not cause stdin to be
closed)

Fixed by extending StreamEventTransformer which has all the
logic. Changed a number of other transformers to use
StreamEventTransformer as well.

Fixed a bug in the StreamEventTransformer implementation.

R=floitsch@google.com

BUG=

Review URL: https://codereview.chromium.org//12313127

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19046 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 15:24:22 +00:00
sgjesse@google.com f59f084587 Fix error in status file
TBR=whesse@google.com

BUG=

Review URL: https://codereview.chromium.org//12334090

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19041 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 13:48:16 +00:00
sgjesse@google.com 6d9d0d8c9c Update status file
standalone/io/raw_secure_socket_pause_test can fail on Windows

TBR=whesse@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=8795

Review URL: https://codereview.chromium.org//12326122

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19040 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 12:31:44 +00:00
sgjesse@google.com 5d0a6bf08f Update status file
standalone/io/raw_secure_socket_test can fail on Windows

TBR=whesse@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=8795

Review URL: https://codereview.chromium.org//12342009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19035 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 11:16:03 +00:00
sgjesse@google.com e92dc863e8 Update status file
standalone/io/secure_socket_test can fail on Windows

TBR=whesse@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=8795

Review URL: https://codereview.chromium.org//12313122

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19034 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 10:22:05 +00:00
sgjesse@google.com 7334cfe100 Don't use external servers in the tests
The use of external servers can lead to unwanted flakiness.

The socket reuse tests where removed alltogether as they where not
testing socket reuse anymore than a lot of the other HTTP/HTTPS tests.

This change revealed some issues with srcure sockets and short writes,
so the short writes are disabled until this is resolved.

R=ajohnsen@google.com

BUG=

Review URL: https://codereview.chromium.org//12330133

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19032 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 09:48:46 +00:00
sgjesse@google.com 90c5e1d30a Don't use strange DNS names HTTP proxy test in Windows
This is an experiment to see if the strange DNS names are related to
the long running time of this test on Windows. It almost always takes
more that 30 sec. on our Windows bots.

R=ajohnsen@google.com

BUG=

Review URL: https://codereview.chromium.org//12317100

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18977 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 16:29:40 +00:00
whesse@google.com 77a1a0c56a dart:io | Fix writing to a Socket while and after calling destroy() on it.
BUG=dartbug.com/8681
TEST=standalone/io/http_client_request_test

Review URL: https://codereview.chromium.org//12330109

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18969 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 14:52:39 +00:00
whesse@google.com 6410628b6b dart:io: Prevent initial WRITE event on RawSecureSocket when writeEventsEnabled is set to false.
BUG=dartbug.com/8736
TEST=standalone/io/raw_secure_server_socket_test

Review URL: https://codereview.chromium.org//12320088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18967 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 14:41:18 +00:00
lrn@google.com 3c0ac360e7 Remove deprecated string features.
Make String.codeUnits return a List.

Review URL: https://codereview.chromium.org//12282038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
ager@google.com 7fe6f5d6a4 Update status files with current dart:io v2 status.
Removed 'OK' marks in status file. It is definitely not ok if
these tests fail.

Broadened supressions for a couple of tests that have been
failing on Linux as well as Windows.

R=whesse@google.com,sgjesse@google.com,ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//12314094

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18956 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 07:13:17 +00:00
efortuna@google.com c534fa2cd9 Update io/secure_client_raw_server_test status.
BUG=

Review URL: https://codereview.chromium.org//12326082

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18922 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 22:10:16 +00:00
efortuna@google.com 18cf1ef956 Update test status for raw_secure_server_socket_test.
BUG=

Review URL: https://codereview.chromium.org//12334049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18918 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 21:47:56 +00:00
whesse@google.com 9d2c8b0d71 dart:io Improve raw_secure_server_socket_test to pin down problem.
BUG=

Review URL: https://codereview.chromium.org//12316071

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18894 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 15:50:07 +00:00
ajohnsen@google.com 8810e2b0ea Reset http-parser instead of only setting _state, when we have handled a full request-response conversation.
BUG=

Review URL: https://codereview.chromium.org//12314065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18892 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 14:08:21 +00:00
whesse@google.com 8e24228b77 Remove old InputStream and OutputStream classes from dart:io.
BUG=

Review URL: https://codereview.chromium.org//12313057

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18891 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 14:05:06 +00:00
ajohnsen@google.com 04cc4cc2a5 Add asserts to kqueue filter/events on mac.
BUG=

Review URL: https://codereview.chromium.org//12334036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18880 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 11:51:24 +00:00
ajohnsen@google.com 5068d80262 Handle legacy epoll event on Linux.
This should fix flaky tests on older versions of Linux (including those
    running buildbot).

Also re-enable test on linux.

BUG=

Review URL: https://codereview.chromium.org//12319067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18873 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 09:51:08 +00:00
whesse@google.com 59021040b7 dart:io SecureSocket error fixed.
BUG=dartbug.com/8673

Review URL: https://codereview.chromium.org//12315033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18870 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 09:06:20 +00:00
ager@google.com 1b834e40c7 Broaden suppression for http_proxy test which has timed out on both Windows and Mac as well.
R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//12321073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18866 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 06:36:22 +00:00
srdjan@google.com 277be5bbc0 Disable test for dart2js since it does not support large integers.
Review URL: https://codereview.chromium.org//12335022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18861 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 23:01:50 +00:00
srdjan@google.com 19995faa3a Recognize pattern (a << b) & c with c being a positive Smi and allow left shift to truncate the result.
Review URL: https://codereview.chromium.org//12218181

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18859 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 22:24:42 +00:00
sgjesse@google.com 5cba8f5e9b Update status file
TBR=ajohnsen@google.com

BUG=

Review URL: https://codereview.chromium.org//12321052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18841 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 16:51:38 +00:00
sgjesse@google.com d4ba577786 Update status file
TBR=whesse@google.com

BUG=

Review URL: https://codereview.chromium.org//12334011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18839 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 16:31:36 +00:00
sgjesse@google.com 6b42a20f46 Update status file with IO v2 flake
R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12313034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18831 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 14:01:47 +00:00
ajohnsen@google.com bf4873e420 Mark two secure tests as flaky.
BUG=

Review URL: https://codereview.chromium.org//12321048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18823 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 12:21:57 +00:00
sgjesse@google.com a7f2f94695 Add missing files from previous commit
TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12328037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18821 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 12:08:34 +00:00
sgjesse@google.com 488b016a2f Merge IO v2 branch to bleeding edge
R=ager@google.com, ajohnsen@google.com, whesse@google.com

BUG=

Review URL: https://codereview.chromium.org//12316036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 11:58:11 +00:00
sgjesse@google.com 7ae583ac58 Support connecting to HTTPS URL's through a proxy
The communication from the client to the proxy server is not secure.

R=ajohnsen@google.com
BUG=http://code.google.com/p/dart/issues/detail?id=5454

Review URL: https://codereview.chromium.org//12314007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18759 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 14:37:25 +00:00