Commit Graph

29 Commits

Author SHA1 Message Date
Alexander Aprelev 6b3abe0a98 [vm/concurrency] Add --experimental_enable_isolate_groups_jit flag, make --enable_isolate_groups AOT only.
Issue b/177800357.

TEST=existing test suite
Change-Id: Id6b113932ab7014b8fa6c105845c5c490b60f5e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181320
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2021-01-27 17:11:29 +00:00
Robert Nystrom 35da19ac07 Migrate standalone_2 to null safety.
Change-Id: I0e97add738bc79314a210cf137525b7391467fc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152595
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
2020-06-26 19:17:50 +00:00
Siva Annamalai bc4860b0cb Most VM specific tests in standalone have been moved to standalone_2 and are being run in the regular bot tests. These tests are for VM functionality like io, process API etc. and have no strong mode implications. Currently we are running these tests twice once from standalone and once from standalone_2.
This CL removes these redundant tests from the standalone directory.

Bug:
Change-Id: Ib0adfa67fffa4de486e847698e18353fb4dd8a46
Reviewed-on: https://dart-review.googlesource.com/18429
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2017-11-07 23:00:00 +00:00
William Hesse 7bf2788bcc Restore all deleted tests to tests/standalone from migration to standalone_2
We are no longer deleting tests from the Dart 1 test directories when we
add them to the _2 directories. This reverts the part of change
https://dart-review.googlesource.com/c/sdk/+/12240 that modifies
the tests/standlone directory.
Bug:
Change-Id: Ie26b185234d0d18736a2fa13b77c5fd42cbb7e92
Reviewed-on: https://dart-review.googlesource.com/12287
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-09 10:46:55 +00:00
Siva Annamalai bd2a8e1d60 Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory.
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2017-10-07 01:29:36 +00:00
Siva Annamalai ff32187145 Revert "Migrate most of the tests in standalone to be strong mode clean and move"
This reverts commit c85563f582.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Migrate most of the tests in standalone to be strong mode clean and move
> them to standalone_2 directory.
> 
> Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
> Reviewed-on: https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2017-10-06 17:24:20 +00:00
Siva Annamalai c85563f582 Migrate most of the tests in standalone to be strong mode clean and move
them to standalone_2 directory.

Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-06 17:07:34 +00:00
Jacob Richman 14531fa62d Re-land "Format all multitests"
Only delta from the original is a bad merge of tests/corelib/list_test.dart

This reverts commit 44d8be0ed3.

BUG=

Review-Url: https://codereview.chromium.org/2774783002 .
2017-03-23 12:40:21 -07:00
Jacob Richman 44d8be0ed3 Revert "Format all multitests"
This reverts commit 312b66dd5f.

BUG=

Review-Url: https://codereview.chromium.org/2770063002 .
2017-03-23 10:49:40 -07:00
Jacob Richman 312b66dd5f Format all multitests
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2768073002 .
2017-03-23 10:26:44 -07:00
Jacob Richman 88eb557b65 Fix warnings_checker.dart handling of multitests
Update all tests

Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com
BUG=

Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
2017-03-21 17:29:56 -07:00
Jacob Richman bf2b545150 Revert "Update all tests"
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
2017-03-21 16:33:18 -07:00
Jacob Richman 3c7353d987 Update all tests
Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2765693002 .
2017-03-21 12:39:28 -07:00
Jacob Richman 6a7d6c385e Add comments
Add spaces to make sure dartfmt doesn't destroy bespoke indentation

BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/2763823002 .
2017-03-20 21:03:12 -07:00
Jan-Hendrik Dolling 89560c68a0 change "the the" to the 2016-10-28 21:47:50 +02:00
Siva Annamalai da1a5534b4 Fix for issue 26555, do not inherit package root and package config from the parent isolate when doing Isolate.spawn
BUG=26555
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2072873002 .
2016-06-17 09:59:15 -07:00
Lasse R.H. Nielsen 191ab42d64 Make VM resolvePackageUri fail on package:foo and package:/foo.
R=asiva@google.com, floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/eb49613cbfaca2167b124ab01064a2412ff844a5

Review URL: https://codereview.chromium.org/1998603002 .
2016-06-14 12:22:15 +02:00
Lasse R.H. Nielsen a5aebce4b7 Revert "Make VM resolvePackageUri fail on package:foo and package:/foo."
There were some tests of the changed behavior.

R=whesse@google.com

Review URL: https://codereview.chromium.org/2068633002 .
2016-06-14 10:53:08 +02:00
Lasse R.H. Nielsen eb49613cbf Make VM resolvePackageUri fail on package:foo and package:/foo.
R=asiva@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org/1998603002.
2016-06-14 09:38:51 +02:00
Lasse R.H. Nielsen 419873dcd3 Add tests for resolving missing packages, relative and absolute URIs.
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2051433002 .
2016-06-09 11:35:15 +02:00
Lasse R.H. Nielsen c7e601c90d Revert "Add package-config tests where test is running in Isolate.spawn-isolates."
This reverts commit f3f6d1e00d.

Running a new process doesn't correctly pass empty command line parameters on Windows.

Committed: https://github.com/dart-lang/sdk/commit/151d1b67961d3be2a7dc8f5f76948ccbfe045fcb

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d8e63e9859a388cd1a3847ef5d20a32ace52c6c

Review URL: https://codereview.chromium.org/2038033002.
2016-06-06 08:46:58 +02:00
Lasse R.H. Nielsen 2d8e63e985 Revert "Add package-config tests where test is running in Isolate.spawn-isolates."
This reverts commit f3f6d1e00d.

Running a new process doesn't correctly pass empty command line parameters on Windows.

Committed: https://github.com/dart-lang/sdk/commit/151d1b67961d3be2a7dc8f5f76948ccbfe045fcb

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2038033002.
2016-06-03 17:12:17 +02:00
Lasse R.H. Nielsen 0bd6b7e924 Add package-config tests where test is running in Isolate.spawn-isolates.
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/f3f6d1e00da547acad377b5a08260dd51d16abb9

Committed: https://github.com/dart-lang/sdk/commit/eda2a81c0c8bada3b40b88a60cb5a463f3aaf3db

Review URL: https://codereview.chromium.org/2020653002.
2016-06-03 16:48:21 +02:00
Lasse R.H. Nielsen eda2a81c0c Add package-config tests where test is running in Isolate.spawn-isolates.
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/f3f6d1e00da547acad377b5a08260dd51d16abb9

Review URL: https://codereview.chromium.org/2020653002.
2016-06-03 16:35:27 +02:00
Lasse R.H. Nielsen 151d1b6796 Revert "Add package-config tests where test is running in Isolate.spawn-isolates."
This reverts commit f3f6d1e00d.

Running a new process doesn't correctly pass empty command line parameters on Windows.

Review URL: https://codereview.chromium.org/2038033002 .
2016-06-03 15:34:52 +02:00
Lasse R.H. Nielsen f3f6d1e00d Add package-config tests where test is running in Isolate.spawn-isolates.
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2020653002 .
2016-06-03 13:53:50 +02:00
Lasse R.H. Nielsen 7009677096 Also add comments requested by review, and some more.
Also exclude more environments from running the test, restricting it to *only* the stand-alone VM and the analyzer.

Review URL: https://codereview.chromium.org/2015193002 .
2016-05-27 13:07:40 +02:00
Lasse R.H. Nielsen dead4294ae Fix analyzer warnings in packages_file_test.dart.
Review URL: https://codereview.chromium.org/2013353003 .
2016-05-27 10:11:45 +02:00
Lasse R.H. Nielsen 39df5d56b2 Add test of some package-config configurations.
More to come.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1993643002 .
2016-05-27 09:19:16 +02:00