3433d8cfc3
[nnbd] Migrate standalone/io to NNBD.
...
The tests are also now dartfmt.
Bug: https://github.com/dart-lang/sdk/issues/40040
Change-Id: I8dece8097b37b70d47a5374dae2f3fadb0fc4b90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134338
Commit-Queue: Jonas Termansen <sortie@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-02-07 14:41:36 +00:00
bc4860b0cb
Most VM specific tests in standalone have been moved to standalone_2 and are being run in the regular bot tests. These tests are for VM functionality like io, process API etc. and have no strong mode implications. Currently we are running these tests twice once from standalone and once from standalone_2.
...
This CL removes these redundant tests from the standalone directory.
Bug:
Change-Id: Ib0adfa67fffa4de486e847698e18353fb4dd8a46
Reviewed-on: https://dart-review.googlesource.com/18429
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
2017-11-07 23:00:00 +00:00
7bf2788bcc
Restore all deleted tests to tests/standalone from migration to standalone_2
...
We are no longer deleting tests from the Dart 1 test directories when we
add them to the _2 directories. This reverts the part of change
https://dart-review.googlesource.com/c/sdk/+/12240 that modifies
the tests/standlone directory.
Bug:
Change-Id: Ie26b185234d0d18736a2fa13b77c5fd42cbb7e92
Reviewed-on: https://dart-review.googlesource.com/12287
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com >
2017-10-09 10:46:55 +00:00
bd2a8e1d60
Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory.
...
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2017-10-07 01:29:36 +00:00
ff32187145
Revert "Migrate most of the tests in standalone to be strong mode clean and move"
...
This reverts commit c85563f582https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com >
TBR=bkonyi@google.com ,asiva@google.com
Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2017-10-06 17:24:20 +00:00
c85563f582
Migrate most of the tests in standalone to be strong mode clean and move
...
them to standalone_2 directory.
Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com >
2017-10-06 17:07:34 +00:00
2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
7c0688a5c6
Ensure ZILB encoder handles all typed data lists correctly
...
R=ajohnsen@google.com , lrn@google.com
BUG= https://github.com/dart-lang/sdk/issues/24521
Review URL: https://codereview.chromium.org/1393013002 .
2015-10-08 18:19:02 +02:00
3f135836fe
Use actual length of dictionary, and not size of a pointer, in zlib.
...
BUG=
R=lrn@google.com
Review URL: https://codereview.chromium.org//185773004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33213 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 13:12:23 +00:00
d6d130abc9
Don't match directly on gzip output of empty message, as it's not strictly specified.
...
Fixes test failure on Windows.
BUG=
R=lrn@google.com
Review URL: https://codereview.chromium.org//183763021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33211 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 12:25:25 +00:00
a22e98f539
[ZLIB] Add support for windowBits, memLevel, raw
...
BUG=159367
**BC breaks:**
All public (API) classes that used to be const are not const any more. This allow checking the validity of input parameters in the constructor body.
- ZLibCodec,
- GZipCodec,
- ZLibEncoder,
- ZLibDecoder
The globals codecs GZIP and ZLIB are now final we should be ok (the class contain only final properties, ie no state).
What should be done:
(- finer grained exceptions, -> later change)
(- Handle the flush modes but probably in an other patch as the updates might be more complex.)
Done:
Patch Set #1
- add some more docs,
- support for memLevel.
Patch Set #2 :
- implement dictionaries (todo: fix mem management),
- integrate review feedback,
- fix CC,
- rebased on master
Patch Set #4 :
- support for strategy,
- add some checks (ie checking the level, memLevel, ...) this could imply adding a constructor body (Codecs, Coders) but this would force making the const non const and break BC, thoughts ?
- Add ZLIB constants Dart side.
- Refactor the tests and test only some levels rather all which was unit testing rather more than the extension. It saves some test time.
Patch Set #8 :
- fix mem management for dictionaries,
R=ajohnsen@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//130513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33206 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 11:43:09 +00:00
18c75d3dc2
Update dart:io tests to use asyncStart/asyncEnd
...
R=ajohnsen@google.com
BUG=http://dartbug.com/12977
Review URL: https://codereview.chromium.org//23886004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27054 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 13:42:56 +00:00
cf6578fafe
Update ZLib/GZip in dart:io to be a Codec/Converter from dart:convert.
...
BUG=
R=floitsch@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//22867033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26577 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 07:12:11 +00:00
faa7227cec
Make new StreamController be async by default.
...
Change all instances, except some tests, to be sync still.
Rename Multiplex to Broadcast everywhere.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//16125005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23453 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 06:07:39 +00:00
1e7a090f26
Actually end a ZLib stream with a Z_FINISH marker.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//14962006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22830 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 06:28:30 +00:00
8fd6d0aafd
Remove Expect from core library.
...
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
bef8ebb5f6
Add Iterable.fold (and Stream.fold) which replace reduce.
...
For now this is just a copy. In a next step we will change the behavior of
`reduce`.
BUG= http://dartbug.com/9536
Review URL: https://codereview.chromium.org//13548002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20978 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 16:12:40 +00:00
844cd39fad
Change getRange to sublist. Make getRange deprecated.
...
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.
Review URL: https://codereview.chromium.org//12817003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 09:15:39 +00:00
5946117315
Fix empty zlib deflate and early close of responses.
...
BUG=
Review URL: https://codereview.chromium.org//12661003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19910 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 08:24:50 +00:00
5dc8107c53
Revert "Remove Expect from core library."
...
This reverts commit 19755.
Review URL: https://codereview.chromium.org//12743005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
12dbd2fd70
Remove Expect from core library.
...
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
ed3d5eefe7
Fix zlib test on Windows.
...
BUG=
Review URL: https://codereview.chromium.org//12533003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19556 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 12:46:44 +00:00
28daa7ba59
Introduce ZLibInflater and ZLibDeflater to dart:io.
...
BUG=
Review URL: https://codereview.chromium.org//12451004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19551 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 11:38:41 +00:00
Jonas Termansen