dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

22 Commits

Author SHA1 Message Date
Leaf Petersen d44457f79d [Core Libraries] Eliminate the fork in the core libraries. 
Move the nnbd core libraries from sdk_nnbd to sdk, and updates
references in build files and elsewhere accordingly.

Change-Id: I09760fe1e006657aacdfe80f3b22fdf6f7e30a9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151121
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-06-16 23:37:36 +00:00
Leaf Petersen d2543e32f4 Migrate standalone tests which rely on the pre-nnbd sdk libraries. 
Migrate all the tests under standalone/ that include files under
sdk/sdk/ as part files to unblock the replacement of the unmigrated
sdk/sdk with the contents of the migrated sdk/sdk_nnbd.

Change-Id: Ia2e78bbff797f58244d94021d4b9616793bd641d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151036
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2020-06-15 19:41:46 +00:00
Zichang Guo 913cf2583e Revert "[dart:io] Fixes Ping/Pong mechanism not updating readyState when closing" 
This reverts commit ac5b24123d.

Reason for revert: Tests are hanging on Windows. https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8882288664919412608/+/steps/test_results/0/logs/new_test_failures__logs_/0

Original change's description:
> [dart:io] Fixes Ping/Pong mechanism not updating readyState when closing
> 
> Bug: https://github.com/dart-lang/sdk/issues/33362
> Change-Id: Icf21ad5c9b66c4176ec65e018f9499b24690ed2c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143890
> Commit-Queue: Zichang Guo <zichangguo@google.com>
> Reviewed-by: Jonas Termansen <sortie@google.com>

TBR=sortie@google.com,asiva@google.com,zichangguo@google.com

Change-Id: I6f32f4a5bf29d949f26381394ce16e103e715c65
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/33362
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144490
Reviewed-by: Zichang Guo <zichangguo@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2020-04-22 21:28:11 +00:00
Zichang Guo ac5b24123d [dart:io] Fixes Ping/Pong mechanism not updating readyState when closing 
Bug: https://github.com/dart-lang/sdk/issues/33362
Change-Id: Icf21ad5c9b66c4176ec65e018f9499b24690ed2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143890
Commit-Queue: Zichang Guo <zichangguo@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2020-04-22 20:12:59 +00:00
Zichang Guo d8f5ca49c5 [dart:io] webSocket pingInterval doesn't close the connection 
pingInterval api pages says, when pong is not received on time, the connection will be closed. But our implementation didn't follow the description.

Bug: https://github.com/dart-lang/sdk/issues/39469
Change-Id: Ic62b8ab0152997ac60b1b836d6a1587d9ce38131
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138760
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2020-03-18 19:51:19 +00:00
Jonas Termansen 3433d8cfc3 [nnbd] Migrate standalone/io to NNBD. 
The tests are also now dartfmt.

Bug: https://github.com/dart-lang/sdk/issues/40040
Change-Id: I8dece8097b37b70d47a5374dae2f3fadb0fc4b90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134338
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-02-07 14:41:36 +00:00
Siva Annamalai bc4860b0cb Most VM specific tests in standalone have been moved to standalone_2 and are being run in the regular bot tests. These tests are for VM functionality like io, process API etc. and have no strong mode implications. Currently we are running these tests twice once from standalone and once from standalone_2. 
This CL removes these redundant tests from the standalone directory.

Bug:
Change-Id: Ib0adfa67fffa4de486e847698e18353fb4dd8a46
Reviewed-on: https://dart-review.googlesource.com/18429
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2017-11-07 23:00:00 +00:00
William Hesse 7bf2788bcc Restore all deleted tests to tests/standalone from migration to standalone_2 
We are no longer deleting tests from the Dart 1 test directories when we
add them to the _2 directories. This reverts the part of change
https://dart-review.googlesource.com/c/sdk/+/12240 that modifies
the tests/standlone directory.
Bug:
Change-Id: Ie26b185234d0d18736a2fa13b77c5fd42cbb7e92
Reviewed-on: https://dart-review.googlesource.com/12287
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-10-09 10:46:55 +00:00
Siva Annamalai bd2a8e1d60 Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory. 
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2017-10-07 01:29:36 +00:00
Siva Annamalai ff32187145 Revert "Migrate most of the tests in standalone to be strong mode clean and move" 
This reverts commit c85563f582.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Migrate most of the tests in standalone to be strong mode clean and move
> them to standalone_2 directory.
> 
> Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
> Reviewed-on: https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2017-10-06 17:24:20 +00:00
Siva Annamalai c85563f582 Migrate most of the tests in standalone to be strong mode clean and move 
them to standalone_2 directory.

Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-06 17:07:34 +00:00
Ryan Macnak f1578b2146 [test] Update library name to make analyzer happy with sideways import of crypto.dart. 
Change-Id: I7f7bdf820f7bd9066420c9cd99f87c28c713079f
Reviewed-on: https://dart-review.googlesource.com/10582
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2017-10-03 19:14:39 +00:00
Ryan Macnak 4b64a835b9 [vm] Remove dead crypto.dart from dart:io. 
Both dart:io and dart:_http have scripts whose uri is just 'crypto.dart'. This confuses vm-service clients who incorrectly assume that scripts are uniquely identified by uri.

Change-Id: I387c42d32f9e1a2aabf03d9d1a89ed4703f0f40d
Reviewed-on: https://dart-review.googlesource.com/10211
Reviewed-by: Zach Anderson <zra@google.com>
 2017-10-03 16:58:18 +00:00
Ryan Macnak 1bfd01c1f7 Revert "Use relative URIs for core library part-of statements." 
This reverts commit 62bc61b367.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2968413002 .
 2017-07-07 11:18:24 -07:00
Lasse R.H. Nielsen 62bc61b367 Use relative URIs for core library part-of statements. 
Reapply "Change some platform libraries to use `part of URI`."
Change to used relative URIs in the part-of declarations.

R=brianwilkerson@google.com, floitsch@google.com

Review-Url: https://codereview.chromium.org/2911903002 .
 2017-07-03 10:04:06 +02:00
Jacob Richman 2dcd56ef43 Format all tests. 
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
 2017-04-17 14:53:02 -07:00
ajohnsen@google.com 5b151dafac Add library tag to web_socket_ping_test. 
BUG=

Review URL: https://codereview.chromium.org//23436005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27000 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-02 08:58:03 +00:00
ajohnsen@google.com 092a50623d Fix web_socket_ping_test to not use any timeouts longer than 100 ms. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//23627003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26998 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-02 08:46:14 +00:00
ajohnsen@google.com 027a6a42f9 Revert 25425 and disable web_socket_ping_test on simulators for now. 
Revert "Implement correct back-throttleing for web-sockets."

BUG=

Review URL: https://codereview.chromium.org//19563006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25427 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-24 17:30:52 +00:00
ajohnsen@google.com 5653113f78 Implement correct back-throttleing for web-sockets. 
This makes it possible to implement a simpler version of
web_socket_ping_test, that doesn't have to involve timers.

BUG=

Review URL: https://codereview.chromium.org//19596008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25425 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-24 17:15:49 +00:00
ajohnsen@google.com ff2827c26f Make web_socket_ping_test pass on simulators, where it takes > 100ms to send data between sockets(!). 
BUG=

Review URL: https://codereview.chromium.org//20088002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25416 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-24 14:27:26 +00:00
ajohnsen@google.com eca9e4cf64 Add ability to send a ping interval on a WebSocket. 
By enabling it, ping messages can be used to ensure if a websocket
connection is open. However, as it depends on the remote peer to support
ping/pong, it's disabled by default.

BUG=https://code.google.com/p/dart/issues/detail?id=7366
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//19970004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25410 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-24 12:51:53 +00:00