There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
Implements SecurityContext.setTrustedCertificates in terms of the new
function. This requires setTrustedCertificates to return a Future,
and removing the `directory` named argument as it is not possible to
implement with BoringSSL without blocking IO.
R=whesse@google.com
Review URL: https://codereview.chromium.org/1665433002 .
This is the first step toward removing blocking IO calls from
the implementation of the SecurityContext API.
Using a buffer rather than a file name API will probably be needed
for implementing SecurityContext and SecureSocket with platform
specific built-in APIs on iOS/Mac/Windows rather than BoringSSL.
related #8227R=whesse@google.com
Review URL: https://codereview.chromium.org/1616073004 .
Resolve issue with server applying context takeover when not enabled.
After resolving negotiation and optimizing client/server takeover usage
an bug became apparent where no context takeover was being applied but
not advertised by the server.
This patch resolves that issue and adds tests to validate in the future.
Ensure encoders/decoders are properly 'discarded' when client_no_context_takeover
and server_no_context_takeover flags are detected.
Resolve issues with client not sending appropriate header request values based
on the configured passed by CompressionOptions.
Add tests for client header values
BUG=25317
Patch by Matthew Butler <butler.matthew@gmail.com>
R=sgjesse@google.com
Review URL: https://codereview.chromium.org/1584653008 .
I undid the patch John McCutchan did to disable compression and compiled and verify that Chrome does not experience any issues with websocket compression negotiation and that compression is enabled.
Also tested with observatory on Firefox and Edge (IE) and both work with current configuration.
BUG=#24864
subject: Ensure proper response to chrome client_max_window_bits
R=sgjesse@google.com
Review URL: https://codereview.chromium.org/1437623002 .
Jonas Termansen