dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

32 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen 8760283247 New implementation of runZoned. 
A combination of `runZoned` and `runZonedGuarded` where only the latter allows an `onError` parameter,
and only that has a nullable return type.

Retains the `onError` parameter on `runZoned` for now because it's too breaking to remove it until packages have been migrated off of it.
It will be removed in a follow-up CL.

Change-Id: If0e86c8d14e13fa089c66f4af975aeacb2616cf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137302
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2020-03-25 00:24:33 +00:00
Jonas Termansen 3433d8cfc3 [nnbd] Migrate standalone/io to NNBD. 
The tests are also now dartfmt.

Bug: https://github.com/dart-lang/sdk/issues/40040
Change-Id: I8dece8097b37b70d47a5374dae2f3fadb0fc4b90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134338
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-02-07 14:41:36 +00:00
Siva Annamalai bc4860b0cb Most VM specific tests in standalone have been moved to standalone_2 and are being run in the regular bot tests. These tests are for VM functionality like io, process API etc. and have no strong mode implications. Currently we are running these tests twice once from standalone and once from standalone_2. 
This CL removes these redundant tests from the standalone directory.

Bug:
Change-Id: Ib0adfa67fffa4de486e847698e18353fb4dd8a46
Reviewed-on: https://dart-review.googlesource.com/18429
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2017-11-07 23:00:00 +00:00
William Hesse 7bf2788bcc Restore all deleted tests to tests/standalone from migration to standalone_2 
We are no longer deleting tests from the Dart 1 test directories when we
add them to the _2 directories. This reverts the part of change
https://dart-review.googlesource.com/c/sdk/+/12240 that modifies
the tests/standlone directory.
Bug:
Change-Id: Ie26b185234d0d18736a2fa13b77c5fd42cbb7e92
Reviewed-on: https://dart-review.googlesource.com/12287
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-10-09 10:46:55 +00:00
Siva Annamalai bd2a8e1d60 Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory. 
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2017-10-07 01:29:36 +00:00
Siva Annamalai ff32187145 Revert "Migrate most of the tests in standalone to be strong mode clean and move" 
This reverts commit c85563f582.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Migrate most of the tests in standalone to be strong mode clean and move
> them to standalone_2 directory.
> 
> Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
> Reviewed-on: https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2017-10-06 17:24:20 +00:00
Siva Annamalai c85563f582 Migrate most of the tests in standalone to be strong mode clean and move 
them to standalone_2 directory.

Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-06 17:07:34 +00:00
Jacob Richman 2dcd56ef43 Format all tests. 
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
 2017-04-17 14:53:02 -07:00
sgjesse@google.com 48584debbd Make Socket address and port getters available after the socket is closed 
There getters are used for generating eddor messages.

TBR=ajohnsen@google.com
BUG=

Review URL: https://codereview.chromium.org//985533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44359 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-10 08:54:22 +00:00
sgjesse@google.com 1d808d071b Fixed a number of bugs on RawSocket and Socket 
The checking of the closed state was not present when dealing
with the properties port, remotePort, address and remoteAddress
on RawSocket and Socket. Then now all throw SocketException when
the RawSocket or Socket is closed.

* Calling port on a RawSocket would return the port even if it
  was closed

* Calling remotePort, address and remoteAddress did not check for
  OSError

* Calling remotePort, address and remoteAddress on a closed
  RawSocket caused syscalls using the already closed fd, which
  might also have been re-allocated already.

* Calling port, remotePort, address and remoteAddress on a closed
  Socket caused null pointer exception

R=ajohnsen@google.com

Correctly check for errors when getting remote address and port

BUG=

Review URL: https://codereview.chromium.org//984403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44319 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-09 13:33:28 +00:00
ajohnsen@google.com 8719f3834b Add Observatory test of io. 
Initially a single test of a HttpServer. More will follow.

This also fixes the case where we don't 'block' when binding to a
ServerSocket. We should not close until the socket is explicitly closed.

BUG=
R=johnmccutchan@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//311153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37164 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-10 07:13:52 +00:00
ajohnsen@google.com 140fddd06e Make event-handlers edge-triggered and move socket-state to Dart. 
This eliminates to pause/resume calls made in the previous one-shot based model.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//169383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32780 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-19 09:44:26 +00:00
ajohnsen@google.com 458ccec72f Fix socket to report write errors async. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//96203006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30777 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-29 11:19:57 +00:00
ajohnsen@google.com 5591751c3c Add test of Zones for HttpServer and RawSocketServer. 
BUG=https://code.google.com/p/dart/issues/detail?id=15367
R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//93973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30775 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-29 10:26:00 +00:00
sgjesse@google.com b1a115db63 Fix errors in dart:io tests found by the analyzer 
TBR=ajohnsen@google.com
BUG=

Review URL: https://codereview.chromium.org//23896002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27057 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-03 14:02:21 +00:00
sgjesse@google.com 18c75d3dc2 Update dart:io tests to use asyncStart/asyncEnd 
R=ajohnsen@google.com
BUG=http://dartbug.com/12977

Review URL: https://codereview.chromium.org//23886004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27054 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-03 13:42:56 +00:00
ajohnsen@google.com 2bd55c23c7 Keep track of when a socket has been destroyed 
This adds the event CLOSED to RawSocket and RawServerSocket. This
event indicate that the underlying socket is now destroyed.

This is used to make Socket.close and ServerSocket.close return a
future which is completed when the unserlying socket is
destroyed. This can be used to start listening on the same port after
closing a server socket.

R=ajohnsen@google.com, kustermann@google.com

BUG=https://code.google.com/p/dart/issues/detail?id=4155

Review URL: https://codereview.chromium.org//14864009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25213 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-19 13:26:48 +00:00
whesse@google.com 3e899b1c75 Add tests that drop read events to the dart:io RawSocket and RawSecureSocket tests. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//16961007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24385 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-25 08:14:10 +00:00
ajohnsen@google.com 4a53caed71 Fix raw_socket_test off-by-one issue. 
BUG=http://code.google.com/p/dart/issues/detail?id=8901

Review URL: https://codereview.chromium.org//17386002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24127 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-18 08:29:26 +00:00
sgjesse@google.com 000875ca45 dart:io | Add File.rename 
R=ajohnsen@google.com
BUG=

Review URL: https://codereview.chromium.org//17033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24029 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-14 12:58:21 +00:00
sgjesse@google.com 55709f1f43 Ensure that only byte values are sent by sockets and web sockets 
R=ajohnsen@google.com
BUG=http://dartbug.com/11007

Review URL: https://codereview.chromium.org//16363005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23896 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-12 08:33:16 +00:00
ajohnsen@google.com 5ce3b9ddea Clean up dart:io exceptions. 
- Introduce IOException.
- Remove HttpParserException.
- Merge RedirectLimitExceededException and RedirectLoopException into
RedirectException.
- Remove 'IO' from FileIOException, DirectoryIOException, LinkIOException
and SocketIOException.

BUG=https://code.google.com/p/dart/issues/detail?id=9955
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//16123036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23848 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-11 13:15:46 +00:00
sgjesse@google.com 2fdb878ebe Change the signature for all network bind calls. 
All the bind calls on RawServerSocket, ServerSocket,
RawSecureServerSocket, SecureServerSocket and HttpServer (and
bindSecure on HttpServer) now have mandatory address and port
parameters. All the rest of the parameters are named optional
(including backlog).

The address parameter can be an InternetAddress or a String for all
these calls.

R=ajohnsen@google.com, whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//14640008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22227 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-01 09:14:04 +00:00
floitsch@google.com 5431a5af54 Remove AsyncError with Expando. 
Review URL: https://codereview.chromium.org//14251006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21498 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-15 18:58:32 +00:00
floitsch@google.com bebe3ac2cd Refactor List.setRange function. 
Review URL: https://codereview.chromium.org//13863012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21452 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-15 13:52:29 +00:00
floitsch@google.com 8fd6d0aafd Remove Expect from core library. 
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756

Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-05 19:43:16 +00:00
floitsch@google.com 5dc8107c53 Revert "Remove Expect from core library." 
This reverts commit 19755.

Review URL: https://codereview.chromium.org//12743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-09 03:19:07 +00:00
floitsch@google.com 12dbd2fd70 Remove Expect from core library. 
Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-09 02:40:37 +00:00
whesse@google.com 1c17911963 dart:io | Split raw_server_socket_cancel test off from raw_socket_test. 
BUG=standalone/io/raw_server_socket_cancel_test

Review URL: https://codereview.chromium.org//12381013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19241 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-28 16:02:03 +00:00
floitsch@google.com 51212d24ed Remove deprecated ms arguments for Timer and Future. 
Review URL: https://codereview.chromium.org//12342014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19220 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-28 13:24:12 +00:00
lrn@google.com 6b4f4b1bab Change new List(n) to return fixed length list. 
Deprecate List.fixedLength, add List.filled.

Make Iterable.toList and List.from take "growable" argument,
defaulting to false.

Review URL: https://codereview.chromium.org//12328104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19112 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-27 08:45:04 +00:00
sgjesse@google.com a7f2f94695 Add missing files from previous commit 
TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//12328037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18821 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-21 12:08:34 +00:00