7df1498352
[nnbd/libs] Fixing more strong mode tests
...
Change-Id: I5c9080ed75112479ddbeaf6485a5beab3bcb2717
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142209
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
Commit-Queue: Liam Appelbe <liama@google.com >
2020-04-03 17:30:09 +00:00
3433d8cfc3
[nnbd] Migrate standalone/io to NNBD.
...
The tests are also now dartfmt.
Bug: https://github.com/dart-lang/sdk/issues/40040
Change-Id: I8dece8097b37b70d47a5374dae2f3fadb0fc4b90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134338
Commit-Queue: Jonas Termansen <sortie@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-02-07 14:41:36 +00:00
0b045aea2b
[ VM ] Removed tests/standalone along with any references in build bot / test runner configurations
...
Deleted irrelevant tests and migrated valid tests to Dart 2
Change-Id: If37611e051b7e2f128c53267f606d480d7fe23a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121902
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2019-10-17 00:41:16 +00:00
87b5112d5b
[dart:_http] Adds Dart-styled constants
...
Change-Id: I42e0c02b3aac7f952c5346bbcddd50293bf2b5b8
Reviewed-on: https://dart-review.googlesource.com/58620
Commit-Queue: Zach Anderson <zra@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-06-07 16:18:33 +00:00
afb490adbc
[dart:io] Provide modern Dart-styled constants
...
This CL updates dart:io but not dart:_http. It updates the sdk sources,
the patch files, and tests.
Change-Id: I64c3da407f09fa2bc6eec582049c4ae3a8afbe6d
Reviewed-on: https://dart-review.googlesource.com/52990
Commit-Queue: Zach Anderson <zra@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2018-05-03 17:00:14 +00:00
aa6353b6da
Dart SDK Spelling b, c, and d.
...
R=kmillikin@google.com
BUG=
Review-Url: https://codereview.chromium.org/2850783002 .
2017-05-01 08:28:10 +02:00
2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
f1ae158a2a
Add debugging information to raw_secure_server_socket_test.
...
R=fschneider@google.com , kustermann@google.com
Review-Url: https://codereview.chromium.org/2571603004 .
2016-12-13 21:29:24 +01:00
fe04737a77
Add test directive to include other files used by a test in its compiled output directory.
...
Fixes #27591
R=fschneider@google.com
Review URL: https://codereview.chromium.org/2423593002 .
2016-10-14 16:11:25 -07:00
e0f5ed22b9
Fix a couple socket tests for short read/write
...
It appears to be timing dependent whether a SocketException or
a HandshakeException is thrown in the presence of short reads
and writes for these secure socket tests that are meant to fail.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2262043003 .
2016-08-22 13:45:10 -07:00
e2729705ff
Rolls back fix of SecurityContext method names.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org/1757453002 .
2016-03-01 10:34:15 -08:00
2cf6405ca9
Adds SecurityContext.setTrustedCertificatesBytes
...
Implements SecurityContext.setTrustedCertificates in terms of the new
function. This requires setTrustedCertificates to return a Future,
and removing the `directory` named argument as it is not possible to
implement with BoringSSL without blocking IO.
R=whesse@google.com
Review URL: https://codereview.chromium.org/1665433002 .
2016-02-08 08:41:49 -08:00
8f356bf87e
Adds SecurityContext.useCertificateChainBytes
...
Changes SecurityContext.useCertificateChain to call the new method and
return a Future.
R=whesse@google.com
Review URL: https://codereview.chromium.org/1648793005 .
2016-02-02 10:54:07 -08:00
98771a083f
Adds SecurityContext.usePrivateKeyBytes
...
This is the first step toward removing blocking IO calls from
the implementation of the SecurityContext API.
Using a buffer rather than a file name API will probably be needed
for implementing SecurityContext and SecureSocket with platform
specific built-in APIs on iOS/Mac/Windows rather than BoringSSL.
related #8227
R=whesse@google.com
Review URL: https://codereview.chromium.org/1616073004 .
2016-01-29 08:52:18 -08:00
13bf8ff9f8
Breaking Change: merge BoringSSL branch into master
...
This replaces the NSS secure networking library from Mozilla
with the BoringSSL library from Google. This library, based
on OpenSSL, reads certificates from files in PEM format, rather
than storing certificates and keys in a SQLite database, the
way NSS does. There will be a blog post, changelog entries,
and other documentation of the breaking changes.
Review URL: https://codereview.chromium.org//1319703002 .
2015-08-26 14:42:12 +02:00
e362db67d1
Clean up secure socket connect.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//262923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35686 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-02 09:25:09 +00:00
bc124036fa
Fix SecureSocket tests to look up localhost only once, where possible.
...
This is needed because 0.01% of the time, macos will return an IPv6 address for localhost, instead of IPv4, or vice versa.
BUG=dartbug.com/12837
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//201993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33750 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 16:15:19 +00:00
e8c1b76526
Change RawSocket.secureServer and RawSoccket.secure to fail on paused subscriptions
...
R=whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//158773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32499 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 13:43:28 +00:00
c38de04d0c
Change dart:io Platform.script to return a Uri.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//46063010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29651 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 07:29:01 +00:00
4f08151090
Revert "Change dart:io Platform.script to return a Uri."
...
This reverts r29619 and r29624. The changes look fine on the buildbot,
but need review before adding to the repository.
BUG=
TBR=sgjesse@google.com
Review URL: https://codereview.chromium.org//52723007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29627 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 02:17:37 +00:00
cb0110350a
Change dart:io Platform.script to return a URI. Change all uses of Platform.script to work with the new value.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//53313007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29619 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 01:08:11 +00:00
b1a115db63
Fix errors in dart:io tests found by the analyzer
...
TBR=ajohnsen@google.com
BUG=
Review URL: https://codereview.chromium.org//23896002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27057 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 14:02:21 +00:00
18c75d3dc2
Update dart:io tests to use asyncStart/asyncEnd
...
R=ajohnsen@google.com
BUG=http://dartbug.com/12977
Review URL: https://codereview.chromium.org//23886004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27054 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 13:42:56 +00:00
e550079125
dart:io | Fix handling of exceptions from onBadCertificate callback.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//20316002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25519 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 13:39:18 +00:00
884436dcb9
Remove uses of Path class from tests/standalone.
...
BUG=
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//19967002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25399 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 07:45:06 +00:00
7db2572902
dart:io | Change names for SecureSocket exceptions.
...
BUG=
R=ajohnsen@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//17589007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24405 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 13:54:42 +00:00
887c8e7596
Move getters from Options to Platform
...
The getters for executable, script and version are now statics on
Platform. I kept them on Options for now, but updated most tests to
use Platform.
R=ajohnsen@google.com , floitsch@google.com , iposva@google.com
BUG=
Review URL: https://codereview.chromium.org//17406010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24401 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 12:56:23 +00:00
3e899b1c75
Add tests that drop read events to the dart:io RawSocket and RawSecureSocket tests.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//16961007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24385 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 08:14:10 +00:00
000875ca45
dart:io | Add File.rename
...
R=ajohnsen@google.com
BUG=
Review URL: https://codereview.chromium.org//17033003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24029 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 12:58:21 +00:00
b5af633ff8
dart:io | Rename optional carryOverData argument to SecureSocket.secureServer to bufferedData.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//16952005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23992 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 15:59:44 +00:00
5ce3b9ddea
Clean up dart:io exceptions.
...
- Introduce IOException.
- Remove HttpParserException.
- Merge RedirectLimitExceededException and RedirectLoopException into
RedirectException.
- Remove 'IO' from FileIOException, DirectoryIOException, LinkIOException
and SocketIOException.
BUG=https://code.google.com/p/dart/issues/detail?id=9955
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//16123036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23848 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 13:15:46 +00:00
60a5efe267
dart:io | Fix issue involving SecureServerSocket error handling and HttpServer stream cancellation.
...
BUG=dartbug.com/11074
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//16021016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23801 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-10 09:28:58 +00:00
2fdb878ebe
Change the signature for all network bind calls.
...
All the bind calls on RawServerSocket, ServerSocket,
RawSecureServerSocket, SecureServerSocket and HttpServer (and
bindSecure on HttpServer) now have mandatory address and port
parameters. All the rest of the parameters are named optional
(including backlog).
The address parameter can be an InternetAddress or a String for all
these calls.
R=ajohnsen@google.com , whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//14640008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22227 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-01 09:14:04 +00:00
c10ddafcd0
Fix upgrade to secure issue
...
Ensure that no raw socket events go to the raw socket being upgraded to a secure socket.
R=whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//14641002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22177 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-30 12:01:37 +00:00
300ceb4c22
Fix test
...
The test started failing on Windows after socket code changes.
TBR=ajohnsen@google.com
BUG=
Review URL: https://codereview.chromium.org//13918016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21943 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 12:33:14 +00:00
55963a1a6d
Add new InternetAddress class with a static lookup function (including IPv6
...
results).
Reapply of https://codereview.chromium.org/13880029/ with fixes.
BUG=
Review URL: https://codereview.chromium.org//14469002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21934 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 09:26:58 +00:00
60946b53fc
Revert "Add new InternetAddress class with a static lookup function (including IPv6 results)."
...
Revert "Attempt to fix strict align issue."
Revert "Trying another fix."
BUG=
Review URL: https://codereview.chromium.org//14036017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21928 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 08:10:00 +00:00
20d1f5ddda
Add new InternetAddress class with a static lookup function (including IPv6 results).
...
Reapply of https://codereview.chromium.org/14083007/ with fixes.
BUG=
Review URL: https://codereview.chromium.org//13880029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21923 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 07:12:05 +00:00
6f14d9678a
Fix static type errors in a number of tests
...
R=ager@google.com
BUG=
Review URL: https://codereview.chromium.org//13860006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21919 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 06:12:08 +00:00
afcb3ce69e
Revert "Add new InternetAddress class with a static lookup function (including IPv6 results)"
...
TBR=ajohnsen@google.com
Review URL: https://codereview.chromium.org//14081024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21865 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 10:07:03 +00:00
b33d142414
Add new InternetAddress class with a static lookup function (including IPv6 results).
...
Socket.connect/ServerSocket.bind now accepts IPv6 host names. If a new ServerSocket is connected to an IPv6 interface, it will (if possible) support incoming IPv4 connections as well.
BUG=
Review URL: https://codereview.chromium.org//14083007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21862 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 09:36:18 +00:00
9216562647
Try to fix flakiness of test standalone/io/raw_secure_server_socket_test
...
The test tests/standalone/io/raw_secure_server_socket_test.dart could
complete the same future twice. This should fix that.
R=ager@google.com
BUG=
Review URL: https://codereview.chromium.org//14189020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21739 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-19 12:27:58 +00:00
e1aa202b58
Add the ability to secure an already established raw socket connection
...
The static methods secure and secureServer can be used to start
TLS handshake as eihter client or server.
This CL only implement the securing of RawSocket.
This also changes the semantics of cancelling a subscription on a
RawSocket from closing the socket to just pausing.
R=ager@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=8789
Review URL: https://codereview.chromium.org//13502004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21719 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-19 07:37:37 +00:00
5431a5af54
Remove AsyncError with Expando.
...
Review URL: https://codereview.chromium.org//14251006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21498 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 18:58:32 +00:00
bebe3ac2cd
Refactor List.setRange function.
...
Review URL: https://codereview.chromium.org//13863012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21452 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 13:52:29 +00:00
8fd6d0aafd
Remove Expect from core library.
...
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
5dc8107c53
Revert "Remove Expect from core library."
...
This reverts commit 19755.
Review URL: https://codereview.chromium.org//12743005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
12dbd2fd70
Remove Expect from core library.
...
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
51212d24ed
Remove deprecated ms arguments for Timer and Future.
...
Review URL: https://codereview.chromium.org//12342014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19220 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 13:24:12 +00:00
6b4f4b1bab
Change new List(n) to return fixed length list.
...
Deprecate List.fixedLength, add List.filled.
Make Iterable.toList and List.from take "growable" argument,
defaulting to false.
Review URL: https://codereview.chromium.org//12328104
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 08:45:04 +00:00
Liam Appelbe