There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
It assumed that an attempt to start a non-existent binary on POSIX always
results in ENOENT (2). However this is not true: we are using execvp(...)
which attempts to find binaries through PATH (as long as the given filename
does not contain `/`) if binary is not found anywhere in the PATH and
some folder in PATH is inaccessible then execvp(...) fails with EACCES (13).
This caused the test to fail on Android whenever PATH contained /sbin which
is inaccessible.
We fix the test by clearing PATH for child processes.
Fixes issue https://github.com/dart-lang/sdk/issues/28299R=kustermann@google.com
BUG=https://github.com/dart-lang/sdk/issues/28299
Review-Url: https://codereview.chromium.org/2639043003 .
Process object only when the process has been successfully started.
This is less error prone since you can use all the methods on a
Process object as soon as you can get your hands on it. Unfortunately,
this change leads to quite a few changes in test.dart. Some of those
changes will fix bugs as well. We used to have a problem with a
timeout that could fire just in between two steps in a chain of
commands that constitute one test run. This change should address
that issue as well.
BUG=dartbug.com/5305
Review URL: https://codereview.chromium.org//11091070
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13729 260f80e4-7a28-3924-810f-c04153c831b5
This appears to be what a lot of our users are doing and it is the
style used in our other libraries.
Noteworthy changes:
- File and Directory objects are now immutable.
- Directory.list returns an active lister object.
- Write operations on files return futures and the
onNoPendingWrites handler is gone. The same
functionality is there by using 'then' on the
future returned from the last write operation.
- Process starting is now done with static methods:
-- Process.start yields an InteractiveProcess.
-- Process.run yields a Future<ProcessResult>
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10392023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7529 260f80e4-7a28-3924-810f-c04153c831b5
jonahwilliams