Commit Graph

42 Commits

Author SHA1 Message Date
Alexander Aprelev 6b3abe0a98 [vm/concurrency] Add --experimental_enable_isolate_groups_jit flag, make --enable_isolate_groups AOT only.
Issue b/177800357.

TEST=existing test suite
Change-Id: Id6b113932ab7014b8fa6c105845c5c490b60f5e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181320
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2021-01-27 17:11:29 +00:00
Martin Kustermann 39577ea564 [vm] Remove (unused & deprecated) --package-root parameter from VM binaries and from tests (Platform.packageRoot always returns null)
Closes https://github.com/dart-lang/sdk/issues/41245

Change-Id: Idd7526199b4c2479297c58b05bc13efcb79d01e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152321
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2020-06-24 18:17:53 +00:00
Jonas Termansen e725e8edf2 [nnbd] Fix regressions in the standalone/io migration.
Closes https://github.com/dart-lang/sdk/issues/40571.

Change-Id: I38704ab2583f4e856866f091ac652a8a652abe54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137101
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
2020-03-18 20:38:52 +00:00
Jonas Termansen 3433d8cfc3 [nnbd] Migrate standalone/io to NNBD.
The tests are also now dartfmt.

Bug: https://github.com/dart-lang/sdk/issues/40040
Change-Id: I8dece8097b37b70d47a5374dae2f3fadb0fc4b90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134338
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-02-07 14:41:36 +00:00
Siva Annamalai bc4860b0cb Most VM specific tests in standalone have been moved to standalone_2 and are being run in the regular bot tests. These tests are for VM functionality like io, process API etc. and have no strong mode implications. Currently we are running these tests twice once from standalone and once from standalone_2.
This CL removes these redundant tests from the standalone directory.

Bug:
Change-Id: Ib0adfa67fffa4de486e847698e18353fb4dd8a46
Reviewed-on: https://dart-review.googlesource.com/18429
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2017-11-07 23:00:00 +00:00
William Hesse 7bf2788bcc Restore all deleted tests to tests/standalone from migration to standalone_2
We are no longer deleting tests from the Dart 1 test directories when we
add them to the _2 directories. This reverts the part of change
https://dart-review.googlesource.com/c/sdk/+/12240 that modifies
the tests/standlone directory.
Bug:
Change-Id: Ie26b185234d0d18736a2fa13b77c5fd42cbb7e92
Reviewed-on: https://dart-review.googlesource.com/12287
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-09 10:46:55 +00:00
Siva Annamalai bd2a8e1d60 Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory.
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2017-10-07 01:29:36 +00:00
Siva Annamalai ff32187145 Revert "Migrate most of the tests in standalone to be strong mode clean and move"
This reverts commit c85563f582.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Migrate most of the tests in standalone to be strong mode clean and move
> them to standalone_2 directory.
> 
> Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
> Reviewed-on: https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2017-10-06 17:24:20 +00:00
Siva Annamalai c85563f582 Migrate most of the tests in standalone to be strong mode clean and move
them to standalone_2 directory.

Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-06 17:07:34 +00:00
William Hesse adb0e8864f Update Dart version to 2.0.0
Bug:
Change-Id: I13a8daea5f7adae670cea73d429d552c1e96c8e6
Reviewed-on: https://dart-review.googlesource.com/6461
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2017-09-18 09:31:05 +00:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
William Hesse 61eee9ee52 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/5d3e356ca75be8aeff3efde5df946d746b9f8352

Review URL: https://codereview.chromium.org/1746743002 .

Reverted: https://github.com/dart-lang/sdk/commit/6d238ba197c8bda71afe790f16f6e9adaf7abd13
2016-09-16 15:03:18 +02:00
Ivan Posva b6781b656a - Implement Platform.packageRoot and Platform.packageConfig based
on the new specification.

BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org/1529063006 .
2015-12-17 07:48:41 -08:00
Soren Gjesse f9e8852edb Fix test on Windows
Forgot to change Platform.executable to Platform.resolvedExecutable in
one place.

TBR=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//1181583004.
2015-06-15 11:45:34 +02:00
Søren Gjesse c05c8c6606 Revert change to Platform.excutable and add Platform.resolvedExecutable
The change to Platform.excutable in
e03ab17437 was a breaking change and it
has been reverted.

A new getter Platform.resolvedExecutable has been added to provide the
the fully qualified path of the executable.

BUG=https://github.com/dart-lang/sdk/issues/16994
R=lrn@google.com, kustermann@google.com, len@google.com

Review URL: https://codereview.chromium.org//1180623006.
2015-06-15 10:13:21 +02:00
Søren Gjesse e03ab17437 Make Platform.executable return the fully qualified path of the executable
BUG=http://dartbug.com/16994
R=kustermann@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//1145053002
2015-05-20 13:14:51 +02:00
sgjesse@google.com 854959e09c Fix broken test of platform version
The version check regexp expected that additional info was stripped. The
dartdoc for Platform.version says that the version is what is before the
first space if any.

R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//953323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44021 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-25 11:46:09 +00:00
sgjesse@google.com 47236d71e5 Fix checked mode test
TBR=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//920823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43727 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 14:20:38 +00:00
sgjesse@google.com 59f8932c9d Update documentation for Platform.version
Add test that Platform.version does start with a valid semver string.

BUG=http://dartbug/22244
R=ricow@google.com

Review URL: https://codereview.chromium.org//921733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43723 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 13:35:56 +00:00
ricow@google.com 10595e509d Make standalone tests not dependent on current working directory.
This also simplifies DartOptions - could we simply remove it, the only usage is the arguments test which could simply call the vm on another file, and validate the output?

R=iposva@google.com, sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//899243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43511 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 16:29:39 +00:00
ajohnsen@google.com eb06b64766 Use toFilePath when extracting the path, in platform_test.
BUG=

Review URL: https://codereview.chromium.org//423863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38618 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 13:06:04 +00:00
ajohnsen@google.com d56b11bf59 Compute absolute script path at isolate startup.
BUG=https://code.google.com/p/dart/issues/detail?id=20119
R=whesse@google.com

Review URL: https://codereview.chromium.org//423843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38616 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 12:31:29 +00:00
sgjesse@google.com c38de04d0c Change dart:io Platform.script to return a Uri.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//46063010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29651 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 07:29:01 +00:00
whesse@google.com 4f08151090 Revert "Change dart:io Platform.script to return a Uri."
This reverts r29619 and r29624.  The changes look fine on the buildbot,
but need review before adding to the repository.

BUG=

TBR=sgjesse@google.com

Review URL: https://codereview.chromium.org//52723007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29627 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 02:17:37 +00:00
whesse@google.com cb0110350a Change dart:io Platform.script to return a URI. Change all uses of Platform.script to work with the new value.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//53313007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29619 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 01:08:11 +00:00
whesse@google.com ad88bc6020 Remove uses of Options from tools directory. Fix platform_test.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//51043004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29562 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 16:20:49 +00:00
whesse@google.com 16eb7fd728 Fix standalone/io/platform_test on Windows. Remove @deprecated from Platform.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//51103012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29558 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 15:57:24 +00:00
floitsch@google.com 6a72655d1b Very simple version of Isolates.
R=ajohnsen@google.com, iposva@google.com, kasperl@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//27215002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:23:00 +00:00
asiva@google.com a294e0a82f Fix for issue 14236:
Retain script path of parent isolate when spawnFunction is called so that
it works when using script snapshots.

The test case issue14236_test.dart is a script snapshot whose original source
file path is issue14236_source.dart

R=iposva@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//35393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29178 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 16:41:22 +00:00
whesse@google.com 6dbc9e5268 dart:io | Remove uses of Options class from standalone tests. Mark Options deprecated.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//37033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29079 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 12:50:18 +00:00
sgjesse@google.com 18c75d3dc2 Update dart:io tests to use asyncStart/asyncEnd
R=ajohnsen@google.com
BUG=http://dartbug.com/12977

Review URL: https://codereview.chromium.org//23886004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27054 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 13:42:56 +00:00
whesse@google.com 9de122a462 Add Platform.packageRoot and Platform.executableArguments to dart:io.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//22999033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26432 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 15:21:55 +00:00
sgjesse@google.com a1158d6c50 Make the values of Platform.executable and Platform.script available to all isolates
BUG=http://dartbug.com/12258

R=iposva@google.com

Review URL: https://codereview.chromium.org//22565003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25913 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 07:19:21 +00:00
sgjesse@google.com 887c8e7596 Move getters from Options to Platform
The getters for executable, script and version are now statics on
Platform. I kept them on Options for now, but updated most tests to
use Platform.

R=ajohnsen@google.com, floitsch@google.com, iposva@google.com
BUG=

Review URL: https://codereview.chromium.org//17406010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24401 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 12:56:23 +00:00
sgjesse@google.com 52329d346c dart:io | Add cache and getters to Platform
Cache the static part of the Platform object. Add boolean getters for operating system.

R=ajohnsen@google.com
BUG=

Review URL: https://codereview.chromium.org//17175007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24219 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 12:05:41 +00:00
floitsch@google.com 8fd6d0aafd Remove Expect from core library.
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756

Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
floitsch@google.com 5dc8107c53 Revert "Remove Expect from core library."
This reverts commit 19755.

Review URL: https://codereview.chromium.org//12743005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
floitsch@google.com 12dbd2fd70 Remove Expect from core library.
Review URL: https://codereview.chromium.org//12212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
whesse@google.com e128dd9f14 Remove old #import, #source, and #library syntax from tests/standalone.
BUG=dart:7066

Review URL: https://codereview.chromium.org//11570005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16106 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 13:06:04 +00:00
jackpal@google.com 9b49d5932b Add "android" as an expected OS target.
Enables this test to pass when run on Android.

BUG=

Review URL: https://chromiumcodereview.appspot.com//10828231

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10590 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-13 17:35:07 +00:00
ager@google.com e6b2635059 Change Platform members to getters instead of methods.
R=sgjesse@google.com
BUG=dartbug.com/1668
TEST=

Review URL: https://chromiumcodereview.appspot.com//10351011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7282 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-03 13:16:33 +00:00
sigmund@google.com f8db005eb2 test rename overhaul: step 12 - standalone
Review URL: https://chromiumcodereview.appspot.com//10252020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7165 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-30 17:34:19 +00:00