d968304570
Reland "Revert commits part of #40548 which still has some design debates and breaks valid local network http traffic"
...
This is a reland of d84f359786#40548 which still has some design debates and breaks valid local network http traffic
>
> Bug: https://github.com/flutter/flutter/issues/72723
> Change-Id: Ib5f809fccf1fad69add441fd40c463da8dc8be36
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192953
> Auto-Submit: Xiao Yu <xster@google.com >
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Bug: https://github.com/flutter/flutter/issues/72723
Change-Id: I466d888b3f324a996f0bef0463e7ab3df3179c56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195485
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Commit-Queue: Xiao Yu <xster@google.com >
2021-04-16 20:25:36 +00:00
f560d90059
Revert "Revert commits part of #40548 which still has some design debates and breaks valid local network http traffic"
...
This reverts commit d84f359786https://buganizer.corp.google.com/issues/185462669
Original change's description:
> Revert commits part of #40548 which still has some design debates and breaks valid local network http traffic
>
> Bug: https://github.com/flutter/flutter/issues/72723
> Change-Id: Ib5f809fccf1fad69add441fd40c463da8dc8be36
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192953
> Auto-Submit: Xiao Yu <xster@google.com >
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
TBR=lrn@google.com ,vegorov@google.com ,xster@google.com
Change-Id: Ie746805ab7ef214bc4ba6f3582eb1d32672360ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/flutter/flutter/issues/72723
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195484
Reviewed-by: Xiao Yu <xster@google.com >
Commit-Queue: Xiao Yu <xster@google.com >
2021-04-15 15:29:28 +00:00
d84f359786
Revert commits part of #40548 which still has some design debates and breaks valid local network http traffic
...
Bug: https://github.com/flutter/flutter/issues/72723
Change-Id: Ib5f809fccf1fad69add441fd40c463da8dc8be36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192953
Auto-Submit: Xiao Yu <xster@google.com >
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2021-04-15 09:25:17 +00:00
f5432d7164
[io/http] Relax http parsing constraints around CRLF.
...
https://tools.ietf.org/html/rfc2616\#section-19.3 advises to
allow CR*LF wherever CRLF line terminator is expected.
Issue https://github.com/dart-lang/sdk/issues/43916
TEST=http_client_parser_crlf_tolerant_test, http_100_continue_test
Change-Id: I8c6d263bdb950b2f3992b69921eff0ee75704c10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192120
Commit-Queue: Alexander Aprelev <aam@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2021-03-20 03:11:28 +00:00
ee37fff58c
[io/http] Have http parser reply with error if Content-Length and Transfer-Encoding are both specified on http request.
...
Issue b/150476984
Change-Id: Iafc7154c84682678e4d7e3d614b74942b0d259b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180485
Commit-Queue: Alexander Aprelev <aam@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2021-01-22 18:32:43 +00:00
909a05cf8a
[dart:io] Remove obsolete http embedder config.
...
This is no longer being used.
Change-Id: I316a28193698cc2ceb62e6d89c87adf0d05f7be7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161800
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Mehmet Fidanboylu <mehmetf@google.com >
2020-09-04 16:50:10 +00:00
d44457f79d
[Core Libraries] Eliminate the fork in the core libraries.
...
Move the nnbd core libraries from sdk_nnbd to sdk, and updates
references in build files and elsewhere accordingly.
Change-Id: I09760fe1e006657aacdfe80f3b22fdf6f7e30a9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151121
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-06-16 23:37:36 +00:00
d2543e32f4
Migrate standalone tests which rely on the pre-nnbd sdk libraries.
...
Migrate all the tests under standalone/ that include files under
sdk/sdk/ as part files to unblock the replacement of the unmigrated
sdk/sdk with the contents of the migrated sdk/sdk_nnbd.
Change-Id: Ia2e78bbff797f58244d94021d4b9616793bd641d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151036
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2020-06-15 19:41:46 +00:00
4549484390
[dart:io] tests http parsing decoding latin1
...
Closes https://github.com/dart-lang/sdk/issues/41706
Change-Id: Icde8046b40bb3f77b015a61478b8ef6f94f5870c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145500
Commit-Queue: Zichang Guo <zichangguo@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2020-05-05 20:32:03 +00:00
74a20b7bfd
Reland "[dart:_http] Allow the embedder to prohibit HTTP traffic."
...
This is a reland of 6b44c631adhttps://github.com/dart-lang/sdk/issues/40548
> Change-Id: Ifec0ad2d759de4bbb836644840d8c312e560f285
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138911
> Commit-Queue: Martin Kustermann <kustermann@google.com >
> Reviewed-by: Jonas Termansen <sortie@google.com >
Bug: https://github.com/dart-lang/sdk/issues/40548
Change-Id: I6ced6c1248b3b6687f6c7d998e5206b2b385f00b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142446
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2020-04-06 17:46:44 +00:00
a5611cdda2
Revert "[dart:_http] Allow the embedder to prohibit HTTP traffic."
...
This reverts commit 6b44c631adhttps://github.com/dart-lang/sdk/issues/40548
> Change-Id: Ifec0ad2d759de4bbb836644840d8c312e560f285
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138911
> Commit-Queue: Martin Kustermann <kustermann@google.com >
> Reviewed-by: Jonas Termansen <sortie@google.com >
TBR=sortie@google.com ,lrn@google.com ,kustermann@google.com ,mehmetf@google.com
Change-Id: I824a1845e82b5facb839109f74bb482e7095e313
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/40548
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142363
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2020-04-03 18:19:17 +00:00
6b44c631ad
[dart:_http] Allow the embedder to prohibit HTTP traffic.
...
This can be configured by embedders by setting the `_embedderAllowsHttp`
variable. It can also be overridden by client apps by introducing a
`Zone` with the variable `#dart.library.io.allow_http` set to `true` or
`false`.
The default behavior in SDK is unchanged.
Bug: https://github.com/dart-lang/sdk/issues/40548
Change-Id: Ifec0ad2d759de4bbb836644840d8c312e560f285
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138911
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2020-04-03 16:39:26 +00:00
3433d8cfc3
[nnbd] Migrate standalone/io to NNBD.
...
The tests are also now dartfmt.
Bug: https://github.com/dart-lang/sdk/issues/40040
Change-Id: I8dece8097b37b70d47a5374dae2f3fadb0fc4b90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134338
Commit-Queue: Jonas Termansen <sortie@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-02-07 14:41:36 +00:00
bc4860b0cb
Most VM specific tests in standalone have been moved to standalone_2 and are being run in the regular bot tests. These tests are for VM functionality like io, process API etc. and have no strong mode implications. Currently we are running these tests twice once from standalone and once from standalone_2.
...
This CL removes these redundant tests from the standalone directory.
Bug:
Change-Id: Ib0adfa67fffa4de486e847698e18353fb4dd8a46
Reviewed-on: https://dart-review.googlesource.com/18429
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
2017-11-07 23:00:00 +00:00
7bf2788bcc
Restore all deleted tests to tests/standalone from migration to standalone_2
...
We are no longer deleting tests from the Dart 1 test directories when we
add them to the _2 directories. This reverts the part of change
https://dart-review.googlesource.com/c/sdk/+/12240 that modifies
the tests/standlone directory.
Bug:
Change-Id: Ie26b185234d0d18736a2fa13b77c5fd42cbb7e92
Reviewed-on: https://dart-review.googlesource.com/12287
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com >
2017-10-09 10:46:55 +00:00
bd2a8e1d60
Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory.
...
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2017-10-07 01:29:36 +00:00
ff32187145
Revert "Migrate most of the tests in standalone to be strong mode clean and move"
...
This reverts commit c85563f582https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com >
TBR=bkonyi@google.com ,asiva@google.com
Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2017-10-06 17:24:20 +00:00
c85563f582
Migrate most of the tests in standalone to be strong mode clean and move
...
them to standalone_2 directory.
Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com >
2017-10-06 17:07:34 +00:00
2948f8c1b7
Reland: [dart:io] Moves Http code into a separate library.
...
This moves Http code into dart:_http. dart:io then imports and
re-exports dart:_http. This is the first stage of moving
dart:_http into its own pub package.
This CL was reverted due to a failure in the Flutter engine build
which happened due to an incomplete change in gen_snapshot.cc, and to
update sdk/lib/libraries.yaml and sdk/lib/libraries.json
Change-Id: Ie90c77ef631aea7a163774b58e8ccbaf71a24d3c
Reviewed-on: https://dart-review.googlesource.com/7588
Reviewed-by: Zach Anderson <zra@google.com >
2017-09-21 19:21:25 +00:00
64bf1b49b0
Revert "[dart:io] Moves Http code into a separate library."
...
Reverting for broken Flutter build and kernel platform compilation test. It looks like the new _http library is missing from various snapshots. Not sure why this didn't fail locally.
This reverts commit ac9ff3f3afhttps://dart-review.googlesource.com/7600
Reviewed-by: Zach Anderson <zra@google.com >
2017-09-21 15:57:59 +00:00
ac9ff3f3af
[dart:io] Moves Http code into a separate library.
...
This moves Http code into dart:_http. dart:io then imports and
re-exports dart:_http. This is the first stage of moving
dart:_http into its own pub package.
Change-Id: Icd33232a97b3d75511ef7ec88b01fd47cdcf5a23
Reviewed-on: https://dart-review.googlesource.com/6420
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Florian Loitsch <floitsch@google.com >
2017-09-21 15:10:22 +00:00
2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
c99e5c02fa
Fix tests that explicitly part in io library files
...
R=sgjesse@google.com
BUG=
Review URL: https://codereview.chromium.org//1328213003 .
2015-09-08 13:30:03 +02:00
13bf8ff9f8
Breaking Change: merge BoringSSL branch into master
...
This replaces the NSS secure networking library from Mozilla
with the BoringSSL library from Google. This library, based
on OpenSSL, reads certificates from files in PEM format, rather
than storing certificates and keys in a SQLite database, the
way NSS does. There will be a blog post, changelog entries,
and other documentation of the breaking changes.
Review URL: https://codereview.chromium.org//1319703002 .
2015-08-26 14:42:12 +02:00
c6e632bcdb
Be more lean when parsing HTTP headers
...
Allow only LF instaed of CRLF when parsing headers. Sometimes old or
hacked up clients will send the headers like this.
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//1078683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44998 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-09 11:15:29 +00:00
198b11bd9b
Add IO service object handler, with initial implementation for HTTP server.
...
This is tempoary disabling the Socket service handler.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//284313011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36417 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-21 11:12:49 +00:00
b15ec57f4f
Clean up usage of streams in http-parser.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//171403003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32790 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 13:27:47 +00:00
b97593a8df
Make dart:io unit-tests pass the analyzer.
...
BUG=http://code.google.com/p/dart/issues/detail?id=7066
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//87743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30662 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 08:38:29 +00:00
c2e9418dd6
Mark status file and fix warnings found by dart2js in test.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//64553015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30346 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 14:36:55 +00:00
f6a50d8894
Use typed-data views for incoming http data.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//59673006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30340 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 12:40:38 +00:00
80a28e9f12
Import dart:collection in dart:io unit-tests.
...
BUG=
Review URL: https://codereview.chromium.org//16948007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23982 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 14:24:02 +00:00
5ce3b9ddea
Clean up dart:io exceptions.
...
- Introduce IOException.
- Remove HttpParserException.
- Merge RedirectLimitExceededException and RedirectLoopException into
RedirectException.
- Remove 'IO' from FileIOException, DirectoryIOException, LinkIOException
and SocketIOException.
BUG=https://code.google.com/p/dart/issues/detail?id=9955
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//16123036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23848 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 13:15:46 +00:00
faa7227cec
Make new StreamController be async by default.
...
Change all instances, except some tests, to be sync still.
Rename Multiplex to Broadcast everywhere.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//16125005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23453 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 06:07:39 +00:00
9d6a64e81b
Merge the dart:uri library into dart:core and update the Uri class
...
This merges the dart:uri library into dart:core removing the dart:uri library. Besides moving the library the Url class has been changed.
* Removed existing Uri constructor as it was equivalent with Uri.parse
* Remamed constructor Uri.fromComponents to Uri
* Moved toplevel function encodeUriComponent to static method Uri.encodeComponent
* Moved toplevel function decodeUriComponent to static method Uri.decodeComponent
* Moved toplevel function encodeUri to static method Uri.encodeFull
* Moved toplevel function decodeUri to static method Uri.decodeFull
* Rename domain to host
* Added static methods Uri.encodeQueryComponent and Uri.decodeQueryComponent
* Added support for path generation and splitting
* Added support for query generation and splitting
* Added some level of normalization
R=floitsch@google.com , lrn@google.com , nweiz@google.com , scheglov@google.com
BUG=
Review URL: https://codereview.chromium.org//16019002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23266 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:35:01 +00:00
781e84284f
Reapply "Active stream subscriptions".
...
Makes subscriptions the active part of a stream, with the stream
itself being just an inert creator of subscriptions.
This changes the behavior of a "single subscription" stream to match
the documentation: After the subscription is canceled, you can't
resubscribe to the stream. Previously, you could do that, but it was
never documented or intended.
This also makes the stream of a StreamController not be paused while
before it's subscribed - it is always the subscription that is paused
or not, and while there is no subscription, the stream cannot be
paused. Previously the stream was set to paused until the first
subscription in order to prevent events from being lost. That is
handled independently of pauses now.
Adds StreamController.multiplex constructor. This name is tentative,
and likely to change. Its behavior may change as well. It currently
provides a new single-subscription stream each time its "stream"
getter is read, and you can subscribe to these.
Adds StreamIterator class that allows iterating over a stream's data
events using (async) "moveNext()" and "current", like a direct style
Iterator (sorry, it won't work in a for-in loop).
Review URL: https://codereview.chromium.org//16131003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23237 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 07:28:36 +00:00
310e5b54b4
Support auto-drain of HttpRequest data.
...
When headers of the HttpResponse are about to be sent, and the HttpRequest have not had any subscriber yet, drain the request body and then write the headers.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//15842004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23228 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 15:43:34 +00:00
cc0d9d57af
Revert until Windows crash is debugged.
...
Reverts r23218, r23217, r23208, r23207, r23206, r23205, r23204.
r23218 | Path observer is listened more than once, so make it multiplex.
r23217 | Add StreamController.multiplex constructor.
r23208 | Fix bug in streamimpl
r23207 | Fix bug in stream iterator.
r23206 | Change expectations for http_parser_test.
r23205 | Fix bug in stream-impl.
r23204 | Make StreamSubscription be the active part of a string.
Review URL: https://codereview.chromium.org//15989006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23221 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 13:03:03 +00:00
ee1c11a2a6
Make StreamSubscription be the active part of a string.
...
It is the one keeping the buffer of events, not the stream.
R=ajohnsen@google.com , floitsch@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//14753009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23204 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 08:34:20 +00:00
1ef03d33a1
Rewrite parts of http-parser, to better handle connection errors and pausing.
...
We now correctly catch up and report 'dead' connections in the
HttpClient.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//15256002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22834 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 08:28:21 +00:00
968ebcff5a
Make Completers asynchronous.
...
BUG= http://dartbug.com/9990
R=ajohnsen@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//14690009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22417 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-06 15:15:15 +00:00
431954b584
Rename dart:typeddata to dart:typed_data.
...
R=asiva@google.com , floitsch@google.com , srdjan@google.com
BUG=
Review URL: https://codereview.chromium.org//14426006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21871 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 11:54:54 +00:00
8fd6d0aafd
Remove Expect from core library.
...
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
b368804b23
- Use dart:typeddata in the tests instead of dart:scalarlist
...
- delete byte_array_test.dart as a dart:typeddata version of this test
is present in typed_data_test.dart
Review URL: https://codereview.chromium.org//12507012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20600 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-28 00:35:37 +00:00
844cd39fad
Change getRange to sublist. Make getRange deprecated.
...
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.
Review URL: https://codereview.chromium.org//12817003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 09:15:39 +00:00
5dc8107c53
Revert "Remove Expect from core library."
...
This reverts commit 19755.
Review URL: https://codereview.chromium.org//12743005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
12dbd2fd70
Remove Expect from core library.
...
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
b675e47aa0
Remane io_stream_consumer.dart to io_sink and move out all implementation from IOSink to _IOSinkImpl.
...
BUG=https://code.google.com/p/dart/issues/detail?id=8873
Review URL: https://codereview.chromium.org//12389050
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19311 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 13:33:19 +00:00
3c0ac360e7
Remove deprecated string features.
...
Make String.codeUnits return a List.
Review URL: https://codereview.chromium.org//12282038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
488b016a2f
Merge IO v2 branch to bleeding edge
...
R=ager@google.com , ajohnsen@google.com , whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//12316036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 11:58:11 +00:00
4a7dfd2da3
Big merge from experimental to bleeding edge.
...
Review URL: https://codereview.chromium.org//11783009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
Xiao Yu